[bpf-next] bpf: remove unused field "mod" in struct bpf_trampoline

Message ID 20240128055443.413291-1-dongmenglong.8@bytedance.com
State New
Headers
Series [bpf-next] bpf: remove unused field "mod" in struct bpf_trampoline |

Commit Message

梦龙董 Jan. 28, 2024, 5:54 a.m. UTC
  It seems that the field "mod" in struct bpf_trampoline is not used
anywhere after the commit 31bf1dbccfb0 ("bpf: Fix attaching
fentry/fexit/fmod_ret/lsm to modules"). So we can just remove it now.

Signed-off-by: Menglong Dong <dongmenglong.8@bytedance.com>
---
 include/linux/bpf.h | 1 -
 1 file changed, 1 deletion(-)
  

Comments

Jiri Olsa Jan. 28, 2024, 9:04 a.m. UTC | #1
On Sun, Jan 28, 2024 at 01:54:43PM +0800, Menglong Dong wrote:
> It seems that the field "mod" in struct bpf_trampoline is not used
> anywhere after the commit 31bf1dbccfb0 ("bpf: Fix attaching
> fentry/fexit/fmod_ret/lsm to modules"). So we can just remove it now.
> 
> Signed-off-by: Menglong Dong <dongmenglong.8@bytedance.com>

Fixes: 31bf1dbccfb0 ("bpf: Fix attaching fentry/fexit/fmod_ret/lsm to modules")

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka


> ---
>  include/linux/bpf.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/linux/bpf.h b/include/linux/bpf.h
> index b86bd15a051d..1ebbee1d648e 100644
> --- a/include/linux/bpf.h
> +++ b/include/linux/bpf.h
> @@ -1189,7 +1189,6 @@ struct bpf_trampoline {
>  	int progs_cnt[BPF_TRAMP_MAX];
>  	/* Executable image of trampoline */
>  	struct bpf_tramp_image *cur_image;
> -	struct module *mod;
>  };
>  
>  struct bpf_attach_target_info {
> -- 
> 2.39.2
>
  
patchwork-bot+netdevbpf@kernel.org Jan. 29, 2024, 3:50 p.m. UTC | #2
Hello:

This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:

On Sun, 28 Jan 2024 13:54:43 +0800 you wrote:
> It seems that the field "mod" in struct bpf_trampoline is not used
> anywhere after the commit 31bf1dbccfb0 ("bpf: Fix attaching
> fentry/fexit/fmod_ret/lsm to modules"). So we can just remove it now.
> 
> Signed-off-by: Menglong Dong <dongmenglong.8@bytedance.com>
> ---
>  include/linux/bpf.h | 1 -
>  1 file changed, 1 deletion(-)

Here is the summary with links:
  - [bpf-next] bpf: remove unused field "mod" in struct bpf_trampoline
    https://git.kernel.org/bpf/bpf-next/c/efaa47db9245

You are awesome, thank you!
  

Patch

diff --git a/include/linux/bpf.h b/include/linux/bpf.h
index b86bd15a051d..1ebbee1d648e 100644
--- a/include/linux/bpf.h
+++ b/include/linux/bpf.h
@@ -1189,7 +1189,6 @@  struct bpf_trampoline {
 	int progs_cnt[BPF_TRAMP_MAX];
 	/* Executable image of trampoline */
 	struct bpf_tramp_image *cur_image;
-	struct module *mod;
 };
 
 struct bpf_attach_target_info {