[1/2] soc: qcom: geni-se: Add M_TX_FIFO_NOT_EMPTY bit definition

Message ID 20240112150307.1.I7dc0993c1e758a1efedd651e7e1670deb1b430fb@changeid
State New
Headers
Series [1/2] soc: qcom: geni-se: Add M_TX_FIFO_NOT_EMPTY bit definition |

Commit Message

Doug Anderson Jan. 12, 2024, 11:03 p.m. UTC
  According to the docs I have, bit 21 of the status register is
asserted when the FIFO is _not_ empty. Add the definition.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

 include/linux/soc/qcom/geni-se.h | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Konrad Dybcio Jan. 12, 2024, 11:21 p.m. UTC | #1
On 13.01.2024 00:03, Douglas Anderson wrote:
> According to the docs I have, bit 21 of the status register is
> asserted when the FIFO is _not_ empty. Add the definition.
> 
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---

Looks like.

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
  
Bjorn Andersson Jan. 28, 2024, 3:10 a.m. UTC | #2
On Fri, Jan 12, 2024 at 03:03:07PM -0800, Douglas Anderson wrote:
> According to the docs I have, bit 21 of the status register is
> asserted when the FIFO is _not_ empty. Add the definition.
> 
> Signed-off-by: Douglas Anderson <dianders@chromium.org>

Acked-by: Bjorn Andersson <andersson@kernel.org>

Regards,
Bjorn

> ---
> 
>  include/linux/soc/qcom/geni-se.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/soc/qcom/geni-se.h b/include/linux/soc/qcom/geni-se.h
> index 29e06905bc1f..0f038a1a0330 100644
> --- a/include/linux/soc/qcom/geni-se.h
> +++ b/include/linux/soc/qcom/geni-se.h
> @@ -178,6 +178,7 @@ struct geni_se {
>  #define M_GP_IRQ_3_EN			BIT(12)
>  #define M_GP_IRQ_4_EN			BIT(13)
>  #define M_GP_IRQ_5_EN			BIT(14)
> +#define M_TX_FIFO_NOT_EMPTY_EN		BIT(21)
>  #define M_IO_DATA_DEASSERT_EN		BIT(22)
>  #define M_IO_DATA_ASSERT_EN		BIT(23)
>  #define M_RX_FIFO_RD_ERR_EN		BIT(24)
> -- 
> 2.43.0.275.g3460e3d667-goog
>
  

Patch

diff --git a/include/linux/soc/qcom/geni-se.h b/include/linux/soc/qcom/geni-se.h
index 29e06905bc1f..0f038a1a0330 100644
--- a/include/linux/soc/qcom/geni-se.h
+++ b/include/linux/soc/qcom/geni-se.h
@@ -178,6 +178,7 @@  struct geni_se {
 #define M_GP_IRQ_3_EN			BIT(12)
 #define M_GP_IRQ_4_EN			BIT(13)
 #define M_GP_IRQ_5_EN			BIT(14)
+#define M_TX_FIFO_NOT_EMPTY_EN		BIT(21)
 #define M_IO_DATA_DEASSERT_EN		BIT(22)
 #define M_IO_DATA_ASSERT_EN		BIT(23)
 #define M_RX_FIFO_RD_ERR_EN		BIT(24)