Message ID | 20240127092034.887085-3-andyshrk@163.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-41128-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2395:b0:106:343:edcb with SMTP id gw21csp394608dyb; Sat, 27 Jan 2024 01:21:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IGoigz/R2Lo6MdzPsjRhkicKU7LouiZz4dFnRH7uBRWUkGzhW1EGA0yFkd3ujI3fE5FYVE5 X-Received: by 2002:ae9:e416:0:b0:783:caae:83cb with SMTP id q22-20020ae9e416000000b00783caae83cbmr1241359qkc.92.1706347314329; Sat, 27 Jan 2024 01:21:54 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706347314; cv=pass; d=google.com; s=arc-20160816; b=Iqvh7z97dYqHX0SS9vxIJnRF8aKH/DqwyeGApj89MvqxZPAhtAyDpYmLV0oUELYJhN ng0n1PINjV0lJixmNNY8LckbHzqmRSypfEAu9kndlF/3/b/9bPqOIVsSSkT30F27S3f5 S1MxjYGZi6OMNTm8OpRbyv/fOYaFL6Lq+Gz02VhiiCUMI4hWESeDR54STxDTWgtyG8R0 E1WWEPcKOEfcBypOax/fugX0TOEzGN/s1d05WE8b5c8cbiN1DH8ln+fO4VX4tE/z+gwW q4UPxL+eMnX5IstxIbX7jIG0VHBAk9RhhXfRQGaEEOYynLFYIN1kKBBawUCGYs/uLCkH C6IQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=ke7aqYeO3SgKHFFAXZGTQJgNGC9RklM/X8fmVFmJVMo=; fh=ZO7aPiTroJzmkQXd0UUl7zpTj0tgEh15/0L4mq2G/+I=; b=GoiGJtbKtTXwe/Rtxap15mawlZMTu7/HPRdaOW3AtDQmX9N9fqBnGtfghXlK/ELhed mE66lhbgyijWW+qSFvdyUL/zpBmkGINulwblFqY8EnXL3SokCM8TrZFqTXl1VXj+dmQp S/2UWnKCdwWWaNzgaw8rgjT72J/lXNNzxTwF2GiFvPd9Z0vbyTQh7kYbSNTQ7FoP0Lg1 8hRfWe/Cq94DIRfuzQs17uYyNuiPLk4cCcxW3HZeVdSnV8dGTrIHR3rHM0Ers768EPDd UOhKtflGQ2MPIjrbmIj/1P8aM5fEkpWNQUF9N9GIg03ZrHDwDKhVWwPTpf2keD7nH9e5 3vRg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=aCwvVHfd; arc=pass (i=1 spf=pass spfdomain=163.com dkim=pass dkdomain=163.com dmarc=pass fromdomain=163.com); spf=pass (google.com: domain of linux-kernel+bounces-41128-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-41128-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id dc2-20020a05620a520200b00783abe87f7dsi3016953qkb.384.2024.01.27.01.21.54 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Jan 2024 01:21:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-41128-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=aCwvVHfd; arc=pass (i=1 spf=pass spfdomain=163.com dkim=pass dkdomain=163.com dmarc=pass fromdomain=163.com); spf=pass (google.com: domain of linux-kernel+bounces-41128-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-41128-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 216A31C2185A for <ouuuleilei@gmail.com>; Sat, 27 Jan 2024 09:21:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 090C71F958; Sat, 27 Jan 2024 09:21:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="aCwvVHfd" Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.4]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4E9B61E516; Sat, 27 Jan 2024 09:21:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.4 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706347286; cv=none; b=d0bZF00mB+5yBADknJagi0yRG2QYVRSbo2tpgX6gWW3jJTQ9DPI/lbb4aLjk8t0leOhelqgGjjG2BYSvHPapYSp656UWfC7vc7ySnbJEfup4+RFEoQIkNZoImDX0JIyFR6t0ursYb6eoc97COQvWed3CkUlSmzloyZ00yJtGy0k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706347286; c=relaxed/simple; bh=KEhFIjcnHD4A22X7uQT1+3J1ulhltLTzb67Z0RlJXUg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=e+bL5A2FvH6yV47zOGBFasATgHep5rvtnR7gaDP/C8SUnnG0ZReAPrB/nyhoIR3UlSh9d232QgdzK5i02CUsjFnwCmpmg61ZRe3cbWipDO5pZbEWgBx8GV1NZl9rFeyKgNWjz5C7C0NtPZ1dPEHX+6GpMybYIpk9TE2tdN4cUwM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=aCwvVHfd; arc=none smtp.client-ip=220.197.31.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=ke7aq YeO3SgKHFFAXZGTQJgNGC9RklM/X8fmVFmJVMo=; b=aCwvVHfdF6SFbE39ZmYnE wO4GcXjp/JfyvcAcUUnppJKIVxs5z27NtpebTolZSvusoMlVXQc2ra2ob+8bUA1I hMjz+/a0hzR8k6twsUngb0Yb9l6lWyTn8Z5T7fZ8vRCSZWv3+S+An0h8LLHLMn11 MhUNKWSqRuRboG5g/gEUow= Received: from ProDesk.. (unknown [58.22.7.114]) by gzga-smtp-mta-g0-4 (Coremail) with SMTP id _____wD3rzHkyrRl5GopBA--.2976S4; Sat, 27 Jan 2024 17:20:41 +0800 (CST) From: Andy Yan <andyshrk@163.com> To: heiko@sntech.de Cc: krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Andy Yan <andyshrk@163.com> Subject: [PATCH 3/4] arm64: dts: rockchip: rename vcc5v0_usb30_host regulator for Cool Pi CM5 EVB Date: Sat, 27 Jan 2024 17:20:33 +0800 Message-Id: <20240127092034.887085-3-andyshrk@163.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240127092034.887085-1-andyshrk@163.com> References: <20240127092034.887085-1-andyshrk@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: _____wD3rzHkyrRl5GopBA--.2976S4 X-Coremail-Antispam: 1Uf129KBjvJXoW7AFyDZryfuFyrCF45Cw1Dtrb_yoW8JF4fpw nxCrZrJr1fuFWUt3yqg3Z7Krs5C395t3Z3ur95Jw1rKw1Iq3ZrtFn3u3WrAFW5twn7Aa1q kFs5ury7JF1qvFJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0z_1v3UUUUUU= X-CM-SenderInfo: 5dqg52xkunqiywtou0bp/xtbBEAxyXmVOB+LqkAABsF X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789234841645403394 X-GMAIL-MSGID: 1789234841645403394 |
Series |
None
|
|
Commit Message
Andy Yan
Jan. 27, 2024, 9:20 a.m. UTC
According to the schematic, this regulator is used both for USB30 and
USB20, so give it a more appropriate name.
Fixes: 791c154c3982 ("arm64: dts: rockchip: Add support for rk3588 based board Cool Pi CM5 EVB")
Signed-off-by: Andy Yan <andyshrk@163.com>
---
arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Comments
Hi Andy, Am Samstag, 27. Januar 2024, 10:20:33 CET schrieb Andy Yan: > According to the schematic, this regulator is used both for USB30 and > USB20, so give it a more appropriate name. I don't have the schematics, so I'll need you to answer this, but what is the regulator called _in_ the schematics? I.e. we want regulators to really be named the same as in the schematic so people can look up thing from the dts in the schematics and the other way around too. Thanks Heiko > Fixes: 791c154c3982 ("arm64: dts: rockchip: Add support for rk3588 based board Cool Pi CM5 EVB") > Signed-off-by: Andy Yan <andyshrk@163.com> > --- > > arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts b/arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts > index 1b5681fe0471..5f42f1065d73 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts > @@ -84,7 +84,7 @@ vcc3v3_lcd: vcc3v3-lcd-regulator { > vin-supply = <&vcc3v3_sys>; > }; > > - vcc5v0_usb30_host: vcc5v0-usb30-host-regulator { > + vcc5v0_usb_host: vcc5v0-usb-host-regulator { > compatible = "regulator-fixed"; > regulator-name = "vcc5v0_host"; > regulator-boot-on; > @@ -200,12 +200,12 @@ &u2phy3 { > }; > > &u2phy2_host { > - phy-supply = <&vcc5v0_usb30_host>; > + phy-supply = <&vcc5v0_usb_host>; > status = "okay"; > }; > > &u2phy3_host { > - phy-supply = <&vcc5v0_usb30_host>; > + phy-supply = <&vcc5v0_usb_host>; > status = "okay"; > }; > >
Hi Heiko: At 2024-01-27 18:36:40, "Heiko Stübner" <heiko@sntech.de> wrote: >Hi Andy, > >Am Samstag, 27. Januar 2024, 10:20:33 CET schrieb Andy Yan: >> According to the schematic, this regulator is used both for USB30 and >> USB20, so give it a more appropriate name. > >I don't have the schematics, so I'll need you to answer this, but what >is the regulator called _in_ the schematics? There are two regulators called VCC50_USB_HOST1 and VCC50_USB_HOST2, and they are both controlled by GPIO1_D5 They both for two usb 2.0 hosts, not usb 30, the schematics make me a bit confused. > >I.e. we want regulators to really be named the same as in the schematic >so people can look up thing from the dts in the schematics and the other >way around too. > > >Thanks >Heiko > > >> Fixes: 791c154c3982 ("arm64: dts: rockchip: Add support for rk3588 based board Cool Pi CM5 EVB") >> Signed-off-by: Andy Yan <andyshrk@163.com> >> --- >> >> arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts b/arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts >> index 1b5681fe0471..5f42f1065d73 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts >> +++ b/arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts >> @@ -84,7 +84,7 @@ vcc3v3_lcd: vcc3v3-lcd-regulator { >> vin-supply = <&vcc3v3_sys>; >> }; >> >> - vcc5v0_usb30_host: vcc5v0-usb30-host-regulator { >> + vcc5v0_usb_host: vcc5v0-usb-host-regulator { >> compatible = "regulator-fixed"; >> regulator-name = "vcc5v0_host"; >> regulator-boot-on; >> @@ -200,12 +200,12 @@ &u2phy3 { >> }; >> >> &u2phy2_host { >> - phy-supply = <&vcc5v0_usb30_host>; >> + phy-supply = <&vcc5v0_usb_host>; >> status = "okay"; >> }; >> >> &u2phy3_host { >> - phy-supply = <&vcc5v0_usb30_host>; >> + phy-supply = <&vcc5v0_usb_host>; >> status = "okay"; >> }; >> >> > > > > > >_______________________________________________ >linux-arm-kernel mailing list >linux-arm-kernel@lists.infradead.org >http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On 2024-01-27 13:15, Andy Yan wrote: > At 2024-01-27 18:36:40, "Heiko Stübner" <heiko@sntech.de> wrote: >> Am Samstag, 27. Januar 2024, 10:20:33 CET schrieb Andy Yan: >>> According to the schematic, this regulator is used both for USB30 and >>> USB20, so give it a more appropriate name. >> >> I don't have the schematics, so I'll need you to answer this, but what >> is the regulator called _in_ the schematics? > > There are two regulators called VCC50_USB_HOST1 and VCC50_USB_HOST2, > and they are both controlled by GPIO1_D5 > They both for two usb 2.0 hosts, not usb 30, the schematics make > me a bit confused. In that case, I'd say that renaming the regulator to vcc5v0_usb_host is fine, but there should also be a comment in the board dts file that it's actually two separate regulators. >> I.e. we want regulators to really be named the same as in the >> schematic >> so people can look up thing from the dts in the schematics and the >> other >> way around too. Ah, that's very helpful. >>> Fixes: 791c154c3982 ("arm64: dts: rockchip: Add support for rk3588 >>> based board Cool Pi CM5 EVB") >>> Signed-off-by: Andy Yan <andyshrk@163.com> >>> --- >>> >>> arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts | 6 +++--- >>> 1 file changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts >>> b/arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts >>> index 1b5681fe0471..5f42f1065d73 100644 >>> --- a/arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts >>> +++ b/arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts >>> @@ -84,7 +84,7 @@ vcc3v3_lcd: vcc3v3-lcd-regulator { >>> vin-supply = <&vcc3v3_sys>; >>> }; >>> >>> - vcc5v0_usb30_host: vcc5v0-usb30-host-regulator { >>> + vcc5v0_usb_host: vcc5v0-usb-host-regulator { >>> compatible = "regulator-fixed"; >>> regulator-name = "vcc5v0_host"; >>> regulator-boot-on; >>> @@ -200,12 +200,12 @@ &u2phy3 { >>> }; >>> >>> &u2phy2_host { >>> - phy-supply = <&vcc5v0_usb30_host>; >>> + phy-supply = <&vcc5v0_usb_host>; >>> status = "okay"; >>> }; >>> >>> &u2phy3_host { >>> - phy-supply = <&vcc5v0_usb30_host>; >>> + phy-supply = <&vcc5v0_usb_host>; >>> status = "okay"; >>> };
Hi Heiko: 在 2024-01-27 21:09:46,"Dragan Simic" <dsimic@manjaro.org> 写道: >On 2024-01-27 13:15, Andy Yan wrote: >> At 2024-01-27 18:36:40, "Heiko Stübner" <heiko@sntech.de> wrote: >>> Am Samstag, 27. Januar 2024, 10:20:33 CET schrieb Andy Yan: >>>> According to the schematic, this regulator is used both for USB30 and >>>> USB20, so give it a more appropriate name. >>> >>> I don't have the schematics, so I'll need you to answer this, but what >>> is the regulator called _in_ the schematics? >> >> There are two regulators called VCC50_USB_HOST1 and VCC50_USB_HOST2, >> and they are both controlled by GPIO1_D5 >> They both for two usb 2.0 hosts, not usb 30, the schematics make >> me a bit confused. > >In that case, I'd say that renaming the regulator to vcc5v0_usb_host is >fine, but there should also be a comment in the board dts file that it's >actually two separate regulators. How do you feel about this ? Or some other style like: vcc5v0_usb_host1: vcc5v0_usb_host2:vcc5v0-usb-host-regulator { > >>> I.e. we want regulators to really be named the same as in the >>> schematic >>> so people can look up thing from the dts in the schematics and the >>> other >>> way around too. > >Ah, that's very helpful. > >>>> Fixes: 791c154c3982 ("arm64: dts: rockchip: Add support for rk3588 >>>> based board Cool Pi CM5 EVB") >>>> Signed-off-by: Andy Yan <andyshrk@163.com> >>>> --- >>>> >>>> arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts | 6 +++--- >>>> 1 file changed, 3 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts >>>> b/arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts >>>> index 1b5681fe0471..5f42f1065d73 100644 >>>> --- a/arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts >>>> +++ b/arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts >>>> @@ -84,7 +84,7 @@ vcc3v3_lcd: vcc3v3-lcd-regulator { >>>> vin-supply = <&vcc3v3_sys>; >>>> }; >>>> >>>> - vcc5v0_usb30_host: vcc5v0-usb30-host-regulator { >>>> + vcc5v0_usb_host: vcc5v0-usb-host-regulator { >>>> compatible = "regulator-fixed"; >>>> regulator-name = "vcc5v0_host"; >>>> regulator-boot-on; >>>> @@ -200,12 +200,12 @@ &u2phy3 { >>>> }; >>>> >>>> &u2phy2_host { >>>> - phy-supply = <&vcc5v0_usb30_host>; >>>> + phy-supply = <&vcc5v0_usb_host>; >>>> status = "okay"; >>>> }; >>>> >>>> &u2phy3_host { >>>> - phy-supply = <&vcc5v0_usb30_host>; >>>> + phy-supply = <&vcc5v0_usb_host>; >>>> status = "okay"; >>>> }; > >_______________________________________________ >linux-arm-kernel mailing list >linux-arm-kernel@lists.infradead.org >http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Am Mittwoch, 31. Januar 2024, 13:21:56 CET schrieb Andy Yan: > > Hi Heiko: > > 在 2024-01-27 21:09:46,"Dragan Simic" <dsimic@manjaro.org> 写道: > >On 2024-01-27 13:15, Andy Yan wrote: > >> At 2024-01-27 18:36:40, "Heiko Stübner" <heiko@sntech.de> wrote: > >>> Am Samstag, 27. Januar 2024, 10:20:33 CET schrieb Andy Yan: > >>>> According to the schematic, this regulator is used both for USB30 and > >>>> USB20, so give it a more appropriate name. > >>> > >>> I don't have the schematics, so I'll need you to answer this, but what > >>> is the regulator called _in_ the schematics? > >> > >> There are two regulators called VCC50_USB_HOST1 and VCC50_USB_HOST2, > >> and they are both controlled by GPIO1_D5 > >> They both for two usb 2.0 hosts, not usb 30, the schematics make > >> me a bit confused. > > > >In that case, I'd say that renaming the regulator to vcc5v0_usb_host is > >fine, but there should also be a comment in the board dts file that it's > >actually two separate regulators. > > How do you feel about this ? Or some other style like: > vcc5v0_usb_host1: vcc5v0_usb_host2:vcc5v0-usb-host-regulator { I think we're using such a scheme in some places already, and yes I really like going this way. So that the phandles follow the schematic names and we can still grep for things. Heiko
diff --git a/arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts b/arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts index 1b5681fe0471..5f42f1065d73 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts +++ b/arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts @@ -84,7 +84,7 @@ vcc3v3_lcd: vcc3v3-lcd-regulator { vin-supply = <&vcc3v3_sys>; }; - vcc5v0_usb30_host: vcc5v0-usb30-host-regulator { + vcc5v0_usb_host: vcc5v0-usb-host-regulator { compatible = "regulator-fixed"; regulator-name = "vcc5v0_host"; regulator-boot-on; @@ -200,12 +200,12 @@ &u2phy3 { }; &u2phy2_host { - phy-supply = <&vcc5v0_usb30_host>; + phy-supply = <&vcc5v0_usb_host>; status = "okay"; }; &u2phy3_host { - phy-supply = <&vcc5v0_usb30_host>; + phy-supply = <&vcc5v0_usb_host>; status = "okay"; };