diff mbox series

clk: Remove a useless include

Message ID 12dd5cb49efa7714f8e0389e4c7b3bc829e8a90e.1668289299.git.christophe.jaillet@wanadoo.fr
State New
Headers
Series clk: Remove a useless include |

Commit Message

Christophe JAILLET Nov. 12, 2022, 9:43 p.m. UTC 
  <linux/rational.h> is not needed for these drivers. Remove the
corresponding #include.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/clk/clk-versaclock5.c | 1 -
 drivers/clk/meson/clk-pll.c   | 1 -
 drivers/clk/rockchip/clk.c    | 1 -
 3 files changed, 3 deletions(-)

Comments

Heiko Stübner Nov. 13, 2022, 8:48 a.m. UTC | #1 
Am Samstag, 12. November 2022, 22:43:03 CET schrieb Christophe JAILLET:
> <linux/rational.h> is not needed for these drivers. Remove the
> corresponding #include.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/clk/clk-versaclock5.c | 1 -
>  drivers/clk/meson/clk-pll.c   | 1 -
>  drivers/clk/rockchip/clk.c    | 1 -

Clock-trees for soc families normally have different sub-maintainers,
so depending on how we want to merge this, you might need to split
this into 3 patches.

But at least for the Rockchip part, I'm also fine with the patch going
in as a whole, so (for the Rockchip part):

Acked-by: Heiko Stuebner <heiko@sntech.de>


Heiko

>  3 files changed, 3 deletions(-)
> 

[...]

> diff --git a/drivers/clk/rockchip/clk.c b/drivers/clk/rockchip/clk.c
> index e63d4f20b479..398c427b8e81 100644
> --- a/drivers/clk/rockchip/clk.c
> +++ b/drivers/clk/rockchip/clk.c
> @@ -21,7 +21,6 @@
>  #include <linux/mfd/syscon.h>
>  #include <linux/regmap.h>
>  #include <linux/reboot.h>
> -#include <linux/rational.h>
>  
>  #include "../clk-fractional-divider.h"
>  #include "clk.h"
>
Jerome Brunet Nov. 13, 2022, 7:29 p.m. UTC | #2 
On Sun 13 Nov 2022 at 09:48, Heiko Stübner <heiko@sntech.de> wrote:

> Am Samstag, 12. November 2022, 22:43:03 CET schrieb Christophe JAILLET:
>> <linux/rational.h> is not needed for these drivers. Remove the
>> corresponding #include.
>> 
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>> ---
>>  drivers/clk/clk-versaclock5.c | 1 -
>>  drivers/clk/meson/clk-pll.c   | 1 -
>>  drivers/clk/rockchip/clk.c    | 1 -
>
> Clock-trees for soc families normally have different sub-maintainers,
> so depending on how we want to merge this, you might need to split
> this into 3 patches.
>
> But at least for the Rockchip part, I'm also fine with the patch going
> in as a whole, so (for the Rockchip part):
>
> Acked-by: Heiko Stuebner <heiko@sntech.de>
>
>
> Heiko

Same for the Amlogic part

Acked-by: Jerome Brunet <jbrunet@baylibre.com>

>
>>  3 files changed, 3 deletions(-)
>> 
>
> [...]
>
>> diff --git a/drivers/clk/rockchip/clk.c b/drivers/clk/rockchip/clk.c
>> index e63d4f20b479..398c427b8e81 100644
>> --- a/drivers/clk/rockchip/clk.c
>> +++ b/drivers/clk/rockchip/clk.c
>> @@ -21,7 +21,6 @@
>>  #include <linux/mfd/syscon.h>
>>  #include <linux/regmap.h>
>>  #include <linux/reboot.h>
>> -#include <linux/rational.h>
>>  
>>  #include "../clk-fractional-divider.h"
>>  #include "clk.h"
>>
Luca Ceresoli Nov. 14, 2022, 8:18 a.m. UTC | #3 
Hello Jerome,

On Sun, 13 Nov 2022 20:29:43 +0100
Jerome Brunet <jbrunet@baylibre.com> wrote:

> On Sun 13 Nov 2022 at 09:48, Heiko Stübner <heiko@sntech.de> wrote:
> 
> > Am Samstag, 12. November 2022, 22:43:03 CET schrieb Christophe JAILLET:  
> >> <linux/rational.h> is not needed for these drivers. Remove the
> >> corresponding #include.
> >> 
> >> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> >> ---
> >>  drivers/clk/clk-versaclock5.c | 1 -
> >>  drivers/clk/meson/clk-pll.c   | 1 -
> >>  drivers/clk/rockchip/clk.c    | 1 -  
> >
> > Clock-trees for soc families normally have different sub-maintainers,
> > so depending on how we want to merge this, you might need to split
> > this into 3 patches.
> >
> > But at least for the Rockchip part, I'm also fine with the patch going
> > in as a whole, so (for the Rockchip part):
> >
> > Acked-by: Heiko Stuebner <heiko@sntech.de>
> >
> >
> > Heiko  
> 
> Same for the Amlogic part
> 
> Acked-by: Jerome Brunet <jbrunet@baylibre.com>

And the same for Versaclock:

Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Stephen Boyd Nov. 23, 2022, 1:52 a.m. UTC | #4 
Quoting Christophe JAILLET (2022-11-12 13:43:03)
> <linux/rational.h> is not needed for these drivers. Remove the
> corresponding #include.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---

Applied to clk-next
diff mbox series

Patch

diff --git a/drivers/clk/clk-versaclock5.c b/drivers/clk/clk-versaclock5.c
index 88689415aff9..e9737969170e 100644
--- a/drivers/clk/clk-versaclock5.c
+++ b/drivers/clk/clk-versaclock5.c
@@ -20,7 +20,6 @@ 
 #include <linux/module.h>
 #include <linux/of.h>
 #include <linux/of_platform.h>
-#include <linux/rational.h>
 #include <linux/regmap.h>
 #include <linux/slab.h>
 
diff --git a/drivers/clk/meson/clk-pll.c b/drivers/clk/meson/clk-pll.c
index 9e55617bc3b4..4b96e1590224 100644
--- a/drivers/clk/meson/clk-pll.c
+++ b/drivers/clk/meson/clk-pll.c
@@ -32,7 +32,6 @@ 
 #include <linux/io.h>
 #include <linux/math64.h>
 #include <linux/module.h>
-#include <linux/rational.h>
 
 #include "clk-regmap.h"
 #include "clk-pll.h"
diff --git a/drivers/clk/rockchip/clk.c b/drivers/clk/rockchip/clk.c
index e63d4f20b479..398c427b8e81 100644
--- a/drivers/clk/rockchip/clk.c
+++ b/drivers/clk/rockchip/clk.c
@@ -21,7 +21,6 @@ 
 #include <linux/mfd/syscon.h>
 #include <linux/regmap.h>
 #include <linux/reboot.h>
-#include <linux/rational.h>
 
 #include "../clk-fractional-divider.h"
 #include "clk.h"