gcn: Add missing space to ASM_SPEC in gcn-hsa.h
Checks
Commit Message
This patch avoids assembler warnings for gfx908 and gfx90a such as
'-xnack-mattr=-sramecc' is not a recognized feature for this target(ignoring feature)
as we pass -mattr=-xnack-mattr=-sramecc to the llvm-mc assembler.
Solution: Add a space before the second '-mattr='.
OK for mainline?
Tobias
Comments
On 25/01/2024 12:44, Tobias Burnus wrote:
> This patch avoids assembler warnings for gfx908 and gfx90a such as
> '-xnack-mattr=-sramecc' is not a recognized feature for this target(ignoring feature)
> as we pass -mattr=-xnack-mattr=-sramecc to the llvm-mc assembler.
>
> Solution: Add a space before the second '-mattr='.
>
> OK for mainline?
OK.
Andrew
gcn: Add missing space to ASM_SPEC in gcn-hsa.h
gcc/
* config/gcn/gcn-hsa.h (ASM_SPEC): Add space after -mxnack= argument.
@@ -89,7 +89,7 @@ extern unsigned int gcn_local_sym_hash (const char *name);
#define ASM_SPEC "-triple=amdgcn--amdhsa " \
"%{march=*:-mcpu=%*} " \
"%{!march=*|march=fiji:--amdhsa-code-object-version=3} " \
- "%{" NO_XNACK XNACKOPT "}" \
+ "%{" NO_XNACK XNACKOPT "} " \
"%{" NO_SRAM_ECC SRAMOPT "} " \
"%{march=gfx1030|march=gfx1100:-mattr=+wavefrontsize64} " \
"-filetype=obj"