Message ID | 20240121134017.374992-1-vaishnav.a@ti.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-32067-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2bc4:b0:101:a8e8:374 with SMTP id hx4csp2072525dyb; Sun, 21 Jan 2024 05:41:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IGzZZcGtgfI0B+j+S/QWh7EDfnf3P6OM5Za71U2VnlLIBNrOE1VgjTQqxv2gtyTOUsRTFjg X-Received: by 2002:a17:902:d488:b0:1d5:8cbb:ad55 with SMTP id c8-20020a170902d48800b001d58cbbad55mr792177plg.134.1705844466817; Sun, 21 Jan 2024 05:41:06 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705844466; cv=pass; d=google.com; s=arc-20160816; b=H+AO1xOWSUxwGK2wioKlkL5Gyjh4IjmVd7AxSpsmZ/GkCuB8lSMkHBvhNq1uHxD4HC vaIQUIq1jFIrm3/EauhIpPMuDr0GglBY/ixulBFa/G8iSMdHKYejRatxXSW5waCgXrMi kcpoH+08rYh8OfR+BB+CfGTW6dwszlQFA3cgVX+ASP+lvtZrgtnuMxshrJlv7FuaALc/ GTmrKJAJEdQe+nzZjdHGvSXLylrebobeEUgtHbOjo+Ni8GkmZpHR2HcDaOStFW3auUzw HuGjoBpECgsLNXOBjjWQx5DLxJbjIe9BUsrkPjPr4eU9tdiC1WUK7apqoCcxpZRX/R3a fX2w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=i6GFj9UMX+JqTYdbgDWSVi0WGO4wE6eK5Pvgbx9HHX4=; fh=SZJUsvHb7m0Mg9NAH0/VuWYw4FAg7/DNGBbAbkBjuAA=; b=wehomFpnNzR4Yz94/LG6Mivqn1qI40oj36P+IElXXQ4lDz9cdf6zTFnuTiziZEHKXm +tus2EWM6Ok2w0W2+alWP53xQNFbcoZ2hEAPNikOTeUSxeQE7Wk518q0r4y39yZH+S4H +It5WqaptBsqM/0jMfBFaeJUcxNIO0vFTfpbcw4S6zSOmf+3VSfaPlMZlPJE59yY15rQ xgIZO1tbxJ6RBbKihpJn+OoEI4xjK82Kp9rJf87KaECS8VeEw9Xd/eVSmtxD/FLNR8mv wafgX3igt/siu8bUpCz6r3UBw4VsVczcysUArb9dLl3SFkvaRU/DntQ9oiAxOwXfNy5o 5Cxw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=rktxHPZI; arc=pass (i=1 spf=pass spfdomain=ti.com dkim=pass dkdomain=ti.com dmarc=pass fromdomain=ti.com); spf=pass (google.com: domain of linux-kernel+bounces-32067-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-32067-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id y6-20020a17090322c600b001d749d3953asi901014plg.162.2024.01.21.05.41.06 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jan 2024 05:41:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-32067-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=rktxHPZI; arc=pass (i=1 spf=pass spfdomain=ti.com dkim=pass dkdomain=ti.com dmarc=pass fromdomain=ti.com); spf=pass (google.com: domain of linux-kernel+bounces-32067-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-32067-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 93FC0282F01 for <ouuuleilei@gmail.com>; Sun, 21 Jan 2024 13:41:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 81083374E4; Sun, 21 Jan 2024 13:40:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="rktxHPZI" Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E530210785; Sun, 21 Jan 2024 13:40:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.19.142 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705844449; cv=none; b=uZqBCcUTe+o0ZTklFri1saHwzcj/GCFdN+A0TK9bxmQ9pX5KYiVY8ALEVNdkIEoL7dCfO6ElSpNzxXjdkUUGKXTDXHfGbgd7Kz1fdlKaGqprID4fYvAOOXk+n/TvILfo+4/csTxGHkFcy1xwb3gQv1wBnUIokK7km1Kye0Ajp3Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705844449; c=relaxed/simple; bh=hhJy+LSXnCKdCNHMvrgQXDg8/glnyLfWKNxCWEFH/tQ=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=up2T/iHMkIMZGDHymETA+O3S42keEH79f737vj4vPupqJB1pCG2lhlKvxxNgwp0+0BXnOMctLPJcZSHXBF1LkHHowdJMb5LL68aeFo1/Au2Bwmf5cFZiTo5jnD+5UAM/5U563Sq6ZbZzhq6fCTD4FO4zdp3boihcqS2ul3Uxids= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=rktxHPZI; arc=none smtp.client-ip=198.47.19.142 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 40LDeMsL011351; Sun, 21 Jan 2024 07:40:22 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1705844422; bh=i6GFj9UMX+JqTYdbgDWSVi0WGO4wE6eK5Pvgbx9HHX4=; h=From:To:CC:Subject:Date; b=rktxHPZIUdgjzsNDdT6pFvQKvAS5I6U5plZRvuO7UWGATnEr99xAF1beAs3fq5Njq AHsBUIZDmUVkBaOInttGaacjnvQwiOPfXmyX3O0eky6mZwn91pSb9VFAPcBX0hxsf1 PcZaz3klUcPqSzw8WQ6xmc/Bk7tUSviXBQPNJ7TM= Received: from DFLE111.ent.ti.com (dfle111.ent.ti.com [10.64.6.32]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 40LDeMmT086287 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Sun, 21 Jan 2024 07:40:22 -0600 Received: from DFLE111.ent.ti.com (10.64.6.32) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Sun, 21 Jan 2024 07:40:21 -0600 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Sun, 21 Jan 2024 07:40:21 -0600 Received: from uda0490681.. ([10.24.69.142]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 40LDeIEb088588; Sun, 21 Jan 2024 07:40:18 -0600 From: Vaishnav Achath <vaishnav.a@ti.com> To: <nm@ti.com>, <vigneshr@ti.com>, <kristo@kernel.org>, <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org> CC: <bb@ti.com>, <linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <u-kumar1@ti.com>, <vaishnav.a@ti.com> Subject: [PATCH] arm64: dts: ti: k3-am62p-mcu/wakeup: Disable MCU and wakeup R5FSS nodes Date: Sun, 21 Jan 2024 19:10:17 +0530 Message-ID: <20240121134017.374992-1-vaishnav.a@ti.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788707567558405381 X-GMAIL-MSGID: 1788707567558405381 |
Series |
arm64: dts: ti: k3-am62p-mcu/wakeup: Disable MCU and wakeup R5FSS nodes
|
|
Commit Message
Vaishnav Achath
Jan. 21, 2024, 1:40 p.m. UTC
K3 Remoteproc R5 driver requires reserved memory carveouts and
mailbox configuration to instantiate the cores successfully.
Since this is a board level dependency, keep the R5 subsytem
disabled at SoC dtsi, otherwise it results in probe errors like
below during AM62P SK boot:
r5fss@79000000: reserved memory init failed, ret = -22
r5fss@79000000: k3_r5_cluster_rproc_init failed, ret = -22
r5fss@78000000: reserved memory init failed, ret = -22
r5fss@78000000: k3_r5_cluster_rproc_init failed, ret = -22
Fixes: b5080c7c1f7e ("arm64: dts: ti: k3-am62p: Add nodes for more IPs")
Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
---
arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi | 2 ++
arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi | 1 +
2 files changed, 3 insertions(+)
Comments
Hello Vaishnav, On 21/01/24 19:10, Vaishnav Achath wrote: > K3 Remoteproc R5 driver requires reserved memory carveouts and > mailbox configuration to instantiate the cores successfully. > Since this is a board level dependency, keep the R5 subsytem > disabled at SoC dtsi, otherwise it results in probe errors like > below during AM62P SK boot: > > r5fss@79000000: reserved memory init failed, ret = -22 > r5fss@79000000: k3_r5_cluster_rproc_init failed, ret = -22 > r5fss@78000000: reserved memory init failed, ret = -22 > r5fss@78000000: k3_r5_cluster_rproc_init failed, ret = -22 > > Fixes: b5080c7c1f7e ("arm64: dts: ti: k3-am62p: Add nodes for more IPs") > > Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com> Reviewed-by: Jayesh Choudhary <j-choudhary@ti.com> > --- > arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi | 2 ++ > arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi > index c4b0b91d70cf..14eb9ba836d3 100644 > --- a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi > @@ -187,6 +187,8 @@ mcu_r5fss0: r5fss@79000000 { > ranges = <0x79000000 0x00 0x79000000 0x8000>, > <0x79020000 0x00 0x79020000 0x8000>; > power-domains = <&k3_pds 7 TI_SCI_PD_EXCLUSIVE>; > + status = "disabled"; > + > mcu_r5fss0_core0: r5f@79000000 { > compatible = "ti,am62-r5f"; > reg = <0x79000000 0x00008000>, > diff --git a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi > index 19f42b39394e..10a7059b2d9b 100644 > --- a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi > @@ -78,6 +78,7 @@ wkup_r5fss0: r5fss@78000000 { > ranges = <0x78000000 0x00 0x78000000 0x8000>, > <0x78100000 0x00 0x78100000 0x8000>; > power-domains = <&k3_pds 119 TI_SCI_PD_EXCLUSIVE>; > + status = "disabled"; > > wkup_r5fss0_core0: r5f@78000000 { > compatible = "ti,am62-r5f"; Thanks.
On 11:26-20240124, Jayesh Choudhary wrote: > Hello Vaishnav, > > On 21/01/24 19:10, Vaishnav Achath wrote: > > K3 Remoteproc R5 driver requires reserved memory carveouts and > > mailbox configuration to instantiate the cores successfully. > > Since this is a board level dependency, keep the R5 subsytem > > disabled at SoC dtsi, otherwise it results in probe errors like > > below during AM62P SK boot: > > > > r5fss@79000000: reserved memory init failed, ret = -22 > > r5fss@79000000: k3_r5_cluster_rproc_init failed, ret = -22 > > r5fss@78000000: reserved memory init failed, ret = -22 > > r5fss@78000000: k3_r5_cluster_rproc_init failed, ret = -22 > > > > Fixes: b5080c7c1f7e ("arm64: dts: ti: k3-am62p: Add nodes for more IPs") > > > > Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com> > > Reviewed-by: Jayesh Choudhary <j-choudhary@ti.com> > > > --- > > arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi | 2 ++ > > arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi | 1 + > > 2 files changed, 3 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi > > index c4b0b91d70cf..14eb9ba836d3 100644 > > --- a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi > > +++ b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi > > @@ -187,6 +187,8 @@ mcu_r5fss0: r5fss@79000000 { > > ranges = <0x79000000 0x00 0x79000000 0x8000>, > > <0x79020000 0x00 0x79020000 0x8000>; > > power-domains = <&k3_pds 7 TI_SCI_PD_EXCLUSIVE>; > > + status = "disabled"; > > + > > mcu_r5fss0_core0: r5f@79000000 { > > compatible = "ti,am62-r5f"; > > reg = <0x79000000 0x00008000>, > > diff --git a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi > > index 19f42b39394e..10a7059b2d9b 100644 > > --- a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi > > +++ b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi > > @@ -78,6 +78,7 @@ wkup_r5fss0: r5fss@78000000 { > > ranges = <0x78000000 0x00 0x78000000 0x8000>, > > <0x78100000 0x00 0x78100000 0x8000>; > > power-domains = <&k3_pds 119 TI_SCI_PD_EXCLUSIVE>; > > + status = "disabled"; Is there a reason for difference in white space addition? > > wkup_r5fss0_core0: r5f@78000000 { > > compatible = "ti,am62-r5f"; > > Thanks.
Hi Nishanth, On 24/01/24 22:51, Nishanth Menon wrote: > On 11:26-20240124, Jayesh Choudhary wrote: >> Hello Vaishnav, >> >> On 21/01/24 19:10, Vaishnav Achath wrote: >>> K3 Remoteproc R5 driver requires reserved memory carveouts and >>> mailbox configuration to instantiate the cores successfully. >>> Since this is a board level dependency, keep the R5 subsytem >>> disabled at SoC dtsi, otherwise it results in probe errors like >>> below during AM62P SK boot: >>> >>> r5fss@79000000: reserved memory init failed, ret = -22 >>> r5fss@79000000: k3_r5_cluster_rproc_init failed, ret = -22 >>> r5fss@78000000: reserved memory init failed, ret = -22 >>> r5fss@78000000: k3_r5_cluster_rproc_init failed, ret = -22 >>> >>> Fixes: b5080c7c1f7e ("arm64: dts: ti: k3-am62p: Add nodes for more IPs") >>> >>> Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com> >> >> Reviewed-by: Jayesh Choudhary <j-choudhary@ti.com> >> >>> --- >>> arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi | 2 ++ >>> arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi | 1 + >>> 2 files changed, 3 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi >>> index c4b0b91d70cf..14eb9ba836d3 100644 >>> --- a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi >>> +++ b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi >>> @@ -187,6 +187,8 @@ mcu_r5fss0: r5fss@79000000 { >>> ranges = <0x79000000 0x00 0x79000000 0x8000>, >>> <0x79020000 0x00 0x79020000 0x8000>; >>> power-domains = <&k3_pds 7 TI_SCI_PD_EXCLUSIVE>; >>> + status = "disabled"; >>> + >>> mcu_r5fss0_core0: r5f@79000000 { >>> compatible = "ti,am62-r5f"; >>> reg = <0x79000000 0x00008000>, >>> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi >>> index 19f42b39394e..10a7059b2d9b 100644 >>> --- a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi >>> +++ b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi >>> @@ -78,6 +78,7 @@ wkup_r5fss0: r5fss@78000000 { >>> ranges = <0x78000000 0x00 0x78000000 0x8000>, >>> <0x78100000 0x00 0x78100000 0x8000>; >>> power-domains = <&k3_pds 119 TI_SCI_PD_EXCLUSIVE>; >>> + status = "disabled"; > > Is there a reason for difference in white space addition? > For mcu_r5fss0_core0 child node there was no blank line as per the recommended coding style : https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst#n124 So I added a newline there and wkup_r5fss0 already had it correct, since the change was trivial it was not mentioned in commit message. Thanks and Regards, Vaishnav >>> wkup_r5fss0_core0: r5f@78000000 { >>> compatible = "ti,am62-r5f"; >> >> Thanks. >
On 11:17-20240125, Vaishnav Achath wrote: > Hi Nishanth, > > On 24/01/24 22:51, Nishanth Menon wrote: > > On 11:26-20240124, Jayesh Choudhary wrote: > > > Hello Vaishnav, > > > > > > On 21/01/24 19:10, Vaishnav Achath wrote: > > > > K3 Remoteproc R5 driver requires reserved memory carveouts and > > > > mailbox configuration to instantiate the cores successfully. > > > > Since this is a board level dependency, keep the R5 subsytem > > > > disabled at SoC dtsi, otherwise it results in probe errors like > > > > below during AM62P SK boot: > > > > > > > > r5fss@79000000: reserved memory init failed, ret = -22 > > > > r5fss@79000000: k3_r5_cluster_rproc_init failed, ret = -22 > > > > r5fss@78000000: reserved memory init failed, ret = -22 > > > > r5fss@78000000: k3_r5_cluster_rproc_init failed, ret = -22 > > > > > > > > Fixes: b5080c7c1f7e ("arm64: dts: ti: k3-am62p: Add nodes for more IPs") > > > > > > > > Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com> > > > > > > Reviewed-by: Jayesh Choudhary <j-choudhary@ti.com> > > > > > > > --- > > > > arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi | 2 ++ > > > > arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi | 1 + > > > > 2 files changed, 3 insertions(+) > > > > > > > > diff --git a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi > > > > index c4b0b91d70cf..14eb9ba836d3 100644 > > > > --- a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi > > > > +++ b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi > > > > @@ -187,6 +187,8 @@ mcu_r5fss0: r5fss@79000000 { > > > > ranges = <0x79000000 0x00 0x79000000 0x8000>, > > > > <0x79020000 0x00 0x79020000 0x8000>; > > > > power-domains = <&k3_pds 7 TI_SCI_PD_EXCLUSIVE>; > > > > + status = "disabled"; > > > > + ^^ Look here. > > > > mcu_r5fss0_core0: r5f@79000000 { > > > > compatible = "ti,am62-r5f"; > > > > reg = <0x79000000 0x00008000>, > > > > diff --git a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi > > > > index 19f42b39394e..10a7059b2d9b 100644 > > > > --- a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi > > > > +++ b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi > > > > @@ -78,6 +78,7 @@ wkup_r5fss0: r5fss@78000000 { > > > > ranges = <0x78000000 0x00 0x78000000 0x8000>, > > > > <0x78100000 0x00 0x78100000 0x8000>; > > > > power-domains = <&k3_pds 119 TI_SCI_PD_EXCLUSIVE>; > > > > + status = "disabled"; > > ^^ no white space here. > > Is there a reason for difference in white space addition? > > > > For mcu_r5fss0_core0 child node there was no blank line as per the > recommended coding style : https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst#n124 > > So I added a newline there and wkup_r5fss0 already had it correct, since the > change was trivial it was not mentioned in commit message. Sigh, please add a EoL here to keep the look consistent between mcu and wakeup dtsis. there is no need to state in commit message.
On 11:17-20240125, Vaishnav Achath wrote: > Hi Nishanth, > > On 24/01/24 22:51, Nishanth Menon wrote: > > On 11:26-20240124, Jayesh Choudhary wrote: > > > Hello Vaishnav, > > > > > > On 21/01/24 19:10, Vaishnav Achath wrote: > > > > K3 Remoteproc R5 driver requires reserved memory carveouts and > > > > mailbox configuration to instantiate the cores successfully. > > > > Since this is a board level dependency, keep the R5 subsytem > > > > disabled at SoC dtsi, otherwise it results in probe errors like > > > > below during AM62P SK boot: > > > > > > > > r5fss@79000000: reserved memory init failed, ret = -22 > > > > r5fss@79000000: k3_r5_cluster_rproc_init failed, ret = -22 > > > > r5fss@78000000: reserved memory init failed, ret = -22 > > > > r5fss@78000000: k3_r5_cluster_rproc_init failed, ret = -22 > > > > > > > > Fixes: b5080c7c1f7e ("arm64: dts: ti: k3-am62p: Add nodes for more IPs") > > > > > > > > Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com> > > > > > > Reviewed-by: Jayesh Choudhary <j-choudhary@ti.com> > > > > > > > --- > > > > arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi | 2 ++ > > > > arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi | 1 + > > > > 2 files changed, 3 insertions(+) > > > > > > > > diff --git a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi > > > > index c4b0b91d70cf..14eb9ba836d3 100644 > > > > --- a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi > > > > +++ b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi > > > > @@ -187,6 +187,8 @@ mcu_r5fss0: r5fss@79000000 { > > > > ranges = <0x79000000 0x00 0x79000000 0x8000>, > > > > <0x79020000 0x00 0x79020000 0x8000>; > > > > power-domains = <&k3_pds 7 TI_SCI_PD_EXCLUSIVE>; > > > > + status = "disabled"; > > > > + > > > > mcu_r5fss0_core0: r5f@79000000 { > > > > compatible = "ti,am62-r5f"; > > > > reg = <0x79000000 0x00008000>, > > > > diff --git a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi > > > > index 19f42b39394e..10a7059b2d9b 100644 > > > > --- a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi > > > > +++ b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi > > > > @@ -78,6 +78,7 @@ wkup_r5fss0: r5fss@78000000 { > > > > ranges = <0x78000000 0x00 0x78000000 0x8000>, > > > > <0x78100000 0x00 0x78100000 0x8000>; > > > > power-domains = <&k3_pds 119 TI_SCI_PD_EXCLUSIVE>; > > > > + status = "disabled"; > > > > Is there a reason for difference in white space addition? > > > > For mcu_r5fss0_core0 child node there was no blank line as per the > recommended coding style : https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst#n124 > > So I added a newline there and wkup_r5fss0 already had it correct, since the > change was trivial it was not mentioned in commit message. > For some reason i was misled to think that the EoL spacing was messed up. Looking at https://lore.kernel.org/all/20240121134017.374992-1-vaishnav.a@ti.com/ i realise it is being fixed properly in the patch. Oops.. my bad. Reviewed-by: Nishanth Menon <nm@ti.com>
Am 21.01.24 um 14:40 schrieb Vaishnav Achath: > K3 Remoteproc R5 driver requires reserved memory carveouts and > mailbox configuration to instantiate the cores successfully. > Since this is a board level dependency, keep the R5 subsytem > disabled at SoC dtsi, otherwise it results in probe errors like > below during AM62P SK boot: > > r5fss@79000000: reserved memory init failed, ret = -22 > r5fss@79000000: k3_r5_cluster_rproc_init failed, ret = -22 > r5fss@78000000: reserved memory init failed, ret = -22 > r5fss@78000000: k3_r5_cluster_rproc_init failed, ret = -22 Shouldn't we have a similar patch for the am64 R5 cores? > > Fixes: b5080c7c1f7e ("arm64: dts: ti: k3-am62p: Add nodes for more IPs") > > Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com> > --- > arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi | 2 ++ > arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi > index c4b0b91d70cf..14eb9ba836d3 100644 > --- a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi > @@ -187,6 +187,8 @@ mcu_r5fss0: r5fss@79000000 { > ranges = <0x79000000 0x00 0x79000000 0x8000>, > <0x79020000 0x00 0x79020000 0x8000>; > power-domains = <&k3_pds 7 TI_SCI_PD_EXCLUSIVE>; > + status = "disabled"; > + > mcu_r5fss0_core0: r5f@79000000 { > compatible = "ti,am62-r5f"; > reg = <0x79000000 0x00008000>, > diff --git a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi > index 19f42b39394e..10a7059b2d9b 100644 > --- a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi > @@ -78,6 +78,7 @@ wkup_r5fss0: r5fss@78000000 { > ranges = <0x78000000 0x00 0x78000000 0x8000>, > <0x78100000 0x00 0x78100000 0x8000>; > power-domains = <&k3_pds 119 TI_SCI_PD_EXCLUSIVE>; > + status = "disabled"; > > wkup_r5fss0_core0: r5f@78000000 { > compatible = "ti,am62-r5f";
Hi Vaishnav Achath, On Sun, 21 Jan 2024 19:10:17 +0530, Vaishnav Achath wrote: > K3 Remoteproc R5 driver requires reserved memory carveouts and > mailbox configuration to instantiate the cores successfully. > Since this is a board level dependency, keep the R5 subsytem > disabled at SoC dtsi, otherwise it results in probe errors like > below during AM62P SK boot: > > r5fss@79000000: reserved memory init failed, ret = -22 > r5fss@79000000: k3_r5_cluster_rproc_init failed, ret = -22 > r5fss@78000000: reserved memory init failed, ret = -22 > r5fss@78000000: k3_r5_cluster_rproc_init failed, ret = -22 > > [...] I have applied the following to branch ti-k3-dts-next on [1]. Thank you! [1/1] arm64: dts: ti: k3-am62p-mcu/wakeup: Disable MCU and wakeup R5FSS nodes commit: dfc90e5f1a0fe0f8124521bc1911e38aa6cd9118 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent up the chain during the next merge window (or sooner if it is a relevant bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. [1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git -- Vignesh
diff --git a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi index c4b0b91d70cf..14eb9ba836d3 100644 --- a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi +++ b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi @@ -187,6 +187,8 @@ mcu_r5fss0: r5fss@79000000 { ranges = <0x79000000 0x00 0x79000000 0x8000>, <0x79020000 0x00 0x79020000 0x8000>; power-domains = <&k3_pds 7 TI_SCI_PD_EXCLUSIVE>; + status = "disabled"; + mcu_r5fss0_core0: r5f@79000000 { compatible = "ti,am62-r5f"; reg = <0x79000000 0x00008000>, diff --git a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi index 19f42b39394e..10a7059b2d9b 100644 --- a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi +++ b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi @@ -78,6 +78,7 @@ wkup_r5fss0: r5fss@78000000 { ranges = <0x78000000 0x00 0x78000000 0x8000>, <0x78100000 0x00 0x78100000 0x8000>; power-domains = <&k3_pds 119 TI_SCI_PD_EXCLUSIVE>; + status = "disabled"; wkup_r5fss0_core0: r5f@78000000 { compatible = "ti,am62-r5f";