Message ID | 20240121051735.32246-2-subhajit.ghosh@tweaklogic.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-31967-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2bc4:b0:101:a8e8:374 with SMTP id hx4csp2385553dyb; Sun, 21 Jan 2024 21:56:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IGC4hwLPiyll44ywtlvRNeHthtoWkIyJHh3Nb9vYTvfe/vHWtbKpV0aHcKKvQxPOmhBRCAl X-Received: by 2002:a05:6512:3e01:b0:50e:ab9b:c32 with SMTP id i1-20020a0565123e0100b0050eab9b0c32mr1911780lfv.78.1705903019589; Sun, 21 Jan 2024 21:56:59 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705903019; cv=pass; d=google.com; s=arc-20160816; b=jarw1LkcPfY8DWYf/8615n6JWr9of7+w+26VrV/Aj22JKQuGI69ET10bGqoYo0OMdw EDp5WWOTWBICf+uUfIkUtW3W4k5v3LpHskQ32c7W0oRNL9ZA22Vx0Lq/XbqR+1OMjUjT n4BNArAr1AMv6bgE5AXmFsPma0SSWYUzj7lI29f+AgJ3NMu99++EO5Pa2o6koIoPeG24 Z4yiW1S3nZDGi3++J8b3a2KAhZuXunjbHImZ7cF4SwIXeNjd2kOi9Dx4suEgewNDfiUD KE/cjGuXi9TL9md5LkGg3aKB3rlS0MWk/cy4xWligIpdBJQ+o/q8haXDnnk3ET8BQAtf noow== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=MUAl0p/EaTR1Qi6adL+zlZovqox3AbpG6qG1zKPGgTM=; fh=UmVHA2HXJwJd6uESM8v9C81mqF3XC2ufORF7x4MKwek=; b=Z1elrdZi39efdD0x3fRUvdbnjX5JBulsL/NQJR4Udzv0dt512UkQHLAm/xYL55mOkY hdboik3YITq3stDV7uo3EvSTavdRH9A4jwlQeukU1K527gTUYnizV0lkcQqJKcdFHpOl cvAoQ2pTTgaNSTlYKOaIDpMWmaZGXlFO0Xub566vfUgGSJpGhhsfhzqDbyqNd2qpsBYO rilQSJtnl8Xb26i7N1kb3ZdmEn2PAKNXN1zuadSpSz2fQfzphoYTkIuQ6nsW0WDMaXt+ cruWbOH5J1PjnMwh5tc1j8Ys3X+iw7/J+toQQVpwNdQUIS+YVzLCNyoVX18LVEy86W9/ l95A== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@tweaklogic.com header.s=google header.b=OuGh2J4U; arc=pass (i=1 spf=pass spfdomain=tweaklogic.com dkim=pass dkdomain=tweaklogic.com); spf=pass (google.com: domain of linux-kernel+bounces-31967-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-31967-ouuuleilei=gmail.com@vger.kernel.org" Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id p18-20020a1709066a9200b00a27eddc5e40si10279501ejr.532.2024.01.21.21.56.59 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jan 2024 21:56:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-31967-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@tweaklogic.com header.s=google header.b=OuGh2J4U; arc=pass (i=1 spf=pass spfdomain=tweaklogic.com dkim=pass dkdomain=tweaklogic.com); spf=pass (google.com: domain of linux-kernel+bounces-31967-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-31967-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 1AE401F21EEC for <ouuuleilei@gmail.com>; Sun, 21 Jan 2024 05:18:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1B836364C8; Sun, 21 Jan 2024 05:17:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tweaklogic.com header.i=@tweaklogic.com header.b="OuGh2J4U" Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1298364AB for <linux-kernel@vger.kernel.org>; Sun, 21 Jan 2024 05:17:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705814275; cv=none; b=Q3M7veSnlGaf+UBN/K38dqB9aohgE3F7yrKn6R/cIUgQJup22AmsCuMD/8qwk7L3zGp2akZFy6RBbZijdzDa8Y/150POAS8U08tnxVSS+MwgFgMeM25EqxlvgMv83wYl6v/z4jCTIsmFY5omgzcAlt9KUpcX9ye3XZAABqjGjag= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705814275; c=relaxed/simple; bh=78a/C/pLLexCT+VsDPwJ1QXzt1+JPkuSS1hne9CUx0M=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=PHXof+KQuMkbQGTpIpXM/fF/8BUV/6slM3CZNIiZ4rflcGPxanZufTxSfENYM3g9o2wS8T5GOcyjQXIxe7taApJ6LDf1USQSTIcOWiaAgQactbY+GpZ9GWsZs0COfLbNmydP8BRpH1r9yH/HhvmA+pm638x3hCIKNDRTfKKKNTU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tweaklogic.com; spf=pass smtp.mailfrom=tweaklogic.com; dkim=pass (2048-bit key) header.d=tweaklogic.com header.i=@tweaklogic.com header.b=OuGh2J4U; arc=none smtp.client-ip=209.85.210.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tweaklogic.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tweaklogic.com Received: by mail-ot1-f44.google.com with SMTP id 46e09a7af769-6dddf12f280so1608772a34.0 for <linux-kernel@vger.kernel.org>; Sat, 20 Jan 2024 21:17:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tweaklogic.com; s=google; t=1705814273; x=1706419073; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MUAl0p/EaTR1Qi6adL+zlZovqox3AbpG6qG1zKPGgTM=; b=OuGh2J4UZ3I/1Q4K/TvETIejK5An/Doufeix7f++6i5I9+9SnH+S9R/DYV4ciUFllL Re3iFK/TsPuARU7fM9hRjVQplnJj1OeiCdyqNVErIlFbpfzpJfUXICV6KHQBAcJCOiKl NpnGSp3IUuFyNV0mpy1+9qjmdzD0DU0V+CkotxfupcFvf5eAvyqBmLVK6pCngELVh7y6 WcdmTn1rw8RbrbrIUBA7KWToDrVC5vodzJQySBZ2HgM1MXpZajTZR9yFjfUXiWWYQi4h leFM9juYHBixxwPgQe1aMzyS/W6vOTMSgQf5hV1t3C0+Rnrpdp5Ha3OGB7AhkZKZHE1I nLIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705814273; x=1706419073; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MUAl0p/EaTR1Qi6adL+zlZovqox3AbpG6qG1zKPGgTM=; b=UXtHszRaoVj3N4dSnmD+ZO0BiF16sAVsP/xWAbHB7kJjb2aw2VZ/MzqsQlpce/qIJs AHLr4V7tJEwL1Ow77Wnl3Rftvx0JuIIRtIx9XQ22oj0KRHlZF4EmwEYdn9vpIhTa+LVY Nis05jIwQvhA7HKYvCQAsaUY0OUWMX/ZUXBtXWL+GzQipDAV4BEf+MPVReBUjzGIORK0 fqCqoVmP1f0Jy+uRkmfKLTiqSUeM9ErAQA19nj6tIwfHVfiOLkhgfuhu+gAeecbvAeuQ 5MpH1P6UiABfnWLcFLqGJaNfHumre98jiUiOtbnmvcpJbsCiUO6kjvOkF1C78A2szqVS IyBQ== X-Gm-Message-State: AOJu0YwEsHje0LzlMrwhblV0f+AgUlGHMKbojyGfJhwJRcKpek0r4EBD yRPgxdaZtGQC0yLCkTITll0jq18YXNxso62PSRZ/XJ1/dwMfSAb085iYp6BSMeI= X-Received: by 2002:a05:6830:3b0b:b0:6d9:db33:39a5 with SMTP id dk11-20020a0568303b0b00b006d9db3339a5mr2452993otb.75.1705814272957; Sat, 20 Jan 2024 21:17:52 -0800 (PST) Received: from localhost.localdomain (2403-580d-82f4-0-3fa1-f9ce-6074-3bab.ip6.aussiebb.net. [2403:580d:82f4:0:3fa1:f9ce:6074:3bab]) by smtp.gmail.com with ESMTPSA id f6-20020a056a000b0600b006d96d034befsm7547196pfu.30.2024.01.20.21.17.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Jan 2024 21:17:52 -0800 (PST) From: Subhajit Ghosh <subhajit.ghosh@tweaklogic.com> To: Jonathan Cameron <jic23@kernel.org>, Lars-Peter Clausen <lars@metafoo.de>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Matti Vaittinen <mazziesaccount@gmail.com>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Marek Vasut <marex@denx.de>, Anshul Dalal <anshulusr@gmail.com>, Javier Carrasco <javier.carrasco.cruz@gmail.com> Cc: Subhajit Ghosh <subhajit.ghosh@tweaklogic.com>, Matt Ranostay <matt@ranostay.sg>, Stefan Windfeldt-Prytz <stefan.windfeldt-prytz@axis.com>, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 1/3] dt-bindings: iio: light: Squash APDS9300 and APDS9960 schemas Date: Sun, 21 Jan 2024 15:47:32 +1030 Message-Id: <20240121051735.32246-2-subhajit.ghosh@tweaklogic.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240121051735.32246-1-subhajit.ghosh@tweaklogic.com> References: <20240121051735.32246-1-subhajit.ghosh@tweaklogic.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788714282502877127 X-GMAIL-MSGID: 1788768964622235486 |
Series |
Support for Avago APDS9306 Ambient Light Sensor
|
|
Commit Message
Subhajit Ghosh
Jan. 21, 2024, 5:17 a.m. UTC
Squashing Avago (Broadcom) APDS9300 and APDS9960 schemas into one
file and removing the other. This is done as per the below review:
Link: https://lore.kernel.org/all/4e785d2e-d310-4592-a75a-13549938dcef@linaro.org/
This patch series adds the driver support and device tree binding schemas
for APDS9306 Ambient Light Sensor. It was pointed out in earlier reviews
that the schemas for APDS9300 and APDS9960 looks similar and should be
merged. This particular patch does the first operation of merging
APDS9300 and APDS9960 schema files.
Signed-off-by: Subhajit Ghosh <subhajit.ghosh@tweaklogic.com>
---
v2 -> v5:
- Removed 'required' for Interrupts and 'oneOf' for compatibility strings
as per below reviews:
Link: https://lore.kernel.org/lkml/20231028142944.7e210eb6@jic23-huawei/
Link: https://lore.kernel.org/lkml/22e9e5e9-d26a-46e9-8986-5062bbfd72ec@linaro.org/
---
.../bindings/iio/light/avago,apds9300.yaml | 11 +++--
.../bindings/iio/light/avago,apds9960.yaml | 44 -------------------
2 files changed, 7 insertions(+), 48 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/iio/light/avago,apds9960.yaml
Comments
On 21/01/2024 06:17, Subhajit Ghosh wrote: > Squashing Avago (Broadcom) APDS9300 and APDS9960 schemas into one > file and removing the other. This is done as per the below review: > Link: https://lore.kernel.org/all/4e785d2e-d310-4592-a75a-13549938dcef@linaro.org/ > > This patch series adds the driver support and device tree binding schemas Please do not use "This commit/patch/change", but imperative mood. See longer explanation here: https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 Also, this is one commit, not patch series. Please write commit msg explaining why and what you are doing. > for APDS9306 Ambient Light Sensor. It was pointed out in earlier reviews > that the schemas for APDS9300 and APDS9960 looks similar and should be > merged. This particular patch does the first operation of merging > APDS9300 and APDS9960 schema files. https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > > Signed-off-by: Subhajit Ghosh <subhajit.ghosh@tweaklogic.com> With changes above and what Jonathan asks: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- This is an automated instruction, just in case, because many review tags are being ignored. If you know the process, you can skip it (please do not feel offended by me posting it here - no bad intentions intended). If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 Best regards, Krzysztof
On 22/1/24 01:57, Jonathan Cameron wrote: > On Sun, 21 Jan 2024 15:47:32 +1030 > Subhajit Ghosh <subhajit.ghosh@tweaklogic.com> wrote: > >> Squashing Avago (Broadcom) APDS9300 and APDS9960 schemas into one >> file and removing the other. This is done as per the below review: >> Link: https://lore.kernel.org/all/4e785d2e-d310-4592-a75a-13549938dcef@linaro.org/ > > Sounds like a Suggested-by tag to reflect the ideas would be sensible here. > >> >> This patch series adds the driver support and device tree binding schemas >> for APDS9306 Ambient Light Sensor. > > This sentence isn't relevant to this patch, so I'd drop it. > We don't need additional motivation. > >> It was pointed out in earlier reviews >> that the schemas for APDS9300 and APDS9960 looks similar and should be >> merged. This particular patch does the first operation of merging >> APDS9300 and APDS9960 schema files. > You have a reference above which is enough. > > "Merge very similar schemas for APDS9300 and APDS9960." > is sufficient description alongside a suggested by tag and if you like > a link tag to as above. Note however that Link is an official tag > so belongs in the tag block at the end, not inline in the text. > >> > Link: ... Thank you so much Jonathan for taking time to explain these things. Regards, Subhajit Ghosh
On 22/1/24 20:20, Krzysztof Kozlowski wrote: > On 21/01/2024 06:17, Subhajit Ghosh wrote: >> Squashing Avago (Broadcom) APDS9300 and APDS9960 schemas into one >> file and removing the other. This is done as per the below review: >> Link: https://lore.kernel.org/all/4e785d2e-d310-4592-a75a-13549938dcef@linaro.org/ >> >> This patch series adds the driver support and device tree binding schemas > > Please do not use "This commit/patch/change", but imperative mood. See > longer explanation here: > https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > > > Also, this is one commit, not patch series. Please write commit msg > explaining why and what you are doing. > >> for APDS9306 Ambient Light Sensor. It was pointed out in earlier reviews >> that the schemas for APDS9300 and APDS9960 looks similar and should be >> merged. This particular patch does the first operation of merging >> APDS9300 and APDS9960 schema files. > > https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > >> >> Signed-off-by: Subhajit Ghosh <subhajit.ghosh@tweaklogic.com> > > With changes above and what Jonathan asks: > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > --- > > This is an automated instruction, just in case, because many review tags > are being ignored. If you know the process, you can skip it (please do > not feel offended by me posting it here - no bad intentions intended). > If you do not know the process, here is a short explanation: > > Please add Acked-by/Reviewed-by/Tested-by tags when posting new > versions, under or above your Signed-off-by tag. Tag is "received", when > provided in a message replied to you on the mailing list. Tools like b4 > can help here. However, there's no need to repost patches *only* to add > the tags. The upstream maintainer will do that for tags received on the > version they apply. > > https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 > > > Best regards, > Krzysztof > Thank you so much Krysztof for the useful resources. Although I got the working knowledge from "A Beginner's Guide to Linux Kernel Development" course offered by Linux Foundation but there are gaps in my understanding. Time to study more. Regards, Subhajit Ghosh
diff --git a/Documentation/devicetree/bindings/iio/light/avago,apds9300.yaml b/Documentation/devicetree/bindings/iio/light/avago,apds9300.yaml index 206af44f2c43..c610780346e8 100644 --- a/Documentation/devicetree/bindings/iio/light/avago,apds9300.yaml +++ b/Documentation/devicetree/bindings/iio/light/avago,apds9300.yaml @@ -4,17 +4,20 @@ $id: http://devicetree.org/schemas/iio/light/avago,apds9300.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: Avago APDS9300 ambient light sensor +title: Avago Gesture/RGB/ALS/Proximity sensors maintainers: - - Jonathan Cameron <jic23@kernel.org> + - Subhajit Ghosh <subhajit.ghosh@tweaklogic.com> description: | - Datasheet at https://www.avagotech.com/docs/AV02-1077EN + Datasheet: https://www.avagotech.com/docs/AV02-1077EN + Datasheet: https://www.avagotech.com/docs/AV02-4191EN properties: compatible: - const: avago,apds9300 + enum: + - avago,apds9300 + - avago,apds9960 reg: maxItems: 1 diff --git a/Documentation/devicetree/bindings/iio/light/avago,apds9960.yaml b/Documentation/devicetree/bindings/iio/light/avago,apds9960.yaml deleted file mode 100644 index f06e0fda5629..000000000000 --- a/Documentation/devicetree/bindings/iio/light/avago,apds9960.yaml +++ /dev/null @@ -1,44 +0,0 @@ -# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) -%YAML 1.2 ---- -$id: http://devicetree.org/schemas/iio/light/avago,apds9960.yaml# -$schema: http://devicetree.org/meta-schemas/core.yaml# - -title: Avago APDS9960 gesture/RGB/ALS/proximity sensor - -maintainers: - - Matt Ranostay <matt.ranostay@konsulko.com> - -description: | - Datasheet at https://www.avagotech.com/docs/AV02-4191EN - -properties: - compatible: - const: avago,apds9960 - - reg: - maxItems: 1 - - interrupts: - maxItems: 1 - -additionalProperties: false - -required: - - compatible - - reg - -examples: - - | - i2c { - #address-cells = <1>; - #size-cells = <0>; - - light-sensor@39 { - compatible = "avago,apds9960"; - reg = <0x39>; - interrupt-parent = <&gpio1>; - interrupts = <16 1>; - }; - }; -...