Message ID | 20231024155137.219700-1-usama.anjum@collabora.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce89:0:b0:403:3b70:6f57 with SMTP id p9csp2036966vqx; Tue, 24 Oct 2023 08:52:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEn0JD3oHgeAdaAE+EUVTp/XjHWJMm4j/hCugTq6LcRN4rZ+jg95CkGMgFO4fzOUCvjclV3 X-Received: by 2002:a17:903:3211:b0:1ca:4d35:b2f3 with SMTP id s17-20020a170903321100b001ca4d35b2f3mr8179456plh.67.1698162730681; Tue, 24 Oct 2023 08:52:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698162730; cv=none; d=google.com; s=arc-20160816; b=av9QsF3vwu6Z3mDsUSfIFt0XAg55h6mbhR0JBnX9BC5mPBnOhuuLq2TYjgLmQDJQ+J dqqy5/MXREplrnbOrf0QzMWVvvzXEAhCj4dBarMh++/94azMPGmgfR8EASzROnsXGjGH Yx1s8K2xNaFEDGde8Ls43HiXRCYLRqyPYFGXvIZ/p0l1Jo5PhR2eaZTDmf2euF+yvV2f KVmzUtmeA4tcG3IhaWO9MEmgQa7ITL+7YhwiKYlcRKw1ZCdDrJStcs1L5Nt2AwUe1+Lm GXQdOprf1SWVnz6KwZ2gVHV5hsj7e8l8KUwXfjhLKQ4ZCaFGMWpVgjGzcFHBZiYedj2D /cQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=zAtCBw/84fj0jRn31+6t866IV1wtuFCttrZUfsGTji8=; fh=nAFKPkALsApfteg1ic/bb0a0C3am9dIjRdO1B5ZSNTk=; b=HpK4lo08uqaCRD2llQENXNoBL6qnUfpLxNVAj6bXttEyfBxSIs20Vn7u+fgO1LKteM epuTFaPGCmvbKtQZAlO5hHqsm1QMHuPYY8WRTyaY4XQicmBd/ars92g23Ac9RL89x4CW aXqNN2/YYIuPuEC5D0AsZoN8Dwmn7Heeyv1H76NE/FMD7d67ArlpMTj8uu90rnHU4c+w j9ow2woOS3fp1wPpF6Ipj9sHkYR3O3gKJdaAzBoK1lCsLLDaQOOHTQmtgjN+O9iw5Eqa ak2yl1lu60lvT2aXLlLtBV8P12VWCv/AbYRRT5Pluh49fhRPYzCp9QjEmxJCHgiPOkky jACQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=lRD69P3C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id d6-20020a170903230600b001c7380aca09si9089629plh.512.2023.10.24.08.52.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 08:52:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=lRD69P3C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 7EB8A80C1603; Tue, 24 Oct 2023 08:52:08 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343790AbjJXPv5 (ORCPT <rfc822;aposhian.dev@gmail.com> + 27 others); Tue, 24 Oct 2023 11:51:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233628AbjJXPv4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 24 Oct 2023 11:51:56 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7404CDE; Tue, 24 Oct 2023 08:51:54 -0700 (PDT) Received: from localhost.localdomain (unknown [116.71.169.209]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madras.collabora.co.uk (Postfix) with ESMTPSA id 04D0A660732E; Tue, 24 Oct 2023 16:51:47 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1698162713; bh=YeYy3+CWlsTYWmE3ZY32EUBI7hsgZl3/P6viV1Tr3jo=; h=From:To:Cc:Subject:Date:From; b=lRD69P3Cm7hmctulCRoxmdcSFIIHWL4f6Yx+BmQrOIU8+qh2zV/lI0najChNE2Fs0 x6BqwVKEpJvPqYQ55vvI/5i8DAZeGa8MNIt6fmhT8z/2Je+0RKAXsTP0KXRBGUrVpv iY3oiKE9pC4u3SjZr0NwOA2vRRo4GIRZ9r11xOkZD1D5RHLASoOalp6UVLDe9NlDUW dGsM0eDdETHP0cxx4yyOP7oVmZ4yCk863OE5Zu+q2+pVPk3DkcvYsNsASIG2+MvnAu N+quqP64kjvEnpw/tTn9HRp8ozlgqHkfgHaER7XB8ciQKGQNAyM9rFDYD/dFwm4e6l 9APAUG98fGlmg== From: Muhammad Usama Anjum <usama.anjum@collabora.com> To: Shuah Khan <shuah@kernel.org>, Muhammad Usama Anjum <usama.anjum@collabora.com> Cc: kernel@collabora.com, Aishwarya TCV <aishwarya.tcv@arm.com>, Shuah Khan <skhan@linuxfoundation.org>, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] selftests: core: include linux/close_range.h for CLOSE_RANGE_* macros Date: Tue, 24 Oct 2023 20:51:25 +0500 Message-ID: <20231024155137.219700-1-usama.anjum@collabora.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 24 Oct 2023 08:52:08 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780652683822972704 X-GMAIL-MSGID: 1780652683822972704 |
Series |
selftests: core: include linux/close_range.h for CLOSE_RANGE_* macros
|
|
Commit Message
Muhammad Usama Anjum
Oct. 24, 2023, 3:51 p.m. UTC
Correct header file is needed for getting CLOSE_RANGE_* macros.
Previously it was tested with newer glibc which didn't show the need to
include the header which was a mistake.
Fixes: ec54424923cf ("selftests: core: remove duplicate defines")
Reported-by: Aishwarya TCV <aishwarya.tcv@arm.com>
Link: https://lore.kernel.org/all/7161219e-0223-d699-d6f3-81abd9abf13b@arm.com
Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
---
tools/testing/selftests/core/close_range_test.c | 1 +
1 file changed, 1 insertion(+)
Comments
Soft reminder On 10/24/23 8:51 PM, Muhammad Usama Anjum wrote: > Correct header file is needed for getting CLOSE_RANGE_* macros. > Previously it was tested with newer glibc which didn't show the need to > include the header which was a mistake. > > Fixes: ec54424923cf ("selftests: core: remove duplicate defines") > Reported-by: Aishwarya TCV <aishwarya.tcv@arm.com> > Link: https://lore.kernel.org/all/7161219e-0223-d699-d6f3-81abd9abf13b@arm.com > Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> > --- > tools/testing/selftests/core/close_range_test.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/core/close_range_test.c b/tools/testing/selftests/core/close_range_test.c > index 534576f06df1c..c59e4adb905df 100644 > --- a/tools/testing/selftests/core/close_range_test.c > +++ b/tools/testing/selftests/core/close_range_test.c > @@ -12,6 +12,7 @@ > #include <syscall.h> > #include <unistd.h> > #include <sys/resource.h> > +#include <linux/close_range.h> > > #include "../kselftest_harness.h" > #include "../clone3/clone3_selftests.h"
Soft reminder On 11/29/23 4:34 PM, Muhammad Usama Anjum wrote: > Soft reminder > > On 10/24/23 8:51 PM, Muhammad Usama Anjum wrote: >> Correct header file is needed for getting CLOSE_RANGE_* macros. >> Previously it was tested with newer glibc which didn't show the need to >> include the header which was a mistake. >> >> Fixes: ec54424923cf ("selftests: core: remove duplicate defines") >> Reported-by: Aishwarya TCV <aishwarya.tcv@arm.com> >> Link: https://lore.kernel.org/all/7161219e-0223-d699-d6f3-81abd9abf13b@arm.com >> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> >> --- >> tools/testing/selftests/core/close_range_test.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/tools/testing/selftests/core/close_range_test.c b/tools/testing/selftests/core/close_range_test.c >> index 534576f06df1c..c59e4adb905df 100644 >> --- a/tools/testing/selftests/core/close_range_test.c >> +++ b/tools/testing/selftests/core/close_range_test.c >> @@ -12,6 +12,7 @@ >> #include <syscall.h> >> #include <unistd.h> >> #include <sys/resource.h> >> +#include <linux/close_range.h> >> >> #include "../kselftest_harness.h" >> #include "../clone3/clone3_selftests.h" >
Kind reminder On 12/11/23 4:01 PM, Muhammad Usama Anjum wrote: > Soft reminder > > On 11/29/23 4:34 PM, Muhammad Usama Anjum wrote: >> Soft reminder >> >> On 10/24/23 8:51 PM, Muhammad Usama Anjum wrote: >>> Correct header file is needed for getting CLOSE_RANGE_* macros. >>> Previously it was tested with newer glibc which didn't show the need to >>> include the header which was a mistake. >>> >>> Fixes: ec54424923cf ("selftests: core: remove duplicate defines") >>> Reported-by: Aishwarya TCV <aishwarya.tcv@arm.com> >>> Link: https://lore.kernel.org/all/7161219e-0223-d699-d6f3-81abd9abf13b@arm.com >>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> >>> --- >>> tools/testing/selftests/core/close_range_test.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/tools/testing/selftests/core/close_range_test.c b/tools/testing/selftests/core/close_range_test.c >>> index 534576f06df1c..c59e4adb905df 100644 >>> --- a/tools/testing/selftests/core/close_range_test.c >>> +++ b/tools/testing/selftests/core/close_range_test.c >>> @@ -12,6 +12,7 @@ >>> #include <syscall.h> >>> #include <unistd.h> >>> #include <sys/resource.h> >>> +#include <linux/close_range.h> >>> >>> #include "../kselftest_harness.h" >>> #include "../clone3/clone3_selftests.h" >> >
Hi, Can anybody please pick this patch? This was fixing genuine regression in some build system. Thanks, On 10/24/23 8:51 PM, Muhammad Usama Anjum wrote: > Correct header file is needed for getting CLOSE_RANGE_* macros. > Previously it was tested with newer glibc which didn't show the need to > include the header which was a mistake. > > Fixes: ec54424923cf ("selftests: core: remove duplicate defines") > Reported-by: Aishwarya TCV <aishwarya.tcv@arm.com> > Link: https://lore.kernel.org/all/7161219e-0223-d699-d6f3-81abd9abf13b@arm.com > Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> > --- > tools/testing/selftests/core/close_range_test.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/core/close_range_test.c b/tools/testing/selftests/core/close_range_test.c > index 534576f06df1c..c59e4adb905df 100644 > --- a/tools/testing/selftests/core/close_range_test.c > +++ b/tools/testing/selftests/core/close_range_test.c > @@ -12,6 +12,7 @@ > #include <syscall.h> > #include <unistd.h> > #include <sys/resource.h> > +#include <linux/close_range.h> > > #include "../kselftest_harness.h" > #include "../clone3/clone3_selftests.h"
diff --git a/tools/testing/selftests/core/close_range_test.c b/tools/testing/selftests/core/close_range_test.c index 534576f06df1c..c59e4adb905df 100644 --- a/tools/testing/selftests/core/close_range_test.c +++ b/tools/testing/selftests/core/close_range_test.c @@ -12,6 +12,7 @@ #include <syscall.h> #include <unistd.h> #include <sys/resource.h> +#include <linux/close_range.h> #include "../kselftest_harness.h" #include "../clone3/clone3_selftests.h"