Message ID | 20240122-breeder-lying-0d3668d98886@spud |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-32998-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2bc4:b0:101:a8e8:374 with SMTP id hx4csp2533158dyb; Mon, 22 Jan 2024 04:25:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IEKhoqSXkO7nHL/cOnfJFEqzHaGOLX98AwhWFP9EWiqVcZ4YxFJ+aeb2EQ43Seu0ZzXbBTz X-Received: by 2002:a05:6a20:daa5:b0:19b:a07a:3495 with SMTP id iy37-20020a056a20daa500b0019ba07a3495mr7214329pzb.25.1705926353027; Mon, 22 Jan 2024 04:25:53 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705926353; cv=pass; d=google.com; s=arc-20160816; b=I1xY+1SOGc2b/iliCSAJEJA81e44ngs7BWAsT5uleJebJw45ghzy8Q9LbhmjH/Rxez YXIRQ9K4l8bv8pNv9fS5OgBxmJYVQ6SisAUwDlurPzg0zb9GUEJjQicpdTOWfCWfhglu yMopHxvPs7+exVPyS2Wh4leulOXHXvDuVxHbwnKnww+Rnwh4zymO7LHo32dvWJc7yMku t2D/B1wfsQeOEYbAXaSKLp/XZ54ExXua1KC3thxBMMlakMISWZhKxAqXxa8V7bB5EnpA BguHhgK03Zbl63GWhBBaE2AeHfA7wWyLJ4+x2wEqfUGoJiohjrZqXL9TYYjwceQ371Ct vczA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=T1eR2ZWK2YFg1dfgPImWRNx1PM+Oe3qV2tgVYPTyk/Y=; fh=7owW42T6ZLRf2RzLwZvq8R8LNTe7zgMt8CKJpj74120=; b=iQuDZBflZApy4jpSG5df8/LU04pewSictmPAMx80CrZzaKd8FgNGSwMTOGgMZQlslg UyIRcQktM4mVAUUCzz8GZejcR82ZQNoF4672nMsPCPL99IPAXmHxF5pFyJqa8F9pnVrP SOAfTVDaKDshXjEbs3SF2szUIO04M+xfiixodN+lS4WLkYPROPI3lLvrWRdiDEZZ+K4b 3S8MSt9ZAsPMTKn7czpfNnfmmJnaEDe8vDZ/B8RfcQYqxli72UmlCVOz8M3hlXeRGGK4 81BkjfuCOysSY1PtItlzy62oDEa4EStEyVJqDEkr+NkSxWLi0JJ/2rCckgcYLcbqoQmw 8KJQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=q0+1BfKX; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-32998-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-32998-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id c6-20020a633506000000b005ce5b74d518si8250872pga.493.2024.01.22.04.25.52 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 04:25:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-32998-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=q0+1BfKX; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-32998-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-32998-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id A08BC28A15D for <ouuuleilei@gmail.com>; Mon, 22 Jan 2024 12:21:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6FCBF3D0C0; Mon, 22 Jan 2024 12:20:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="q0+1BfKX" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBF0F3CF6D; Mon, 22 Jan 2024 12:20:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705926021; cv=none; b=nWb7LrfAbtMJLhDA5d4WcBp0aOEiAm8XQfKht5rbUwV9j6Y1SD/DvSbTCnhqGl40vfvHe97G0GJJSLG6bSdYeqSBU7NbdPE6bGUgQxnRzraU11MwS9FCeRItfYsmyzb7buacZL+jOLdvvo9VUtgYiE+SywzHpQFZfsqYnqr9CFc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705926021; c=relaxed/simple; bh=8d4o8b6w9hvJ+ehL0Gmci/4wXJY8BAIb5BXSCLU2izA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=u5VTJju5Ykz8qBxS4LA7nnEYHHKMsiYVEhdoO1ryGqUhHQuS25dMGsk2hOcd0ZZAD9BlaCyguQzLx0IoPVW0YyFeSoPdoihGQFY0bTBi8L0DYrdC3v2xSAyCcSPYyRK7kaG46MihSZrs++HXxYDYqLr9BhUx/BQtyg30Zn48bhU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=q0+1BfKX; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2AC3C433F1; Mon, 22 Jan 2024 12:20:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705926021; bh=8d4o8b6w9hvJ+ehL0Gmci/4wXJY8BAIb5BXSCLU2izA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=q0+1BfKXT/Q3WTcV0v6zrkcMPc7AkN+h+88/RrAqg+eqV8RBIoaHAbJhpXzXjsRsz GJl3f+fXohP8flUgMqa9BI4qS2FBiQ9dyCT4MvEbvcvBLz3u48iApRltaJxIKcKMrK 9s1FrXOCnW9axnQEJMkr75lPaYRkKQTCmI+xxYau+xQc/4XB5+WF01JEY4lrXX+IKV eavw9YDFVtmp+zwwdxyUgPDl3objzuoXbGs+H2/1C0jlbk48f0OhDcG009hXW903xf GVGQm0Mako7Pxixm/wjC2jBKo/FIiCqLRZum/bT05i32Dd8POLYXCJuaL980eBU67u 0o+hXceniIHhA== From: Conor Dooley <conor@kernel.org> To: linux-riscv@lists.infradead.org Cc: conor@kernel.org, Conor Dooley <conor.dooley@microchip.com>, Daire McNamara <daire.mcnamara@microchip.com>, Wolfgang Grandegger <wg@grandegger.com>, Marc Kleine-Budde <mkl@pengutronix.de>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, linux-can@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: [PATCH v2 2/7] dt-bindings: can: mpfs: add missing required clock Date: Mon, 22 Jan 2024 12:19:50 +0000 Message-ID: <20240122-breeder-lying-0d3668d98886@spud> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240122-catty-roast-d3625dbb02fe@spud> References: <20240122-catty-roast-d3625dbb02fe@spud> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1423; i=conor.dooley@microchip.com; h=from:subject:message-id; bh=NrajZ8DKLByCJYLOG7gevyAp2euhGy7v9GQJAOxw45A=; b=owGbwMvMwCFWscWwfUFT0iXG02pJDKnrYlPKSnQ17k1J/f3WvmYO46S1vI6Zc+PX+eiHL7mtm OS1+1xcRykLgxgHg6yYIkvi7b4WqfV/XHY497yFmcPKBDKEgYtTACay9Bwjw6rOzD+StveFa45F 3lLZYsjaYnNviefhqQbpbO5Pw4zdvRj+xxjJuMotUOz7uJhffcfz6Q+9jdZdWXft3VytDs0X8uH qLAA= X-Developer-Key: i=conor.dooley@microchip.com; a=openpgp; fpr=F9ECA03CF54F12CD01F1655722E2C55B37CF380C Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788793431755284231 X-GMAIL-MSGID: 1788793431755284231 |
Series |
MPFS clock fixes required for correct CAN clock modeling
|
|
Commit Message
Conor Dooley
Jan. 22, 2024, 12:19 p.m. UTC
From: Conor Dooley <conor.dooley@microchip.com> The CAN controller on PolarFire SoC has an AHB peripheral clock _and_ a CAN bus clock. The bus clock was omitted when the binding was written, but is required for operation. Make up for lost time and add it. Cautionary tale in adding bindings without having implemented a real user for them perhaps. Fixes: c878d518d7b6 ("dt-bindings: can: mpfs: document the mpfs CAN controller") Signed-off-by: Conor Dooley <conor.dooley@microchip.com> --- .../devicetree/bindings/net/can/microchip,mpfs-can.yaml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
Comments
On 22.01.2024 12:19:50, Conor Dooley wrote: > From: Conor Dooley <conor.dooley@microchip.com> > > The CAN controller on PolarFire SoC has an AHB peripheral clock _and_ a > CAN bus clock. The bus clock was omitted when the binding was written, > but is required for operation. Make up for lost time and add it. > > Cautionary tale in adding bindings without having implemented a real > user for them perhaps. > > Fixes: c878d518d7b6 ("dt-bindings: can: mpfs: document the mpfs CAN controller") > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > --- > .../devicetree/bindings/net/can/microchip,mpfs-can.yaml | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml > index 45aa3de7cf01..01e4d4a54df6 100644 > --- a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml > +++ b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml > @@ -24,7 +24,9 @@ properties: > maxItems: 1 > > clocks: > - maxItems: 1 > + items: > + - description: AHB peripheral clock > + - description: CAN bus clock What about adding clock-names, so that the order can be checked automatically? > > required: > - compatible > @@ -39,7 +41,7 @@ examples: > can@2010c000 { > compatible = "microchip,mpfs-can"; > reg = <0x2010c000 0x1000>; > - clocks = <&clkcfg 17>; > + clocks = <&clkcfg 17>, <&clkcfg 37>; > interrupt-parent = <&plic>; > interrupts = <56>; > }; > -- > 2.43.0 > > Marc
On Mon, Jan 22, 2024 at 02:13:16PM +0100, Marc Kleine-Budde wrote: > On 22.01.2024 12:19:50, Conor Dooley wrote: > > From: Conor Dooley <conor.dooley@microchip.com> > > > > The CAN controller on PolarFire SoC has an AHB peripheral clock _and_ a > > CAN bus clock. The bus clock was omitted when the binding was written, > > but is required for operation. Make up for lost time and add it. > > > > Cautionary tale in adding bindings without having implemented a real > > user for them perhaps. > > > > Fixes: c878d518d7b6 ("dt-bindings: can: mpfs: document the mpfs CAN controller") > > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > > --- > > .../devicetree/bindings/net/can/microchip,mpfs-can.yaml | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml > > index 45aa3de7cf01..01e4d4a54df6 100644 > > --- a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml > > +++ b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml > > @@ -24,7 +24,9 @@ properties: > > maxItems: 1 > > > > clocks: > > - maxItems: 1 > > + items: > > + - description: AHB peripheral clock > > + - description: CAN bus clock > > What about adding clock-names, so that the order can be checked > automatically? I don't personally care for doing so, but if your heart is set on having them, then sure. Cheers, Conor.
On 22.01.2024 14:21:04, Conor Dooley wrote: > On Mon, Jan 22, 2024 at 02:13:16PM +0100, Marc Kleine-Budde wrote: > > On 22.01.2024 12:19:50, Conor Dooley wrote: > > > From: Conor Dooley <conor.dooley@microchip.com> > > > > > > The CAN controller on PolarFire SoC has an AHB peripheral clock _and_ a > > > CAN bus clock. The bus clock was omitted when the binding was written, > > > but is required for operation. Make up for lost time and add it. > > > > > > Cautionary tale in adding bindings without having implemented a real > > > user for them perhaps. > > > > > > Fixes: c878d518d7b6 ("dt-bindings: can: mpfs: document the mpfs CAN controller") > > > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > > > --- > > > .../devicetree/bindings/net/can/microchip,mpfs-can.yaml | 6 ++++-- > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml > > > index 45aa3de7cf01..01e4d4a54df6 100644 > > > --- a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml > > > +++ b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml > > > @@ -24,7 +24,9 @@ properties: > > > maxItems: 1 > > > > > > clocks: > > > - maxItems: 1 > > > + items: > > > + - description: AHB peripheral clock > > > + - description: CAN bus clock > > > > What about adding clock-names, so that the order can be checked > > automatically? > > I don't personally care for doing so, but if your heart is set on having > them, then sure. Usually the CAN driver needs to have the clock rate of the clocks that the basis for the CAN bus clock. Looking at the clocks description it's probably the 2nd one. With clock-names we can automatically check that the 2nd clock is always the CAN clock. Marc
On Mon, Jan 22, 2024 at 03:46:04PM +0100, Marc Kleine-Budde wrote: > On 22.01.2024 14:21:04, Conor Dooley wrote: > > On Mon, Jan 22, 2024 at 02:13:16PM +0100, Marc Kleine-Budde wrote: > > > On 22.01.2024 12:19:50, Conor Dooley wrote: > > > > From: Conor Dooley <conor.dooley@microchip.com> > > > > > > > > The CAN controller on PolarFire SoC has an AHB peripheral clock _and_ a > > > > CAN bus clock. The bus clock was omitted when the binding was written, > > > > but is required for operation. Make up for lost time and add it. > > > > > > > > Cautionary tale in adding bindings without having implemented a real > > > > user for them perhaps. > > > > > > > > Fixes: c878d518d7b6 ("dt-bindings: can: mpfs: document the mpfs CAN controller") > > > > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > > > > --- > > > > .../devicetree/bindings/net/can/microchip,mpfs-can.yaml | 6 ++++-- > > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml > > > > index 45aa3de7cf01..01e4d4a54df6 100644 > > > > --- a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml > > > > +++ b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml > > > > @@ -24,7 +24,9 @@ properties: > > > > maxItems: 1 > > > > > > > > clocks: > > > > - maxItems: 1 > > > > + items: > > > > + - description: AHB peripheral clock > > > > + - description: CAN bus clock > > > > > > What about adding clock-names, so that the order can be checked > > > automatically? > > > > I don't personally care for doing so, but if your heart is set on having > > them, then sure. > > Usually the CAN driver needs to have the clock rate of the clocks that > the basis for the CAN bus clock. Looking at the clocks description it's > probably the 2nd one. > > With clock-names we can automatically check that the 2nd clock is always > the CAN clock. I think we already had this discussion on v1, where I said that the binding requires the clocks to be in that order, regardless of whether or not clock-names is provided. You feel more strongly about it than I do, so I will add them when I get around to sending a v3. Cheers, Conor.
On 22.01.2024 14:56:09, Conor Dooley wrote: > On Mon, Jan 22, 2024 at 03:46:04PM +0100, Marc Kleine-Budde wrote: > > On 22.01.2024 14:21:04, Conor Dooley wrote: > > > On Mon, Jan 22, 2024 at 02:13:16PM +0100, Marc Kleine-Budde wrote: > > > > On 22.01.2024 12:19:50, Conor Dooley wrote: > > > > > From: Conor Dooley <conor.dooley@microchip.com> > > > > > > > > > > The CAN controller on PolarFire SoC has an AHB peripheral clock _and_ a > > > > > CAN bus clock. The bus clock was omitted when the binding was written, > > > > > but is required for operation. Make up for lost time and add it. > > > > > > > > > > Cautionary tale in adding bindings without having implemented a real > > > > > user for them perhaps. > > > > > > > > > > Fixes: c878d518d7b6 ("dt-bindings: can: mpfs: document the mpfs CAN controller") > > > > > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > > > > > --- > > > > > .../devicetree/bindings/net/can/microchip,mpfs-can.yaml | 6 ++++-- > > > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml > > > > > index 45aa3de7cf01..01e4d4a54df6 100644 > > > > > --- a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml > > > > > +++ b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml > > > > > @@ -24,7 +24,9 @@ properties: > > > > > maxItems: 1 > > > > > > > > > > clocks: > > > > > - maxItems: 1 > > > > > + items: > > > > > + - description: AHB peripheral clock > > > > > + - description: CAN bus clock > > > > > > > > What about adding clock-names, so that the order can be checked > > > > automatically? > > > > > > I don't personally care for doing so, but if your heart is set on having > > > them, then sure. > > > > Usually the CAN driver needs to have the clock rate of the clocks that > > the basis for the CAN bus clock. Looking at the clocks description it's > > probably the 2nd one. > > > > With clock-names we can automatically check that the 2nd clock is always > > the CAN clock. > > I think we already had this discussion on v1, where I said that the > binding requires the clocks to be in that order, regardless of whether > or not clock-names is provided. You feel more strongly about it than I > do, so I will add them when I get around to sending a v3. Yes, this discussion sounded very familiar to me, never mind. Keep it as is, and let's get this binding and the CAN driver upstream! regards, Marc
On Mon, Jan 22, 2024 at 04:31:32PM +0100, Marc Kleine-Budde wrote:
> let's get this binding and the CAN driver upstream!
FWIW, the driver seems to be in a good state (or as good as it can to
someone unaware of the goings on of CAN). Hopefully the author gets
a chance to send it out soon.
Cheers,
Conor.
On 22/01/2024 13:19, Conor Dooley wrote: > From: Conor Dooley <conor.dooley@microchip.com> > > The CAN controller on PolarFire SoC has an AHB peripheral clock _and_ a > CAN bus clock. The bus clock was omitted when the binding was written, > but is required for operation. Make up for lost time and add it. > > Cautionary tale in adding bindings without having implemented a real > user for them perhaps. > > Fixes: c878d518d7b6 ("dt-bindings: can: mpfs: document the mpfs CAN controller") > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > --- > .../devicetree/bindings/net/can/microchip,mpfs-can.yaml | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Mon, Jan 22, 2024 at 04:31:32PM +0100, Marc Kleine-Budde wrote: > On 22.01.2024 14:56:09, Conor Dooley wrote: > > I think we already had this discussion on v1, where I said that the > > binding requires the clocks to be in that order, regardless of whether > > or not clock-names is provided. You feel more strongly about it than I > > do, so I will add them when I get around to sending a v3. > > Yes, this discussion sounded very familiar to me, never mind. Keep it as > is, and let's get this binding and the CAN driver upstream! BTW, I didn't see an ack on this nor do I see it in linux-next (yet). Are you expecting the patch to go with the rest via the clock tree, via the DT tree or will you be taking it with CAN stuff via netdev? I can resend this one patch with a netdev appropriate subject prefix if you like. Thanks, Conor.
On 30.01.2024 12:11:44, Conor Dooley wrote: > On Mon, Jan 22, 2024 at 04:31:32PM +0100, Marc Kleine-Budde wrote: > > On 22.01.2024 14:56:09, Conor Dooley wrote: > > > > I think we already had this discussion on v1, where I said that the > > > binding requires the clocks to be in that order, regardless of whether > > > or not clock-names is provided. You feel more strongly about it than I > > > do, so I will add them when I get around to sending a v3. > > > > Yes, this discussion sounded very familiar to me, never mind. Keep it as > > is, and let's get this binding and the CAN driver upstream! > > BTW, I didn't see an ack on this nor do I see it in linux-next (yet). > Are you expecting the patch to go with the rest via the clock tree, > via the DT tree or will you be taking it with CAN stuff via netdev? > > I can resend this one patch with a netdev appropriate subject prefix > if you like. Feel free to take the whole series via the clock tree. Marc
On Tue, Jan 30, 2024 at 02:01:09PM +0100, Marc Kleine-Budde wrote: > On 30.01.2024 12:11:44, Conor Dooley wrote: > > On Mon, Jan 22, 2024 at 04:31:32PM +0100, Marc Kleine-Budde wrote: > > > On 22.01.2024 14:56:09, Conor Dooley wrote: > > > > > > I think we already had this discussion on v1, where I said that the > > > > binding requires the clocks to be in that order, regardless of whether > > > > or not clock-names is provided. You feel more strongly about it than I > > > > do, so I will add them when I get around to sending a v3. > > > > > > Yes, this discussion sounded very familiar to me, never mind. Keep it as > > > is, and let's get this binding and the CAN driver upstream! > > > > BTW, I didn't see an ack on this nor do I see it in linux-next (yet). > > Are you expecting the patch to go with the rest via the clock tree, > > via the DT tree or will you be taking it with CAN stuff via netdev? > > > > I can resend this one patch with a netdev appropriate subject prefix > > if you like. > > Feel free to take the whole series via the clock tree. Okay, I've gone and applied all of the binding and driver patches to the branch we will send to Stephen. Thanks!
diff --git a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml index 45aa3de7cf01..01e4d4a54df6 100644 --- a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml +++ b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml @@ -24,7 +24,9 @@ properties: maxItems: 1 clocks: - maxItems: 1 + items: + - description: AHB peripheral clock + - description: CAN bus clock required: - compatible @@ -39,7 +41,7 @@ examples: can@2010c000 { compatible = "microchip,mpfs-can"; reg = <0x2010c000 0x1000>; - clocks = <&clkcfg 17>; + clocks = <&clkcfg 17>, <&clkcfg 37>; interrupt-parent = <&plic>; interrupts = <56>; };