diff mbox series

iio: adc: ad7091r8: Fix error code in ad7091r8_gpio_setup()

Message ID fd905ad0-6413-489c-9a3b-90c0cdb35ec9@moroto.mountain
State New
Headers
Series iio: adc: ad7091r8: Fix error code in ad7091r8_gpio_setup() |

Commit Message

Dan Carpenter Jan. 8, 2024, 9:07 a.m. UTC 
  There is a copy and paste error so it accidentally returns ->convst_gpio
instead of ->reset_gpio.  Fix it.

Fixes: 0b76ff46c463 ("iio: adc: Add support for AD7091R-8")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 drivers/iio/adc/ad7091r8.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Marcelo Schmitt Jan. 12, 2024, 2 a.m. UTC | #1 
On 01/08, Dan Carpenter wrote:
> There is a copy and paste error so it accidentally returns ->convst_gpio
> instead of ->reset_gpio.  Fix it.
> 
> Fixes: 0b76ff46c463 ("iio: adc: Add support for AD7091R-8")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---

Oops, that also slipped through.
Thanks for the fix.

Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com>

>  drivers/iio/adc/ad7091r8.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/ad7091r8.c b/drivers/iio/adc/ad7091r8.c
> index 57700f124803..700564305057 100644
> --- a/drivers/iio/adc/ad7091r8.c
> +++ b/drivers/iio/adc/ad7091r8.c
> @@ -195,7 +195,7 @@ static int ad7091r8_gpio_setup(struct ad7091r_state *st)
>  	st->reset_gpio = devm_gpiod_get_optional(st->dev, "reset",
>  						 GPIOD_OUT_HIGH);
>  	if (IS_ERR(st->reset_gpio))
> -		return dev_err_probe(st->dev, PTR_ERR(st->convst_gpio),
> +		return dev_err_probe(st->dev, PTR_ERR(st->reset_gpio),
>  				     "Error on requesting reset GPIO\n");
>  
>  	if (st->reset_gpio) {
> -- 
> 2.42.0
> 
>
Jonathan Cameron Jan. 21, 2024, 4:59 p.m. UTC | #2 
On Thu, 11 Jan 2024 23:00:22 -0300
Marcelo Schmitt <marcelo.schmitt1@gmail.com> wrote:

> On 01/08, Dan Carpenter wrote:
> > There is a copy and paste error so it accidentally returns ->convst_gpio
> > instead of ->reset_gpio.  Fix it.
> > 
> > Fixes: 0b76ff46c463 ("iio: adc: Add support for AD7091R-8")
> > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> > ---  
> 
> Oops, that also slipped through.
> Thanks for the fix.
> 
> Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
Applied to the fixes-togreg branch of iio.git.

Thanks,

Jonathan

> 
> >  drivers/iio/adc/ad7091r8.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/iio/adc/ad7091r8.c b/drivers/iio/adc/ad7091r8.c
> > index 57700f124803..700564305057 100644
> > --- a/drivers/iio/adc/ad7091r8.c
> > +++ b/drivers/iio/adc/ad7091r8.c
> > @@ -195,7 +195,7 @@ static int ad7091r8_gpio_setup(struct ad7091r_state *st)
> >  	st->reset_gpio = devm_gpiod_get_optional(st->dev, "reset",
> >  						 GPIOD_OUT_HIGH);
> >  	if (IS_ERR(st->reset_gpio))
> > -		return dev_err_probe(st->dev, PTR_ERR(st->convst_gpio),
> > +		return dev_err_probe(st->dev, PTR_ERR(st->reset_gpio),
> >  				     "Error on requesting reset GPIO\n");
> >  
> >  	if (st->reset_gpio) {
> > -- 
> > 2.42.0
> > 
> >
diff mbox series

Patch

diff --git a/drivers/iio/adc/ad7091r8.c b/drivers/iio/adc/ad7091r8.c
index 57700f124803..700564305057 100644
--- a/drivers/iio/adc/ad7091r8.c
+++ b/drivers/iio/adc/ad7091r8.c
@@ -195,7 +195,7 @@  static int ad7091r8_gpio_setup(struct ad7091r_state *st)
 	st->reset_gpio = devm_gpiod_get_optional(st->dev, "reset",
 						 GPIOD_OUT_HIGH);
 	if (IS_ERR(st->reset_gpio))
-		return dev_err_probe(st->dev, PTR_ERR(st->convst_gpio),
+		return dev_err_probe(st->dev, PTR_ERR(st->reset_gpio),
 				     "Error on requesting reset GPIO\n");
 
 	if (st->reset_gpio) {