Message ID | 20240112094538.65639-1-angelogioacchino.delregno@collabora.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-24497-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2614:b0:101:6a76:bbe3 with SMTP id mm20csp63964dyc; Fri, 12 Jan 2024 01:46:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IHB5mgxjFpwDmqFLA4p9UL4GJ5zxHBfdPYvXBRGSSG2rcC7+TY2bn5QZoN+S/E2z0OW1WgB X-Received: by 2002:a05:6a20:1614:b0:199:fc46:53ba with SMTP id l20-20020a056a20161400b00199fc4653bamr621554pzj.54.1705052778715; Fri, 12 Jan 2024 01:46:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705052778; cv=none; d=google.com; s=arc-20160816; b=ZJoxUXBSM4S9WInzZW0M4lv3o4NSzUlkgR9C4L0C5pFuaZ4mHt+jiYgbmmE6amP4l2 M1kJMyYjMldEN58nDtv5KeNveFeIb+sCB9USRN3LbBGv28MuTTixdQdVVQJXtOYVF9rB 6Su+BfQw+JP91vNvJIZsRtGH81kdGoHl2Xu4iLqVWWcSUBavvrVklCJRHb3tsHEC91Ic N5OMQk1+7P3tEucPqk+bBgqWV5Gb8wT5sIWSmWYP1TUm6JEYfNzGI8WMqkjp0zv9ge6P ZeEEwwSyJ3LNWxs7XnrDkjbqhIyQuS2CWiGizDDCBOsCOGbjbehFwUciPpyzsfv2AeJ6 oTQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=bPRcJwo6xsSCSwIaeAHSl5TpF7dT8vt1ryzp6V3Agsc=; fh=lqkJ6CqbbxegKG7LCDgWfgW+IZauwXtYaDSejBiAbNc=; b=OPIbI+3njghdO521Bv0h6a4PUqKpiHukIgWxNVd8BONxm3Qrb80cY+CNFWODe2Bzeb 2tDW43BWA2y4hP2GTeXAgO5vchINuai/wnjAGffZ1kSVUkIeJqvSDT65SYmVyAVG03b8 B/q9MAAEmNp1vLTDneVWr5+uSWCqRFgfvrSjLLY61DoQb/V/ZuogfrjgvmcD4oODJFz8 N0kKzrHK/rOlMs3C0lBdS9eZS8bXh+HEZczmRnm7AZvn+L++M7eHMVk0HqTXBISLR2Y+ 5tJ8tIqrs4I/4DgOzTFRg+++xnGHdfcLe2rI/U+Zxy5wgw7pGHJ76mnhj+39drSJPAn+ rH4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=xF2OLl39; spf=pass (google.com: domain of linux-kernel+bounces-24497-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-24497-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id t11-20020a170902e84b00b001d4768590d9si3213354plg.414.2024.01.12.01.46.18 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jan 2024 01:46:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-24497-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=xF2OLl39; spf=pass (google.com: domain of linux-kernel+bounces-24497-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-24497-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 7E4DA286B27 for <ouuuleilei@gmail.com>; Fri, 12 Jan 2024 09:46:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 59E835D73A; Fri, 12 Jan 2024 09:45:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="xF2OLl39" Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B7082BD1A; Fri, 12 Jan 2024 09:45:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1705052743; bh=IJ0fhahSkBQixlmEf3QoSmH4xGCg8CHJlBEhtfGdLM8=; h=From:To:Cc:Subject:Date:From; b=xF2OLl39wqqJO0TA3f5smqCQhLClBMqGoWzc+IhNY9x7wNUhvQ4D2yAB9RZ1h6CAj S81nrzPjhZUf+/Biy3FyEAYk5Us59/bXA5WRAexnVZpERmXexIBGSYuWi7nJ7mrMAM MeXgOE04Twr5J6IiarBICERj8O7gC7MIUDvjz/4AMvrlpnhoRVISBGGWt74o/u0hXi 1JEDzIX5UTgngaCooH/5JiceZkb6u+WP2qnQp+of/hkbAmwFHyJGsyyXiqFD4QTrAk 1JZwdmmKJ8YitiJpMPIwFCRT7DmEX5NL0xByT5ImcFFwN36hDvPKxXI4WMjziyM2n8 Oqn29EOzVTfkg== Received: from IcarusMOD.eternityproject.eu (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 70B0E3781FCF; Fri, 12 Jan 2024 09:45:42 +0000 (UTC) From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> To: chunfeng.yun@mediatek.com Cc: gregkh@linuxfoundation.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, linux@roeck-us.net, heikki.krogerus@linux.intel.com, cy_huang@richtek.com, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: [PATCH 1/2] dt-bindings: usb: mt6360-tcpc: Rename IRQ to PD-IRQB Date: Fri, 12 Jan 2024 10:45:37 +0100 Message-ID: <20240112094538.65639-1-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787877422476537430 X-GMAIL-MSGID: 1787877422476537430 |
Series |
[1/2] dt-bindings: usb: mt6360-tcpc: Rename IRQ to PD-IRQB
|
|
Commit Message
AngeloGioacchino Del Regno
Jan. 12, 2024, 9:45 a.m. UTC
Since there is no user yet, rename the only interrupt of this device
to "PD-IRQB", avoiding underscores.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On Fri, 12 Jan 2024 10:45:37 +0100, AngeloGioacchino Del Regno wrote: > Since there is no user yet, rename the only interrupt of this device > to "PD-IRQB", avoiding underscores. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > .../devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/mediatek,mt6360.example.dtb: pmic@34: tcpc:interrupt-names:0: 'PD-IRQB' was expected from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6360.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/mediatek,mt6360.example.dtb: tcpc: interrupt-names:0: 'PD-IRQB' was expected from schema $id: http://devicetree.org/schemas/usb/mediatek,mt6360-tcpc.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240112094538.65639-1-angelogioacchino.delregno@collabora.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Fri, Jan 12, 2024 at 10:45:37AM +0100, AngeloGioacchino Del Regno wrote: > Since there is no user yet, rename the only interrupt of this device > to "PD-IRQB", avoiding underscores. It is primarily node and property names that have this recommendation, not so much -names values. If there is only 1 interrupt, I'd just drop the name. > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > .../devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml > index 053264e60583..0bea23ce2f09 100644 > --- a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml > +++ b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml > @@ -24,7 +24,7 @@ properties: > > interrupt-names: > items: > - - const: PD_IRQB > + - const: PD-IRQB > > connector: > type: object > @@ -58,7 +58,7 @@ examples: > tcpc { > compatible = "mediatek,mt6360-tcpc"; > interrupts-extended = <&gpio26 3 IRQ_TYPE_LEVEL_LOW>; > - interrupt-names = "PD_IRQB"; > + interrupt-names = "PD-IRQB"; > > connector { > compatible = "usb-c-connector"; > -- > 2.43.0 >
Il 12/01/24 15:20, Rob Herring ha scritto: > On Fri, Jan 12, 2024 at 10:45:37AM +0100, AngeloGioacchino Del Regno wrote: >> Since there is no user yet, rename the only interrupt of this device >> to "PD-IRQB", avoiding underscores. > > It is primarily node and property names that have this recommendation, > not so much -names values. > > If there is only 1 interrupt, I'd just drop the name. > Yeah, you're totally right. I'll just drop it. Thanks! Angelo >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> --- >> .../devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml >> index 053264e60583..0bea23ce2f09 100644 >> --- a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml >> +++ b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml >> @@ -24,7 +24,7 @@ properties: >> >> interrupt-names: >> items: >> - - const: PD_IRQB >> + - const: PD-IRQB >> >> connector: >> type: object >> @@ -58,7 +58,7 @@ examples: >> tcpc { >> compatible = "mediatek,mt6360-tcpc"; >> interrupts-extended = <&gpio26 3 IRQ_TYPE_LEVEL_LOW>; >> - interrupt-names = "PD_IRQB"; >> + interrupt-names = "PD-IRQB"; >> >> connector { >> compatible = "usb-c-connector"; >> -- >> 2.43.0 >>
diff --git a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml index 053264e60583..0bea23ce2f09 100644 --- a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml +++ b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml @@ -24,7 +24,7 @@ properties: interrupt-names: items: - - const: PD_IRQB + - const: PD-IRQB connector: type: object @@ -58,7 +58,7 @@ examples: tcpc { compatible = "mediatek,mt6360-tcpc"; interrupts-extended = <&gpio26 3 IRQ_TYPE_LEVEL_LOW>; - interrupt-names = "PD_IRQB"; + interrupt-names = "PD-IRQB"; connector { compatible = "usb-c-connector";