Message ID | 20230901200419.3277274-1-vladimir.mezentsev@oracle.com |
---|---|
State | Unresolved |
Headers |
Return-Path: <binutils-bounces+ouuuleilei=gmail.com@sourceware.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c792:0:b0:3f2:4152:657d with SMTP id b18csp1115835vqu; Fri, 1 Sep 2023 13:04:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFmNdeEgYEn51qqf2FYFVpjYtp5O4Sj8XljVFguokyoYQt4dRuLqD8GKXvGrY3H2dJihU7s X-Received: by 2002:a17:907:1de9:b0:9a1:d087:e0bf with SMTP id og41-20020a1709071de900b009a1d087e0bfmr2297337ejc.43.1693598682372; Fri, 01 Sep 2023 13:04:42 -0700 (PDT) Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id l17-20020a1709060e1100b009886470de61si3111791eji.857.2023.09.01.13.04.42 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Sep 2023 13:04:42 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=IFbbGUun; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2ED823858D37 for <ouuuleilei@gmail.com>; Fri, 1 Sep 2023 20:04:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2ED823858D37 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1693598681; bh=5Rj/JE42Wx53F8Pxz7wcYgq3cTtv+DVk2xXqqpNW1JU=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=IFbbGUunShzZkYUoILHfuRXiUaQfkofJx0dbJipSxE+IIzhpjK8/cf+bWhh0rPM07 7+O8UP78aduy/UnyTp1lO/hLzSllpAX637fcTd49JWrI+OkLqLNJBXzSahV9K9BKoM lw1zyBv1maMpDeupyKkNtNb/0hNUID4lgrH5K790= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id C6AED3858D1E for <binutils@sourceware.org>; Fri, 1 Sep 2023 20:04:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C6AED3858D1E Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 381CAOE9011313 for <binutils@sourceware.org>; Fri, 1 Sep 2023 20:04:29 GMT Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3sq9k6cr8q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for <binutils@sourceware.org>; Fri, 01 Sep 2023 20:04:29 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 381IEm4W000580 for <binutils@sourceware.org>; Fri, 1 Sep 2023 20:04:28 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2041.outbound.protection.outlook.com [104.47.66.41]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3sr6gftx32-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for <binutils@sourceware.org>; Fri, 01 Sep 2023 20:04:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GIRYAukqhB7a2GTNoa9A4PmcfvavJHb4Tm/VRT13YW4IYZbU854HXTJ3ZtTnOIgYOPRuzrRNF1ntPR5Ly9n+DK+8XhuYUvrJ+UIiOl/tU4v8KaVP+hXjlUJ7nczaqbaMXSdUCvvDIIn2b6FccVLQcc57mjLhTCXFj3qYJl9MCpLp2JB3ZyfZoboCcYD+3R6uZlLMmIr5kEIaJ7W3ay35exu5SP2LblPVaVAbdiSYSyzIPUyV1nzST0oMCu7xaeJrA6t1OpnR3RgX+Rv5OIa1Ax+Ig7N+t6XO4z5jAelk6NXSl/56Gt2TOkHoNN6wipRg2riJZp1ETgGL35zNYWopdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5Rj/JE42Wx53F8Pxz7wcYgq3cTtv+DVk2xXqqpNW1JU=; b=oJ3QAVVCN+n4i25+JfyaOUnDCBTnsXnuUTBpEZK7Grl6JH2z0URmcjoDLHEjQ4LhrDx6IpBSEYLnO2H9ad01KQTeJHXjScXd+NYpvoiWmp6P2fdlPGxZ/+nFXqhYIhvtov1lvS7IXVz2XODRCHM9Jgizz5fLp5phL+f/hMeJ1kvS1AHAsUGwoLbJXNiKGi9Al3TktNN2dEaEI4D/60RufYLC7Abn3ijkbGTCskNsirPyChHOTReg6k1sz0ISH6/MmcOFL5maj00YGJDgYLYoX06+wHVbeB7LH0tlDREe+vFIru/c6dpyAjzOlNVW1bH0XhSDZrKCryub+U9O6+Br7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from SA2PR10MB4636.namprd10.prod.outlook.com (2603:10b6:806:11e::10) by PH8PR10MB6528.namprd10.prod.outlook.com (2603:10b6:510:228::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.20; Fri, 1 Sep 2023 20:04:25 +0000 Received: from SA2PR10MB4636.namprd10.prod.outlook.com ([fe80::a030:1b79:dc48:566b]) by SA2PR10MB4636.namprd10.prod.outlook.com ([fe80::a030:1b79:dc48:566b%4]) with mapi id 15.20.6745.021; Fri, 1 Sep 2023 20:04:25 +0000 To: binutils@sourceware.org Subject: [PATCH] Fix 30808 gprofng tests failed Date: Fri, 1 Sep 2023 13:04:19 -0700 Message-Id: <20230901200419.3277274-1-vladimir.mezentsev@oracle.com> X-Mailer: git-send-email 2.31.1 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: BYAPR08CA0072.namprd08.prod.outlook.com (2603:10b6:a03:117::49) To SA2PR10MB4636.namprd10.prod.outlook.com (2603:10b6:806:11e::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PR10MB4636:EE_|PH8PR10MB6528:EE_ X-MS-Office365-Filtering-Correlation-Id: f6082e7e-99a3-436b-d996-08dbab26a444 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: M1r3oPmnLeXa60xOG315bYuLlegazujewCUrXaraqw9dF92kqbITEK/987HkpItS9eYd0ggfuvHWpZ6HfM5BWeq9xWGVy5vEIJpKItggKh+lNFmLeJrLK8guRVz1UZRX5+SzErd7R9r8aNL5MEoUvg5l2UyXLJCbkrzn3HF19RZUdQ1cU6xX/f47MUNdCA1mEQ2US3QvFK14PqI9EnPCP/YMkuQHP17w6tqNeNvfKRBJWIT2Hfwx4Zk/VbX6m4UBLPCuKuu4wZ66L7IrLl4w4HRwTG1ujTJYIkhA6EZOVZAY5gv5xelNZOsnvxSXkSbQpU+KlTJLbnmMN1vZC26P6UYqNMP5wZfUXeF042jxobn0mEqKM1oIUeLhgGdPkEoktUkyzpxZ/lttQroky+PTRhCzP6NRn+Wwb10SSOMiY8ULKeCAIN8drd7TpsCUk89fM86QVIs4v3x7+4RTUElMeXkneI3fke1Qpnz4qS3n2dglweR7yGpq2bnKIb+NW6lboWCClaL2NIR7tYTTuVdUkAcDPkpYKHYHXu6iop6ZT6dVhbmj8U07+Dca7U0HGv/6 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR10MB4636.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(136003)(366004)(39860400002)(346002)(376002)(451199024)(186009)(1800799009)(38100700002)(36756003)(2906002)(5660300002)(86362001)(4326008)(8676002)(66556008)(41300700001)(8936002)(83380400001)(6506007)(107886003)(1076003)(2616005)(6512007)(316002)(9686003)(66946007)(6666004)(478600001)(6486002)(66476007)(6916009); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: gTuJaF8HNmYnAaqt1QWOGuyt6zlxn88oSi9ovzR8NaWrtu0SExcMyE1zZ2xBQxxNTHmx1nr9aJ+nifXSvlhxE65vFbQQYfhLdMAeUPa72StNlvcm+bdGPWtsLd5hJTGM5dUZLLpVsiOjdpXynJ0WjoLa9cn2lLoknW4HV+YfhW5XGby0mMW7bKg0BBm96NsXXLWErKtpLrYKiSf6MuO/wkCyhXLptI+SsQRzrf9KiQu4qfHWkcI7XQ8tA7EnfRlcS19JC+0aE94XGZ7BEmc5XaiYkF1fl/9IuyNywBlKu6ssuW3S9RFNqnONUnHy7GB0ja53Iw3d5q+gTWUScxwQIkPz48+wzWEwBA2+iguimYct79ssj5Hwp/sXcjkDudDLOxe1TuTtfRLWeoTeJSchUflJegUMdIh2iHxupmMnn/iD0J+CLNfJl33IsVJmrPW1Xj+JwaqeCEIi2DeSB7RPQ6waXDIVLDxeE3r5z1ym2PEsdXW0AvyGbQAqXLc4yCsosycmBnqH29tmiNgJiYWM+Ea76kD52Pl6m01u1wnZUWofRf6H7bHqwboPfHHVULdoEB1pxBlup5OBCF7FGaA2d/+oOGO4oERNpImo1p2fXCaWrgw/WZgyuQf1wbFtLnSPwC3YCRE9lLxcYmwzX17hQFAo5e8hsqtOoVOTqXncJ30OW3n8pv+GHWK630m2nqgdt53VJCdCXzQmO4m7HgqXo/S9thRGKpj3TGia9nvbWP6x46L6vIZ4vBiCABlNRNiexZQY9OV+Hqo73ixN9OT0GzEClbY7VzPnbWStboAb17l30shkf99XNcdWPWaOpMQNmgR8Gmy8HmIdfAWb8rJnXgR2JZb+OQ4paqVPXWibUvZvRTxoZQlMggQwlSPKYez6JU6RE3t7JY1Ah3qVCOWOb4aG61R+M0DiMMhGruA8DJuUepMFJctTHMAm+sra2IOBTd2QuzQDVDcM/sdaiJmmkhgrdCCEgMNInaudZnWDfPeECiICvGe1h/63nYjnKOTHHFNdrds19tVxPHSRs9qvN1Y7x/yAH12YviAHcx7iiSAKlOMnC/BdUsXxoWg55ULMcnUdrVfZVjDCYfOlb3k61udVJPcl/Lw6BBLgatn5Lz/r3XMH6PNCnD6QGbqsZn/fa9UUPXyc8yVGi6RgKkrt41y63Z/j8PdDuX3LzjorG+ld0oZcCmdo/ke17LJbO16Pg0xKnR9DcspgsBxA8RGD0s6aSC7H1ppBuHZ1wgvgVoH3g9yy0Q8sal5To9amFVUm9OBGKMRGnvad3X86iRMHGnkkp6+kznAdvRoywzCSPSm0Po1hvWhvVBYWAvEGikUZ/d/DnF1l8cRpvUl8vz8rTvG8agqbfKJ98KTBvCSsw7KWy/5msmY/B8RTFuDCLg9jfnY91lp7sID1xLT1MhqoNi0CHaGcWxfn4f/AFVo3FBgamvD8SUO8Y6sEzLxq3cUcTM2WVyVHa0IXBzYPMq7l9KfVYzGRFXAzITuCv9gQmzGf6VzxVxxoeIk0l46LpQ/q0tczapL7uSWgoDC7C080NhxqaTVLmz7POllocXvg9ceXf0cvbbl94rJDZzyrHAsxVYjMfCqZz+mDCJ1m96i7Tb8jm4JpBacPT1A+/Bjt4pY= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ApfNcC/73s+uQFxlird1kJnw96X0XDUT+2DU+UnhjMd+JBPhfCajCAB55q6HE5S5CuW9Rgnzlpggnt7s0g8fnkuRW4jjdOmclg/gtaI9vsiUjPuau2oPLha02lX6A0xIxu4JdpEUWMNJGZ45+WHmK8LkcwV/c6vcL+/P3/0MoJ88b2qxd5r7ZTaVVM66I+PGd35TPpSXoah7cRyH+soaO2bSi46eXYEsyzTLz023VjIeBWgkZuRsKQUPecDh3irCN093WxHr07zBtY6jxtMEK1dcv8qPx9ucebTzns0bS/6cT2TG0M8qyc6Eje0cZFQtjWTNd25+mFZt2qrZs1MrgjeRuQUy/kis23vDvW/Tg/l1T1PjJ0+A32R9NvFpjkr8fVQKz+1cU/gwWOV8U3syKEwKZk3bq33qVD2kEqdtZfFUDfZWS/0ZxRZOQ/sh3AokFYp8n6fNXDNVbEjgwLOWF1BdM06WcLcLNVEvBwm90qrBvd+v82Jgyp9ndL7pT7h/VPddANTBhkIaitO7rwjzplvOiy8MuM7ik+lgMitgcChv928cPcQ+2A8zIDH91D6OvEVGEIPgBk2QE8nUHr1jbJsNoY6f4VAoJz4a3CVAuJzm71YHrDVpOPg/t70q3wqBSeFWO4SNRS+RQYGwnaiAatWfBD/Y2P8fXKiR9LtQ6H1esEWatdTZwZzgDAroHmMKpPMG1mjRTpI5znZIQUXYGV62PcyyYqPkBCE6HKOb2vxxMqB8a/9onhvaRz7yRv5Y X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6082e7e-99a3-436b-d996-08dbab26a444 X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4636.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2023 20:04:25.7955 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ho16NcTWNvSXFBvdwFofWSu4ANKZoTcvLmNYQS5B1iBrSOY8ND+P0YWGNWB2eY5oME4sZhOuhAUoaWHwCuojiB9u3GUaciYETx3tSaZA7F0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR10MB6528 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-01_17,2023-08-31_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 adultscore=0 bulkscore=0 spamscore=0 phishscore=0 suspectscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2309010188 X-Proofpoint-GUID: ifUBAbNobbUzj0JKHJBvLLgnYMMtabcQ X-Proofpoint-ORIG-GUID: ifUBAbNobbUzj0JKHJBvLLgnYMMtabcQ X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list <binutils.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/binutils>, <mailto:binutils-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/binutils/> List-Post: <mailto:binutils@sourceware.org> List-Help: <mailto:binutils-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/binutils>, <mailto:binutils-request@sourceware.org?subject=subscribe> From: Vladimir Mezentsev via Binutils <binutils@sourceware.org> Reply-To: vladimir.mezentsev@oracle.com Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" <binutils-bounces+ouuuleilei=gmail.com@sourceware.org> X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1775866932221744341 X-GMAIL-MSGID: 1775866932221744341 |
Series |
Fix 30808 gprofng tests failed
|
|
Checks
Context | Check | Description |
---|---|---|
snail/binutils-gdb-check | warning | Git am fail log |
Commit Message
Frager, Neal via Binutils
Sept. 1, 2023, 8:04 p.m. UTC
From: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
In gprofng testing, we need a tempory gprofng installation to resolve run-time
dependencies on libraries (libgprofng, libopcodes, libbfd, etc).
We set LD_LIBRARY_PATH and GPROFNG_SYSCONFDIR to find our libraries and
configuration file. These variables must be set for all gprofng tests.
Tested on aarch64 and x86_64 with and without --enable-shared and --target=<>.
gprofng/ChangeLog
2023-08-31 Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
PR gprofng/30808
* testsuite/config/default.exp: Make a temporary install dir.
Set LD_LIBRARY_PATH, GPROFNG_SYSCONFDIR.
* testsuite/lib/Makefile.skel: Move LD_LIBRARY_PATH and
GPROFNG_SYSCONFDIR setting in testsuite/config/default.exp.
---
gprofng/testsuite/config/default.exp | 20 ++++++++++++++------
gprofng/testsuite/lib/Makefile.skel | 5 -----
2 files changed, 14 insertions(+), 11 deletions(-)
Comments
On Fri, 2023-09-01 at 13:04 -0700, Vladimir Mezentsev via Binutils wrote: > diff --git a/gprofng/testsuite/config/default.exp b/gprofng/testsuite/config/default.exp > index 1c862d54592..c4a6588bb64 100644 > --- a/gprofng/testsuite/config/default.exp > +++ b/gprofng/testsuite/config/default.exp > @@ -32,17 +32,25 @@ if {![info exists CFLAGS]} { > set CFLAGS "-g -O2" > } > > +remote_exec host "sh -c \"rm -rf tmpdir; mkdir -p tmpdir\"" > if { "$CHECK_TARGET" == "check-install" } { > set ::env(GPROFNG) "$PREFIX/bin/gprofng" > } else { > - set ::env(GPROFNG) "$BUILDDIR/src/gprofng" > + # Make a temporary install dir to run gprofng from, and point at it > + remote_exec host "sh -c \"$MAKE -C .. install-gprofng MAKEFLAGS=program_transform_name= DESTDIR=$BUILDDIR/tmpdir/root\"" Unfortunately this has bring back PR29107. I've created PR31252.
On 1/17/24 03:24, Xi Ruoyao wrote: > On Fri, 2023-09-01 at 13:04 -0700, Vladimir Mezentsev via Binutils wrote: > >> diff --git a/gprofng/testsuite/config/default.exp b/gprofng/testsuite/config/default.exp >> index 1c862d54592..c4a6588bb64 100644 >> --- a/gprofng/testsuite/config/default.exp >> +++ b/gprofng/testsuite/config/default.exp >> @@ -32,17 +32,25 @@ if {![info exists CFLAGS]} { >> set CFLAGS "-g -O2" >> } >> >> +remote_exec host "sh -c \"rm -rf tmpdir; mkdir -p tmpdir\"" >> if { "$CHECK_TARGET" == "check-install" } { >> set ::env(GPROFNG) "$PREFIX/bin/gprofng" >> } else { >> - set ::env(GPROFNG) "$BUILDDIR/src/gprofng" >> + # Make a temporary install dir to run gprofng from, and point at it >> + remote_exec host "sh -c \"$MAKE -C .. install-gprofng MAKEFLAGS=program_transform_name= DESTDIR=$BUILDDIR/tmpdir/root\"" > Unfortunately this has bring back PR29107. I've created PR31252. > I cannot reproduce the problem on the master branch ( OL8 / x86_64 ). I did: mkdir bld_x86_64 cd bld_x86_64 ../configure --prefix=/usr --with-system-zlib --enable-shared --disable-{gdb,gdbserver,libbacktrace,libdecnumber,readline,sim} make -j16 -O tooldir=/usr V=1 2>&1 | tee make.log make -k -j16 -O check 2>&1 | tee make_check.log I see errors but they are not related to 30808. % grep FAIL make_check.log FAIL: /ws/gprofng-dev-backedup/vmezents/GPROF/binutils-gdb/libctf/testsuite/libctf-regression/libctf-repeat-cu.exp FAIL: /ws/gprofng-dev-backedup/vmezents/GPROF/binutils-gdb/libctf/testsuite/libctf-regression/nonstatic-var-section-ld-r.c FAIL: replacing SOURCE_DATE_EPOCH deterministic member (wrong size, expected: 1120) FAIL: archive with empty element FAIL: cxxfilt: demangling _Z1fIvJiELb0EEvPDOT1_EFT_DpT0_E FAIL: cxxfilt: demangling _Z14int_if_addableI1YERiP1AIXszpldecvPT_Li0EdecvS4_Li0EEE Could you send me the log files with errors. Thank you, -Vladimir
在 2024-01-17星期三的 16:49 -0800,Vladimir Mezentsev写道: > On 1/17/24 03:24, Xi Ruoyao wrote: > > On Fri, 2023-09-01 at 13:04 -0700, Vladimir Mezentsev via Binutils wrote: > > > > > diff --git a/gprofng/testsuite/config/default.exp b/gprofng/testsuite/config/default.exp > > > index 1c862d54592..c4a6588bb64 100644 > > > --- a/gprofng/testsuite/config/default.exp > > > +++ b/gprofng/testsuite/config/default.exp > > > @@ -32,17 +32,25 @@ if {![info exists CFLAGS]} { > > > set CFLAGS "-g -O2" > > > } > > > > > > +remote_exec host "sh -c \"rm -rf tmpdir; mkdir -p tmpdir\"" > > > if { "$CHECK_TARGET" == "check-install" } { > > > set ::env(GPROFNG) "$PREFIX/bin/gprofng" > > > } else { > > > - set ::env(GPROFNG) "$BUILDDIR/src/gprofng" > > > + # Make a temporary install dir to run gprofng from, and point at it > > > + remote_exec host "sh -c \"$MAKE -C .. install-gprofng MAKEFLAGS=program_transform_name= DESTDIR=$BUILDDIR/tmpdir/root\"" > > Unfortunately this has bring back PR29107. I've created PR31252. > > > > I cannot reproduce the problem on the master branch ( OL8 / x86_64 ). > I did: > > mkdir bld_x86_64 > cd bld_x86_64 > ../configure --prefix=/usr --with-system-zlib --enable-shared > --disable-{gdb,gdbserver,libbacktrace,libdecnumber,readline,sim} > make -j16 -O tooldir=/usr V=1 2>&1 | tee make.log > make -k -j16 -O check 2>&1 | tee make_check.log > > I see errors but they are not related to 30808. But they are likely caused by the change. I think I (and Nick) have explained the issue well in https://sourceware.org/bugzilla/show_bug.cgi?id=29107: if you run "make install" in the test suite, libtool will relink some shared libraries and the other test suite using these shared libraries will error out with messages like "file too short" or "undefined symbol" while the shared libraries are being overwritten. So you shouldn't run "make install" in the test suite, period, no some sort of "but I need it" things.
On Wed, Jan 17, 2024 at 7:53 PM Xi Ruoyao <xry111@xry111.site> wrote: > > 在 2024-01-17星期三的 16:49 -0800,Vladimir Mezentsev写道: > > On 1/17/24 03:24, Xi Ruoyao wrote: > > > On Fri, 2023-09-01 at 13:04 -0700, Vladimir Mezentsev via Binutils wrote: > > > > > > > diff --git a/gprofng/testsuite/config/default.exp b/gprofng/testsuite/config/default.exp > > > > index 1c862d54592..c4a6588bb64 100644 > > > > --- a/gprofng/testsuite/config/default.exp > > > > +++ b/gprofng/testsuite/config/default.exp > > > > @@ -32,17 +32,25 @@ if {![info exists CFLAGS]} { > > > > set CFLAGS "-g -O2" > > > > } > > > > > > > > +remote_exec host "sh -c \"rm -rf tmpdir; mkdir -p tmpdir\"" > > > > if { "$CHECK_TARGET" == "check-install" } { > > > > set ::env(GPROFNG) "$PREFIX/bin/gprofng" > > > > } else { > > > > - set ::env(GPROFNG) "$BUILDDIR/src/gprofng" > > > > + # Make a temporary install dir to run gprofng from, and point at it > > > > + remote_exec host "sh -c \"$MAKE -C .. install-gprofng MAKEFLAGS=program_transform_name= DESTDIR=$BUILDDIR/tmpdir/root\"" > > > Unfortunately this has bring back PR29107. I've created PR31252. > > > > > > > I cannot reproduce the problem on the master branch ( OL8 / x86_64 ). > > I did: > > > > mkdir bld_x86_64 > > cd bld_x86_64 > > ../configure --prefix=/usr --with-system-zlib --enable-shared > > --disable-{gdb,gdbserver,libbacktrace,libdecnumber,readline,sim} > > make -j16 -O tooldir=/usr V=1 2>&1 | tee make.log > > make -k -j16 -O check 2>&1 | tee make_check.log > > > > I see errors but they are not related to 30808. > > But they are likely caused by the change. > > I think I (and Nick) have explained the issue well in > https://sourceware.org/bugzilla/show_bug.cgi?id=29107: if you run "make > install" in the test suite, libtool will relink some shared libraries > and the other test suite using these shared libraries will error out > with messages like "file too short" or "undefined symbol" while the > shared libraries are being overwritten. > > So you shouldn't run "make install" in the test suite, period, no some > sort of "but I need it" things. > I agree. Does LD_LIBRARY_PATH work for gprofng tests?
diff --git a/gprofng/testsuite/config/default.exp b/gprofng/testsuite/config/default.exp index 1c862d54592..c4a6588bb64 100644 --- a/gprofng/testsuite/config/default.exp +++ b/gprofng/testsuite/config/default.exp @@ -32,17 +32,25 @@ if {![info exists CFLAGS]} { set CFLAGS "-g -O2" } +remote_exec host "sh -c \"rm -rf tmpdir; mkdir -p tmpdir\"" if { "$CHECK_TARGET" == "check-install" } { set ::env(GPROFNG) "$PREFIX/bin/gprofng" } else { - set ::env(GPROFNG) "$BUILDDIR/src/gprofng" + # Make a temporary install dir to run gprofng from, and point at it + remote_exec host "sh -c \"$MAKE -C .. install-gprofng MAKEFLAGS=program_transform_name= DESTDIR=$BUILDDIR/tmpdir/root\"" + set ::env(GPROFNG) [exec find $BUILDDIR/tmpdir -type f -name gprofng -perm -u+x | head -1] + + set x [exec find $BUILDDIR/tmpdir -type d -name gprofng | head -1] + set ::env(LD_LIBRARY_PATH) "$x:$x/.." + + set x [exec find $BUILDDIR/tmpdir -type f -name gprofng.rc | head -1] + set ::env(GPROFNG_SYSCONFDIR) [exec dirname $x] + + puts "### LD_LIBRARY_PATH: $env(LD_LIBRARY_PATH)" + puts "### GPROFNG_SYSCONFDIR: $env(GPROFNG_SYSCONFDIR)" } +puts "### GPROFNG: $env(GPROFNG)" set TEST_TIMEOUT 300 -# Create directories where gprofng can find libraries and binaries: -remote_exec host "sh -c \"rm -rf tmpdir; mkdir -p tmpdir\"" -remote_exec host "sh -c \"mkdir -p lib; rm -f lib/gprofng; ln -s ../libcollector/.libs lib/gprofng\"" -remote_exec host "sh -c \"rm -f bin; ln -s src bin\"" - load_lib display-lib.exp diff --git a/gprofng/testsuite/lib/Makefile.skel b/gprofng/testsuite/lib/Makefile.skel index 5a30966c1cd..9ccc0340c10 100644 --- a/gprofng/testsuite/lib/Makefile.skel +++ b/gprofng/testsuite/lib/Makefile.skel @@ -39,11 +39,6 @@ DISPLAY = $(GPROFNG) display text EXPERIMENT = test.er DISPLAY_LOG = display.log -export LD_LIBRARY_PATH := $(BUILDDIR)/src - -# Set GPROFNG_SYSCONFDIR to find out gprofng.rc: -export GPROFNG_SYSCONFDIR := $(srcdir)/../../../src - .PHONY: all collect compare clobber clean all: compare