diff mbox series

[v2,1/2] dt-bindings: arm: coresight: Remove pattern match of ETE node name

Message ID 20240116064505.487-2-quic_jinlmao@quicinc.com
State New
Headers
Series arm64: dts: qcom: Add coresight nodes for sm8450 |

Commit Message

Mao Jinlong Jan. 16, 2024, 6:45 a.m. UTC 
  Remove pattern match of ETE node name. Use ete with the number as the
name for ete nodes.

Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
---
 .../bindings/arm/arm,embedded-trace-extension.yaml          | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Krzysztof Kozlowski Jan. 16, 2024, 7:28 a.m. UTC | #1 
On 16/01/2024 07:45, Mao Jinlong wrote:
> Remove pattern match of ETE node name. Use ete with the number as the
> name for ete nodes.
> 
> Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
> ---
>  .../bindings/arm/arm,embedded-trace-extension.yaml          | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml b/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml
> index f725e6940993..ed78cc7ae94a 100644
> --- a/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml
> +++ b/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml
> @@ -22,8 +22,6 @@ description: |
>    with any optional connection graph as per the coresight bindings.
>  
>  properties:
> -  $nodename:
> -    pattern: "^ete([0-9a-f]+)$"
>    compatible:
>      items:
>        - const: arm,embedded-trace-extension
> @@ -55,13 +53,13 @@ examples:
>  
>  # An ETE node without legacy CoreSight connections
>    - |
> -    ete0 {
> +    ete-0 {

ete {

>        compatible = "arm,embedded-trace-extension";
>        cpu = <&cpu_0>;
>      };
>  # An ETE node with legacy CoreSight connections
>    - |
> -   ete1 {
> +   ete-1 {

ete {

Best regards,
Krzysztof
Suzuki K Poulose Jan. 16, 2024, 9:33 a.m. UTC | #2 
On 16/01/2024 06:45, Mao Jinlong wrote:
> Remove pattern match of ETE node name. Use ete with the number as the
> name for ete nodes.
> 
> Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
> ---
>   .../bindings/arm/arm,embedded-trace-extension.yaml          | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml b/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml
> index f725e6940993..ed78cc7ae94a 100644
> --- a/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml
> +++ b/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml
> @@ -22,8 +22,6 @@ description: |
>     with any optional connection graph as per the coresight bindings.
>   
>   properties:
> -  $nodename:
> -    pattern: "^ete([0-9a-f]+)$"
>     compatible:
>       items:
>         - const: arm,embedded-trace-extension
> @@ -55,13 +53,13 @@ examples:
>   
>   # An ETE node without legacy CoreSight connections
>     - |
> -    ete0 {
> +    ete-0 {

Why do we need the number ? why not simply "ete" as Krzysztof suggested ?

Suzuki
Mao Jinlong Jan. 17, 2024, 2:14 a.m. UTC | #3 
On 1/16/2024 5:33 PM, Suzuki K Poulose wrote:
> On 16/01/2024 06:45, Mao Jinlong wrote:
>> Remove pattern match of ETE node name. Use ete with the number as the
>> name for ete nodes.
>>
>> Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
>> ---
>>   .../bindings/arm/arm,embedded-trace-extension.yaml          | 6 ++----
>>   1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git 
>> a/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml b/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml
>> index f725e6940993..ed78cc7ae94a 100644
>> --- 
>> a/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml
>> +++ 
>> b/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml
>> @@ -22,8 +22,6 @@ description: |
>>     with any optional connection graph as per the coresight bindings.
>>   properties:
>> -  $nodename:
>> -    pattern: "^ete([0-9a-f]+)$"
>>     compatible:
>>       items:
>>         - const: arm,embedded-trace-extension
>> @@ -55,13 +53,13 @@ examples:
>>   # An ETE node without legacy CoreSight connections
>>     - |
>> -    ete0 {
>> +    ete-0 {
> 
> Why do we need the number ? why not simply "ete" as Krzysztof suggested ?
> 

Hi Suzuki & Krzysztof ,

If name all the ete nodes' name as 'ete', there will be error below when 
build images.

arch/arm64/boot/dts/qcom/sm8450.dtsi:301.6-312.4: ERROR 
(duplicate_node_names): /ete: Duplicate node name
arch/arm64/boot/dts/qcom/sm8450.dtsi:314.6-325.4: ERROR 
(duplicate_node_names): /ete: Duplicate node name
arch/arm64/boot/dts/qcom/sm8450.dtsi:327.6-338.4: ERROR 
(duplicate_node_names): /ete: Duplicate node name
arch/arm64/boot/dts/qcom/sm8450.dtsi:340.6-351.4: ERROR 
(duplicate_node_names): /ete: Duplicate node name
arch/arm64/boot/dts/qcom/sm8450.dtsi:353.6-364.4: ERROR 
(duplicate_node_names): /ete: Duplicate node name
arch/arm64/boot/dts/qcom/sm8450.dtsi:366.6-377.4: ERROR 
(duplicate_node_names): /ete: Duplicate node name
arch/arm64/boot/dts/qcom/sm8450.dtsi:379.6-390.4: ERROR 
(duplicate_node_names): /ete: Duplicate node name

Thanks
Jinlong Mao

> 
>
Krzysztof Kozlowski Jan. 17, 2024, 7:40 a.m. UTC | #4 
On 17/01/2024 03:14, Jinlong Mao wrote:
>>>         - const: arm,embedded-trace-extension
>>> @@ -55,13 +53,13 @@ examples:
>>>   # An ETE node without legacy CoreSight connections
>>>     - |
>>> -    ete0 {
>>> +    ete-0 {
>>
>> Why do we need the number ? why not simply "ete" as Krzysztof suggested ?
>>
> 
> Hi Suzuki & Krzysztof ,
> 
> If name all the ete nodes' name as 'ete', there will be error below when 
> build images.
> 
> arch/arm64/boot/dts/qcom/sm8450.dtsi:301.6-312.4: ERROR 

Why are you pasting DTSI for binding? How is it related? Do we talk
about DTSI here? No, this is a binding patch.

Best regards,
Krzysztof
Mao Jinlong Jan. 17, 2024, 7:49 a.m. UTC | #5 
On 1/17/2024 3:40 PM, Krzysztof Kozlowski wrote:
> On 17/01/2024 03:14, Jinlong Mao wrote:
>>>>          - const: arm,embedded-trace-extension
>>>> @@ -55,13 +53,13 @@ examples:
>>>>    # An ETE node without legacy CoreSight connections
>>>>      - |
>>>> -    ete0 {
>>>> +    ete-0 {
>>>
>>> Why do we need the number ? why not simply "ete" as Krzysztof suggested ?
>>>
>>
>> Hi Suzuki & Krzysztof ,
>>
>> If name all the ete nodes' name as 'ete', there will be error below when
>> build images.
>>
>> arch/arm64/boot/dts/qcom/sm8450.dtsi:301.6-312.4: ERROR
> 
> Why are you pasting DTSI for binding? How is it related? Do we talk
> about DTSI here? No, this is a binding patch.
> 

Hi Krzysztof,

Do you mean the name in DTSI can be different from the name in binding ?

Thanks
Jinlong Mao

>
Krzysztof Kozlowski Jan. 17, 2024, 7:53 a.m. UTC | #6 
On 17/01/2024 08:49, Jinlong Mao wrote:
> 
> 
> On 1/17/2024 3:40 PM, Krzysztof Kozlowski wrote:
>> On 17/01/2024 03:14, Jinlong Mao wrote:
>>>>>          - const: arm,embedded-trace-extension
>>>>> @@ -55,13 +53,13 @@ examples:
>>>>>    # An ETE node without legacy CoreSight connections
>>>>>      - |
>>>>> -    ete0 {
>>>>> +    ete-0 {
>>>>
>>>> Why do we need the number ? why not simply "ete" as Krzysztof suggested ?
>>>>
>>>
>>> Hi Suzuki & Krzysztof ,
>>>
>>> If name all the ete nodes' name as 'ete', there will be error below when
>>> build images.
>>>
>>> arch/arm64/boot/dts/qcom/sm8450.dtsi:301.6-312.4: ERROR
>>
>> Why are you pasting DTSI for binding? How is it related? Do we talk
>> about DTSI here? No, this is a binding patch.
>>
> 
> Hi Krzysztof,
> 
> Do you mean the name in DTSI can be different from the name in binding ?

Yes, we do not talk about DTSI here, so I did not suggest anything about
DTSI.

Best regards,
Krzysztof
Mao Jinlong Jan. 17, 2024, 7:55 a.m. UTC | #7 
On 1/17/2024 3:53 PM, Krzysztof Kozlowski wrote:
> On 17/01/2024 08:49, Jinlong Mao wrote:
>>
>>
>> On 1/17/2024 3:40 PM, Krzysztof Kozlowski wrote:
>>> On 17/01/2024 03:14, Jinlong Mao wrote:
>>>>>>           - const: arm,embedded-trace-extension
>>>>>> @@ -55,13 +53,13 @@ examples:
>>>>>>     # An ETE node without legacy CoreSight connections
>>>>>>       - |
>>>>>> -    ete0 {
>>>>>> +    ete-0 {
>>>>>
>>>>> Why do we need the number ? why not simply "ete" as Krzysztof suggested ?
>>>>>
>>>>
>>>> Hi Suzuki & Krzysztof ,
>>>>
>>>> If name all the ete nodes' name as 'ete', there will be error below when
>>>> build images.
>>>>
>>>> arch/arm64/boot/dts/qcom/sm8450.dtsi:301.6-312.4: ERROR
>>>
>>> Why are you pasting DTSI for binding? How is it related? Do we talk
>>> about DTSI here? No, this is a binding patch.
>>>
>>
>> Hi Krzysztof,
>>
>> Do you mean the name in DTSI can be different from the name in binding ?
> 
> Yes, we do not talk about DTSI here, so I did not suggest anything about
> DTSI.

Ok. I will use 'ete' as the name here.

Thanks
Jinlong Mao

> 
> Best regards,
> Krzysztof
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml b/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml
index f725e6940993..ed78cc7ae94a 100644
--- a/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml
+++ b/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml
@@ -22,8 +22,6 @@  description: |
   with any optional connection graph as per the coresight bindings.
 
 properties:
-  $nodename:
-    pattern: "^ete([0-9a-f]+)$"
   compatible:
     items:
       - const: arm,embedded-trace-extension
@@ -55,13 +53,13 @@  examples:
 
 # An ETE node without legacy CoreSight connections
   - |
-    ete0 {
+    ete-0 {
       compatible = "arm,embedded-trace-extension";
       cpu = <&cpu_0>;
     };
 # An ETE node with legacy CoreSight connections
   - |
-   ete1 {
+   ete-1 {
       compatible = "arm,embedded-trace-extension";
       cpu = <&cpu_1>;