diff mbox series

[net-next] devlink: remove redundant health state set to error

Message ID 1668933412-5498-1-git-send-email-moshe@nvidia.com
State New
Headers
Series [net-next] devlink: remove redundant health state set to error |

Commit Message

Moshe Shemesh Nov. 20, 2022, 8:36 a.m. UTC 
  Reporter health_state is set twice to error in devlink_health_report().
Remove second time as it is redundant.

Signed-off-by: Moshe Shemesh <moshe@nvidia.com>
Reviewed-by: Eran Ben Elisha <eranbe@nvidia.com>
---
 net/core/devlink.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Leon Romanovsky Nov. 22, 2022, 12:48 p.m. UTC | #1 
On Sun, Nov 20, 2022 at 10:36:52AM +0200, Moshe Shemesh wrote:
> Reporter health_state is set twice to error in devlink_health_report().
> Remove second time as it is redundant.
> 
> Signed-off-by: Moshe Shemesh <moshe@nvidia.com>
> Reviewed-by: Eran Ben Elisha <eranbe@nvidia.com>
> ---
>  net/core/devlink.c | 2 --
>  1 file changed, 2 deletions(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
patchwork-bot+netdevbpf@kernel.org Nov. 23, 2022, 4:52 a.m. UTC | #2 
Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Sun, 20 Nov 2022 10:36:52 +0200 you wrote:
> Reporter health_state is set twice to error in devlink_health_report().
> Remove second time as it is redundant.
> 
> Signed-off-by: Moshe Shemesh <moshe@nvidia.com>
> Reviewed-by: Eran Ben Elisha <eranbe@nvidia.com>
> ---
>  net/core/devlink.c | 2 --
>  1 file changed, 2 deletions(-)

Here is the summary with links:
  - [net-next] devlink: remove redundant health state set to error
    https://git.kernel.org/netdev/net-next/c/815bc3ac75e9

You are awesome, thank you!
diff mbox series

Patch

diff --git a/net/core/devlink.c b/net/core/devlink.c
index d93bc95cd7cb..cea154ddce7a 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -7846,8 +7846,6 @@  int devlink_health_report(struct devlink_health_reporter *reporter,
 		return -ECANCELED;
 	}
 
-	reporter->health_state = DEVLINK_HEALTH_REPORTER_STATE_ERROR;
-
 	if (reporter->auto_dump) {
 		mutex_lock(&reporter->dump_lock);
 		/* store current dump of current error, for later analysis */