Message ID | 20240116113800.82529-3-dharma.b@microchip.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-27332-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:42cf:b0:101:a8e8:374 with SMTP id q15csp192385dye; Tue, 16 Jan 2024 03:40:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IGDbajrNf3xNtxtI8kWgJGP8OsuQfmmJzDxlg6XfpHAMc2PCiow0AB2SbzLWPffOv0kgYaP X-Received: by 2002:a05:6a20:939d:b0:19a:dc79:dec9 with SMTP id x29-20020a056a20939d00b0019adc79dec9mr5632747pzh.20.1705405202894; Tue, 16 Jan 2024 03:40:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705405202; cv=none; d=google.com; s=arc-20160816; b=bY1mM+ek9uPmDfq3jqyd4kOzu8CjxbfdZlE0AygKhKA5LsHFeZ57a92sWCNi2N2ZHH j0zkPSz1LD+9oJrvT5pgspyzIFwracRlYI1lkPK5vgJuG3EsmHuDbWGi6MWA/CP9E2X3 hHNxc9PCICXnJwXJS3s+aOYpwUkRjnZUwKxuKLWkpKpIwkG/hl5W1/YA1zX+c2PgHh31 vqhNnqpHJe7+RqFGa4zfSZ8fnK27RGZ8lKQWFsuIQFjMD8bCa2rqrM2HUTsuw3K7HT8F IMiGnRLLtS5RBr0MZdtcY6tHvqfmwBkABvZs04PqwPmwEX47G0coWuq6/kLLdu0C+bkg Huhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=sNymo/uyTFh6peRNlsQ//mZeyDbLTDlUFOm2f620dXQ=; fh=LHEisZzXZy93WtT4/b9KAvsJamyWsL28ELp4yehw8yM=; b=dgxSs/NyeG/6z+hOkUeyxf9oXkOC7iFHrxti7e6Md0k3ORrjl11FlJaMUShVCUc2xZ QI4HJgNVWxY+BQHtm5eBIIi/kdpsUoZxXiEwJO2ec/A2JT1p5K6ZtjzC6gwJ71OxNmpB u50Xl7BpdoI8R0ac2vyQzyKeWEDODGHIzv8bC8knW8gduQhChWk65leY0fjDxv302lh7 Zji32U5RAofkXGXNmNyvc1P83MebOmvIZ5JjG1JEH+K2FUPPp9yUv2BCnCsDl8jKjuQf 22m6NX2Eu6uCtdwa8Pa2bjoyUkQSuNwsGTDWGxf5JEGRzDl8Eq8sDemJb3V5ZLJenzuJ RGJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=kSs32IAf; spf=pass (google.com: domain of linux-kernel+bounces-27332-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-27332-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=microchip.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id j9-20020a056a00174900b006db79fe5c8csi4413318pfc.151.2024.01.16.03.40.02 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jan 2024 03:40:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-27332-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=kSs32IAf; spf=pass (google.com: domain of linux-kernel+bounces-27332-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-27332-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=microchip.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id ABF0028198A for <ouuuleilei@gmail.com>; Tue, 16 Jan 2024 11:40:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 012811BC3A; Tue, 16 Jan 2024 11:39:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="kSs32IAf" Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88B6E1B806; Tue, 16 Jan 2024 11:39:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1705405163; x=1736941163; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=RIiWVzj7Ca/iNWN17fr7ywzCMG3qG3fY2kNHZejfSLI=; b=kSs32IAfC6tbkgNOBL+TwlebuEFP7o1fpL0mlFe7YFfmBd8HW5oWAmkE KJkHngIW56cmJinl3uj3Q+I80PhNTlqmU5K8j1Islkw77QCMGenjx2VuP G2Q9gf2SzQu808avitkVrzdQQX+Gw2GigJ1AGQuOD2DKA5osRkciy2GiM rlPDZXsn0tpNwrf89FNqWdMaK0Iqt58MF4RdiDoRHR0MnBjpD1INeDydU fPJ2A3xTdFGf4bFx5/OWx5pvQ94c2sXkGaMf6xqg/xwuXKkUfkJKMezIP NygoZLZbUXAmxGgTtb1gUlIwScb1Uns0/HxlZuf5MetbLGywW6HzPJut+ w==; X-CSE-ConnectionGUID: m9+TCx76QtaEOtm0pEMV+w== X-CSE-MsgGUID: GYTwxfHPTs+QFwvuoeMh7A== X-IronPort-AV: E=Sophos;i="6.05,199,1701154800"; d="scan'208";a="245533631" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa5.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Jan 2024 04:39:21 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 16 Jan 2024 04:38:51 -0700 Received: from che-lt-i70843lx.amer.actel.com (10.10.85.11) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2507.35 via Frontend Transport; Tue, 16 Jan 2024 04:38:40 -0700 From: Dharma Balasubiramani <dharma.b@microchip.com> To: <conor.dooley@microchip.com>, <sam@ravnborg.org>, <bbrezillon@kernel.org>, <maarten.lankhorst@linux.intel.com>, <mripard@kernel.org>, <tzimmermann@suse.de>, <airlied@gmail.com>, <daniel@ffwll.ch>, <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>, <nicolas.ferre@microchip.com>, <alexandre.belloni@bootlin.com>, <claudiu.beznea@tuxon.dev>, <dri-devel@lists.freedesktop.org>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <lee@kernel.org>, <thierry.reding@gmail.com>, <u.kleine-koenig@pengutronix.de>, <linux-pwm@vger.kernel.org> CC: <linux4microchip@microchip.com>, Dharma Balasubiramani <dharma.b@microchip.com> Subject: [PATCH v2 2/3] dt-bindings: atmel,hlcdc: convert pwm bindings to json-schema Date: Tue, 16 Jan 2024 17:07:59 +0530 Message-ID: <20240116113800.82529-3-dharma.b@microchip.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240116113800.82529-1-dharma.b@microchip.com> References: <20240116113800.82529-1-dharma.b@microchip.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788246965613380585 X-GMAIL-MSGID: 1788246965613380585 |
Series |
Convert Microchip's HLCDC Text based DT bindings to JSON schema
|
|
Commit Message
Dharma Balasubiramani
Jan. 16, 2024, 11:37 a.m. UTC
Convert device tree bindings for Atmel's HLCDC PWM controller to YAML
format.
Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
---
changelog
v1 -> v2
- Remove the explicit copyrights.
- Modify title (not include words like binding/driver).
- Modify description actually describing the hardware and not the driver.
- Remove pinctrl properties which aren't required.
- Drop parent node and it's other sub-device node which are not related here.
---
.../bindings/pwm/atmel,hlcdc-pwm.yaml | 47 +++++++++++++++++++
.../bindings/pwm/atmel-hlcdc-pwm.txt | 29 ------------
2 files changed, 47 insertions(+), 29 deletions(-)
create mode 100644 Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml
delete mode 100644 Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt
Comments
On Tue, Jan 16, 2024 at 05:07:59PM +0530, Dharma Balasubiramani wrote: > Convert device tree bindings for Atmel's HLCDC PWM controller to YAML > format. > > Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> > --- > changelog > v1 -> v2 > - Remove the explicit copyrights. > - Modify title (not include words like binding/driver). > - Modify description actually describing the hardware and not the driver. > - Remove pinctrl properties which aren't required. > - Drop parent node and it's other sub-device node which are not related here. > --- > .../bindings/pwm/atmel,hlcdc-pwm.yaml | 47 +++++++++++++++++++ > .../bindings/pwm/atmel-hlcdc-pwm.txt | 29 ------------ > 2 files changed, 47 insertions(+), 29 deletions(-) > create mode 100644 Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml > delete mode 100644 Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt > > diff --git a/Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml b/Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml > new file mode 100644 > index 000000000000..751122309fa9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml > @@ -0,0 +1,47 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) The original file has no license, but was originally written by a free-electrons employee, so the relicensing here is fine. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pwm/atmel,hlcdc-pwm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Atmel's HLCDC's PWM controller > + > +maintainers: > + - Nicolas Ferre <nicolas.ferre@microchip.com> > + - Alexandre Belloni <alexandre.belloni@bootlin.com> > + - Claudiu Beznea <claudiu.beznea@tuxon.dev> > + > +description: | Again, the | is not needed here. > + The LCDC integrates a Pulse Width Modulation (PWM) Controller. This block > + generates the LCD contrast control signal (LCD_PWM) that controls the > + display's contrast by software. LCDC_PWM is an 8-bit PWM signal that can be > + converted to an analog voltage with a simple passive filter. LCD display > + panels have different backlight specifications in terms of minimum/maximum > + values for PWM frequency. If the LCDC PWM frequency range does not match the > + LCD display panel, it is possible to use the standalone PWM Controller to > + drive the backlight. > + > +properties: > + compatible: > + const: atmel,hlcdc-pwm > + > + "#pwm-cells": > + const: 3 > + description: | > + This PWM chip uses the default 3 cells bindings defined in pwm.yaml in > + this directory. I would delete this description tbh. > + > +required: > + - compatible > + - "#pwm-cells" > + > +additionalProperties: false > + > +examples: > + - | > + pwm: pwm { > + compatible = "atmel,hlcdc-pwm"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_lcd_pwm>; > + #pwm-cells = <3>; > + }; The label here is not used and can be dropped. Otherwise, Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor. > diff --git a/Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt b/Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt > deleted file mode 100644 > index afa501bf7f94..000000000000 > --- a/Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt > +++ /dev/null > @@ -1,29 +0,0 @@ > -Device-Tree bindings for Atmel's HLCDC (High-end LCD Controller) PWM driver > - > -The Atmel HLCDC PWM is subdevice of the HLCDC MFD device. > -See ../mfd/atmel-hlcdc.txt for more details. > - > -Required properties: > - - compatible: value should be one of the following: > - "atmel,hlcdc-pwm" > - - pinctr-names: the pin control state names. Should contain "default". > - - pinctrl-0: should contain the pinctrl states described by pinctrl > - default. > - - #pwm-cells: should be set to 3. This PWM chip use the default 3 cells > - bindings defined in pwm.yaml in this directory. > - > -Example: > - > - hlcdc: hlcdc@f0030000 { > - compatible = "atmel,sama5d3-hlcdc"; > - reg = <0xf0030000 0x2000>; > - clocks = <&lcdc_clk>, <&lcdck>, <&clk32k>; > - clock-names = "periph_clk","sys_clk", "slow_clk"; > - > - hlcdc_pwm: hlcdc-pwm { > - compatible = "atmel,hlcdc-pwm"; > - pinctrl-names = "default"; > - pinctrl-0 = <&pinctrl_lcd_pwm>; > - #pwm-cells = <3>; > - }; > - }; > -- > 2.25.1 >
On 16/01/2024 18:03:19+0000, Conor Dooley wrote: > On Tue, Jan 16, 2024 at 05:07:59PM +0530, Dharma Balasubiramani wrote: > > Convert device tree bindings for Atmel's HLCDC PWM controller to YAML > > format. > > > > Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> > > --- > > changelog > > v1 -> v2 > > - Remove the explicit copyrights. > > - Modify title (not include words like binding/driver). > > - Modify description actually describing the hardware and not the driver. > > - Remove pinctrl properties which aren't required. > > - Drop parent node and it's other sub-device node which are not related here. > > --- > > .../bindings/pwm/atmel,hlcdc-pwm.yaml | 47 +++++++++++++++++++ > > .../bindings/pwm/atmel-hlcdc-pwm.txt | 29 ------------ > > 2 files changed, 47 insertions(+), 29 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml > > delete mode 100644 Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt > > > > diff --git a/Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml b/Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml > > new file mode 100644 > > index 000000000000..751122309fa9 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml > > @@ -0,0 +1,47 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > The original file has no license, but was originally written by a > free-electrons employee, so the relicensing here is fine. > I confirm relicensing is fine, even assigning the copyright to Microchip (note that Bootlin is legally the same entity as free-electrons) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/pwm/atmel,hlcdc-pwm.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Atmel's HLCDC's PWM controller > > + > > +maintainers: > > + - Nicolas Ferre <nicolas.ferre@microchip.com> > > + - Alexandre Belloni <alexandre.belloni@bootlin.com> > > + - Claudiu Beznea <claudiu.beznea@tuxon.dev> > > + > > +description: | > > Again, the | is not needed here. > > > + The LCDC integrates a Pulse Width Modulation (PWM) Controller. This block > > + generates the LCD contrast control signal (LCD_PWM) that controls the > > + display's contrast by software. LCDC_PWM is an 8-bit PWM signal that can be > > + converted to an analog voltage with a simple passive filter. LCD display > > + panels have different backlight specifications in terms of minimum/maximum > > + values for PWM frequency. If the LCDC PWM frequency range does not match the > > + LCD display panel, it is possible to use the standalone PWM Controller to > > + drive the backlight. > > + > > +properties: > > + compatible: > > + const: atmel,hlcdc-pwm > > + > > + "#pwm-cells": > > + const: 3 > > + description: | > > + This PWM chip uses the default 3 cells bindings defined in pwm.yaml in > > + this directory. > > I would delete this description tbh. > > > + > > +required: > > + - compatible > > + - "#pwm-cells" > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + pwm: pwm { > > + compatible = "atmel,hlcdc-pwm"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_lcd_pwm>; > > + #pwm-cells = <3>; > > + }; > > The label here is not used and can be dropped. Otherwise, > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > > > Cheers, > Conor. > > > diff --git a/Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt b/Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt > > deleted file mode 100644 > > index afa501bf7f94..000000000000 > > --- a/Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt > > +++ /dev/null > > @@ -1,29 +0,0 @@ > > -Device-Tree bindings for Atmel's HLCDC (High-end LCD Controller) PWM driver > > - > > -The Atmel HLCDC PWM is subdevice of the HLCDC MFD device. > > -See ../mfd/atmel-hlcdc.txt for more details. > > - > > -Required properties: > > - - compatible: value should be one of the following: > > - "atmel,hlcdc-pwm" > > - - pinctr-names: the pin control state names. Should contain "default". > > - - pinctrl-0: should contain the pinctrl states described by pinctrl > > - default. > > - - #pwm-cells: should be set to 3. This PWM chip use the default 3 cells > > - bindings defined in pwm.yaml in this directory. > > - > > -Example: > > - > > - hlcdc: hlcdc@f0030000 { > > - compatible = "atmel,sama5d3-hlcdc"; > > - reg = <0xf0030000 0x2000>; > > - clocks = <&lcdc_clk>, <&lcdck>, <&clk32k>; > > - clock-names = "periph_clk","sys_clk", "slow_clk"; > > - > > - hlcdc_pwm: hlcdc-pwm { > > - compatible = "atmel,hlcdc-pwm"; > > - pinctrl-names = "default"; > > - pinctrl-0 = <&pinctrl_lcd_pwm>; > > - #pwm-cells = <3>; > > - }; > > - }; > > -- > > 2.25.1 > >
On 17/01/24 1:40 am, Alexandre Belloni wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 16/01/2024 18:03:19+0000, Conor Dooley wrote: >> On Tue, Jan 16, 2024 at 05:07:59PM +0530, Dharma Balasubiramani wrote: >>> Convert device tree bindings for Atmel's HLCDC PWM controller to YAML >>> format. >>> >>> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> >>> --- >>> changelog >>> v1 -> v2 >>> - Remove the explicit copyrights. >>> - Modify title (not include words like binding/driver). >>> - Modify description actually describing the hardware and not the driver. >>> - Remove pinctrl properties which aren't required. >>> - Drop parent node and it's other sub-device node which are not related here. >>> --- >>> .../bindings/pwm/atmel,hlcdc-pwm.yaml | 47 +++++++++++++++++++ >>> .../bindings/pwm/atmel-hlcdc-pwm.txt | 29 ------------ >>> 2 files changed, 47 insertions(+), 29 deletions(-) >>> create mode 100644 Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml >>> delete mode 100644 Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt >>> >>> diff --git a/Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml b/Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml >>> new file mode 100644 >>> index 000000000000..751122309fa9 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml >>> @@ -0,0 +1,47 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> >> The original file has no license, but was originally written by a >> free-electrons employee, so the relicensing here is fine. >> > > I confirm relicensing is fine, even assigning the copyright to > Microchip (note that Bootlin is legally the same entity as > free-electrons) Thanks Conor and Alexandre. I will add the copyrights back in v3. > >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/pwm/atmel,hlcdc-pwm.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Atmel's HLCDC's PWM controller >>> + >>> +maintainers: >>> + - Nicolas Ferre <nicolas.ferre@microchip.com> >>> + - Alexandre Belloni <alexandre.belloni@bootlin.com> >>> + - Claudiu Beznea <claudiu.beznea@tuxon.dev> >>> + >>> +description: | >> >> Again, the | is not needed here. Sure, I will drop it. >> >>> + The LCDC integrates a Pulse Width Modulation (PWM) Controller. This block >>> + generates the LCD contrast control signal (LCD_PWM) that controls the >>> + display's contrast by software. LCDC_PWM is an 8-bit PWM signal that can be >>> + converted to an analog voltage with a simple passive filter. LCD display >>> + panels have different backlight specifications in terms of minimum/maximum >>> + values for PWM frequency. If the LCDC PWM frequency range does not match the >>> + LCD display panel, it is possible to use the standalone PWM Controller to >>> + drive the backlight. >>> + >>> +properties: >>> + compatible: >>> + const: atmel,hlcdc-pwm >>> + >>> + "#pwm-cells": >>> + const: 3 >>> + description: | >>> + This PWM chip uses the default 3 cells bindings defined in pwm.yaml in >>> + this directory. >> >> I would delete this description tbh. Sure, I will remove it. >> >>> + >>> +required: >>> + - compatible >>> + - "#pwm-cells" >>> + >>> +additionalProperties: false >>> + >>> +examples: >>> + - | >>> + pwm: pwm { >>> + compatible = "atmel,hlcdc-pwm"; >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&pinctrl_lcd_pwm>; >>> + #pwm-cells = <3>; >>> + }; >> >> The label here is not used and can be dropped. Otherwise, >> Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Sure, I will remove the label. -- With Best Regards, Dharma B. >> >> >> Cheers, >> Conor. >> >>> diff --git a/Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt b/Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt >>> deleted file mode 100644 >>> index afa501bf7f94..000000000000 >>> --- a/Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt >>> +++ /dev/null >>> @@ -1,29 +0,0 @@ >>> -Device-Tree bindings for Atmel's HLCDC (High-end LCD Controller) PWM driver >>> - >>> -The Atmel HLCDC PWM is subdevice of the HLCDC MFD device. >>> -See ../mfd/atmel-hlcdc.txt for more details. >>> - >>> -Required properties: >>> - - compatible: value should be one of the following: >>> - "atmel,hlcdc-pwm" >>> - - pinctr-names: the pin control state names. Should contain "default". >>> - - pinctrl-0: should contain the pinctrl states described by pinctrl >>> - default. >>> - - #pwm-cells: should be set to 3. This PWM chip use the default 3 cells >>> - bindings defined in pwm.yaml in this directory. >>> - >>> -Example: >>> - >>> - hlcdc: hlcdc@f0030000 { >>> - compatible = "atmel,sama5d3-hlcdc"; >>> - reg = <0xf0030000 0x2000>; >>> - clocks = <&lcdc_clk>, <&lcdck>, <&clk32k>; >>> - clock-names = "periph_clk","sys_clk", "slow_clk"; >>> - >>> - hlcdc_pwm: hlcdc-pwm { >>> - compatible = "atmel,hlcdc-pwm"; >>> - pinctrl-names = "default"; >>> - pinctrl-0 = <&pinctrl_lcd_pwm>; >>> - #pwm-cells = <3>; >>> - }; >>> - }; >>> -- >>> 2.25.1 >>> > > > > -- > Alexandre Belloni, co-owner and COO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
On Wed, Jan 17, 2024 at 02:43:00AM +0000, Dharma.B@microchip.com wrote: > On 17/01/24 1:40 am, Alexandre Belloni wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > > On 16/01/2024 18:03:19+0000, Conor Dooley wrote: > >> On Tue, Jan 16, 2024 at 05:07:59PM +0530, Dharma Balasubiramani wrote: > >>> Convert device tree bindings for Atmel's HLCDC PWM controller to YAML > >>> format. > >>> > >>> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> > >>> --- > >>> changelog > >>> v1 -> v2 > >>> - Remove the explicit copyrights. > >>> - Modify title (not include words like binding/driver). > >>> - Modify description actually describing the hardware and not the driver. > >>> - Remove pinctrl properties which aren't required. > >>> - Drop parent node and it's other sub-device node which are not related here. > >>> --- > >>> .../bindings/pwm/atmel,hlcdc-pwm.yaml | 47 +++++++++++++++++++ > >>> .../bindings/pwm/atmel-hlcdc-pwm.txt | 29 ------------ > >>> 2 files changed, 47 insertions(+), 29 deletions(-) > >>> create mode 100644 Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml > >>> delete mode 100644 Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt > >>> > >>> diff --git a/Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml b/Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml > >>> new file mode 100644 > >>> index 000000000000..751122309fa9 > >>> --- /dev/null > >>> +++ b/Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml > >>> @@ -0,0 +1,47 @@ > >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >> > >> The original file has no license, but was originally written by a > >> free-electrons employee, so the relicensing here is fine. > >> > > > > I confirm relicensing is fine, even assigning the copyright to > > Microchip (note that Bootlin is legally the same entity as > > free-electrons) > Thanks Conor and Alexandre. > I will add the copyrights back in v3. Just to note, in case you misunderstood my original comment here: What I said had nothing to do with adding a Microchip copyright assignment to the file, but rather about the fact that your patch relicenses the binding from GPL v2 to GPL v2 OR BSD 2 Clause.
On 17/01/24 9:03 pm, Conor Dooley wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > ForwardedMessage.eml > > Subject: > Re: [PATCH v2 2/3] dt-bindings: atmel,hlcdc: convert pwm bindings to > json-schema > From: > Conor Dooley <conor@kernel.org> > Date: > 17/01/24, 9:03 pm > > To: > Dharma.B@microchip.com > CC: > alexandre.belloni@bootlin.com, Conor.Dooley@microchip.com, > sam@ravnborg.org, bbrezillon@kernel.org, > maarten.lankhorst@linux.intel.com, mripard@kernel.org, > tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, > robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, > conor+dt@kernel.org, Nicolas.Ferre@microchip.com, > claudiu.beznea@tuxon.dev, dri-devel@lists.freedesktop.org, > devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, > linux-kernel@vger.kernel.org, lee@kernel.org, thierry.reding@gmail.com, > u.kleine-koenig@pengutronix.de, linux-pwm@vger.kernel.org, > Linux4Microchip@microchip.com > > > On Wed, Jan 17, 2024 at 02:43:00AM +0000,Dharma.B@microchip.com wrote: >> On 17/01/24 1:40 am, Alexandre Belloni wrote: >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >>> >>> On 16/01/2024 18:03:19+0000, Conor Dooley wrote: >>>> On Tue, Jan 16, 2024 at 05:07:59PM +0530, Dharma Balasubiramani wrote: >>>>> Convert device tree bindings for Atmel's HLCDC PWM controller to YAML >>>>> format. >>>>> >>>>> Signed-off-by: Dharma Balasubiramani<dharma.b@microchip.com> >>>>> --- >>>>> changelog >>>>> v1 -> v2 >>>>> - Remove the explicit copyrights. >>>>> - Modify title (not include words like binding/driver). >>>>> - Modify description actually describing the hardware and not the driver. >>>>> - Remove pinctrl properties which aren't required. >>>>> - Drop parent node and it's other sub-device node which are not related here. >>>>> --- >>>>> .../bindings/pwm/atmel,hlcdc-pwm.yaml | 47 +++++++++++++++++++ >>>>> .../bindings/pwm/atmel-hlcdc-pwm.txt | 29 ------------ >>>>> 2 files changed, 47 insertions(+), 29 deletions(-) >>>>> create mode 100644 Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml >>>>> delete mode 100644 Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml b/Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml >>>>> new file mode 100644 >>>>> index 000000000000..751122309fa9 >>>>> --- /dev/null >>>>> +++ b/Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml >>>>> @@ -0,0 +1,47 @@ >>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>> The original file has no license, but was originally written by a >>>> free-electrons employee, so the relicensing here is fine. >>>> >>> I confirm relicensing is fine, even assigning the copyright to >>> Microchip (note that Bootlin is legally the same entity as >>> free-electrons) >> Thanks Conor and Alexandre. >> I will add the copyrights back in v3. > Just to note, in case you misunderstood my original comment here: > What I said had nothing to do with adding a Microchip copyright assignment > to the file, but rather about the fact that your patch relicenses the > binding from GPL v2 to GPL v2 OR BSD 2 Clause. I appreciate the clarification; my initial understanding was not accurate. Thanks > -- With Best Regards, Dharma B.
diff --git a/Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml b/Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml new file mode 100644 index 000000000000..751122309fa9 --- /dev/null +++ b/Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml @@ -0,0 +1,47 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/pwm/atmel,hlcdc-pwm.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Atmel's HLCDC's PWM controller + +maintainers: + - Nicolas Ferre <nicolas.ferre@microchip.com> + - Alexandre Belloni <alexandre.belloni@bootlin.com> + - Claudiu Beznea <claudiu.beznea@tuxon.dev> + +description: | + The LCDC integrates a Pulse Width Modulation (PWM) Controller. This block + generates the LCD contrast control signal (LCD_PWM) that controls the + display's contrast by software. LCDC_PWM is an 8-bit PWM signal that can be + converted to an analog voltage with a simple passive filter. LCD display + panels have different backlight specifications in terms of minimum/maximum + values for PWM frequency. If the LCDC PWM frequency range does not match the + LCD display panel, it is possible to use the standalone PWM Controller to + drive the backlight. + +properties: + compatible: + const: atmel,hlcdc-pwm + + "#pwm-cells": + const: 3 + description: | + This PWM chip uses the default 3 cells bindings defined in pwm.yaml in + this directory. + +required: + - compatible + - "#pwm-cells" + +additionalProperties: false + +examples: + - | + pwm: pwm { + compatible = "atmel,hlcdc-pwm"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_lcd_pwm>; + #pwm-cells = <3>; + }; diff --git a/Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt b/Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt deleted file mode 100644 index afa501bf7f94..000000000000 --- a/Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt +++ /dev/null @@ -1,29 +0,0 @@ -Device-Tree bindings for Atmel's HLCDC (High-end LCD Controller) PWM driver - -The Atmel HLCDC PWM is subdevice of the HLCDC MFD device. -See ../mfd/atmel-hlcdc.txt for more details. - -Required properties: - - compatible: value should be one of the following: - "atmel,hlcdc-pwm" - - pinctr-names: the pin control state names. Should contain "default". - - pinctrl-0: should contain the pinctrl states described by pinctrl - default. - - #pwm-cells: should be set to 3. This PWM chip use the default 3 cells - bindings defined in pwm.yaml in this directory. - -Example: - - hlcdc: hlcdc@f0030000 { - compatible = "atmel,sama5d3-hlcdc"; - reg = <0xf0030000 0x2000>; - clocks = <&lcdc_clk>, <&lcdck>, <&clk32k>; - clock-names = "periph_clk","sys_clk", "slow_clk"; - - hlcdc_pwm: hlcdc-pwm { - compatible = "atmel,hlcdc-pwm"; - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_lcd_pwm>; - #pwm-cells = <3>; - }; - };