Message ID | 20240116090455.3407378-1-usama.anjum@collabora.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-27150-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:42cf:b0:101:a8e8:374 with SMTP id q15csp132661dye; Tue, 16 Jan 2024 01:05:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IHzB/07hR7aDCnMBMUEBMm0btpoWy7KdteJMcy4z25A1nRkJ7+Yc3NG8KRoCl8YziGd/GCJ X-Received: by 2002:aa7:cf0e:0:b0:553:29f0:d4ad with SMTP id a14-20020aa7cf0e000000b0055329f0d4admr2949587edy.82.1705395948392; Tue, 16 Jan 2024 01:05:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705395948; cv=none; d=google.com; s=arc-20160816; b=Q9IyARnpsq3jmGfALwRhQJatpTSHVNjQvUunCehF6d0XT88Kdiy+ZMNs8iLTcYofr7 stvEA++QronfyYkCg8zgUkpMGlJXIEoQoZSJBt00JpNStOVSGBGp1RjoxPEELjhF7kOi Zpd9XpTMWij+wKdnykRpdY1QVM1MnOYkL66YF6FBF1ow+lU97b4gvbFz7qrVgw1XfuX6 8vAUn0+ItHpKXOnUzdVuDqMdFUGpjYe6uQjhU96qdQj8Oe2Fn7/WHyin/G4YeUPs/dI4 h/4CZUBZsx7iFIIfe47WneoNjhvt8yIILRoV7PPmpQDVaIJ04ZWtlRsNNx9d60y0IVoU nTIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=XBM++dyY53xmwvWVLsHxFMWxC5pSrc4GXd3AOsWO+8M=; fh=mVBrUHkdhr4FdAuGFuDLONjpBFXQ76Q1/p1ghTG2QxI=; b=EheqQ4/p0DwxaHPxphAjU+bscXYO+KmFI+nZAla0XsO/y8qR+o8Q5s9lgffWmxghhP QsceIJ16gc+xSpqYP9ZrAgwhNFhWodorI4KZeBZ0Lap5/pIeuMjzLIcP6xJ/QAMJSuzP D4GXrYzr5nBXsl1RthpAHFDsNdlTW00HudFlMpEsJcxuxOIB64xAUYdoxI+ChAppnP5R V05HTxEJTo4PuAFHpJ5bUlsCD/1sawZW0Td2deXdUwXNqoIpTud+pUsuH5a/jFePk7AM tx7oW26gMfQBw6C+acaTG8YyB3AuMRFo6/aLt4lelGSxgmCD5+btnTPYY4MX9b0eKFCl pPiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@collabora.com header.s=mail header.b=MjVEw5nk; spf=pass (google.com: domain of linux-kernel+bounces-27150-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-27150-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id o9-20020a056402444900b00557de2fda06si4785025edb.679.2024.01.16.01.05.48 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jan 2024 01:05:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-27150-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@collabora.com header.s=mail header.b=MjVEw5nk; spf=pass (google.com: domain of linux-kernel+bounces-27150-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-27150-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 02AF01F24200 for <ouuuleilei@gmail.com>; Tue, 16 Jan 2024 09:05:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1285612B7F; Tue, 16 Jan 2024 09:05:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="MjVEw5nk" Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5EB512B70; Tue, 16 Jan 2024 09:05:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1705395929; bh=ugmXZTrJwY2DWctHzDYOn6LeXz0LXSbkdXjcp9JcxPY=; h=From:To:Cc:Subject:Date:From; b=MjVEw5nkSkP/JIGNqaz8zdXhJ+OBdsmCH/EnCjOyDWaEJf94kW40RkGtgkxlk7dHq psvYgaoIkR3YK0x1sP+41I/XoAnYotI6lwTiq3X/uIpfjD4uUzh9+Sd4IYYZQt7WgW yG7p8rr842sLq9QwHppi8v8x/8oirKTNiUb+6wIu2lzg/wlW4UtGdU9pb8upJjP3qC k1/iA6Q3kEP7iKDSch3PsUmrvVL8+EVK2D1ceypwisR0XunEXPgySBJISukKY3Fe/g cF7ZAzgupoHnFyrrZtZDpQ651GwKEc4zHh169MQNUV36jrzsYQtDbENiOt96VbwqJi xRR0ZrrVcYSsA== Received: from localhost.localdomain (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 212D7378200E; Tue, 16 Jan 2024 09:05:26 +0000 (UTC) From: Muhammad Usama Anjum <usama.anjum@collabora.com> To: Andrew Morton <akpm@linux-foundation.org>, Shuah Khan <shuah@kernel.org> Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>, kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] selftests/mm: switch to bash from sh Date: Tue, 16 Jan 2024 14:04:54 +0500 Message-ID: <20240116090455.3407378-1-usama.anjum@collabora.com> X-Mailer: git-send-email 2.42.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788237261919043946 X-GMAIL-MSGID: 1788237261919043946 |
Series |
selftests/mm: switch to bash from sh
|
|
Commit Message
Muhammad Usama Anjum
Jan. 16, 2024, 9:04 a.m. UTC
Running charge_reserved_hugetlb.sh generates errors if sh is set to
dash:
/charge_reserved_hugetlb.sh: 9: [[: not found
/charge_reserved_hugetlb.sh: 19: [[: not found
/charge_reserved_hugetlb.sh: 27: [[: not found
/charge_reserved_hugetlb.sh: 37: [[: not found
/charge_reserved_hugetlb.sh: 45: Syntax error: "(" unexpected
Switch to using /bin/bash instead of /bin/sh. Make the switch for
write_hugetlb_memory.sh as well which is called from
charge_reserved_hugetlb.sh.
Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
---
tools/testing/selftests/mm/charge_reserved_hugetlb.sh | 2 +-
tools/testing/selftests/mm/write_hugetlb_memory.sh | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
Comments
From: Muhammad Usama Anjum > Sent: 16 January 2024 09:05 > > Running charge_reserved_hugetlb.sh generates errors if sh is set to > dash: > > /charge_reserved_hugetlb.sh: 9: [[: not found > /charge_reserved_hugetlb.sh: 19: [[: not found > /charge_reserved_hugetlb.sh: 27: [[: not found > /charge_reserved_hugetlb.sh: 37: [[: not found > /charge_reserved_hugetlb.sh: 45: Syntax error: "(" unexpected > > Switch to using /bin/bash instead of /bin/sh. Make the switch for > write_hugetlb_memory.sh as well which is called from > charge_reserved_hugetlb.sh. Why not just fix the script? Looks like most of the [[ ... ]] could be [ ... ] although some might need to be [ -n "$cgroup2" ]. The delete the 'function' keyword another bash-ism. It's not as though you are trying to run on a system when /bin/sh is a traditional (aka non-posix) bourne shell. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
On 1/16/24 9:52 PM, David Laight wrote: > From: Muhammad Usama Anjum >> Sent: 16 January 2024 09:05 >> >> Running charge_reserved_hugetlb.sh generates errors if sh is set to >> dash: >> >> /charge_reserved_hugetlb.sh: 9: [[: not found >> /charge_reserved_hugetlb.sh: 19: [[: not found >> /charge_reserved_hugetlb.sh: 27: [[: not found >> /charge_reserved_hugetlb.sh: 37: [[: not found >> /charge_reserved_hugetlb.sh: 45: Syntax error: "(" unexpected >> >> Switch to using /bin/bash instead of /bin/sh. Make the switch for >> write_hugetlb_memory.sh as well which is called from >> charge_reserved_hugetlb.sh. > > Why not just fix the script? The Bash is being used in all or most of the selftests. I'd seen other similar [1][2] patches floating around which are converting /bin/sh (pointing to dash) to /bin/bash. [1] https://lore.kernel.org/linux-kselftest/20240110141436.157419-2-bpoirier@nvidia.com/ [2] https://lore.kernel.org/linux-kselftest/20231229131931.3961150-1-yujie.liu@intel.com/ > Looks like most of the [[ ... ]] could be [ ... ] > although some might need to be [ -n "$cgroup2" ]. > The delete the 'function' keyword another bash-ism. > > It's not as though you are trying to run on a system > when /bin/sh is a traditional (aka non-posix) bourne shell. > > David > > - > Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK > Registration No: 1397386 (Wales) > >
diff --git a/tools/testing/selftests/mm/charge_reserved_hugetlb.sh b/tools/testing/selftests/mm/charge_reserved_hugetlb.sh index 0899019a7fcb..e14bdd4455f2 100755 --- a/tools/testing/selftests/mm/charge_reserved_hugetlb.sh +++ b/tools/testing/selftests/mm/charge_reserved_hugetlb.sh @@ -1,4 +1,4 @@ -#!/bin/sh +#!/bin/bash # SPDX-License-Identifier: GPL-2.0 # Kselftest framework requirement - SKIP code is 4. diff --git a/tools/testing/selftests/mm/write_hugetlb_memory.sh b/tools/testing/selftests/mm/write_hugetlb_memory.sh index 70a02301f4c2..3d2d2eb9d6ff 100755 --- a/tools/testing/selftests/mm/write_hugetlb_memory.sh +++ b/tools/testing/selftests/mm/write_hugetlb_memory.sh @@ -1,4 +1,4 @@ -#!/bin/sh +#!/bin/bash # SPDX-License-Identifier: GPL-2.0 set -e