Message ID | 20240116093903.19403-3-johan+linaro@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-27189-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:42cf:b0:101:a8e8:374 with SMTP id q15csp145607dye; Tue, 16 Jan 2024 01:41:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IEG1gRFJaKbWX1KKuKndSpT1cgj3KGgKx0n7tb1wNSeurx+ehTiGXpPvfln3FRrjgW6QJUx X-Received: by 2002:a17:902:f545:b0:1d4:326c:1c9f with SMTP id h5-20020a170902f54500b001d4326c1c9fmr3799255plf.86.1705398067452; Tue, 16 Jan 2024 01:41:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705398067; cv=none; d=google.com; s=arc-20160816; b=j0TK72FrlAzBqpvoysEYIlgCZ29Nl17a3pkC6Q6UfWAqUmkR8sDHB+n4gprWS8/vHc VvFY+HoOOUkWdbPqJH6KyIkA36Hu+sMiek3ZArNabcd87TShy1zyixtf9+cxVrlvw5k3 YdjiqTm6iqhFxeGybDVQz7Ib+1Pp4vxXTEwJbtaP1JA3MX6orGJMFsuWfmMRGXp7QLkW fjUWXj3s434QKWX1JY+s8Rkbiq4vUZ4npwDNs50WS3nD57uvd6WJSCNmu/ci+GY8RmUP cKIo+sQ3g9cie2IIcuezZUgUo/OgwnuFRwAPZXGtVo9e23OLrBDn3RbIiP/qMe4GZeAX dpFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=YaorwE+xhyjglqhqkxzD9kRzXodpJ8sJlkDJtY6Y0xQ=; fh=KBIhiGdu1Ygtr3M+FTFcsBcOHAnQgw4Q3/a7frwkCBE=; b=wz4G36xkKR9xb8bZNG0Hf73D+2WlZJE8+FX94lljMHdpSgg9UnUnhY/oeVynopqhsj ODFpW0zLFo3AcwSbtfRRDzAQb3dTXJrlBmN/I5km3ZbnaXlxhQDcvvKPdnh3iea5NlDN AeeoGiEACacNc5AkTkN/r8XyNxDLa/N05ySwJeUZAEC3Eulz9ABe+LejyNy4NqsUV/KT lvqDFBZTcnLSGo11uKjUerUrNemgQ+MFrc/SGgrQW6HhhoXDZjc5fDeRoPCtzlwvFoFQ rt6p4mVCE9habOi/6XM1bD25N56rlPIAHTp7SCTE3g9e8Cm98bCEVHax/4IvI5qKsvpo Cm8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hzZKRWMr; spf=pass (google.com: domain of linux-kernel+bounces-27189-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-27189-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id kl6-20020a170903074600b001d5eb28abbfsi623560plb.138.2024.01.16.01.41.07 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jan 2024 01:41:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-27189-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hzZKRWMr; spf=pass (google.com: domain of linux-kernel+bounces-27189-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-27189-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 2FE1C284560 for <ouuuleilei@gmail.com>; Tue, 16 Jan 2024 09:41:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B461518647; Tue, 16 Jan 2024 09:39:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hzZKRWMr" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E99CF12B9D; Tue, 16 Jan 2024 09:39:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8CFEFC43394; Tue, 16 Jan 2024 09:39:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705397981; bh=N8c8yQ8JoVaZ43ekrgFMJaI6nSmiX70JukNaBce+F1M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hzZKRWMrHhV/16BojQ69j2BghzEVFFRdYyUQsp9ne6dQpadmkTlTbx6LxBT483wRm xDA1RCjOqZqOeb8D7WPBMXeUmEr/3z6qzsMYhBvuz2TZ2lsgL1xwFomapPg2QcNnan OTGBQem22S3QJ5C0gZUdmpIyeIdd8fsUi05I3wt0MqJc1xJpEQTCkg8UI11YOx60LI O4esH6VYlFUFOX1I57ZFeeC9ma3NFmTyINVkDozvRZY2rSqV595p/9q7iS8mkE4UMb KAnyQ0VYAmhNSRGjcVucA72rkvPu4TFzgB3HhyoB/c/InpqjOQhDMRFIgNrqKlmQ0G uoMcWnfQEsClg== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from <johan+linaro@kernel.org>) id 1rPfv6-00053T-0r; Tue, 16 Jan 2024 10:39:44 +0100 From: Johan Hovold <johan+linaro@kernel.org> To: Mark Brown <broonie@kernel.org> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, Banajit Goswami <bgoswami@quicinc.com>, Liam Girdwood <lgirdwood@gmail.com>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold <johan+linaro@kernel.org>, stable@vger.kernel.org Subject: [PATCH 2/7] ASoC: codecs: lpass-wsa-macro: fix compander volume hack Date: Tue, 16 Jan 2024 10:38:58 +0100 Message-ID: <20240116093903.19403-3-johan+linaro@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240116093903.19403-1-johan+linaro@kernel.org> References: <20240116093903.19403-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788239484214432792 X-GMAIL-MSGID: 1788239484214432792 |
Series |
ASoC: qcom: volume fixes and codec cleanups
|
|
Commit Message
Johan Hovold
Jan. 16, 2024, 9:38 a.m. UTC
The LPASS WSA macro codec driver is updating the digital gain settings
behind the back of user space on DAPM events if companding has been
enabled.
As compander control is exported to user space, this can result in the
digital gain setting being incremented (or decremented) every time the
sound server is started and the codec suspended depending on what the
UCM configuration looks like.
Soon enough playback will become distorted (or too quiet).
This is specifically a problem on the Lenovo ThinkPad X13s as this
bypasses the limit for the digital gain setting that has been set by the
machine driver.
Fix this by simply dropping the compander gain hack. If someone cares
about modelling the impact of the compander setting this can possibly be
done by exporting it as a volume control later.
Fixes: 2c4066e5d428 ("ASoC: codecs: lpass-wsa-macro: add dapm widgets and route")
Cc: stable@vger.kernel.org # 5.11
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
sound/soc/codecs/lpass-wsa-macro.c | 10 ----------
1 file changed, 10 deletions(-)
Comments
Thanks Johan for this patch, On 16/01/2024 09:38, Johan Hovold wrote: > The LPASS WSA macro codec driver is updating the digital gain settings > behind the back of user space on DAPM events if companding has been > enabled. > > As compander control is exported to user space, this can result in the > digital gain setting being incremented (or decremented) every time the > sound server is started and the codec suspended depending on what the > UCM configuration looks like. > > Soon enough playback will become distorted (or too quiet). > > This is specifically a problem on the Lenovo ThinkPad X13s as this > bypasses the limit for the digital gain setting that has been set by the > machine driver. > > Fix this by simply dropping the compander gain hack. If someone cares > about modelling the impact of the compander setting this can possibly be > done by exporting it as a volume control later. > This is not a hack, wsa codec requires gain to be programmed after the clk is enabled for that particular interpolator. However I agree with you on programming the gain that is different to what user set it. This is because of unimplemented or half baked implementation of half-db feature of gain control in this codec. We can clean that half baked implementation for now and still continue to program the gain values after the clks are enabled. lets remove spkr_gain_offset and associated code paths in this codec, which should fix the issue that you have reported and still do the right thing of programming gain after clks are enabled. thanks, Srini > Fixes: 2c4066e5d428 ("ASoC: codecs: lpass-wsa-macro: add dapm widgets and route") > Cc: stable@vger.kernel.org # 5.11 > Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- > sound/soc/codecs/lpass-wsa-macro.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/sound/soc/codecs/lpass-wsa-macro.c b/sound/soc/codecs/lpass-wsa-macro.c > index 7e21cec3c2fb..7de221464d47 100644 > --- a/sound/soc/codecs/lpass-wsa-macro.c > +++ b/sound/soc/codecs/lpass-wsa-macro.c > @@ -1583,8 +1583,6 @@ static int wsa_macro_enable_interpolator(struct snd_soc_dapm_widget *w, > struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm); > u16 gain_reg; > u16 reg; > - int val; > - int offset_val = 0; > struct wsa_macro *wsa = snd_soc_component_get_drvdata(component); > > if (w->shift == WSA_MACRO_COMP1) { > @@ -1623,11 +1621,7 @@ static int wsa_macro_enable_interpolator(struct snd_soc_dapm_widget *w, > CDC_WSA_RX1_RX_PATH_MIX_SEC0, > CDC_WSA_RX_PGA_HALF_DB_MASK, > CDC_WSA_RX_PGA_HALF_DB_ENABLE); > - offset_val = -2; > } > - val = snd_soc_component_read(component, gain_reg); > - val += offset_val; > - snd_soc_component_write(component, gain_reg, val); > wsa_macro_config_ear_spkr_gain(component, wsa, > event, gain_reg); > break; > @@ -1654,10 +1648,6 @@ static int wsa_macro_enable_interpolator(struct snd_soc_dapm_widget *w, > CDC_WSA_RX1_RX_PATH_MIX_SEC0, > CDC_WSA_RX_PGA_HALF_DB_MASK, > CDC_WSA_RX_PGA_HALF_DB_DISABLE); > - offset_val = 2; > - val = snd_soc_component_read(component, gain_reg); > - val += offset_val; > - snd_soc_component_write(component, gain_reg, val); > } > wsa_macro_config_ear_spkr_gain(component, wsa, > event, gain_reg);
On Tue, Jan 16, 2024 at 11:10:21AM +0000, Srinivas Kandagatla wrote: > Thanks Johan for this patch, > > On 16/01/2024 09:38, Johan Hovold wrote: > > The LPASS WSA macro codec driver is updating the digital gain settings > > behind the back of user space on DAPM events if companding has been > > enabled. > > > > As compander control is exported to user space, this can result in the > > digital gain setting being incremented (or decremented) every time the > > sound server is started and the codec suspended depending on what the > > UCM configuration looks like. > > > > Soon enough playback will become distorted (or too quiet). > > > > This is specifically a problem on the Lenovo ThinkPad X13s as this > > bypasses the limit for the digital gain setting that has been set by the > > machine driver. > > > > Fix this by simply dropping the compander gain hack. If someone cares > > about modelling the impact of the compander setting this can possibly be > > done by exporting it as a volume control later. > > > This is not a hack, wsa codec requires gain to be programmed after the > clk is enabled for that particular interpolator. Ok, but then it's also broken as, as I mentioned off-list, these registers are cached so unless companding is enabled, the write on enable will have no effect. > However I agree with you on programming the gain that is different to > what user set it. > > This is because of unimplemented or half baked implementation of half-db > feature of gain control in this codec. > > We can clean that half baked implementation for now and still continue > to program the gain values after the clks are enabled. > > lets remove spkr_gain_offset and associated code paths in this codec, > which should fix the issue that you have reported and still do the right > thing of programming gain after clks are enabled. Removing the offset which can alter the gain, will cause both of these writes to become no-ops as the registers are cached (e.g. just as for the follow-on codec cleanups). So then we might as well just remove this too. How is the half-dB feature supposed to work? And are you sure that you need to reprogram the gain value after enabling the clock? Everything seems to work without doing so. Johan
On Tue, Jan 16, 2024 at 02:10:19PM +0100, Johan Hovold wrote: > On Tue, Jan 16, 2024 at 11:10:21AM +0000, Srinivas Kandagatla wrote: > > This is not a hack, wsa codec requires gain to be programmed after the > > clk is enabled for that particular interpolator. > > Ok, but then it's also broken as, as I mentioned off-list, these > registers are cached so unless companding is enabled, the write on > enable will have no effect. I was obviously confused here, and indeed tests reveal that those writes are needed for any prior updates to take effect (e.g. volume changes while the codec is runtime suspended). I've just sent a v2 here: https://lore.kernel.org/lkml/20240117090331.31111-1-johan+linaro@kernel.org/ Johan
diff --git a/sound/soc/codecs/lpass-wsa-macro.c b/sound/soc/codecs/lpass-wsa-macro.c index 7e21cec3c2fb..7de221464d47 100644 --- a/sound/soc/codecs/lpass-wsa-macro.c +++ b/sound/soc/codecs/lpass-wsa-macro.c @@ -1583,8 +1583,6 @@ static int wsa_macro_enable_interpolator(struct snd_soc_dapm_widget *w, struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm); u16 gain_reg; u16 reg; - int val; - int offset_val = 0; struct wsa_macro *wsa = snd_soc_component_get_drvdata(component); if (w->shift == WSA_MACRO_COMP1) { @@ -1623,11 +1621,7 @@ static int wsa_macro_enable_interpolator(struct snd_soc_dapm_widget *w, CDC_WSA_RX1_RX_PATH_MIX_SEC0, CDC_WSA_RX_PGA_HALF_DB_MASK, CDC_WSA_RX_PGA_HALF_DB_ENABLE); - offset_val = -2; } - val = snd_soc_component_read(component, gain_reg); - val += offset_val; - snd_soc_component_write(component, gain_reg, val); wsa_macro_config_ear_spkr_gain(component, wsa, event, gain_reg); break; @@ -1654,10 +1648,6 @@ static int wsa_macro_enable_interpolator(struct snd_soc_dapm_widget *w, CDC_WSA_RX1_RX_PATH_MIX_SEC0, CDC_WSA_RX_PGA_HALF_DB_MASK, CDC_WSA_RX_PGA_HALF_DB_DISABLE); - offset_val = 2; - val = snd_soc_component_read(component, gain_reg); - val += offset_val; - snd_soc_component_write(component, gain_reg, val); } wsa_macro_config_ear_spkr_gain(component, wsa, event, gain_reg);