Message ID | 20240115-lpg-v5-1-3c56f77f9cec@quicinc.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-25819-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2614:b0:101:6a76:bbe3 with SMTP id mm20csp1600962dyc; Mon, 15 Jan 2024 01:49:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IGq6kpy3BVHqw61s9695xUkgQNoHppjxRMOm/1822ISvPX5KO2r4eil+0SzTdcTOfpCc+v/ X-Received: by 2002:a05:6358:101:b0:175:6496:5e10 with SMTP id f1-20020a056358010100b0017564965e10mr6617021rwa.40.1705312146190; Mon, 15 Jan 2024 01:49:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705312146; cv=none; d=google.com; s=arc-20160816; b=p+x97aHryDOMvDD3q3dn8Hm8VZa0PvnIVj3+/hpOxeT8qzWGwZPXrqU0qqHASlY4I0 JZLj1QEFpF/N+FUQBs86qcrv74B3oV6l8YJO5XlokQSa7v4DCc8emf34GiOhh62ATU+D Brygd3Yk6PMdfj+IeMEfCnlx5iKfFwRjF8cewayHNJCht2jON0Rep9Qi1bDIi3H5ttSj 8RltvwzrFytpDuPQQlsApsm1md+fyF8vUZbC5nSH8a2TLasXYP0nzxM7zkGcIoQjHMXW BQKebDKqwTsEINWnfMt8zup035hDLvB2oWvbCCgKY0aQqBygo2FUMlymkeLKVlBL6Ncl EKVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=reply-to:cc:to:message-id:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:subject:date :from:dkim-signature; bh=YHQd3/DKLr+BdkkA8nj4imzqWp9YKnyqdhON8WdyDw4=; fh=5Nw6CUKfQDR0dyHzzV7EuwdgQ4LSCXOAo1TFv08iboM=; b=nCMIFXgpTGivnrppIzlSFKL25GmNyhXHUXFoCLxEsdnu825RacFN2yF9y474hJb0Aa F6izc1EjvgBCfyO9QR/RmKvtr78KDDpi0axaE10wnYRLRisw9d9HO9Y4Ho7AmZ3KwaXi rWUMIQ/7KKthfDVooqJ3XKV5ZUPAsKdhKckF70ybwo7mprQ3DV4Xu1px3DNXFTy17H02 5p9WjDiqdZnbVTBWQ4VGnDu52k2ChJD7TPEjChAeCMkPHnTZTzvaYrXvBf0vg1q+W+oa Gg3aakG/ZPFfiSOSCti9dlor/dkmeiwIr95nGn2XwNZuD0t8DaPgtV4U8unslEp7cMlk ylBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CY1l8xIA; spf=pass (google.com: domain of linux-kernel+bounces-25819-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-25819-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id d2-20020a633602000000b005cecaf95c61si9026763pga.894.2024.01.15.01.49.06 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jan 2024 01:49:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-25819-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CY1l8xIA; spf=pass (google.com: domain of linux-kernel+bounces-25819-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-25819-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id B4A60281B91 for <ouuuleilei@gmail.com>; Mon, 15 Jan 2024 09:49:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9CCF7F4E9; Mon, 15 Jan 2024 09:48:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CY1l8xIA" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 053D9D2F5; Mon, 15 Jan 2024 09:48:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 85D03C433C7; Mon, 15 Jan 2024 09:48:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705312130; bh=D8eqyGJBMl/zmbPd8uMuLY2qesCRT+s4btQ/GCmYQIw=; h=From:Date:Subject:To:Cc:Reply-To:From; b=CY1l8xIAPtPo9+Fb87monGh/dYTtJV0bz1NnwXnv1dTNX3G3sZ9onMjIsIVPD9i6Z OXZpWO7S7dlklPmF7/3paM/CDcWUaVtTqkAbodn9yVUt6oV+XiaCENuRyfkKD1tihD jVS+TeaGLiuyOWFxn6TFRygg5j0O5pVwhxaMWUKOFMz0DuqEHg3QpzeSdyL+5vmPR8 shz8enDRn+9udYvY4fNRR+ZwkR63vBawu2oBYmMEmdxjbMm8jIqtQCOCeg0hG54gY6 GGFyPXrPXrk5aWSW1FTj5Vn2z0NUbfSiDBJlOv4Z5yQWoBzZlih/RHAvs0bdyYlG2x nQ8fu4aNSA1Ng== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66438C3DA79; Mon, 15 Jan 2024 09:48:50 +0000 (UTC) From: Hui Liu via B4 Relay <devnull+quic_huliu.quicinc.com@kernel.org> Date: Mon, 15 Jan 2024 17:48:37 +0800 Subject: [PATCH v5] arm64: dts: qcom: qcm6490-idp: Add definition for three LEDs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240115-lpg-v5-1-3c56f77f9cec@quicinc.com> X-B4-Tracking: v=1; b=H4sIAHX/pGUC/1WO3wqCMBxGXyV23WK/bS7pqveIiLk/OlCnm41Cf PemEeHlge8cvhlFE5yJ6HKYUTDJRef7DMXxgFQj+9pgpzMjSigDCgVuhxpzKbVmZ14CSJSXQzD WvbbK7Z7ZBt/hqQlG/l0Agkflu0drdMSJYsBMSQ22qpQo5HV8OuV6dcqTNdm4OPnw3n4ltob3F xLLAW6orogS2hZ2F1hPJP6zOAGgX4tnS3FCOKFClKLaW8uyfAB9zWyOEQEAAA== To: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org> Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Hui Liu <quic_huliu@quicinc.com> X-Mailer: b4 0.13-dev-83828 X-Developer-Signature: v=1; a=ed25519-sha256; t=1705312129; l=1982; i=quic_huliu@quicinc.com; s=20230823; h=from:subject:message-id; bh=kbl/RWkKCwiC9v8FHJS+qQTVX4k0SVTLaRWOhdD+XYo=; b=MmaOYHX12oex5H21exM2lmlZ4WrwfDdHYzPHMkIFWMZ1AxXDFqLJij+2eCSpU4ch55er29s/g vqBq9BNnFCHCEAUOtlyLRS4z8evAdZzlIb06UWqF1W7sBA1IAbH+sSv X-Developer-Key: i=quic_huliu@quicinc.com; a=ed25519; pk=1z+A50UnTuKe/FdQv2c0W3ajDsJOYddwIHo2iivhTTA= X-Endpoint-Received: by B4 Relay for quic_huliu@quicinc.com/20230823 with auth_id=80 X-Original-From: Hui Liu <quic_huliu@quicinc.com> Reply-To: <quic_huliu@quicinc.com> X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788149388726130969 X-GMAIL-MSGID: 1788149388726130969 |
Series |
[v5] arm64: dts: qcom: qcm6490-idp: Add definition for three LEDs
|
|
Commit Message
Hui Liu via B4 Relay
Jan. 15, 2024, 9:48 a.m. UTC
From: Hui Liu <quic_huliu@quicinc.com> Add definition for three LEDs to make sure they can be enabled base on QCOM LPG LED driver. Signed-off-by: Hui Liu <quic_huliu@quicinc.com> --- Changes in v5: - Rephrased commit text, replaced qcs6490-idp to qcm6490-idp. - Removed the unnecessary full. - Link to v4: https://lore.kernel.org/r/20240112-lpg-v4-1-c4004026686b@quicinc.com Changes in v4: - Removed "label" definition and added "function" definition. - Link to v3: https://lore.kernel.org/r/20231215-lpg-v3-1-4e2db0c6df5f@quicinc.com Changes in v3: - Rephrased commit text and updated the nodes to qcm6490-idp board file. - Link to v2: https://lore.kernel.org/all/20231110-qcom_leds-v2-1-3cad1fbbc65a@quicinc.com/ Changes in v2: - Rephrased commit text and updated the nodes to board file. - Link to v1: https://lore.kernel.org/r/20231108-qcom_leds-v1-1-c3e1c8572cb0@quicinc.com --- arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) --- base-commit: 17cb8a20bde66a520a2ca7aad1063e1ce7382240 change-id: 20231215-lpg-4aadd374811a Best regards,
Comments
On Mon, 15 Jan 2024 at 11:48, Hui Liu via B4 Relay <devnull+quic_huliu.quicinc.com@kernel.org> wrote: > > From: Hui Liu <quic_huliu@quicinc.com> > > Add definition for three LEDs to make sure they can > be enabled base on QCOM LPG LED driver. The "function" property is still placed incorrectly. Posting the next iteration before concluding the discussion on the previous one is not the best idea. > > Signed-off-by: Hui Liu <quic_huliu@quicinc.com> > --- > Changes in v5: > - Rephrased commit text, replaced qcs6490-idp to qcm6490-idp. > - Removed the unnecessary full. > - Link to v4: https://lore.kernel.org/r/20240112-lpg-v4-1-c4004026686b@quicinc.com > > Changes in v4: > - Removed "label" definition and added "function" definition. > - Link to v3: https://lore.kernel.org/r/20231215-lpg-v3-1-4e2db0c6df5f@quicinc.com > > Changes in v3: > - Rephrased commit text and updated the nodes to qcm6490-idp board file. > - Link to v2: https://lore.kernel.org/all/20231110-qcom_leds-v2-1-3cad1fbbc65a@quicinc.com/ > > Changes in v2: > - Rephrased commit text and updated the nodes to board file. > - Link to v1: https://lore.kernel.org/r/20231108-qcom_leds-v1-1-c3e1c8572cb0@quicinc.com > --- > arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts > index 37c91fdf3ab9..8268fad505e7 100644 > --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts > +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts > @@ -5,6 +5,7 @@ > > /dts-v1/; > > +#include <dt-bindings/leds/common.h> > #include <dt-bindings/regulator/qcom,rpmh-regulator.h> > #include "sc7280.dtsi" > #include "pm7325.dtsi" > @@ -414,6 +415,28 @@ vreg_bob_3p296: bob { > }; > }; > > +&pm8350c_pwm { > + function = LED_FUNCTION_STATUS; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "okay"; > + > + led@1 { > + reg = <1>; > + color = <LED_COLOR_ID_RED>; > + }; > + > + led@2 { > + reg = <2>; > + color = <LED_COLOR_ID_GREEN>; > + }; > + > + led@3 { > + reg = <3>; > + color = <LED_COLOR_ID_BLUE>; > + }; > +}; > + > &qupv3_id_0 { > status = "okay"; > }; > > --- > base-commit: 17cb8a20bde66a520a2ca7aad1063e1ce7382240 > change-id: 20231215-lpg-4aadd374811a > > Best regards, > -- > Hui Liu <quic_huliu@quicinc.com> > >
On 1/15/2024 5:56 PM, Dmitry Baryshkov wrote: > On Mon, 15 Jan 2024 at 11:48, Hui Liu via B4 Relay > <devnull+quic_huliu.quicinc.com@kernel.org> wrote: >> >> From: Hui Liu <quic_huliu@quicinc.com> >> >> Add definition for three LEDs to make sure they can >> be enabled base on QCOM LPG LED driver. > > The "function" property is still placed incorrectly. Posting the next > iteration before concluding the discussion on the previous one is not > the best idea. Do you mean I should update it as below? Seems there is no consumer to use the function config, do we need to add now? pm8350c_pwm { + function = LED_FUNCTION_STATUS; + #address-cells = <1>; + #size-cells = <0>; + status = "okay"; + + led@1 { + reg = <1>; + color = <LED_COLOR_ID_RED>; + function = LED_FUNCTION_STATUS; + }; + ... > >> >> Signed-off-by: Hui Liu <quic_huliu@quicinc.com> >> --- >> Changes in v5: >> - Rephrased commit text, replaced qcs6490-idp to qcm6490-idp. >> - Removed the unnecessary full. >> - Link to v4: https://lore.kernel.org/r/20240112-lpg-v4-1-c4004026686b@quicinc.com >> >> Changes in v4: >> - Removed "label" definition and added "function" definition. >> - Link to v3: https://lore.kernel.org/r/20231215-lpg-v3-1-4e2db0c6df5f@quicinc.com >> >> Changes in v3: >> - Rephrased commit text and updated the nodes to qcm6490-idp board file. >> - Link to v2: https://lore.kernel.org/all/20231110-qcom_leds-v2-1-3cad1fbbc65a@quicinc.com/ >> >> Changes in v2: >> - Rephrased commit text and updated the nodes to board file. >> - Link to v1: https://lore.kernel.org/r/20231108-qcom_leds-v1-1-c3e1c8572cb0@quicinc.com >> --- >> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 23 +++++++++++++++++++++++ >> 1 file changed, 23 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >> index 37c91fdf3ab9..8268fad505e7 100644 >> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >> @@ -5,6 +5,7 @@ >> >> /dts-v1/; >> >> +#include <dt-bindings/leds/common.h> >> #include <dt-bindings/regulator/qcom,rpmh-regulator.h> >> #include "sc7280.dtsi" >> #include "pm7325.dtsi" >> @@ -414,6 +415,28 @@ vreg_bob_3p296: bob { >> }; >> }; >> >> +&pm8350c_pwm { >> + function = LED_FUNCTION_STATUS; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + status = "okay"; >> + >> + led@1 { >> + reg = <1>; >> + color = <LED_COLOR_ID_RED>; >> + }; >> + >> + led@2 { >> + reg = <2>; >> + color = <LED_COLOR_ID_GREEN>; >> + }; >> + >> + led@3 { >> + reg = <3>; >> + color = <LED_COLOR_ID_BLUE>; >> + }; >> +}; >> + >> &qupv3_id_0 { >> status = "okay"; >> }; >> >> --- >> base-commit: 17cb8a20bde66a520a2ca7aad1063e1ce7382240 >> change-id: 20231215-lpg-4aadd374811a >> >> Best regards, >> -- >> Hui Liu <quic_huliu@quicinc.com> >> >> > >
On 15/01/2024 11:18, hui liu wrote: > > > On 1/15/2024 5:56 PM, Dmitry Baryshkov wrote: >> On Mon, 15 Jan 2024 at 11:48, Hui Liu via B4 Relay >> <devnull+quic_huliu.quicinc.com@kernel.org> wrote: >>> >>> From: Hui Liu <quic_huliu@quicinc.com> >>> >>> Add definition for three LEDs to make sure they can >>> be enabled base on QCOM LPG LED driver. >> >> The "function" property is still placed incorrectly. Posting the next >> iteration before concluding the discussion on the previous one is not >> the best idea. > Do you mean I should update it as below? Seems there is no consumer to > use the function config, do we need to add now? Paste the output of dtbs_check for your board (or CHECK_DTBS=y for your Makefile target). Best regards, Krzysztof
On 1/15/2024 6:26 PM, Krzysztof Kozlowski wrote: > On 15/01/2024 11:18, hui liu wrote: >> >> >> On 1/15/2024 5:56 PM, Dmitry Baryshkov wrote: >>> On Mon, 15 Jan 2024 at 11:48, Hui Liu via B4 Relay >>> <devnull+quic_huliu.quicinc.com@kernel.org> wrote: >>>> >>>> From: Hui Liu <quic_huliu@quicinc.com> >>>> >>>> Add definition for three LEDs to make sure they can >>>> be enabled base on QCOM LPG LED driver. >>> >>> The "function" property is still placed incorrectly. Posting the next >>> iteration before concluding the discussion on the previous one is not >>> the best idea. >> Do you mean I should update it as below? Seems there is no consumer to >> use the function config, do we need to add now? > > Paste the output of dtbs_check for your board (or CHECK_DTBS=y for your > Makefile target). I checked the dt-binding file of LPG LED, I will update the dts as below, if you think it's correct, I will push v6. +&pm8350c_pwm { + #address-cells = <1>; + #size-cells = <0>; + status = "okay"; + + led@1 { + reg = <1>; + color = <LED_COLOR_ID_RED>; + function = LED_FUNCTION_STATUS; + }; + + led@2 { + reg = <2>; + color = <LED_COLOR_ID_GREEN>; + function = LED_FUNCTION_STATUS; + }; + + led@3 { + reg = <3>; + color = <LED_COLOR_ID_BLUE>; + function = LED_FUNCTION_STATUS; + }; +}; + Thanks, Hui > > Best regards, > Krzysztof >
On Wed, 17 Jan 2024 at 05:02, hui liu <quic_huliu@quicinc.com> wrote: > > > > On 1/15/2024 6:26 PM, Krzysztof Kozlowski wrote: > > On 15/01/2024 11:18, hui liu wrote: > >> > >> > >> On 1/15/2024 5:56 PM, Dmitry Baryshkov wrote: > >>> On Mon, 15 Jan 2024 at 11:48, Hui Liu via B4 Relay > >>> <devnull+quic_huliu.quicinc.com@kernel.org> wrote: > >>>> > >>>> From: Hui Liu <quic_huliu@quicinc.com> > >>>> > >>>> Add definition for three LEDs to make sure they can > >>>> be enabled base on QCOM LPG LED driver. > >>> > >>> The "function" property is still placed incorrectly. Posting the next > >>> iteration before concluding the discussion on the previous one is not > >>> the best idea. > >> Do you mean I should update it as below? Seems there is no consumer to > >> use the function config, do we need to add now? > > > > Paste the output of dtbs_check for your board (or CHECK_DTBS=y for your > > Makefile target). > I checked the dt-binding file of LPG LED, I will update the dts as > below, if you think it's correct, I will push v6. Is there any reason why you are defining three different LEDs instead of multi-led with three components? > > +&pm8350c_pwm { > + #address-cells = <1>; > + #size-cells = <0>; > + status = "okay"; > + > + led@1 { > + reg = <1>; > + color = <LED_COLOR_ID_RED>; > + function = LED_FUNCTION_STATUS; > + }; > + > + led@2 { > + reg = <2>; > + color = <LED_COLOR_ID_GREEN>; > + function = LED_FUNCTION_STATUS; > + }; > + > + led@3 { > + reg = <3>; > + color = <LED_COLOR_ID_BLUE>; > + function = LED_FUNCTION_STATUS; > + }; > +};
On 1/17/2024 11:41 AM, Dmitry Baryshkov wrote: > On Wed, 17 Jan 2024 at 05:02, hui liu <quic_huliu@quicinc.com> wrote: >> >> >> >> On 1/15/2024 6:26 PM, Krzysztof Kozlowski wrote: >>> On 15/01/2024 11:18, hui liu wrote: >>>> >>>> >>>> On 1/15/2024 5:56 PM, Dmitry Baryshkov wrote: >>>>> On Mon, 15 Jan 2024 at 11:48, Hui Liu via B4 Relay >>>>> <devnull+quic_huliu.quicinc.com@kernel.org> wrote: >>>>>> >>>>>> From: Hui Liu <quic_huliu@quicinc.com> >>>>>> >>>>>> Add definition for three LEDs to make sure they can >>>>>> be enabled base on QCOM LPG LED driver. >>>>> >>>>> The "function" property is still placed incorrectly. Posting the next >>>>> iteration before concluding the discussion on the previous one is not >>>>> the best idea. >>>> Do you mean I should update it as below? Seems there is no consumer to >>>> use the function config, do we need to add now? >>> >>> Paste the output of dtbs_check for your board (or CHECK_DTBS=y for your >>> Makefile target). >> I checked the dt-binding file of LPG LED, I will update the dts as >> below, if you think it's correct, I will push v6. > > Is there any reason why you are defining three different LEDs instead > of multi-led with three components? In the HW design, they are three seprete LEDs, there are three LEDs on device. why do we need to add for multi-led? Thanks, Hui > >> >> +&pm8350c_pwm { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + status = "okay"; >> + >> + led@1 { >> + reg = <1>; >> + color = <LED_COLOR_ID_RED>; >> + function = LED_FUNCTION_STATUS; >> + }; >> + >> + led@2 { >> + reg = <2>; >> + color = <LED_COLOR_ID_GREEN>; >> + function = LED_FUNCTION_STATUS; >> + }; >> + >> + led@3 { >> + reg = <3>; >> + color = <LED_COLOR_ID_BLUE>; >> + function = LED_FUNCTION_STATUS; >> + }; >> +}; > > >
On 1/18/2024 10:06 AM, hui liu wrote: > > > On 1/17/2024 11:41 AM, Dmitry Baryshkov wrote: >> On Wed, 17 Jan 2024 at 05:02, hui liu <quic_huliu@quicinc.com> wrote: >>> >>> >>> >>> On 1/15/2024 6:26 PM, Krzysztof Kozlowski wrote: >>>> On 15/01/2024 11:18, hui liu wrote: >>>>> >>>>> >>>>> On 1/15/2024 5:56 PM, Dmitry Baryshkov wrote: >>>>>> On Mon, 15 Jan 2024 at 11:48, Hui Liu via B4 Relay >>>>>> <devnull+quic_huliu.quicinc.com@kernel.org> wrote: >>>>>>> >>>>>>> From: Hui Liu <quic_huliu@quicinc.com> >>>>>>> >>>>>>> Add definition for three LEDs to make sure they can >>>>>>> be enabled base on QCOM LPG LED driver. >>>>>> >>>>>> The "function" property is still placed incorrectly. Posting the next >>>>>> iteration before concluding the discussion on the previous one is not >>>>>> the best idea. >>>>> Do you mean I should update it as below? Seems there is no consumer to >>>>> use the function config, do we need to add now? >>>> >>>> Paste the output of dtbs_check for your board (or CHECK_DTBS=y for your >>>> Makefile target). >>> I checked the dt-binding file of LPG LED, I will update the dts as >>> below, if you think it's correct, I will push v6. >> >> Is there any reason why you are defining three different LEDs instead >> of multi-led with three components? > Hi Dmitry, If there is no other issue, can I push the V6? Thanks, Hui > In the HW design, they are three seprete LEDs, there are three LEDs on > device. why do we need to add for multi-led? > > Thanks, > Hui >> >>> >>> +&pm8350c_pwm { >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + status = "okay"; >>> + >>> + led@1 { >>> + reg = <1>; >>> + color = <LED_COLOR_ID_RED>; >>> + function = LED_FUNCTION_STATUS; >>> + }; >>> + >>> + led@2 { >>> + reg = <2>; >>> + color = <LED_COLOR_ID_GREEN>; >>> + function = LED_FUNCTION_STATUS; >>> + }; >>> + >>> + led@3 { >>> + reg = <3>; >>> + color = <LED_COLOR_ID_BLUE>; >>> + function = LED_FUNCTION_STATUS; >>> + }; >>> +}; >> >> >>
On 1/22/2024 1:42 PM, hui liu wrote: > > > On 1/18/2024 10:06 AM, hui liu wrote: >> >> >> On 1/17/2024 11:41 AM, Dmitry Baryshkov wrote: >>> On Wed, 17 Jan 2024 at 05:02, hui liu <quic_huliu@quicinc.com> wrote: >>>> >>>> >>>> >>>> On 1/15/2024 6:26 PM, Krzysztof Kozlowski wrote: >>>>> On 15/01/2024 11:18, hui liu wrote: >>>>>> >>>>>> >>>>>> On 1/15/2024 5:56 PM, Dmitry Baryshkov wrote: >>>>>>> On Mon, 15 Jan 2024 at 11:48, Hui Liu via B4 Relay >>>>>>> <devnull+quic_huliu.quicinc.com@kernel.org> wrote: >>>>>>>> >>>>>>>> From: Hui Liu <quic_huliu@quicinc.com> >>>>>>>> >>>>>>>> Add definition for three LEDs to make sure they can >>>>>>>> be enabled base on QCOM LPG LED driver. >>>>>>> >>>>>>> The "function" property is still placed incorrectly. Posting the >>>>>>> next >>>>>>> iteration before concluding the discussion on the previous one is >>>>>>> not >>>>>>> the best idea. >>>>>> Do you mean I should update it as below? Seems there is no >>>>>> consumer to >>>>>> use the function config, do we need to add now? >>>>> >>>>> Paste the output of dtbs_check for your board (or CHECK_DTBS=y for >>>>> your >>>>> Makefile target). >>>> I checked the dt-binding file of LPG LED, I will update the dts as >>>> below, if you think it's correct, I will push v6. >>> >>> Is there any reason why you are defining three different LEDs instead >>> of multi-led with three components? > >> In the HW design, they are three seprete LEDs, there are three LEDs on >> device. why do we need to add for multi-led? >> >> Thanks, >> Hui I double confirmed the HW design, for IDP devcie, we should set it to multi led, for another similar device(RB3-GEN2, I will push LED change for this device later), it should be set to seperate LED. They are different, so I will push V6 to set it for multi-led for QCM6490-IDP device. Thanks for your review. >>> >>>> >>>> +&pm8350c_pwm { >>>> + #address-cells = <1>; >>>> + #size-cells = <0>; >>>> + status = "okay"; >>>> + >>>> + led@1 { >>>> + reg = <1>; >>>> + color = <LED_COLOR_ID_RED>; >>>> + function = LED_FUNCTION_STATUS; >>>> + }; >>>> + >>>> + led@2 { >>>> + reg = <2>; >>>> + color = <LED_COLOR_ID_GREEN>; >>>> + function = LED_FUNCTION_STATUS; >>>> + }; >>>> + >>>> + led@3 { >>>> + reg = <3>; >>>> + color = <LED_COLOR_ID_BLUE>; >>>> + function = LED_FUNCTION_STATUS; >>>> + }; >>>> +}; >>> >>> >>>
On Mon, 22 Jan 2024 at 08:26, hui liu <quic_huliu@quicinc.com> wrote: > > > > On 1/22/2024 1:42 PM, hui liu wrote: > > > > > > On 1/18/2024 10:06 AM, hui liu wrote: > >> > >> > >> On 1/17/2024 11:41 AM, Dmitry Baryshkov wrote: > >>> On Wed, 17 Jan 2024 at 05:02, hui liu <quic_huliu@quicinc.com> wrote: > >>>> > >>>> > >>>> > >>>> On 1/15/2024 6:26 PM, Krzysztof Kozlowski wrote: > >>>>> On 15/01/2024 11:18, hui liu wrote: > >>>>>> > >>>>>> > >>>>>> On 1/15/2024 5:56 PM, Dmitry Baryshkov wrote: > >>>>>>> On Mon, 15 Jan 2024 at 11:48, Hui Liu via B4 Relay > >>>>>>> <devnull+quic_huliu.quicinc.com@kernel.org> wrote: > >>>>>>>> > >>>>>>>> From: Hui Liu <quic_huliu@quicinc.com> > >>>>>>>> > >>>>>>>> Add definition for three LEDs to make sure they can > >>>>>>>> be enabled base on QCOM LPG LED driver. > >>>>>>> > >>>>>>> The "function" property is still placed incorrectly. Posting the > >>>>>>> next > >>>>>>> iteration before concluding the discussion on the previous one is > >>>>>>> not > >>>>>>> the best idea. > >>>>>> Do you mean I should update it as below? Seems there is no > >>>>>> consumer to > >>>>>> use the function config, do we need to add now? > >>>>> > >>>>> Paste the output of dtbs_check for your board (or CHECK_DTBS=y for > >>>>> your > >>>>> Makefile target). > >>>> I checked the dt-binding file of LPG LED, I will update the dts as > >>>> below, if you think it's correct, I will push v6. > >>> > >>> Is there any reason why you are defining three different LEDs instead > >>> of multi-led with three components? > > > >> In the HW design, they are three seprete LEDs, there are three LEDs on > >> device. why do we need to add for multi-led? > >> > >> Thanks, > >> Hui > > I double confirmed the HW design, for IDP devcie, we should set it to > multi led, for another similar device(RB3-GEN2, I will push LED change > for this device later), it should be set to seperate LED. > They are different, so I will push V6 to set it for multi-led for > QCM6490-IDP device. Thanks for your review. Ack, thank you. > > >>> > >>>> > >>>> +&pm8350c_pwm { > >>>> + #address-cells = <1>; > >>>> + #size-cells = <0>; > >>>> + status = "okay"; > >>>> + > >>>> + led@1 { > >>>> + reg = <1>; > >>>> + color = <LED_COLOR_ID_RED>; > >>>> + function = LED_FUNCTION_STATUS; > >>>> + }; > >>>> + > >>>> + led@2 { > >>>> + reg = <2>; > >>>> + color = <LED_COLOR_ID_GREEN>; > >>>> + function = LED_FUNCTION_STATUS; > >>>> + }; > >>>> + > >>>> + led@3 { > >>>> + reg = <3>; > >>>> + color = <LED_COLOR_ID_BLUE>; > >>>> + function = LED_FUNCTION_STATUS; > >>>> + }; > >>>> +}; > >>> > >>> > >>>
On 1/22/2024 9:37 PM, Dmitry Baryshkov wrote: > On Mon, 22 Jan 2024 at 08:26, hui liu <quic_huliu@quicinc.com> wrote: >> >> >> >> On 1/22/2024 1:42 PM, hui liu wrote: >>> >>> >>> On 1/18/2024 10:06 AM, hui liu wrote: >>>> >>>> >>>> On 1/17/2024 11:41 AM, Dmitry Baryshkov wrote: >>>>> On Wed, 17 Jan 2024 at 05:02, hui liu <quic_huliu@quicinc.com> wrote: >>>>>> >>>>>> >>>>>> >>>>>> On 1/15/2024 6:26 PM, Krzysztof Kozlowski wrote: >>>>>>> On 15/01/2024 11:18, hui liu wrote: >>>>>>>> >>>>>>>> >>>>>>>> On 1/15/2024 5:56 PM, Dmitry Baryshkov wrote: >>>>>>>>> On Mon, 15 Jan 2024 at 11:48, Hui Liu via B4 Relay >>>>>>>>> <devnull+quic_huliu.quicinc.com@kernel.org> wrote: >>>>>>>>>> >>>>>>>>>> From: Hui Liu <quic_huliu@quicinc.com> >>>>>>>>>> >>>>>>>>>> Add definition for three LEDs to make sure they can >>>>>>>>>> be enabled base on QCOM LPG LED driver. >>>>>>>>> >>>>>>>>> The "function" property is still placed incorrectly. Posting the >>>>>>>>> next >>>>>>>>> iteration before concluding the discussion on the previous one is >>>>>>>>> not >>>>>>>>> the best idea. >>>>>>>> Do you mean I should update it as below? Seems there is no >>>>>>>> consumer to >>>>>>>> use the function config, do we need to add now? >>>>>>> >>>>>>> Paste the output of dtbs_check for your board (or CHECK_DTBS=y for >>>>>>> your >>>>>>> Makefile target). >>>>>> I checked the dt-binding file of LPG LED, I will update the dts as >>>>>> below, if you think it's correct, I will push v6. >>>>> >>>>> Is there any reason why you are defining three different LEDs instead >>>>> of multi-led with three components? >>> >>>> In the HW design, they are three seprete LEDs, there are three LEDs on >>>> device. why do we need to add for multi-led? >>>> >>>> Thanks, >>>> Hui >> >> I double confirmed the HW design, for IDP devcie, we should set it to >> multi led, for another similar device(RB3-GEN2, I will push LED change >> for this device later), it should be set to seperate LED. >> They are different, so I will push V6 to set it for multi-led for >> QCM6490-IDP device. Thanks for your review. > > Ack, thank you. Hi Dmitry, Could you give the approval for V6? https://lore.kernel.org/all/20240126-lpg-v6-1-f879cecbce69@quicinc.com/ Thanks, Hui > >> >>>>> >>>>>> >>>>>> +&pm8350c_pwm { >>>>>> + #address-cells = <1>; >>>>>> + #size-cells = <0>; >>>>>> + status = "okay"; >>>>>> + >>>>>> + led@1 { >>>>>> + reg = <1>; >>>>>> + color = <LED_COLOR_ID_RED>; >>>>>> + function = LED_FUNCTION_STATUS; >>>>>> + }; >>>>>> + >>>>>> + led@2 { >>>>>> + reg = <2>; >>>>>> + color = <LED_COLOR_ID_GREEN>; >>>>>> + function = LED_FUNCTION_STATUS; >>>>>> + }; >>>>>> + >>>>>> + led@3 { >>>>>> + reg = <3>; >>>>>> + color = <LED_COLOR_ID_BLUE>; >>>>>> + function = LED_FUNCTION_STATUS; >>>>>> + }; >>>>>> +}; >>>>> >>>>> >>>>> > > >
diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts index 37c91fdf3ab9..8268fad505e7 100644 --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts @@ -5,6 +5,7 @@ /dts-v1/; +#include <dt-bindings/leds/common.h> #include <dt-bindings/regulator/qcom,rpmh-regulator.h> #include "sc7280.dtsi" #include "pm7325.dtsi" @@ -414,6 +415,28 @@ vreg_bob_3p296: bob { }; }; +&pm8350c_pwm { + function = LED_FUNCTION_STATUS; + #address-cells = <1>; + #size-cells = <0>; + status = "okay"; + + led@1 { + reg = <1>; + color = <LED_COLOR_ID_RED>; + }; + + led@2 { + reg = <2>; + color = <LED_COLOR_ID_GREEN>; + }; + + led@3 { + reg = <3>; + color = <LED_COLOR_ID_BLUE>; + }; +}; + &qupv3_id_0 { status = "okay"; };