Message ID | 20240112-lpg-v4-1-c4004026686b@quicinc.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-24260-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2411:b0:101:2151:f287 with SMTP id m17csp1873777dyi; Thu, 11 Jan 2024 19:07:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IHxnbQERVbypVyCqafDBPUsmWBaGn7FY2Z/59Uxkbv7Lr8Y7/jsmjT1mo8B81DJJPLBwI4o X-Received: by 2002:a05:6a00:1743:b0:6d9:9f8d:ad2f with SMTP id j3-20020a056a00174300b006d99f8dad2fmr257639pfc.41.1705028879309; Thu, 11 Jan 2024 19:07:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705028879; cv=none; d=google.com; s=arc-20160816; b=VrTAn2ne7Ll18JKIDvLwLzz/PlSvRJ5zxbcWUOZH9dRsWF5znYvSu/I5skztkpOfiy WQNwhSkBHWTj4vZ2Vk3DbPIT2CvsC9Z0LeyEWE3j9w6ngdW565zM6r0koS+dv2mxXulN 7VouBBm/MqZXjf7aTonSsRMEAMzcdeLo4D6NkD7i9F2IZF1XUyCHWJEzloFUGTL8X7JJ vRLCOPVzK1KTQSlBbIvPAW6o7BJuoiZjyPDBmPMTyhHbeQF8dyb1oCFIplxldpGGMUIm kuHSgdI/RxYP6iFKxBzdIfYH9KH5VA//sIL5iGu5nWHNApXj7Ou5rlMUHd6eGLxwVNGF 0iVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=reply-to:cc:to:message-id:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:subject:date :from:dkim-signature; bh=SzGoEMB9VtpOlfrFCHCkVw2vO/AjyuvLb271H1sgKAg=; fh=5Nw6CUKfQDR0dyHzzV7EuwdgQ4LSCXOAo1TFv08iboM=; b=d43VLJ1ZuDJu8lHnHmM8TItNQzRWdino4EPiSKuJ2H2hf8r3v3hLzP+7/eiC32hSMU 3yRNmwDq+mc2xzpp3Yaelo4F6NfbmUjCt04cSTHYD7ODrofCNxtaTpOhNUgbZZtDxeno cTaB5L440lG8PETmp1+RZaLgIYXiCwZ11O5BHCeh6MC3T4SIpsdPkMH+SXh//NzhIyDp uPpY5C69v+xq4rg6a/+vmBGVrs9lmjkPvyrLb6dGSybc7Y3LaXsLBqSGdYohzmhknLoq 5LxOBbqM7SxoBeCA5XjWGBBevKBB5YHvH15QMbXyR0bb2HOa+JwsGsEkxXoMW9zRw1wO HE1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZnagKHVt; spf=pass (google.com: domain of linux-kernel+bounces-24260-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-24260-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id t10-20020a63534a000000b005cdf9bab888si2285635pgl.231.2024.01.11.19.07.59 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 19:07:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-24260-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZnagKHVt; spf=pass (google.com: domain of linux-kernel+bounces-24260-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-24260-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id F3DC3286ED8 for <ouuuleilei@gmail.com>; Fri, 12 Jan 2024 03:07:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 217EB539E; Fri, 12 Jan 2024 03:07:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZnagKHVt" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 742B3805; Fri, 12 Jan 2024 03:07:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id E5079C433F1; Fri, 12 Jan 2024 03:07:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705028862; bh=n9MqZcEV8yupS47tT5sl4+gL1xBsGKmEaUgifpv190o=; h=From:Date:Subject:To:Cc:Reply-To:From; b=ZnagKHVtg84b06PpjbwyBcpBZhFR56iO57gOoEpz/I92g1h0yRCyDTzlM225G+h/R SndNGy4vQlKn0eAqz5gWkIJcnTnZULAymE0WL023xG9goJo4Pe2UgQYCIjGb4ZWlfW SsljE2UjR2A3BNqFxuLLii234s7G+seTz+wPoPbvkNWMkyn28Pm2NVVcoA/KHjs0oB III4ceIfC/UW89jGot0vVvSR7oZJbVhO9pzL/607BwOPXLawC8B/Z6J/XTW7iNcVes JGU5dLN1ksMo9tes9c/6OCKumRLCOiuVACW5kLQwO4az3M/grKNRKodjSprncA8FLU YV7WhoVpfkz9g== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8B63C4707C; Fri, 12 Jan 2024 03:07:41 +0000 (UTC) From: Hui Liu via B4 Relay <devnull+quic_huliu.quicinc.com@kernel.org> Date: Fri, 12 Jan 2024 11:05:23 +0800 Subject: [PATCH v4] arm64: dts: qcom: qcs6490-idp: Add definition for three LEDs. Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240112-lpg-v4-1-c4004026686b@quicinc.com> X-B4-Tracking: v=1; b=H4sIAHOsoGUC/1WOwQqDMBAFf0Vy7hY3UVt66n8UKTHZaECNJja0i P/e6KX0ODBveCsL5C0FdstW5inaYN2YoDhlTHVybAmsTsx4zgVyLKGfWiik1FpciiuiZMmcPBn 7PiqPOrHxboCl8yR/W8QcZuWGZ086QOSAIJTUaJpGVaW8zy+r7KjOSdmTnQ2L85/jVxR7+P9CF ClQENdNriptSvMXqLdt+wIYOIwp2wAAAA== To: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org> Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Hui Liu <quic_huliu@quicinc.com> X-Mailer: b4 0.13-dev-83828 X-Developer-Signature: v=1; a=ed25519-sha256; t=1705028860; l=1784; i=quic_huliu@quicinc.com; s=20230823; h=from:subject:message-id; bh=3J2JAmE3HrG4pHWMcjf5Ib9yX4UdsBMnHOiWMa/2sVY=; b=4oaVWMLN1he3cUfY5Yh3QWaWm4vA/7unhwaDc9/wahU6XZdUUep1PyqUWSuYjECf9jRZS3vXc Pxi6qLX+FD7BUa1/QrNmtBqQtRV+oD7j8TqIsC9Ut5cLC16wAu5PnML X-Developer-Key: i=quic_huliu@quicinc.com; a=ed25519; pk=1z+A50UnTuKe/FdQv2c0W3ajDsJOYddwIHo2iivhTTA= X-Endpoint-Received: by B4 Relay for quic_huliu@quicinc.com/20230823 with auth_id=80 X-Original-From: Hui Liu <quic_huliu@quicinc.com> Reply-To: <quic_huliu@quicinc.com> X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787852361754251750 X-GMAIL-MSGID: 1787852361754251750 |
Series |
[v4] arm64: dts: qcom: qcs6490-idp: Add definition for three LEDs.
|
|
Commit Message
Hui Liu via B4 Relay
Jan. 12, 2024, 3:05 a.m. UTC
From: Hui Liu <quic_huliu@quicinc.com> Add definition for three LEDs to make sure they can be enabled base on QCOM LPG LED driver. Signed-off-by: Hui Liu <quic_huliu@quicinc.com> --- Changes in v4: - Removed "label" definition and added "function" definition. - Link to v3: https://lore.kernel.org/r/20231215-lpg-v3-1-4e2db0c6df5f@quicinc.com Changes in v3: - Rephrased commit text and updated the nodes to qcm6490-idp board file. - Link to v2: https://lore.kernel.org/all/20231110-qcom_leds-v2-1-3cad1fbbc65a@quicinc.com/ Changes in v2: - Rephrased commit text and updated the nodes to board file. - Link to v1: https://lore.kernel.org/r/20231108-qcom_leds-v1-1-c3e1c8572cb0@quicinc.com --- arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) --- base-commit: 17cb8a20bde66a520a2ca7aad1063e1ce7382240 change-id: 20231215-lpg-4aadd374811a Best regards,
Comments
On Fri, 12 Jan 2024 at 05:07, Hui Liu via B4 Relay <devnull+quic_huliu.quicinc.com@kernel.org> wrote: > > From: Hui Liu <quic_huliu@quicinc.com> > > Add definition for three LEDs to make sure they can > be enabled base on QCOM LPG LED driver. > > Signed-off-by: Hui Liu <quic_huliu@quicinc.com> > --- > Changes in v4: > - Removed "label" definition and added "function" definition. You have removed "label", but you didn't add "function". BTW: the commit subject is still wrong. Compare "qmp6490-idp" vs "qcs6490-idp" > - Link to v3: https://lore.kernel.org/r/20231215-lpg-v3-1-4e2db0c6df5f@quicinc.com > > Changes in v3: > - Rephrased commit text and updated the nodes to qcm6490-idp board file. > - Link to v2: https://lore.kernel.org/all/20231110-qcom_leds-v2-1-3cad1fbbc65a@quicinc.com/ > > Changes in v2: > - Rephrased commit text and updated the nodes to board file. > - Link to v1: https://lore.kernel.org/r/20231108-qcom_leds-v1-1-c3e1c8572cb0@quicinc.com > --- > arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts > index 37c91fdf3ab9..8268fad505e7 100644 > --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts > +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts > @@ -5,6 +5,7 @@ > > /dts-v1/; > > +#include <dt-bindings/leds/common.h> > #include <dt-bindings/regulator/qcom,rpmh-regulator.h> > #include "sc7280.dtsi" > #include "pm7325.dtsi" > @@ -414,6 +415,28 @@ vreg_bob_3p296: bob { > }; > }; > > +&pm8350c_pwm { > + function = LED_FUNCTION_STATUS; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "okay"; > + > + led@1 { > + reg = <1>; > + color = <LED_COLOR_ID_RED>; > + }; > + > + led@2 { > + reg = <2>; > + color = <LED_COLOR_ID_GREEN>; > + }; > + > + led@3 { > + reg = <3>; > + color = <LED_COLOR_ID_BLUE>; > + }; > +}; > + > &qupv3_id_0 { > status = "okay"; > }; > > --- > base-commit: 17cb8a20bde66a520a2ca7aad1063e1ce7382240 > change-id: 20231215-lpg-4aadd374811a > > Best regards, > -- > Hui Liu <quic_huliu@quicinc.com> > >
On 12/01/2024 04:05, Hui Liu via B4 Relay wrote: > From: Hui Liu <quic_huliu@quicinc.com> > > Add definition for three LEDs to make sure they can > be enabled base on QCOM LPG LED driver. > > Signed-off-by: Hui Liu <quic_huliu@quicinc.com> > --- > Changes in v4: > - Removed "label" definition and added "function" definition. You did not test your patch before sending. Subject is still wrong. Also, it still has unnecessary full stop. Drop it. Best regards, Krzysztof
On 1/12/2024 11:36 AM, Dmitry Baryshkov wrote: > On Fri, 12 Jan 2024 at 05:07, Hui Liu via B4 Relay > <devnull+quic_huliu.quicinc.com@kernel.org> wrote: >> >> From: Hui Liu <quic_huliu@quicinc.com> >> >> Add definition for three LEDs to make sure they can >> be enabled base on QCOM LPG LED driver. >> >> Signed-off-by: Hui Liu <quic_huliu@quicinc.com> >> --- >> Changes in v4: >> - Removed "label" definition and added "function" definition. > > You have removed "label", but you didn't add "function". I added function node "function = LED_FUNCTION_STATUS;" Don't you mean this function node? I didn't get your mean. > > BTW: the commit subject is still wrong. Compare "qmp6490-idp" vs "qcs6490-idp" OK, I will update it to qcm6490-idp. > >> - Link to v3: https://lore.kernel.org/r/20231215-lpg-v3-1-4e2db0c6df5f@quicinc.com >> >> Changes in v3: >> - Rephrased commit text and updated the nodes to qcm6490-idp board file. >> - Link to v2: https://lore.kernel.org/all/20231110-qcom_leds-v2-1-3cad1fbbc65a@quicinc.com/ >> >> Changes in v2: >> - Rephrased commit text and updated the nodes to board file. >> - Link to v1: https://lore.kernel.org/r/20231108-qcom_leds-v1-1-c3e1c8572cb0@quicinc.com >> --- >> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 23 +++++++++++++++++++++++ >> 1 file changed, 23 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >> index 37c91fdf3ab9..8268fad505e7 100644 >> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >> @@ -5,6 +5,7 @@ >> >> /dts-v1/; >> >> +#include <dt-bindings/leds/common.h> >> #include <dt-bindings/regulator/qcom,rpmh-regulator.h> >> #include "sc7280.dtsi" >> #include "pm7325.dtsi" >> @@ -414,6 +415,28 @@ vreg_bob_3p296: bob { >> }; >> }; >> >> +&pm8350c_pwm { >> + function = LED_FUNCTION_STATUS; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + status = "okay"; >> + >> + led@1 { >> + reg = <1>; >> + color = <LED_COLOR_ID_RED>; >> + }; >> + >> + led@2 { >> + reg = <2>; >> + color = <LED_COLOR_ID_GREEN>; >> + }; >> + >> + led@3 { >> + reg = <3>; >> + color = <LED_COLOR_ID_BLUE>; >> + }; >> +}; >> + >> &qupv3_id_0 { >> status = "okay"; >> }; >> >> --- >> base-commit: 17cb8a20bde66a520a2ca7aad1063e1ce7382240 >> change-id: 20231215-lpg-4aadd374811a >> >> Best regards, >> -- >> Hui Liu <quic_huliu@quicinc.com> >> >> > >
On 1/12/2024 3:44 PM, Krzysztof Kozlowski wrote: > On 12/01/2024 04:05, Hui Liu via B4 Relay wrote: >> From: Hui Liu <quic_huliu@quicinc.com> >> >> Add definition for three LEDs to make sure they can >> be enabled base on QCOM LPG LED driver. >> >> Signed-off-by: Hui Liu <quic_huliu@quicinc.com> >> --- >> Changes in v4: >> - Removed "label" definition and added "function" definition. > > You did not test your patch before sending. > > Subject is still wrong. Also, it still has unnecessary full stop. Drop it. I will update it to qcm6490-idp, I understood wrong previously. > > Best regards, > Krzysztof >
On Mon, 15 Jan 2024 at 07:53, hui liu <quic_huliu@quicinc.com> wrote: > On 1/12/2024 11:36 AM, Dmitry Baryshkov wrote: > > On Fri, 12 Jan 2024 at 05:07, Hui Liu via B4 Relay > > <devnull+quic_huliu.quicinc.com@kernel.org> wrote: > >> > >> From: Hui Liu <quic_huliu@quicinc.com> > >> > >> Add definition for three LEDs to make sure they can > >> be enabled base on QCOM LPG LED driver. > >> > >> Signed-off-by: Hui Liu <quic_huliu@quicinc.com> > >> --- > >> Changes in v4: > >> - Removed "label" definition and added "function" definition. > > > > You have removed "label", but you didn't add "function". > I added function node "function = LED_FUNCTION_STATUS;" > Don't you mean this function node? I didn't get your mean. The "function" is a property of the LED (each of them) rather than being a top-level property. > > > > BTW: the commit subject is still wrong. Compare "qmp6490-idp" vs "qcs6490-idp" > OK, I will update it to qcm6490-idp. > > > >> - Link to v3: https://lore.kernel.org/r/20231215-lpg-v3-1-4e2db0c6df5f@quicinc.com > >> > >> Changes in v3: > >> - Rephrased commit text and updated the nodes to qcm6490-idp board file. > >> - Link to v2: https://lore.kernel.org/all/20231110-qcom_leds-v2-1-3cad1fbbc65a@quicinc.com/ > >> > >> Changes in v2: > >> - Rephrased commit text and updated the nodes to board file. > >> - Link to v1: https://lore.kernel.org/r/20231108-qcom_leds-v1-1-c3e1c8572cb0@quicinc.com > >> --- > >> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 23 +++++++++++++++++++++++ > >> 1 file changed, 23 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts > >> index 37c91fdf3ab9..8268fad505e7 100644 > >> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts > >> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts > >> @@ -5,6 +5,7 @@ > >> > >> /dts-v1/; > >> > >> +#include <dt-bindings/leds/common.h> > >> #include <dt-bindings/regulator/qcom,rpmh-regulator.h> > >> #include "sc7280.dtsi" > >> #include "pm7325.dtsi" > >> @@ -414,6 +415,28 @@ vreg_bob_3p296: bob { > >> }; > >> }; > >> > >> +&pm8350c_pwm { > >> + function = LED_FUNCTION_STATUS; > >> + #address-cells = <1>; > >> + #size-cells = <0>; > >> + status = "okay"; > >> + > >> + led@1 { > >> + reg = <1>; > >> + color = <LED_COLOR_ID_RED>; > >> + }; > >> + > >> + led@2 { > >> + reg = <2>; > >> + color = <LED_COLOR_ID_GREEN>; > >> + }; > >> + > >> + led@3 { > >> + reg = <3>; > >> + color = <LED_COLOR_ID_BLUE>; > >> + }; > >> +}; > >> + > >> &qupv3_id_0 { > >> status = "okay"; > >> }; > >> > >> --- > >> base-commit: 17cb8a20bde66a520a2ca7aad1063e1ce7382240 > >> change-id: 20231215-lpg-4aadd374811a > >> > >> Best regards, > >> -- > >> Hui Liu <quic_huliu@quicinc.com> > >> > >> > > > >
diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts index 37c91fdf3ab9..8268fad505e7 100644 --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts @@ -5,6 +5,7 @@ /dts-v1/; +#include <dt-bindings/leds/common.h> #include <dt-bindings/regulator/qcom,rpmh-regulator.h> #include "sc7280.dtsi" #include "pm7325.dtsi" @@ -414,6 +415,28 @@ vreg_bob_3p296: bob { }; }; +&pm8350c_pwm { + function = LED_FUNCTION_STATUS; + #address-cells = <1>; + #size-cells = <0>; + status = "okay"; + + led@1 { + reg = <1>; + color = <LED_COLOR_ID_RED>; + }; + + led@2 { + reg = <2>; + color = <LED_COLOR_ID_GREEN>; + }; + + led@3 { + reg = <3>; + color = <LED_COLOR_ID_BLUE>; + }; +}; + &qupv3_id_0 { status = "okay"; };