diff mbox series

iio: imu: bno055: serdev requires REGMAP

Message ID 20240110185611.19723-1-rdunlap@infradead.org
State New
Headers
Series iio: imu: bno055: serdev requires REGMAP |

Commit Message

Randy Dunlap Jan. 10, 2024, 6:56 p.m. UTC 
  There are a ton of build errors when REGMAP is not set, so select
REGMAP to fix all of them.

Examples (not all of them):

./drivers/iio/imu/bno055/bno055_ser_core.c:495:15: error: variable 'bno055_ser_regmap_bus' has initializer but incomplete type
  495 | static struct regmap_bus bno055_ser_regmap_bus = {
./drivers/iio/imu/bno055/bno055_ser_core.c:496:10: error: 'struct regmap_bus' has no member named 'write'
  496 |         .write = bno055_ser_write_reg,
./drivers/iio/imu/bno055/bno055_ser_core.c:497:10: error: 'struct regmap_bus' has no member named 'read'
  497 |         .read = bno055_ser_read_reg,
./drivers/iio/imu/bno055/bno055_ser_core.c: In function 'bno055_ser_probe':
./drivers/iio/imu/bno055/bno055_ser_core.c:532:18: error: implicit declaration of function 'devm_regmap_init'; did you mean 'vmem_map_init'? [-Werror=implicit-function-declaration]
  532 |         regmap = devm_regmap_init(&serdev->dev, &bno055_ser_regmap_bus,
./drivers/iio/imu/bno055/bno055_ser_core.c:532:16: warning: assignment to 'struct regmap *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
  532 |         regmap = devm_regmap_init(&serdev->dev, &bno055_ser_regmap_bus,
./drivers/iio/imu/bno055/bno055_ser_core.c: At top level:
./drivers/iio/imu/bno055/bno055_ser_core.c:495:26: error: storage size of 'bno055_ser_regmap_bus' isn't known
  495 | static struct regmap_bus bno055_ser_regmap_bus = {

Fixes: 2eef5a9cc643 ("iio: imu: add BNO055 serdev driver")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Andrea Merello <andrea.merello@iit.it>
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-iio@vger.kernel.org
---
 drivers/iio/imu/bno055/Kconfig |    1 +
 1 file changed, 1 insertion(+)

Comments

Jonathan Cameron Jan. 13, 2024, 4:26 p.m. UTC | #1 
On Wed, 10 Jan 2024 10:56:11 -0800
Randy Dunlap <rdunlap@infradead.org> wrote:

> There are a ton of build errors when REGMAP is not set, so select
> REGMAP to fix all of them.
> 
> Examples (not all of them):
> 
> ../drivers/iio/imu/bno055/bno055_ser_core.c:495:15: error: variable 'bno055_ser_regmap_bus' has initializer but incomplete type
>   495 | static struct regmap_bus bno055_ser_regmap_bus = {
> ../drivers/iio/imu/bno055/bno055_ser_core.c:496:10: error: 'struct regmap_bus' has no member named 'write'
>   496 |         .write = bno055_ser_write_reg,
> ../drivers/iio/imu/bno055/bno055_ser_core.c:497:10: error: 'struct regmap_bus' has no member named 'read'
>   497 |         .read = bno055_ser_read_reg,
> ../drivers/iio/imu/bno055/bno055_ser_core.c: In function 'bno055_ser_probe':
> ../drivers/iio/imu/bno055/bno055_ser_core.c:532:18: error: implicit declaration of function 'devm_regmap_init'; did you mean 'vmem_map_init'? [-Werror=implicit-function-declaration]
>   532 |         regmap = devm_regmap_init(&serdev->dev, &bno055_ser_regmap_bus,
> ../drivers/iio/imu/bno055/bno055_ser_core.c:532:16: warning: assignment to 'struct regmap *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
>   532 |         regmap = devm_regmap_init(&serdev->dev, &bno055_ser_regmap_bus,
> ../drivers/iio/imu/bno055/bno055_ser_core.c: At top level:
> ../drivers/iio/imu/bno055/bno055_ser_core.c:495:26: error: storage size of 'bno055_ser_regmap_bus' isn't known
>   495 | static struct regmap_bus bno055_ser_regmap_bus = {
> 
> Fixes: 2eef5a9cc643 ("iio: imu: add BNO055 serdev driver")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Andrea Merello <andrea.merello@iit.it>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: linux-iio@vger.kernel.org
Applied to the fixes-togreg branch of iio.git and marked for stable.

Thanks,
Jonathan

> ---
>  drivers/iio/imu/bno055/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff -- a/drivers/iio/imu/bno055/Kconfig b/drivers/iio/imu/bno055/Kconfig
> --- a/drivers/iio/imu/bno055/Kconfig
> +++ b/drivers/iio/imu/bno055/Kconfig
> @@ -8,6 +8,7 @@ config BOSCH_BNO055
>  config BOSCH_BNO055_SERIAL
>  	tristate "Bosch BNO055 attached via UART"
>  	depends on SERIAL_DEV_BUS
> +	select REGMAP
>  	select BOSCH_BNO055
>  	help
>  	  Enable this to support Bosch BNO055 IMUs attached via UART.
diff mbox series

Patch

diff -- a/drivers/iio/imu/bno055/Kconfig b/drivers/iio/imu/bno055/Kconfig
--- a/drivers/iio/imu/bno055/Kconfig
+++ b/drivers/iio/imu/bno055/Kconfig
@@ -8,6 +8,7 @@  config BOSCH_BNO055
 config BOSCH_BNO055_SERIAL
 	tristate "Bosch BNO055 attached via UART"
 	depends on SERIAL_DEV_BUS
+	select REGMAP
 	select BOSCH_BNO055
 	help
 	  Enable this to support Bosch BNO055 IMUs attached via UART.