Message ID | 20240112-opp_support-v6-1-77bbf7d0cc37@quicinc.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-24734-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2614:b0:101:6a76:bbe3 with SMTP id mm20csp206423dyc; Fri, 12 Jan 2024 06:23:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IE/qp2j2kefaqBigEBsHUsABl1yIfkRekbNepjDnddVYvAXgsGcEX3g7kCzOWLafjYYgCsM X-Received: by 2002:ac8:5709:0:b0:429:c6fd:6381 with SMTP id 9-20020ac85709000000b00429c6fd6381mr1729107qtw.46.1705069421135; Fri, 12 Jan 2024 06:23:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705069421; cv=none; d=google.com; s=arc-20160816; b=OoeV2om03yg7nGsukOB6VdV63zFJmaXdBmCBL42FuX6nM8KlsmgV8t3XOPCChDLEev WVMCjTtoaR2S5vWL/DvWRBqKGL7tPLd3XpLg2cMkE041PZundUon2mK+HH8V3dGiBZOo 37tSXm63scA7yG+YrUj9pxS/UxW3g0Tmf5Bm9HVCRCkMoK7xQiIUx8w0t5j20ui7Womc IL0k8He92F6st5sBmNMuMTOLxPVJIPHh+9nVR9QrIO6JFNe6VL+ZPiV5ZX5P+SbFAA2n Ra3q+TEsQEVo2w7t94szxQNtfKKPUzeRHfCfpdd0YfHnOcvXTBAgNZvUaKoP2svctygO XOzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=/L3WlgpX03GQF1vPUoHxwu+UYb5yP+qM6ZbW9unAsEA=; fh=qy+4K2Our8FgIwRPsvePEWc9yS5HV+GOlB0H/jQK3pI=; b=n7CHV/C71CvVvet1NfC6TBXDis00/xm5T1JrjLc5hGMAlLzXB9ARv1HWV6Xb7AR9Ix 6K8tyJj6JG54aW/kpUBx8YP+Ku0ns1wjvcF2x7s4LKzC+V0iStMNO1lfkD9toEqWQmzg 1Q6HgYWmQXu8BTFJjwBDgx43yo1L0CdnOsoFGx8qY5lHqHXvfF7oKR/+Io7ErlUpXYi6 u8r0GWIPgtb+5Ft9/JFl6mv87R7RHYLDEgV+UfWBbWR21Fp66n9JHsfRbJh6OaQRZdu6 tB15yLuPq8wBp/fg7QUau5kWcqPc4Jt8o5UH0pZameEDc7qa02NY0smiODlV+ULwHTG+ k1DA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=Jcign8Iy; spf=pass (google.com: domain of linux-kernel+bounces-24734-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-24734-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id a16-20020a05622a065000b004299165c22csi3122711qtb.467.2024.01.12.06.23.40 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jan 2024 06:23:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-24734-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=Jcign8Iy; spf=pass (google.com: domain of linux-kernel+bounces-24734-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-24734-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id CFBAF1C213A3 for <ouuuleilei@gmail.com>; Fri, 12 Jan 2024 14:23:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EE96A6E2DD; Fri, 12 Jan 2024 14:22:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="Jcign8Iy" Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B3826E2B5; Fri, 12 Jan 2024 14:22:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40CDYq2Y031873; Fri, 12 Jan 2024 14:22:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= from:date:subject:mime-version:content-type :content-transfer-encoding:message-id:references:in-reply-to:to :cc; s=qcppdkim1; bh=/L3WlgpX03GQF1vPUoHxwu+UYb5yP+qM6ZbW9unAsEA =; b=Jcign8IyMaA+1uiHeK4phkhz4qiR9M8dUgp6hAaI9uIo/dhwKS+AubTSZiA 20ZPxQp1fKNTLQ94DunB5B1tOacrE+FCrbEHnwrhs4uCo6GQxA7VL2PXehQCRECr mHtUDkQmyqm2KZLq/FGE2ouuPwA6uORcTjZ1CjivFmLZTc38eBqU5L8iyTTM3wuS UkXZXvwDAHpvS6rtk+vQh9ZUfz95dn1LgBqaHZrG1IBpfAy4gbgyP3kWrWoD9sB8 AN2VYzHFuOrLgupEaackz1uSiiNHrWTJvjO/fSdEBA2YMbxEm28AvwC2TJYt7Dly A1NleXJX2loVVRHerSAoPhQ6jwA== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3vk6ee82x9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 12 Jan 2024 14:22:27 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 40CEMQfU012607 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 12 Jan 2024 14:22:26 GMT Received: from hu-krichai-hyd.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Fri, 12 Jan 2024 06:22:20 -0800 From: Krishna chaitanya chundru <quic_krichai@quicinc.com> Date: Fri, 12 Jan 2024 19:52:00 +0530 Subject: [PATCH v6 1/6] dt-bindings: PCI: qcom: Add interconnects path as required property Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-ID: <20240112-opp_support-v6-1-77bbf7d0cc37@quicinc.com> References: <20240112-opp_support-v6-0-77bbf7d0cc37@quicinc.com> In-Reply-To: <20240112-opp_support-v6-0-77bbf7d0cc37@quicinc.com> To: Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Bjorn Helgaas <bhelgaas@google.com>, "Lorenzo Pieralisi" <lpieralisi@kernel.org>, =?utf-8?q?Krzysztof_Wilczy?= =?utf-8?q?=C5=84ski?= <kw@linux.com>, Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Manivannan Sadhasivam <mani@kernel.org>, Rob Herring <robh+dt@kernel.org>, Johan Hovold <johan+linaro@kernel.org>, Brian Masney <bmasney@redhat.com>, Georgi Djakov <djakov@kernel.org> CC: <linux-arm-msm@vger.kernel.org>, <vireshk@kernel.org>, <quic_vbadigan@quicinc.com>, <quic_skananth@quicinc.com>, <quic_nitegupt@quicinc.com>, <linux-pci@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, "Krishna chaitanya chundru" <quic_krichai@quicinc.com> X-Mailer: b4 0.13-dev-83828 X-Developer-Signature: v=1; a=ed25519-sha256; t=1705069332; l=817; i=quic_krichai@quicinc.com; s=20230907; h=from:subject:message-id; bh=29UFTWiRmlAql7J/GXeEUCOVbgSGdmJNLHJ5lmBvfn4=; b=f05J6NN5LdS5giO/hEhVIR5R+mxKTswfQpQkruvUeczx7iH3Zzzp6uOpoDQaR2EU9fk3b1DeP CALPWbfyDfbCFtf+LCxSt078vokzG0qjYObnikonoZpNgb45BGAyYal X-Developer-Key: i=quic_krichai@quicinc.com; a=ed25519; pk=10CL2pdAKFyzyOHbfSWHCD0X0my7CXxj8gJScmn1FAg= X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: vBEGje_XmDtYm4tdS9nq2ELN4HpPVfD- X-Proofpoint-GUID: vBEGje_XmDtYm4tdS9nq2ELN4HpPVfD- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-09_01,2023-12-07_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 mlxlogscore=622 clxscore=1015 malwarescore=0 impostorscore=0 mlxscore=0 adultscore=0 spamscore=0 priorityscore=1501 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2311290000 definitions=main-2401120113 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787894873502937473 X-GMAIL-MSGID: 1787894873502937473 |
Series |
PCI: qcom: Add support for OPP
|
|
Commit Message
Krishna chaitanya chundru
Jan. 12, 2024, 2:22 p.m. UTC
Add the interconnects path as required property for sm8450 platform.
Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com>
---
Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 ++
1 file changed, 2 insertions(+)
Comments
On Fri, Jan 12, 2024 at 07:52:00PM +0530, Krishna chaitanya chundru wrote: > Add the interconnects path as required property for sm8450 platform. There's no explaination here as to why you need two different compatibles for the instances on this device. Please add one. Thanks, Conor. > > Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> > --- > Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > index eadba38171e1..bc28669f6fa0 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > @@ -777,6 +777,8 @@ allOf: > - qcom,pcie-sa8540p > - qcom,pcie-sa8775p > - qcom,pcie-sc8280xp > + - qcom,pcie-sm8450-pcie0 > + - qcom,pcie-sm8450-pcie1 > then: > required: > - interconnects > > -- > 2.42.0 >
On Fri, 12 Jan 2024 at 18:55, Conor Dooley <conor@kernel.org> wrote: > > On Fri, Jan 12, 2024 at 07:52:00PM +0530, Krishna chaitanya chundru wrote: > > Add the interconnects path as required property for sm8450 platform. > > There's no explaination here as to why you need two different > compatibles for the instances on this device. Please add one. Note, these are not new compatible strings. They are already defined (separate because port0 and port1 have different sets of NoC clocks). > > Thanks, > Conor. > > > > > Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> > > --- > > Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > index eadba38171e1..bc28669f6fa0 100644 > > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > @@ -777,6 +777,8 @@ allOf: > > - qcom,pcie-sa8540p > > - qcom,pcie-sa8775p > > - qcom,pcie-sc8280xp > > + - qcom,pcie-sm8450-pcie0 > > + - qcom,pcie-sm8450-pcie1 > > then: > > required: > > - interconnects > > > > -- > > 2.42.0 > >
On Fri, Jan 12, 2024 at 07:12:01PM +0200, Dmitry Baryshkov wrote: > On Fri, 12 Jan 2024 at 18:55, Conor Dooley <conor@kernel.org> wrote: > > > > On Fri, Jan 12, 2024 at 07:52:00PM +0530, Krishna chaitanya chundru wrote: > > > Add the interconnects path as required property for sm8450 platform. > > > > There's no explaination here as to why you need two different > > compatibles for the instances on this device. Please add one. > > Note, these are not new compatible strings. They are already defined > (separate because port0 and port1 have different sets of NoC clocks). Ahh, my bad. My comment can be disregarded. :wq > > > > > Thanks, > > Conor. > > > > > > > > Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> > > > --- > > > Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > > index eadba38171e1..bc28669f6fa0 100644 > > > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > > @@ -777,6 +777,8 @@ allOf: > > > - qcom,pcie-sa8540p > > > - qcom,pcie-sa8775p > > > - qcom,pcie-sc8280xp > > > + - qcom,pcie-sm8450-pcie0 > > > + - qcom,pcie-sm8450-pcie1 > > > then: > > > required: > > > - interconnects > > > > > > -- > > > 2.42.0 > > > > > > > -- > With best wishes > Dmitry
On Fri, 12 Jan 2024 19:52:00 +0530, Krishna chaitanya chundru wrote: > Add the interconnects path as required property for sm8450 platform. > > Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> > --- > Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by: Rob Herring <robh@kernel.org>
On Fri, Jan 12, 2024 at 07:52:00PM +0530, Krishna chaitanya chundru wrote: > Add the interconnects path as required property for sm8450 platform. > > Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> - Mani > --- > Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > index eadba38171e1..bc28669f6fa0 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > @@ -777,6 +777,8 @@ allOf: > - qcom,pcie-sa8540p > - qcom,pcie-sa8775p > - qcom,pcie-sc8280xp > + - qcom,pcie-sm8450-pcie0 > + - qcom,pcie-sm8450-pcie1 > then: > required: > - interconnects > > -- > 2.42.0 >
diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml index eadba38171e1..bc28669f6fa0 100644 --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml @@ -777,6 +777,8 @@ allOf: - qcom,pcie-sa8540p - qcom,pcie-sa8775p - qcom,pcie-sc8280xp + - qcom,pcie-sm8450-pcie0 + - qcom,pcie-sm8450-pcie1 then: required: - interconnects