Message ID | 20231227130810.2744550-1-claudiu.beznea.uj@bp.renesas.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-12031-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp1420301dyb; Wed, 27 Dec 2023 05:09:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IEGT0OoPP5weU3exDul/GdbtvaVXUjbDt/fQjKE3hplIUfsAIYRxAkvysRwRVcCGMQ9lWMc X-Received: by 2002:a17:906:d1cc:b0:a23:4264:1a85 with SMTP id bs12-20020a170906d1cc00b00a2342641a85mr3796631ejb.1.1703682565575; Wed, 27 Dec 2023 05:09:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703682565; cv=none; d=google.com; s=arc-20160816; b=F2G//ko8X9TSsGEboXHkcqyC5vmuCoo+eTzVXvcWhtzrmOJHdgAqV1ng7DzCK4k2PC PCQJUUK99h8gSQAUhrjQqJ54xjaFlrQr1KuJzTQlypwyPpEkifK9WddKopd+Ad/ypdK/ p0doDP8xgzRrz0pMpUqYxHYfXxQxliH1hAaVsnNJYGv0FEuRE52B8NySdKRpkrFp6gHq j8kwZUtVbI33/reN3oKvmxiYE7KUjHvp5mIw+d1yemcaNh2by55KtbDKGK1G4BQK+uhO 5BYnzLxqTlPTVfcH5U+U/fSy5tO2UdCMn+YPDND4076GvmG91lOXAaY1C8RsZfsLILzg qbyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=ocsSiEqBdtanIffaaT52Hpat/4WnkDj2kMGWbB3pX8E=; fh=TIzQPZEPC/xVc/4kEImzd2AxlPEWW0R91ogxVmUckdg=; b=PzeORTfHOMean9E9nTz+zwG15weDlZYPGkXAAE5iVSFCLXCREObpBvn3tZKX2ahFpn aMbWsPDQRmatsWFOXR7AZVXYBi2404Y+6aaOFPhZssa/HWRosQsynxzFLol+iDbctuaX X4PiDvNEleUlXAX6P66pTZN2AM9RalKANEl8p/PiIQ4SOUWUmAH6QsCeR4g2I4VK1h2n cJIYmrKcpo86yijkSwG6WS5gIBJOZgN+uFKYtjlQflO/TRbiUMBzfzT7iA27YRxuHjDU 0EgIg/ZKPsAoDd52LwQGKDx7CFDf5jBhspDMmLBLgYiVKAIw9Yi8r+vLsd/SRAXlE4b7 gfMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@tuxon.dev header.s=google header.b=hiV6n+4q; spf=pass (google.com: domain of linux-kernel+bounces-12031-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12031-ouuuleilei=gmail.com@vger.kernel.org" Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id wi21-20020a170906fd5500b00a26ac400698si5129438ejb.17.2023.12.27.05.09.25 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 05:09:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12031-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@tuxon.dev header.s=google header.b=hiV6n+4q; spf=pass (google.com: domain of linux-kernel+bounces-12031-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12031-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 345141F220B5 for <ouuuleilei@gmail.com>; Wed, 27 Dec 2023 13:09:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6E8E644C8F; Wed, 27 Dec 2023 13:08:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="hiV6n+4q" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B75FD45961 for <linux-kernel@vger.kernel.org>; Wed, 27 Dec 2023 13:08:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-336c9acec03so1593440f8f.2 for <linux-kernel@vger.kernel.org>; Wed, 27 Dec 2023 05:08:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1703682510; x=1704287310; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ocsSiEqBdtanIffaaT52Hpat/4WnkDj2kMGWbB3pX8E=; b=hiV6n+4q8Z0ZFX2ngX+LspAOsc5eVlPs0eU7Crk1XUHoFi5u4/paBB3Zspkf/NPIpj uVC3JxdQoSJJXSzYr/1ZtEoEKSzy/0MzBeTrLDmjp6vROdjmyPbp1u6qLf3Fng/tcewk yBgDIsP30+CBRDqjFdIgJVi4LpCUHEKzYkD1JhuLjDiq+AmVSnf4Ibb0tN01DEXqW3Tx RvcL7KUNN00NYV17+LJIdytKap7f+qCdUSngiz3FD1Ueu93W4aepWrTqR4l2PGxZYdDm /iP1XAeXi+nLPmn4SQdlN74VsLH3MasRlkiCFqDAfpyShUG+k3TMbsSf/WLyCXChho5f 58ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703682510; x=1704287310; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ocsSiEqBdtanIffaaT52Hpat/4WnkDj2kMGWbB3pX8E=; b=nnN5zcposafRTyc18uVFKTN7mff+5C2+iIohiAOu4Ww/Gey8LgTYLMHqvYcyTAmCgF tnp7etEXseGwzDh1Rk7uc13V4+aG0qUhpGslaFF0XW03v8UxcbU6BCsSrBF03z/E0Zqc 7Y72jvpfnHbIenNIo44edGcDpbTcD8BcImB0id257L2ac7qvYqFM7cPjFvEdys+RuH0p 6nLG9hdBZLabiKNgthQV3h1i+pNjDcTO+JH5GUH4T8UA/BCdaqTlM/eI5K17WUFzvSvh LXiVpozwCsiLA+w3SrSxUCvRkuQ7vrHHcen8VRzvMzr39zltEGw/PLejiG5vynW2COiT 7hig== X-Gm-Message-State: AOJu0YzxP70NzIJHzKLXg4rPoGu0mjfhgXP7qaN/2w9XvQyC74DNgyOl SRPPNSWqdPf/CACrNS6iTy8FdsMtd/oVNg== X-Received: by 2002:a5d:6d06:0:b0:336:c159:d3df with SMTP id e6-20020a5d6d06000000b00336c159d3dfmr3250890wrq.87.1703682509846; Wed, 27 Dec 2023 05:08:29 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.5]) by smtp.gmail.com with ESMTPSA id c6-20020adfe706000000b0033342338a24sm14906263wrm.6.2023.12.27.05.08.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 05:08:29 -0800 (PST) From: Claudiu <claudiu.beznea@tuxon.dev> X-Google-Original-From: Claudiu <claudiu.beznea.uj@bp.renesas.com> To: geert+renesas@glider.be, magnus.damm@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, claudiu.beznea@tuxon.dev, Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> Subject: [PATCH] arm64: dts: renesas: rzg3s-smarc: Add gpio keys Date: Wed, 27 Dec 2023 15:08:10 +0200 Message-Id: <20231227130810.2744550-1-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786440649936397832 X-GMAIL-MSGID: 1786440649936397832 |
Series |
arm64: dts: renesas: rzg3s-smarc: Add gpio keys
|
|
Commit Message
claudiu beznea
Dec. 27, 2023, 1:08 p.m. UTC
From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> RZ SMARC Carrier II board has 3 user buttons called USER_SW1, USER_SW2, USER_SW3. Add a DT node in device tree to propertly instantiate the gpio-keys driver for these buttons. Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> --- arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi | 53 ++++++++++++++++++++ 1 file changed, 53 insertions(+)
Comments
Hi Claudiu, On Wed, Dec 27, 2023 at 2:08 PM Claudiu <claudiu.beznea@tuxon.dev> wrote: > From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > > RZ SMARC Carrier II board has 3 user buttons called USER_SW1, USER_SW2, > USER_SW3. Add a DT node in device tree to propertly instantiate the > gpio-keys driver for these buttons. > > Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi > +++ b/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi > @@ -6,6 +6,7 @@ > */ > > #include <dt-bindings/gpio/gpio.h> > +#include <dt-bindings/input/input.h> > #include <dt-bindings/pinctrl/rzg2l-pinctrl.h> > > / { > @@ -14,6 +15,37 @@ aliases { > mmc1 = &sdhi1; > }; > > + keys { Do you mind if I s/keys/keypad/ while applying? ... > + compatible = "gpio-keys"; > + > + key-1 { > + interrupts = <RZG2L_GPIO(18, 0) IRQ_TYPE_EDGE_FALLING>; Oh, the horror of interrupt controllers that don't support generating interrupts on both edges... > + interrupt-parent = <&pinctrl>; .. and move these one level up, to avoid duplication? > + linux,code = <KEY_1>; > + label = "USER_SW1"; > + wakeup-source; > + debounce-interval = <20>; > + }; > + > + key-2 { > + interrupts = <RZG2L_GPIO(0, 1) IRQ_TYPE_EDGE_FALLING>; > + interrupt-parent = <&pinctrl>; > + linux,code = <KEY_2>; > + label = "USER_SW2"; > + wakeup-source; > + debounce-interval = <20>; > + }; > + > + key-3 { > + interrupts = <RZG2L_GPIO(0, 3) IRQ_TYPE_EDGE_FALLING>; > + interrupt-parent = <&pinctrl>; > + linux,code = <KEY_3>; > + label = "USER_SW3"; > + wakeup-source; > + debounce-interval = <20>; > + }; > + }; > + > vcc_sdhi1: regulator-vcc-sdhi1 { > compatible = "regulator-fixed"; > regulator-name = "SDHI1 Vcc"; Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in renesas-devel for v6.9, with the above fixed. Gr{oetje,eeting}s, Geert
Hi, Geert, On 12.01.2024 15:55, Geert Uytterhoeven wrote: > Hi Claudiu, > > On Wed, Dec 27, 2023 at 2:08 PM Claudiu <claudiu.beznea@tuxon.dev> wrote: >> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> >> >> RZ SMARC Carrier II board has 3 user buttons called USER_SW1, USER_SW2, >> USER_SW3. Add a DT node in device tree to propertly instantiate the >> gpio-keys driver for these buttons. >> >> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > > Thanks for your patch! > >> --- a/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi >> +++ b/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi >> @@ -6,6 +6,7 @@ >> */ >> >> #include <dt-bindings/gpio/gpio.h> >> +#include <dt-bindings/input/input.h> >> #include <dt-bindings/pinctrl/rzg2l-pinctrl.h> >> >> / { >> @@ -14,6 +15,37 @@ aliases { >> mmc1 = &sdhi1; >> }; >> >> + keys { > > Do you mind if I s/keys/keypad/ while applying? ... Is not actually a keypad... there are 3 buttons in a corner of the board... I see only 2 entries in arm64 and arm DTS directory following this pattern for gpio-keys compatible node: arch/arm/boot/dts/renesas/r8a7779-marzen.dts arch/arm/boot/dts/renesas/r8a7779-marzen.dts But if you prefer it like this, I have nothing against. Just asking, do you have a particular reason for naming it like this? > >> + compatible = "gpio-keys"; >> + >> + key-1 { >> + interrupts = <RZG2L_GPIO(18, 0) IRQ_TYPE_EDGE_FALLING>; > > Oh, the horror of interrupt controllers that don't support generating > interrupts on both edges... Yes. > >> + interrupt-parent = <&pinctrl>; > > ... and move these one level up, to avoid duplication? Moving it just near compatible will make the schema validation to fail with this (driver is working, though): arch/arm64/boot/dts/renesas/r9a08g045s33-smarc.dtb: keys: 'interrupt-parent' does not match any of the regexes: '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/input/gpio-keys.yaml# Thank you, Claudiu Beznea > >> + linux,code = <KEY_1>; >> + label = "USER_SW1"; >> + wakeup-source; >> + debounce-interval = <20>; >> + }; >> + >> + key-2 { >> + interrupts = <RZG2L_GPIO(0, 1) IRQ_TYPE_EDGE_FALLING>; >> + interrupt-parent = <&pinctrl>; >> + linux,code = <KEY_2>; >> + label = "USER_SW2"; >> + wakeup-source; >> + debounce-interval = <20>; >> + }; >> + >> + key-3 { >> + interrupts = <RZG2L_GPIO(0, 3) IRQ_TYPE_EDGE_FALLING>; >> + interrupt-parent = <&pinctrl>; >> + linux,code = <KEY_3>; >> + label = "USER_SW3"; >> + wakeup-source; >> + debounce-interval = <20>; >> + }; >> + }; >> + >> vcc_sdhi1: regulator-vcc-sdhi1 { >> compatible = "regulator-fixed"; >> regulator-name = "SDHI1 Vcc"; > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > i.e. will queue in renesas-devel for v6.9, with the above fixed. > > Gr{oetje,eeting}s, > > Geert >
Hi Claudiu, On Fri, Jan 12, 2024 at 4:38 PM claudiu beznea <claudiu.beznea@tuxon.dev> wrote: > On 12.01.2024 15:55, Geert Uytterhoeven wrote: > > On Wed, Dec 27, 2023 at 2:08 PM Claudiu <claudiu.beznea@tuxon.dev> wrote: > >> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > >> > >> RZ SMARC Carrier II board has 3 user buttons called USER_SW1, USER_SW2, > >> USER_SW3. Add a DT node in device tree to propertly instantiate the > >> gpio-keys driver for these buttons. > >> > >> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > > > > Thanks for your patch! > > > >> --- a/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi > >> +++ b/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi > >> @@ -14,6 +15,37 @@ aliases { > >> mmc1 = &sdhi1; > >> }; > >> > >> + keys { > > > > Do you mind if I s/keys/keypad/ while applying? ... > > Is not actually a keypad... there are 3 buttons in a corner of the board.. > > I see only 2 entries in arm64 and arm DTS directory following this pattern > for gpio-keys compatible node: > > arch/arm/boot/dts/renesas/r8a7779-marzen.dts > arch/arm/boot/dts/renesas/r8a7779-marzen.dts > > But if you prefer it like this, I have nothing against. > > Just asking, do you have a particular reason for naming it like this? See the discussion in [1], and the resulting patch[2], which added the (so far) single user in arch/arm/boot/dts/renesas/r8a7779-marzen.dts [1] https://lore.kernel.org/all/20231023144134.1881973-1-geert+renesas@glider.be [2] https://lore.kernel.org/all/eec1ccfb75c6215428609fdcaf3a37c75fe1fc87.1698228163.git.geert+renesas@glider.be > > >> + interrupt-parent = <&pinctrl>; > > > > ... and move these one level up, to avoid duplication? > > Moving it just near compatible will make the schema validation to fail with > this (driver is working, though): > > arch/arm64/boot/dts/renesas/r9a08g045s33-smarc.dtb: keys: > 'interrupt-parent' does not match any of the regexes: > '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', > 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/input/gpio-keys.yaml# Oops, I had completely forgotten r8a7779-marzen.dts triggers this, too... Let's keep it for now. Gr{oetje,eeting}s, Geert
Hi, Geert, On 12.01.2024 18:20, Geert Uytterhoeven wrote: > Hi Claudiu, > > On Fri, Jan 12, 2024 at 4:38 PM claudiu beznea <claudiu.beznea@tuxon.dev> wrote: >> On 12.01.2024 15:55, Geert Uytterhoeven wrote: >>> On Wed, Dec 27, 2023 at 2:08 PM Claudiu <claudiu.beznea@tuxon.dev> wrote: >>>> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> >>>> >>>> RZ SMARC Carrier II board has 3 user buttons called USER_SW1, USER_SW2, >>>> USER_SW3. Add a DT node in device tree to propertly instantiate the >>>> gpio-keys driver for these buttons. >>>> >>>> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> >>> >>> Thanks for your patch! >>> >>>> --- a/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi >>>> +++ b/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi >>>> @@ -14,6 +15,37 @@ aliases { >>>> mmc1 = &sdhi1; >>>> }; >>>> >>>> + keys { >>> >>> Do you mind if I s/keys/keypad/ while applying? ... >> >> Is not actually a keypad... there are 3 buttons in a corner of the board... >> >> I see only 2 entries in arm64 and arm DTS directory following this pattern >> for gpio-keys compatible node: >> >> arch/arm/boot/dts/renesas/r8a7779-marzen.dts >> arch/arm/boot/dts/renesas/r8a7779-marzen.dts >> >> But if you prefer it like this, I have nothing against. >> >> Just asking, do you have a particular reason for naming it like this? > > See the discussion in [1], and the resulting patch[2], which added the > (so far) single user in arch/arm/boot/dts/renesas/r8a7779-marzen.dts > > [1] https://lore.kernel.org/all/20231023144134.1881973-1-geert+renesas@glider.be Ah, I remember part of this discussion. Good for me to rename it as you proposed. > [2] https://lore.kernel.org/all/eec1ccfb75c6215428609fdcaf3a37c75fe1fc87.1698228163.git.geert+renesas@glider.be >> >>>> + interrupt-parent = <&pinctrl>; >>> >>> ... and move these one level up, to avoid duplication? >> >> Moving it just near compatible will make the schema validation to fail with >> this (driver is working, though): >> >> arch/arm64/boot/dts/renesas/r9a08g045s33-smarc.dtb: keys: >> 'interrupt-parent' does not match any of the regexes: >> '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', >> 'pinctrl-[0-9]+' >> from schema $id: http://devicetree.org/schemas/input/gpio-keys.yaml# > > Oops, I had completely forgotten r8a7779-marzen.dts triggers this, too... > Let's keep it for now. > > Gr{oetje,eeting}s, > > Geert >
diff --git a/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi b/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi index 214520137230..deb2ad37bb2e 100644 --- a/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi +++ b/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi @@ -6,6 +6,7 @@ */ #include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/input/input.h> #include <dt-bindings/pinctrl/rzg2l-pinctrl.h> / { @@ -14,6 +15,37 @@ aliases { mmc1 = &sdhi1; }; + keys { + compatible = "gpio-keys"; + + key-1 { + interrupts = <RZG2L_GPIO(18, 0) IRQ_TYPE_EDGE_FALLING>; + interrupt-parent = <&pinctrl>; + linux,code = <KEY_1>; + label = "USER_SW1"; + wakeup-source; + debounce-interval = <20>; + }; + + key-2 { + interrupts = <RZG2L_GPIO(0, 1) IRQ_TYPE_EDGE_FALLING>; + interrupt-parent = <&pinctrl>; + linux,code = <KEY_2>; + label = "USER_SW2"; + wakeup-source; + debounce-interval = <20>; + }; + + key-3 { + interrupts = <RZG2L_GPIO(0, 3) IRQ_TYPE_EDGE_FALLING>; + interrupt-parent = <&pinctrl>; + linux,code = <KEY_3>; + label = "USER_SW3"; + wakeup-source; + debounce-interval = <20>; + }; + }; + vcc_sdhi1: regulator-vcc-sdhi1 { compatible = "regulator-fixed"; regulator-name = "SDHI1 Vcc"; @@ -35,6 +67,27 @@ vccq_sdhi1: regulator-vccq-sdhi1 { }; &pinctrl { + key-1-gpio-hog { + gpio-hog; + gpios = <RZG2L_GPIO(18, 0) GPIO_ACTIVE_LOW>; + input; + line-name = "key-1-gpio-irq"; + }; + + key-2-gpio-hog { + gpio-hog; + gpios = <RZG2L_GPIO(0, 1) GPIO_ACTIVE_LOW>; + input; + line-name = "key-2-gpio-irq"; + }; + + key-3-gpio-hog { + gpio-hog; + gpios = <RZG2L_GPIO(0, 3) GPIO_ACTIVE_LOW>; + input; + line-name = "key-3-gpio-irq"; + }; + scif0_pins: scif0 { pinmux = <RZG2L_PORT_PINMUX(6, 3, 1)>, /* RXD */ <RZG2L_PORT_PINMUX(6, 4, 1)>; /* TXD */