Message ID | 20240110194031.2384005-7-kmatsui@gcc.gnu.org |
---|---|
State | Unresolved |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2411:b0:101:2151:f287 with SMTP id m17csp1015018dyi; Wed, 10 Jan 2024 11:43:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IFu6Lio6vJ0WTlZJPcLmWqOUuh0SqEiv6G914Q0zp01xH8YFJnXwRkXP5VdAfR9szOHoGnu X-Received: by 2002:a05:6870:93c5:b0:203:b690:eaf1 with SMTP id c5-20020a05687093c500b00203b690eaf1mr73634oal.81.1704915782206; Wed, 10 Jan 2024 11:43:02 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1704915782; cv=pass; d=google.com; s=arc-20160816; b=wGkTdi6AwCH8GbYsLMYzltirvWBtAhNluk8UKywR2nl7pPWIX/P6xevCLW5CumS/tQ Y146VNaSqyR6kn3tyC2RtaClw1amT/vzm9Uc+Mo0Mt33O4A2YeheC1AtbeedLWc4Qy2t al1dYt4OYcAXCk+9jzRlZpDhCPIb4EJbsq4VdrLvKzdngI5IkgG6aGOo3MREN2l2Bhbn sy+HHfbMqGpqsTOsAtAuBMZzJGjzfVK+MKqQzki6KWgZlbWr8cXfz7Ks4bQxx/6LiFGx KmGQqPZnyy6nYFOWzzcnV90uo1utW/rbCzl87n4HuMo+fAqQM+1b3qmL+He6OyoL/WIa FeEw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:arc-filter:dmarc-filter:delivered-to:dkim-signature :dkim-filter; bh=Zne5f8WqGP8Zt3b1tk1mSUmJx1zUryiwbFAllQn5doM=; fh=kSSy/oyUXqQD15FLeKdymIgDBFPFITPA1Gj52CNOxRQ=; b=f4fI2l8Hzf+hUtfG5Ylr+KgYxe/KChXCxdQT+bHDmKLKJQIDiijY91yNFNeut5OY0r r3FUyHAgG0Tsl3evaOo8RK5prTslbKd/ViOpmuZPiOE5cTWwOd1tKBoye9lKp/VAGsMB bPI8Iv83b76oZtqfEJ85l5Q+sC25ObJ9QAkuhPgkh4xxO1p2Hlfmbtv0UvcXiGR92qN5 KNlkyMgbSUTSZbrLJM14uPRHlMPG+7weO/5m2Ya6Q0UL5/W8XLRMjwDUDM5G8myj4CCr eLK5WzJgmtePiG/mDyJTwmdvjgrMjBSZKVeOdnQFMcY5I2DAYvvrMR9Mx0c/hRk2XBt9 gRjg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=Gv4gJoCP; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id t12-20020a05620a004c00b007810ca77e71si4510170qkt.539.2024.01.10.11.43.02 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 11:43:02 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=Gv4gJoCP; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A8BF93857828 for <ouuuleilei@gmail.com>; Wed, 10 Jan 2024 19:43:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A8BF93857828 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1704915781; bh=Zne5f8WqGP8Zt3b1tk1mSUmJx1zUryiwbFAllQn5doM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Gv4gJoCPfS6fAigZoRLF3JcDAv9ZWKqmgU3phjcO41xPnITHCsA7NglJfXaKL2R8+ /qIO60rwPKqJJsci8pdWQsq7nQejaCyt/5I7INQuZjTQGBIC4YUqhyugKesAI64Nll 2PKoy93AWioQgE97BKqks9XP4EUXV3D4vmMbTJSE= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-00641c01.pphosted.com (mx0a-00641c01.pphosted.com [205.220.165.146]) by sourceware.org (Postfix) with ESMTPS id 2C2123858C52; Wed, 10 Jan 2024 19:41:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2C2123858C52 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=gcc.gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2C2123858C52 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.165.146 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704915677; cv=none; b=ojoW0vSrhdd6+S5g8N0GjSXUGJCu0hTiNQ16cqbVm9BSxwNCzzbqf/rwLa8iIT+DXHolELRGRhut2S5M0isp233KAytQxSaDt9bmjTVnElQJV+n7Hw3DNwrAZZa0ib7SRoFxY7OjRgkkGDq4StXaT7CaQKWqlylskYcnyUUFPK8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704915677; c=relaxed/simple; bh=d549OKW2xBZlQBAzYI49WJfrqAq5/4dHwPKh52fn3J8=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=AUnO32u05p+2DEKZy0IGdJgi/3UV4VxwTseO2DLWlQ7XRqwMI4KY7nOwkT9/QCjws7tlNWgrPdgXvXUDZGQLn90IkNBnF65QuMmkDP8xcp8WWKdRBJT0jWFnkm4xEqC6PXZKjxDbqhId0LVJCEmOIRBAPMkxPC9hy7SX+5DNL5c= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0247470.ppops.net [127.0.0.1]) by mx0a-00641c01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 40AJdR44018049; Wed, 10 Jan 2024 19:41:10 GMT Received: from mxout25.s.uw.edu (mxout25.s.uw.edu [140.142.234.175]) by mx0a-00641c01.pphosted.com (PPS) with ESMTPS id 3vhyq0sc4c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Jan 2024 19:41:10 +0000 Received: from smtp.washington.edu (smtp.washington.edu [128.208.60.54]) by mxout25.s.uw.edu (8.14.4+UW20.07/8.14.4+UW22.04) with ESMTP id 40AJegB6002141 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 10 Jan 2024 11:40:42 -0800 X-Auth-Received: from kmatsui-ThinkPad-X1-Carbon-Gen-9.dhcp4.washington.edu ([10.154.74.143]) (authenticated authid=kmatsui) by smtp.washington.edu (8.16.1+UW21.10/8.14.4+UW19.10) with ESMTPSA id 40AJefnF020412 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Jan 2024 11:40:42 -0800 X-UW-Orig-Sender: kmatsui@smtp.washington.edu From: Ken Matsui <kmatsui@gcc.gnu.org> To: gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org, Ken Matsui <kmatsui@gcc.gnu.org> Subject: [PATCH 06/14] libstdc++: Optimize std::is_arithmetic compilation performance Date: Wed, 10 Jan 2024 01:22:57 -0800 Message-ID: <20240110194031.2384005-7-kmatsui@gcc.gnu.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240110194031.2384005-1-kmatsui@gcc.gnu.org> References: <20240110194031.2384005-1-kmatsui@gcc.gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: 7Gz9W49gnfzgO7ppa-rVgoFtQZkwgW12 X-Proofpoint-GUID: 7Gz9W49gnfzgO7ppa-rVgoFtQZkwgW12 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-10_10,2024-01-10_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 clxscore=1034 impostorscore=0 malwarescore=0 spamscore=0 bulkscore=0 phishscore=0 mlxscore=0 mlxlogscore=528 suspectscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401100156 X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DATE_IN_PAST_06_12, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NEUTRAL, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787733771656221453 X-GMAIL-MSGID: 1787733771656221453 |
Series |
Optimize integral-related type traits
|
|
Checks
Context | Check | Description |
---|---|---|
snail/gcc-patch-check | warning | Git am fail log |
Commit Message
Ken Matsui
Jan. 10, 2024, 9:22 a.m. UTC
This patch optimizes the compilation performance of std::is_arithmetic
by dispatching to the new __is_arithmetic built-in trait.
libstdc++-v3/ChangeLog:
* include/std/type_traits (is_arithmetic): Use __is_arithmetic
built-in trait.
(is_arithmetic_v): Likewise.
Signed-off-by: Ken Matsui <kmatsui@gcc.gnu.org>
---
libstdc++-v3/include/std/type_traits | 13 +++++++++++++
1 file changed, 13 insertions(+)
Comments
On Wed, 10 Jan 2024 at 19:47, Ken Matsui <kmatsui@gcc.gnu.org> wrote: > > This patch optimizes the compilation performance of std::is_arithmetic > by dispatching to the new __is_arithmetic built-in trait. OK for trunk (if the new built-in is approved). > > libstdc++-v3/ChangeLog: > > * include/std/type_traits (is_arithmetic): Use __is_arithmetic > built-in trait. > (is_arithmetic_v): Likewise. > > Signed-off-by: Ken Matsui <kmatsui@gcc.gnu.org> > --- > libstdc++-v3/include/std/type_traits | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits > index 23ea70eca18..9baf3b2aa46 100644 > --- a/libstdc++-v3/include/std/type_traits > +++ b/libstdc++-v3/include/std/type_traits > @@ -728,10 +728,17 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > #endif > > /// is_arithmetic > +#if _GLIBCXX_USE_BUILTIN_TRAIT(__is_arithmetic) > + template<typename _Tp> > + struct is_arithmetic > + : public __bool_constant<__is_arithmetic(_Tp)> > + { }; > +#else > template<typename _Tp> > struct is_arithmetic > : public __or_<is_integral<_Tp>, is_floating_point<_Tp>>::type > { }; > +#endif > > /// is_fundamental > template<typename _Tp> > @@ -3317,8 +3324,14 @@ template <typename _Tp> > inline constexpr bool is_reference_v<_Tp&&> = true; > #endif > > +#if _GLIBCXX_USE_BUILTIN_TRAIT(__is_arithmetic) > +template <typename _Tp> > + inline constexpr bool is_arithmetic_v = __is_arithmetic(_Tp); > +#else > template <typename _Tp> > inline constexpr bool is_arithmetic_v = is_arithmetic<_Tp>::value; > +#endif > + > template <typename _Tp> > inline constexpr bool is_fundamental_v = is_fundamental<_Tp>::value; > > -- > 2.43.0 >
diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits index 23ea70eca18..9baf3b2aa46 100644 --- a/libstdc++-v3/include/std/type_traits +++ b/libstdc++-v3/include/std/type_traits @@ -728,10 +728,17 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION #endif /// is_arithmetic +#if _GLIBCXX_USE_BUILTIN_TRAIT(__is_arithmetic) + template<typename _Tp> + struct is_arithmetic + : public __bool_constant<__is_arithmetic(_Tp)> + { }; +#else template<typename _Tp> struct is_arithmetic : public __or_<is_integral<_Tp>, is_floating_point<_Tp>>::type { }; +#endif /// is_fundamental template<typename _Tp> @@ -3317,8 +3324,14 @@ template <typename _Tp> inline constexpr bool is_reference_v<_Tp&&> = true; #endif +#if _GLIBCXX_USE_BUILTIN_TRAIT(__is_arithmetic) +template <typename _Tp> + inline constexpr bool is_arithmetic_v = __is_arithmetic(_Tp); +#else template <typename _Tp> inline constexpr bool is_arithmetic_v = is_arithmetic<_Tp>::value; +#endif + template <typename _Tp> inline constexpr bool is_fundamental_v = is_fundamental<_Tp>::value;