Message ID | 20240110194031.2384005-9-kmatsui@gcc.gnu.org |
---|---|
State | Unresolved |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2411:b0:101:2151:f287 with SMTP id m17csp1016083dyi; Wed, 10 Jan 2024 11:45:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IFV25kQC90fx2ZvbyMF27ZdrJ3ZI9OP6l4wVMYwk+o3LeKayecWcCB3My4XDDEoBu2oZ7SB X-Received: by 2002:a05:6214:2aae:b0:681:a12:26b7 with SMTP id js14-20020a0562142aae00b006810a1226b7mr977844qvb.52.1704915921083; Wed, 10 Jan 2024 11:45:21 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1704915921; cv=pass; d=google.com; s=arc-20160816; b=BRXUhrLwHhnsS6+pZrS9tC0fmixJcDyh+j6IGukaN4Fb6JTQ4/aImszZb4i7q+kWLa w6UDxe/HUdKnALLkRq2IGK/NKHyc8dwUl1A3X9kBGeh63HtQHSGJ+PVfKmM4V/K6WL4x nHmc7U9LDABIpOjDZNWQ1YsljiIGGcsNb6Ghavn4/sawDHi3DoXlySEydRixRPokWKEu 1UqqhzBhJHDTDv/acNkX5wuES8H7sCaGd0sXTcyiyfmpoeCXXM4HU7KGZgHqw92l/ad7 1GYZyugFLB5qmKPrxpYI/murlIL50c0L/w0fmAL7GdvtnEJdc+zhJ79boy2wr87al1cT becg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:arc-filter:dmarc-filter:delivered-to:dkim-signature :dkim-filter; bh=aE6XYey9ECbcKKCCuueZ3g2OH51uiL9QQmzat5VCL54=; fh=kSSy/oyUXqQD15FLeKdymIgDBFPFITPA1Gj52CNOxRQ=; b=F0+VKP3Ixwkw/caW2GHdNiPFCEtO2j+LxFy4dl8Mr7N3qMC+rtzGLTu9UerFrAWsEx /+pavc3kIoxghbhhCvHai7yRwIKrtJ9stB8DYGiy4PvMm9/GwQE5KSTvmEC/yAVeMQo0 aDEmjMaB8HWi0C4uUQ56+j+N9GWLnFpb94SnBvTK82+0WdxVit53EPTu2RuArtlepoR1 qQflC9WY3R6KSsZ6ee81XoNy72fOn1PeZ2nC+v2ifbGv/CRqvDVBYUWSjiuKNxMbu36k I+rAFnGNEWMMttlmL6C41fROkOJ1GJqN/1WHFR8NLT6OMGKAI0UvcohH+S+cTMOZNiBJ sgfQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b="V/IRgMNo"; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id a5-20020a0ce345000000b0068077cd22c7si5131754qvm.190.2024.01.10.11.45.20 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 11:45:21 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b="V/IRgMNo"; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B411A3858D38 for <ouuuleilei@gmail.com>; Wed, 10 Jan 2024 19:45:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B411A3858D38 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1704915920; bh=aE6XYey9ECbcKKCCuueZ3g2OH51uiL9QQmzat5VCL54=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=V/IRgMNo9pDJX17AL7qgvAC5n2IuR+F84Bbfe3xJ/giJn6jNSxLje2fDxJ8nHVlyi 7OtY+p7JJAeDM66Hecm2zuv0taZuE9S6ETXgxN1qDnjlg/4PmMhrWuRqMSxD6T/eiz PsLShgL4lalNoMmigFpSS6HSfPEc13Z4KfxoPLDg= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-00641c01.pphosted.com (mx0b-00641c01.pphosted.com [205.220.177.146]) by sourceware.org (Postfix) with ESMTPS id E7F9D3858036; Wed, 10 Jan 2024 19:41:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E7F9D3858036 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=gcc.gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E7F9D3858036 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.177.146 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704915667; cv=none; b=q0rDCo7uwKEeGf7LCnVIOdU1R5c2b3G4cxg2jSKTbfk0NnylooeGtOxFMBCu146SXHSmZDrL3yo8HAPcLN2uR/wOsrhnOKc5uD7PpJEXMspNGNOQoPWsK1UhwTxngV/379xGLxdgY/znOapczfDYjwKwQ65Q+E7BC1szJS5xW0A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704915667; c=relaxed/simple; bh=nlvkwJQosUyV07pbOUuNIEfSIOQNxQsHRobdL268ZJQ=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=WmOLw/KgxkvrN0Gxme6FsiYL8RBwBbisK1VSXsCDvuzA92X+9lxbTgLe47eBTWwDnmgnmyKL/wi5I9KFsmLJSqzkbPcqMbJC5PrZEfvS+AIehu6LvHmilers37Q6tjbqrAFcsEd+aj10tZowGfVVED1qeZRTbBL120FZ09UK3hI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0247478.ppops.net [127.0.0.1]) by mx0a-00641c01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 40AJdeEL025273; Wed, 10 Jan 2024 19:41:04 GMT Received: from mxout23.cac.washington.edu (mxout23.cac.washington.edu [140.142.32.140]) by mx0a-00641c01.pphosted.com (PPS) with ESMTPS id 3vj0g38ptd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Jan 2024 19:41:04 +0000 Received: from smtp.washington.edu (smtp.washington.edu [128.208.60.54]) by mxout23.cac.washington.edu (8.14.4+UW20.07/8.14.4+UW22.04) with ESMTP id 40AJeghx027801 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 10 Jan 2024 11:40:42 -0800 X-Auth-Received: from kmatsui-ThinkPad-X1-Carbon-Gen-9.dhcp4.washington.edu ([10.154.74.143]) (authenticated authid=kmatsui) by smtp.washington.edu (8.16.1+UW21.10/8.14.4+UW19.10) with ESMTPSA id 40AJefnH020412 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Jan 2024 11:40:42 -0800 X-UW-Orig-Sender: kmatsui@smtp.washington.edu From: Ken Matsui <kmatsui@gcc.gnu.org> To: gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org, Ken Matsui <kmatsui@gcc.gnu.org> Subject: [PATCH 08/14] libstdc++: Optimize std::is_compound compilation performance Date: Wed, 10 Jan 2024 01:22:59 -0800 Message-ID: <20240110194031.2384005-9-kmatsui@gcc.gnu.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240110194031.2384005-1-kmatsui@gcc.gnu.org> References: <20240110194031.2384005-1-kmatsui@gcc.gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: as5GvjQni_Eil-rUwutrcjolzf0WhY48 X-Proofpoint-GUID: as5GvjQni_Eil-rUwutrcjolzf0WhY48 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-10_10,2024-01-10_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 malwarescore=0 spamscore=0 clxscore=1034 priorityscore=1501 adultscore=0 mlxscore=0 lowpriorityscore=0 bulkscore=0 mlxlogscore=354 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401100156 X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DATE_IN_PAST_06_12, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787733916702928012 X-GMAIL-MSGID: 1787733916702928012 |
Series |
Optimize integral-related type traits
|
|
Checks
Context | Check | Description |
---|---|---|
snail/gcc-patch-check | warning | Git am fail log |
Commit Message
Ken Matsui
Jan. 10, 2024, 9:22 a.m. UTC
This patch optimizes the compilation performance of std::is_compound
by dispatching to the new __is_arithmetic built-in trait.
libstdc++-v3/ChangeLog:
* include/std/type_traits (is_compound): Do not use __not_.
(is_compound_v): Use is_fundamental_v instead.
Signed-off-by: Ken Matsui <kmatsui@gcc.gnu.org>
---
libstdc++-v3/include/std/type_traits | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On Wed, 10 Jan 2024 at 19:41, Ken Matsui <kmatsui@gcc.gnu.org> wrote: > > This patch optimizes the compilation performance of std::is_compound > by dispatching to the new __is_arithmetic built-in trait. OK for trunk (no need to wait for anything else to be approved). > > libstdc++-v3/ChangeLog: > > * include/std/type_traits (is_compound): Do not use __not_. > (is_compound_v): Use is_fundamental_v instead. > > Signed-off-by: Ken Matsui <kmatsui@gcc.gnu.org> > --- > libstdc++-v3/include/std/type_traits | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits > index 1c560d97e85..6294f5af533 100644 > --- a/libstdc++-v3/include/std/type_traits > +++ b/libstdc++-v3/include/std/type_traits > @@ -784,7 +784,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > /// is_compound > template<typename _Tp> > struct is_compound > - : public __not_<is_fundamental<_Tp>>::type { }; > + : public __bool_constant<!is_fundamental<_Tp>::value> { }; > > /// is_member_pointer > #if _GLIBCXX_USE_BUILTIN_TRAIT(__is_member_pointer) > @@ -3358,7 +3358,7 @@ template <typename _Tp> > template <typename _Tp> > inline constexpr bool is_scalar_v = is_scalar<_Tp>::value; > template <typename _Tp> > - inline constexpr bool is_compound_v = is_compound<_Tp>::value; > + inline constexpr bool is_compound_v = !is_fundamental_v<_Tp>; > > #if _GLIBCXX_USE_BUILTIN_TRAIT(__is_member_pointer) > template <typename _Tp> > -- > 2.43.0 >
On 01-10 (21:21), Jonathan Wakely wrote: > On Wed, 10 Jan 2024 at 19:41, Ken Matsui <kmatsui@gcc.gnu.org> wrote: > > > > This patch optimizes the compilation performance of std::is_compound > > by dispatching to the new __is_arithmetic built-in trait. > > OK for trunk (no need to wait for anything else to be approved). > Thank you for your all reviews! This commit message is not quite accurate, so I will update it before committing. > > > > libstdc++-v3/ChangeLog: > > > > * include/std/type_traits (is_compound): Do not use __not_. > > (is_compound_v): Use is_fundamental_v instead. > > > > Signed-off-by: Ken Matsui <kmatsui@gcc.gnu.org> > > --- > > libstdc++-v3/include/std/type_traits | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits > > index 1c560d97e85..6294f5af533 100644 > > --- a/libstdc++-v3/include/std/type_traits > > +++ b/libstdc++-v3/include/std/type_traits > > @@ -784,7 +784,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > > /// is_compound > > template<typename _Tp> > > struct is_compound > > - : public __not_<is_fundamental<_Tp>>::type { }; > > + : public __bool_constant<!is_fundamental<_Tp>::value> { }; > > > > /// is_member_pointer > > #if _GLIBCXX_USE_BUILTIN_TRAIT(__is_member_pointer) > > @@ -3358,7 +3358,7 @@ template <typename _Tp> > > template <typename _Tp> > > inline constexpr bool is_scalar_v = is_scalar<_Tp>::value; > > template <typename _Tp> > > - inline constexpr bool is_compound_v = is_compound<_Tp>::value; > > + inline constexpr bool is_compound_v = !is_fundamental_v<_Tp>; > > > > #if _GLIBCXX_USE_BUILTIN_TRAIT(__is_member_pointer) > > template <typename _Tp> > > -- > > 2.43.0 > > >
diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits index 1c560d97e85..6294f5af533 100644 --- a/libstdc++-v3/include/std/type_traits +++ b/libstdc++-v3/include/std/type_traits @@ -784,7 +784,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION /// is_compound template<typename _Tp> struct is_compound - : public __not_<is_fundamental<_Tp>>::type { }; + : public __bool_constant<!is_fundamental<_Tp>::value> { }; /// is_member_pointer #if _GLIBCXX_USE_BUILTIN_TRAIT(__is_member_pointer) @@ -3358,7 +3358,7 @@ template <typename _Tp> template <typename _Tp> inline constexpr bool is_scalar_v = is_scalar<_Tp>::value; template <typename _Tp> - inline constexpr bool is_compound_v = is_compound<_Tp>::value; + inline constexpr bool is_compound_v = !is_fundamental_v<_Tp>; #if _GLIBCXX_USE_BUILTIN_TRAIT(__is_member_pointer) template <typename _Tp>