| Message ID | 20221121075358.76582-1-luca.weiss@fairphone.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp1442640wrr;
Sun, 20 Nov 2022 23:56:52 -0800 (PST)
X-Google-Smtp-Source:
AA0mqf60K2xoiKILGvjUPk4hvGFlmirB88Oe+OuPwQqeCjJCLRYYHeDHyj8O1Z0QBw4dpWhWSxqi
X-Received: by 2002:a17:906:c40d:b0:7af:1534:73c9 with SMTP id
u13-20020a170906c40d00b007af153473c9mr14344574ejz.558.1669017412761;
Sun, 20 Nov 2022 23:56:52 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1669017412; cv=none;
d=google.com; s=arc-20160816;
b=D4x8w9q6Wt1FbTpCbwWaK+tl6w8FNBl2fxHYI8bOvTTKE5Zz7e9uF9sojX1tbvubvf
CZT4OgAzcfhINXAtjiQPA0n/MNv7jbJElfDvOL/NGmR0jzOJJIpLXbsup01yhB3/z6og
CSDSdzvG0Wa22/p+jZog+BDrA62ODKvpWc00wDD+Eq+72Q/OvQf7l22sl6zGriC0G3LL
Sv9vNV3VxgagEKrLScJg5ziKLXjlP1IZuQIhKWgCTR7W4BDs4R6trbsAB3v3KE5taPOs
uhTUJ6lAyIlNPF5ptKLi+NPKAqmESMj4VH2COWUJOPU2+6xWQju889SrdRP/WiFSZcd6
/96Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=GT9ErDbClBtlo66hqT2klzySCTqQIgR/TIVfNl1Gg+Y=;
b=ybnazDzFkL19aOzzo72QrW24dXAUDiTQ9zdp9LUomFjRmqYRZFNU0s0qSxVTMZfkrq
cUTnOzeS6soJrnyqv8McVOYwZiP0pMU2prBkyYKWGgHM/0UFXxJSDa8oCVpP0iidNA08
jo9YhD9DwZN/pqkn2f3iL+rSV342lZ3jhJsk6XND54PwMEAk91GATYaUSPwaUcruvE+p
mVqXXjBAidso3EIpB4RkQCc5VALf8BappnpY0ZuUj+T5EMTasf2Onu6MvL1Z+MFls+AF
vacAbe+cc4oM6XI5YKfPYM/BTJd9Ttq1AwBrG5wxpwmO1rY4ppgR85KQ74jSpv2M571J
x8LA==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@fairphone.com header.s=fair header.b=O8QBYlAG;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fairphone.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
dm8-20020a170907948800b007add150c78bsi9281556ejc.216.2022.11.20.23.56.28;
Sun, 20 Nov 2022 23:56:52 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@fairphone.com header.s=fair header.b=O8QBYlAG;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fairphone.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229653AbiKUHyg (ORCPT <rfc822;peter110.wang@gmail.com>
+ 99 others); Mon, 21 Nov 2022 02:54:36 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59114 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229995AbiKUHyT (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Mon, 21 Nov 2022 02:54:19 -0500
Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com
[IPv6:2a00:1450:4864:20::62d])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 084D86B9D9
for <linux-kernel@vger.kernel.org>;
Sun, 20 Nov 2022 23:54:06 -0800 (PST)
Received: by mail-ej1-x62d.google.com with SMTP id ft34so26463321ejc.12
for <linux-kernel@vger.kernel.org>;
Sun, 20 Nov 2022 23:54:05 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=fairphone.com; s=fair;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=GT9ErDbClBtlo66hqT2klzySCTqQIgR/TIVfNl1Gg+Y=;
b=O8QBYlAGTTApUL6TLXRC+RdaXgjr6tjZq/PDzzK6ry8Y4u+YJOmeMB5Bn7NTt1qSBi
Fukr5kVtdZ4oP8jT3o5Y4ig2M23vgoSWxqsEKX17jKqWA1nakj+jDvHCYj3zVMtgXt4L
6w3BeLQUjC/HSQg6TnRYqaWM1WO8NI8d0YViYJ+vy0UvKzyKtMySsWpp99tt08PwS7Vh
0/xED8W60TuQkxU12/G2BNND3IPn28OjtYxeXPDUHtbs4zYNN81rhzun5rLMy8kSU1GK
QygY7zjiZdOTBVHWAttgYDOf2YlF1/SdqxTmuvWrr2LRwf4fhLC8LAIsuE8j8fh1D7Fu
RzQg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=GT9ErDbClBtlo66hqT2klzySCTqQIgR/TIVfNl1Gg+Y=;
b=RzSf/wWT5u82M6AKyIq3uUR/44ShpnHC4M3fRmIxwStaJTKTeqogQGv1SKoLMDXfHk
baLWybtnP/4GcNHtlicDOC4rlyUddN8OUQSVQNBrtwhP/o0LmGt45qbDSWrQ7EInNuSP
zT7dFidgivyRfsthelXK/1dTV9x6qPPXBmWcMiJvfkks2Iw9rZmKHQ2RSqyxtQzcX/om
sqeZ9JxD4Y1IqTi9PB8H+mMuDcpiSUI2+HU0x4lPGlh1j4D9nxbzRiYPfKRRG0Arp1ls
JMOs5f1RzA65FAtSMCx7IScWpODBNssefMHQuiU2oUw36DSCrrc25mo1WSJ2cel7eb/x
KBYQ==
X-Gm-Message-State: ANoB5pnm5gMOBXQEbhiS88BfGBuNsZZhegoVo21w+wDMom5QcGX5Esa8
9Djizs/MKRKFQY98/+ht6VcgQg==
X-Received: by 2002:a17:906:2804:b0:78d:e7c0:a2b with SMTP id
r4-20020a170906280400b0078de7c00a2bmr14766006ejc.273.1669017244575;
Sun, 20 Nov 2022 23:54:04 -0800 (PST)
Received: from otso.. (144-178-202-138.static.ef-service.nl.
[144.178.202.138])
by smtp.gmail.com with ESMTPSA id
o11-20020a170906860b00b007ad4a555499sm4700805ejx.204.2022.11.20.23.54.03
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sun, 20 Nov 2022 23:54:04 -0800 (PST)
From: Luca Weiss <luca.weiss@fairphone.com>
To: linux-arm-msm@vger.kernel.org
Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org,
Luca Weiss <luca.weiss@fairphone.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Wesley Cheng <quic_wcheng@quicinc.com>,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/3] dt-bindings: phy: qcom,qmp-usb3-dp: Add sm6350 compatible
Date: Mon, 21 Nov 2022 08:53:55 +0100
Message-Id: <20221121075358.76582-1-luca.weiss@fairphone.com>
X-Mailer: git-send-email 2.38.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1750091602856032799?=
X-GMAIL-MSGID: =?utf-8?q?1750091602856032799?=
|
| Series |
[1/3] dt-bindings: phy: qcom,qmp-usb3-dp: Add sm6350 compatible
|
|
Commit Message
Luca Weiss
Nov. 21, 2022, 7:53 a.m. UTC
Add the compatible describing the combo phy found on SM6350.
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml | 1 +
1 file changed, 1 insertion(+)
Comments
On Mon, Nov 21, 2022 at 08:53:55AM +0100, Luca Weiss wrote: > Add the compatible describing the combo phy found on SM6350. > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > --- > Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml > index 97a7ecafbf85..68aecb638870 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml > @@ -18,6 +18,7 @@ properties: > - qcom,sc8180x-qmp-usb3-dp-phy > - qcom,sc8280xp-qmp-usb43dp-phy > - qcom,sdm845-qmp-usb3-dp-phy > + - qcom,sm6350-qmp-usb3-dp-phy > - qcom,sm8250-qmp-usb3-dp-phy > reg: > items: The current USB3-DP bindings are broken and we should no be adding further compatibles here. Please consider rebasing on: https://lore.kernel.org/all/20221115144005.2478-1-johan+linaro@kernel.org/ Johan
Hi Johan, On Mon Nov 21, 2022 at 9:07 AM CET, Johan Hovold wrote: > On Mon, Nov 21, 2022 at 08:53:55AM +0100, Luca Weiss wrote: > > Add the compatible describing the combo phy found on SM6350. > > > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > > --- > > Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml > > index 97a7ecafbf85..68aecb638870 100644 > > --- a/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml > > +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml > > @@ -18,6 +18,7 @@ properties: > > - qcom,sc8180x-qmp-usb3-dp-phy > > - qcom,sc8280xp-qmp-usb43dp-phy > > - qcom,sdm845-qmp-usb3-dp-phy > > + - qcom,sm6350-qmp-usb3-dp-phy > > - qcom,sm8250-qmp-usb3-dp-phy > > reg: > > items: > > The current USB3-DP bindings are broken and we should no be adding > further compatibles here. Please consider rebasing on: > > https://lore.kernel.org/all/20221115144005.2478-1-johan+linaro@kernel.org/ I'm not quite clear what you want me to do. Just rebase this change on top of your patchset and resend or something else? Regards Luca > > Johan
On Tue, Nov 22, 2022 at 08:55:31AM +0100, Luca Weiss wrote: > Hi Johan, > > On Mon Nov 21, 2022 at 9:07 AM CET, Johan Hovold wrote: > > On Mon, Nov 21, 2022 at 08:53:55AM +0100, Luca Weiss wrote: > > > Add the compatible describing the combo phy found on SM6350. > > > > > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > > > --- > > > Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml > > > index 97a7ecafbf85..68aecb638870 100644 > > > --- a/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml > > > +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml > > > @@ -18,6 +18,7 @@ properties: > > > - qcom,sc8180x-qmp-usb3-dp-phy > > > - qcom,sc8280xp-qmp-usb43dp-phy > > > - qcom,sdm845-qmp-usb3-dp-phy > > > + - qcom,sm6350-qmp-usb3-dp-phy > > > - qcom,sm8250-qmp-usb3-dp-phy > > > reg: > > > items: > > > > The current USB3-DP bindings are broken and we should no be adding > > further compatibles here. Please consider rebasing on: > > > > https://lore.kernel.org/all/20221115144005.2478-1-johan+linaro@kernel.org/ > > I'm not quite clear what you want me to do. Just rebase this change on > top of your patchset and resend or something else? Yes, you should rebase this series on top of the above, add qcom,sm6350-qmp-usb3-dp-phy to the new (sc8280xp) schema, add a register offset table for QMP v3 to the PHY driver, and update the dts. Note that the USB/DP configuration structures have been merged (and some config fields have already been removed in linux-next). Johan
diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml index 97a7ecafbf85..68aecb638870 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml @@ -18,6 +18,7 @@ properties: - qcom,sc8180x-qmp-usb3-dp-phy - qcom,sc8280xp-qmp-usb43dp-phy - qcom,sdm845-qmp-usb3-dp-phy + - qcom,sm6350-qmp-usb3-dp-phy - qcom,sm8250-qmp-usb3-dp-phy reg: items: