Message ID | 20240109171950.31010-9-afd@ti.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-21163-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2411:b0:101:2151:f287 with SMTP id m17csp262895dyi; Tue, 9 Jan 2024 09:22:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IEzdx6rcpKr5A941xgRMNCsgYD5mjuqLUU/83Nd0KZcIL67+2/dwtZqyBArrpykeA21UM2Y X-Received: by 2002:a50:d75e:0:b0:558:15f2:6b4d with SMTP id i30-20020a50d75e000000b0055815f26b4dmr594167edj.51.1704820967469; Tue, 09 Jan 2024 09:22:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704820967; cv=none; d=google.com; s=arc-20160816; b=agIv2p1IHSqELuVsDNmHokgkaQqT2YZCp8XGzXNMhooPv3pSm9dTAEztHaIAGfJ+R6 7YKmJh2XkqB3cuyFriaoD/O9nXyXMvc72gzkNHUrWJ//GhreGoo+a6UZxqoTKipOPepZ BEnLaL62r7yPDM6EtYShdMchFirXXDDF+u7dsMbjOKUzh4eL+R+a589aShbp28U8U+m6 6w8qsAo6B6ATp1+w4zsUcTPWczb0jr2wMjbDz69pNbF6eN6aAEI6Xc/kHoTFC0GUDGg9 7RXaBHeVfi3XMsHix2huG+t+Ub3d7ZXkICtF6kqSVSwgqoCSEpAbYDOpv56u3E4ctXKC fsUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=/A8F7GnR9icPmLdv2WR17zNBw67OAAXurt/PLePpvhA=; fh=ZG1o7912NHLwbBkHH0z+Slv6fuXpoDUZHQaf9q8LDGE=; b=BkvAQxBJEKiDczQQnmQP4XJihSvuJjw19Ki9u25pDyawyeJeZR6LVAJ7VZeZmU69p3 7Ox2EzdSgQn5aJ4tp2HS3yDbplUyWc76dfOVwad7YH5RwKxuYtagnsJmctM9d5PkHUkZ XXeOED3Wrl4N5JMRP6EVFsRCXtDnNuYf98xX28BRvyrJdZkpMGigOd5+1TIZsU+Wg93K VQUnyM/9uDjplAtNAN8RA/h3PntixXgcieDvOCjBGn3EaNlFpsnSsuQxits7KbD/taiX dfQnRrErdbsRLyGUm80yHKEqNG8gBu0a+rAYC2Tgqli6wgHFtEqE+k/SMOc4+IvQDtKN wobA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=LmE0wQiO; spf=pass (google.com: domain of linux-kernel+bounces-21163-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-21163-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id g9-20020a50d5c9000000b00557173ca427si918264edj.271.2024.01.09.09.22.47 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jan 2024 09:22:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-21163-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=LmE0wQiO; spf=pass (google.com: domain of linux-kernel+bounces-21163-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-21163-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 1839C1F24858 for <ouuuleilei@gmail.com>; Tue, 9 Jan 2024 17:22:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8A2943D55B; Tue, 9 Jan 2024 17:20:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="LmE0wQiO" Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 738963B293; Tue, 9 Jan 2024 17:20:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 409HJxbE123319; Tue, 9 Jan 2024 11:19:59 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1704820799; bh=/A8F7GnR9icPmLdv2WR17zNBw67OAAXurt/PLePpvhA=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=LmE0wQiOpOW7/7f0TnqOukOxuxjo8rWFnW/2bfX9Z9XZ4qvHS7RfPBtTz01kTzRwp 8t4LNsQV+OG5uugH7Ew/9gIrvju7lycZ21PbX6L7aPtsOFKA6bZXyki+KEjoY+GR2v FgA6NdnKB/BicxUA73RY2XLNzFkJOEdWxIu5+e+k= Received: from DLEE108.ent.ti.com (dlee108.ent.ti.com [157.170.170.38]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 409HJxoF053360 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 9 Jan 2024 11:19:59 -0600 Received: from DLEE112.ent.ti.com (157.170.170.23) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 9 Jan 2024 11:19:59 -0600 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 9 Jan 2024 11:19:59 -0600 Received: from lelvsmtp5.itg.ti.com ([10.249.40.136]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 409HJouD089645; Tue, 9 Jan 2024 11:19:58 -0600 From: Andrew Davis <afd@ti.com> To: Frank Binns <frank.binns@imgtec.com>, Matt Coster <matt.coster@imgtec.com>, "H . Nikolaus Schaller" <hns@goldelico.com>, Adam Ford <aford173@gmail.com>, Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Samuel Holland <samuel@sholland.org>, =?utf-8?q?Beno=C3=AEt_Cousson?= <bcousson@baylibre.com>, Tony Lindgren <tony@atomide.com>, Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>, Tero Kristo <kristo@kernel.org>, Paul Cercueil <paul@crapouillou.net> CC: <dri-devel@lists.freedesktop.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-sunxi@lists.linux.dev>, <linux-omap@vger.kernel.org>, <linux-mips@vger.kernel.org>, Andrew Davis <afd@ti.com> Subject: [PATCH 08/11] ARM: dts: DRA7xx: Add device tree entry for SGX GPU Date: Tue, 9 Jan 2024 11:19:47 -0600 Message-ID: <20240109171950.31010-9-afd@ti.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240109171950.31010-1-afd@ti.com> References: <20240109171950.31010-1-afd@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787634351253736710 X-GMAIL-MSGID: 1787634351253736710 |
Series |
Device tree support for Imagination Series5 GPU
|
|
Commit Message
Andrew Davis
Jan. 9, 2024, 5:19 p.m. UTC
Add SGX GPU device entry to base DRA7x dtsi file. Signed-off-by: Andrew Davis <afd@ti.com> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> --- arch/arm/boot/dts/ti/omap/dra7.dtsi | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
Comments
* Andrew Davis <afd@ti.com> [240109 17:20]: > --- a/arch/arm/boot/dts/ti/omap/dra7.dtsi > +++ b/arch/arm/boot/dts/ti/omap/dra7.dtsi > @@ -850,12 +850,19 @@ target-module@56000000 { > <SYSC_IDLE_SMART>; > ti,sysc-sidle = <SYSC_IDLE_FORCE>, > <SYSC_IDLE_NO>, > - <SYSC_IDLE_SMART>; > + <SYSC_IDLE_SMART>, > + <SYSC_IDLE_SMART_WKUP>; You probably checked this already.. But just in case, can you please confirm this is intentional. The documentation lists the smart wakeup capability bit as reserved for dra7, maybe the documentation is wrong. Regards, Tony
On 1/10/24 2:29 AM, Tony Lindgren wrote: > * Andrew Davis <afd@ti.com> [240109 17:20]: >> --- a/arch/arm/boot/dts/ti/omap/dra7.dtsi >> +++ b/arch/arm/boot/dts/ti/omap/dra7.dtsi >> @@ -850,12 +850,19 @@ target-module@56000000 { >> <SYSC_IDLE_SMART>; >> ti,sysc-sidle = <SYSC_IDLE_FORCE>, >> <SYSC_IDLE_NO>, >> - <SYSC_IDLE_SMART>; >> + <SYSC_IDLE_SMART>, >> + <SYSC_IDLE_SMART_WKUP>; > > You probably checked this already.. But just in case, can you please > confirm this is intentional. The documentation lists the smart wakeup > capability bit as reserved for dra7, maybe the documentation is wrong. > It was an intentional change, although I'm not sure it is correct :) This is how we had it in our "evil vendor tree" for years (back when it was hwmod based), so when converting these nodes to use "ti,sysc" I noticed this bit was set, but as you point out the documentation disagrees. I'd rather go with what has worked before, but it doesn't seem to break anything either way, so we could also break this change out into its own patch if you would prefer. Andrew > Regards, > > Tony >
* Andrew Davis <afd@ti.com> [240117 15:52]: > On 1/10/24 2:29 AM, Tony Lindgren wrote: > > * Andrew Davis <afd@ti.com> [240109 17:20]: > > > --- a/arch/arm/boot/dts/ti/omap/dra7.dtsi > > > +++ b/arch/arm/boot/dts/ti/omap/dra7.dtsi > > > @@ -850,12 +850,19 @@ target-module@56000000 { > > > <SYSC_IDLE_SMART>; > > > ti,sysc-sidle = <SYSC_IDLE_FORCE>, > > > <SYSC_IDLE_NO>, > > > - <SYSC_IDLE_SMART>; > > > + <SYSC_IDLE_SMART>, > > > + <SYSC_IDLE_SMART_WKUP>; > > > > You probably checked this already.. But just in case, can you please > > confirm this is intentional. The documentation lists the smart wakeup > > capability bit as reserved for dra7, maybe the documentation is wrong. > > > > It was an intentional change, although I'm not sure it is correct :) > > This is how we had it in our "evil vendor tree" for years (back when it > was hwmod based), so when converting these nodes to use "ti,sysc" I noticed > this bit was set, but as you point out the documentation disagrees. > > I'd rather go with what has worked before, but it doesn't seem to > break anything either way, so we could also break this change out into > its own patch if you would prefer. I agree it's best to stick what is known to work. How about let's add the related information to the patch description? Regards, Tony
* Tony Lindgren <tony@atomide.com> [240118 08:57]: > * Andrew Davis <afd@ti.com> [240117 15:52]: > > On 1/10/24 2:29 AM, Tony Lindgren wrote: > > > * Andrew Davis <afd@ti.com> [240109 17:20]: > > > > --- a/arch/arm/boot/dts/ti/omap/dra7.dtsi > > > > +++ b/arch/arm/boot/dts/ti/omap/dra7.dtsi > > > > @@ -850,12 +850,19 @@ target-module@56000000 { > > > > <SYSC_IDLE_SMART>; > > > > ti,sysc-sidle = <SYSC_IDLE_FORCE>, > > > > <SYSC_IDLE_NO>, > > > > - <SYSC_IDLE_SMART>; > > > > + <SYSC_IDLE_SMART>, > > > > + <SYSC_IDLE_SMART_WKUP>; > > > > > > You probably checked this already.. But just in case, can you please > > > confirm this is intentional. The documentation lists the smart wakeup > > > capability bit as reserved for dra7, maybe the documentation is wrong. > > > > > > > It was an intentional change, although I'm not sure it is correct :) > > > > This is how we had it in our "evil vendor tree" for years (back when it > > was hwmod based), so when converting these nodes to use "ti,sysc" I noticed > > this bit was set, but as you point out the documentation disagrees. > > > > I'd rather go with what has worked before, but it doesn't seem to > > break anything either way, so we could also break this change out into > > its own patch if you would prefer. > > I agree it's best to stick what is known to work. How about let's add > the related information to the patch description? I'll update the commit message for it and apply these, no need to repost. Regards, Tony
diff --git a/arch/arm/boot/dts/ti/omap/dra7.dtsi b/arch/arm/boot/dts/ti/omap/dra7.dtsi index 6509c742fb58c..8527643cb69a8 100644 --- a/arch/arm/boot/dts/ti/omap/dra7.dtsi +++ b/arch/arm/boot/dts/ti/omap/dra7.dtsi @@ -850,12 +850,19 @@ target-module@56000000 { <SYSC_IDLE_SMART>; ti,sysc-sidle = <SYSC_IDLE_FORCE>, <SYSC_IDLE_NO>, - <SYSC_IDLE_SMART>; + <SYSC_IDLE_SMART>, + <SYSC_IDLE_SMART_WKUP>; clocks = <&gpu_clkctrl DRA7_GPU_CLKCTRL 0>; clock-names = "fck"; #address-cells = <1>; #size-cells = <1>; ranges = <0 0x56000000 0x2000000>; + + gpu@0 { + compatible = "ti,am5728-gpu", "img,powervr-sgx544"; + reg = <0x0 0x10000>; /* 64kB */ + interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>; + }; }; crossbar_mpu: crossbar@4a002a48 {