Message ID | 20240109171950.31010-2-afd@ti.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-21162-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2411:b0:101:2151:f287 with SMTP id m17csp267933dyi; Tue, 9 Jan 2024 09:31:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IEM42f15kaxmThIs3lg+NvVGTX9SDmOmWIaQsDtci73fWJ7hEi+hHBBy96KfxC7inA0r7kp X-Received: by 2002:a05:6e02:b4a:b0:35f:c959:6404 with SMTP id f10-20020a056e020b4a00b0035fc9596404mr7899265ilu.113.1704821490758; Tue, 09 Jan 2024 09:31:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704821490; cv=none; d=google.com; s=arc-20160816; b=K7C6cb7hOUNawu9FdUhXjKMWQm854WBzJL6HQg75QXVZNtjD9P+7hyLmoc1KSRywdP HvEQ00v2+cw9c0Y+Kdw8emvGOlnWH7KX+g7lv4tw/TB4WoJ2Eu2zkBQMq75iVnqFuvpw vM/2K6umnHNlK9bnmxCP2e9qOEIawzaEhClkPN9iQ1CqATPpLePW/4aPVMju8brJD4Sm +NcOCyYSTKx/7TlG2M6ci7oydy08SBdra+hzcOCna8f+/KmJgasOdVITa0M8JWlZT8/N C8VLxcMC8v9GwWbtONBkv4GwT/6W21+AGkxXYkWQz9bVa/jYj0cpxxxUVudP0QHQ1K5l q1AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=epFNXejMFGFMpNlRz8xyTT1KBYbxImqO/bjKUiAjdE0=; fh=ZG1o7912NHLwbBkHH0z+Slv6fuXpoDUZHQaf9q8LDGE=; b=qtg6eyR0IybmxJ4poN/EKrfIk2UrWItqXJzXWx3RrpoHlrIFw1MD2aSzmUT8nQvFGz 2ENHQe7kBDEf0Nz1N36GA0hMB83JcTfJ1c9TxnF+864YfjUlucSvqE2oN3z/V16yJfxe SlLOLCndbqCFpny1iJiFasL8hza2Q5U1dCpyxdOHoRsagrd9DtBMfMkO9Nr3H9ejrfHL A4QxvVe6tT0ARhRspU28xiQ6B/ooC46EceuFC6iUO3DIT01igV0UXGmiqIMMDucFJIov ++HO+RFNlNfqeQ13bU9I17KSR7sSVLaEOnlkx+LoYHKlAjfG3OJqurI9eSyh1DgFbbAu 0HRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=n3pIoV3P; spf=pass (google.com: domain of linux-kernel+bounces-21162-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-21162-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id g24-20020a633758000000b005ce12225e6bsi1740013pgn.210.2024.01.09.09.31.30 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jan 2024 09:31:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-21162-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=n3pIoV3P; spf=pass (google.com: domain of linux-kernel+bounces-21162-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-21162-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 3F76028227E for <ouuuleilei@gmail.com>; Tue, 9 Jan 2024 17:31:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 42F0A3D397; Tue, 9 Jan 2024 17:20:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="n3pIoV3P" Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 297A23AC25; Tue, 9 Jan 2024 17:20:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 409HJrKq123263; Tue, 9 Jan 2024 11:19:53 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1704820793; bh=epFNXejMFGFMpNlRz8xyTT1KBYbxImqO/bjKUiAjdE0=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=n3pIoV3PWgN7Xoj4xyq1OqcOfErt7tB1Zm+7YLRJF+RuH9O92swROIPgs4JVirbK5 ndy+2lBkrRucOJ3aAJSPqiWEU2PMbnJ67eHOOzr54QCwFLM1H6o9neFqpa9v1MKu3t VK7z4pV9SbPINi4uQzzOB4Ifv+2ywzvSwyWtLbbc= Received: from DFLE113.ent.ti.com (dfle113.ent.ti.com [10.64.6.34]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 409HJrP8127656 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 9 Jan 2024 11:19:53 -0600 Received: from DFLE110.ent.ti.com (10.64.6.31) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 9 Jan 2024 11:19:52 -0600 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 9 Jan 2024 11:19:52 -0600 Received: from lelvsmtp5.itg.ti.com ([10.249.40.136]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 409HJou6089645; Tue, 9 Jan 2024 11:19:52 -0600 From: Andrew Davis <afd@ti.com> To: Frank Binns <frank.binns@imgtec.com>, Matt Coster <matt.coster@imgtec.com>, "H . Nikolaus Schaller" <hns@goldelico.com>, Adam Ford <aford173@gmail.com>, Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Samuel Holland <samuel@sholland.org>, =?utf-8?q?Beno=C3=AEt_Cousson?= <bcousson@baylibre.com>, Tony Lindgren <tony@atomide.com>, Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>, Tero Kristo <kristo@kernel.org>, Paul Cercueil <paul@crapouillou.net> CC: <dri-devel@lists.freedesktop.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-sunxi@lists.linux.dev>, <linux-omap@vger.kernel.org>, <linux-mips@vger.kernel.org>, Andrew Davis <afd@ti.com> Subject: [PATCH 01/11] dt-bindings: gpu: Rename img,powervr to img,powervr-rogue Date: Tue, 9 Jan 2024 11:19:40 -0600 Message-ID: <20240109171950.31010-2-afd@ti.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240109171950.31010-1-afd@ti.com> References: <20240109171950.31010-1-afd@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787634899937654215 X-GMAIL-MSGID: 1787634899937654215 |
Series |
Device tree support for Imagination Series5 GPU
|
|
Commit Message
Andrew Davis
Jan. 9, 2024, 5:19 p.m. UTC
This binding will be used for GPUs starting from Series6 (Rogue) and later. A different binding document will describe Series5. With that the name "img,powervr" is too generic, rename to "img,powervr-rogue" to avoid confusion. Suggested-by: Maxime Ripard <mripard@kernel.org> Signed-off-by: Andrew Davis <afd@ti.com> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Reviewed-by: Frank Binns <frank.binns@imgtec.com> --- .../bindings/gpu/{img,powervr.yaml => img,powervr-rogue.yaml} | 4 ++-- MAINTAINERS | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) rename Documentation/devicetree/bindings/gpu/{img,powervr.yaml => img,powervr-rogue.yaml} (91%)
Comments
On 09/01/2024 18:19, Andrew Davis wrote: > This binding will be used for GPUs starting from Series6 (Rogue) > and later. A different binding document will describe Series5. > With that the name "img,powervr" is too generic, rename to > "img,powervr-rogue" to avoid confusion. > > Suggested-by: Maxime Ripard <mripard@kernel.org> > Signed-off-by: Andrew Davis <afd@ti.com> > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> > Reviewed-by: Frank Binns <frank.binns@imgtec.com> > --- Why do you send new version while we still talk about previous? Please implement feedback from v1 (and this is v2, so next is v3) or keep discussing. Best regards, Krzysztof
On 1/9/24 12:59 PM, Krzysztof Kozlowski wrote: > On 09/01/2024 18:19, Andrew Davis wrote: >> This binding will be used for GPUs starting from Series6 (Rogue) >> and later. A different binding document will describe Series5. >> With that the name "img,powervr" is too generic, rename to >> "img,powervr-rogue" to avoid confusion. >> >> Suggested-by: Maxime Ripard <mripard@kernel.org> >> Signed-off-by: Andrew Davis <afd@ti.com> >> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> >> Reviewed-by: Frank Binns <frank.binns@imgtec.com> >> --- > > Why do you send new version while we still talk about previous? > > Please implement feedback from v1 (and this is v2, so next is v3) or > keep discussing. > I agreed with everything you said in the last round (RFC v2) and made all requested changes. Did I miss something in this version? Thanks, Andrew > Best regards, > Krzysztof >
On 09/01/2024 20:04, Andrew Davis wrote: > On 1/9/24 12:59 PM, Krzysztof Kozlowski wrote: >> On 09/01/2024 18:19, Andrew Davis wrote: >>> This binding will be used for GPUs starting from Series6 (Rogue) >>> and later. A different binding document will describe Series5. >>> With that the name "img,powervr" is too generic, rename to >>> "img,powervr-rogue" to avoid confusion. >>> >>> Suggested-by: Maxime Ripard <mripard@kernel.org> >>> Signed-off-by: Andrew Davis <afd@ti.com> >>> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> >>> Reviewed-by: Frank Binns <frank.binns@imgtec.com> >>> --- >> >> Why do you send new version while we still talk about previous? >> >> Please implement feedback from v1 (and this is v2, so next is v3) or >> keep discussing. >> > > I agreed with everything you said in the last round (RFC v2) and > made all requested changes. Did I miss something in this version? The recommendation is that naming of the file matches generic compatible and your file has only one generic compatible. Therefore I don't understand why you claimed there are multiple compatibles. Best regards, Krzysztof
On 1/9/24 1:17 PM, Krzysztof Kozlowski wrote: > On 09/01/2024 20:04, Andrew Davis wrote: >> On 1/9/24 12:59 PM, Krzysztof Kozlowski wrote: >>> On 09/01/2024 18:19, Andrew Davis wrote: >>>> This binding will be used for GPUs starting from Series6 (Rogue) >>>> and later. A different binding document will describe Series5. >>>> With that the name "img,powervr" is too generic, rename to >>>> "img,powervr-rogue" to avoid confusion. >>>> >>>> Suggested-by: Maxime Ripard <mripard@kernel.org> >>>> Signed-off-by: Andrew Davis <afd@ti.com> >>>> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> >>>> Reviewed-by: Frank Binns <frank.binns@imgtec.com> >>>> --- >>> >>> Why do you send new version while we still talk about previous? >>> >>> Please implement feedback from v1 (and this is v2, so next is v3) or >>> keep discussing. >>> >> >> I agreed with everything you said in the last round (RFC v2) and >> made all requested changes. Did I miss something in this version? > > The recommendation is that naming of the file matches generic compatible > and your file has only one generic compatible. Therefore I don't > understand why you claimed there are multiple compatibles. > I said "There are (or will be) multiple compatible strings", the rest are on the way. So I didn't want to make this file less generic when other bindings are almost ready. Frank, can you help here, I'm assuming you have "img,img-bxs" and "img,img-8xe" bindings staged for upstreaming somewhere; you'll be putting those in this same file, right? Thanks, Andrew > Best regards, > Krzysztof >
On 09/01/2024 20:33, Andrew Davis wrote: > On 1/9/24 1:17 PM, Krzysztof Kozlowski wrote: >> On 09/01/2024 20:04, Andrew Davis wrote: >>> On 1/9/24 12:59 PM, Krzysztof Kozlowski wrote: >>>> On 09/01/2024 18:19, Andrew Davis wrote: >>>>> This binding will be used for GPUs starting from Series6 (Rogue) >>>>> and later. A different binding document will describe Series5. >>>>> With that the name "img,powervr" is too generic, rename to >>>>> "img,powervr-rogue" to avoid confusion. >>>>> >>>>> Suggested-by: Maxime Ripard <mripard@kernel.org> >>>>> Signed-off-by: Andrew Davis <afd@ti.com> >>>>> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> >>>>> Reviewed-by: Frank Binns <frank.binns@imgtec.com> >>>>> --- >>>> >>>> Why do you send new version while we still talk about previous? >>>> >>>> Please implement feedback from v1 (and this is v2, so next is v3) or >>>> keep discussing. >>>> >>> >>> I agreed with everything you said in the last round (RFC v2) and >>> made all requested changes. Did I miss something in this version? >> >> The recommendation is that naming of the file matches generic compatible >> and your file has only one generic compatible. Therefore I don't >> understand why you claimed there are multiple compatibles. >> > > I said "There are (or will be) multiple compatible strings", the rest OK. > are on the way. So I didn't want to make this file less generic when > other bindings are almost ready. > > Frank, can you help here, I'm assuming you have "img,img-bxs" and > "img,img-8xe" bindings staged for upstreaming somewhere; you'll be > putting those in this same file, right? > That's fine then. Best regards, Krzysztof
On 09/01/2024 18:19, Andrew Davis wrote: > This binding will be used for GPUs starting from Series6 (Rogue) > and later. A different binding document will describe Series5. > With that the name "img,powervr" is too generic, rename to > "img,powervr-rogue" to avoid confusion. > > Suggested-by: Maxime Ripard <mripard@kernel.org> > Signed-off-by: Andrew Davis <afd@ti.com> > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> > Reviewed-by: Frank Binns <frank.binns@imgtec.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/gpu/img,powervr.yaml b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml similarity index 91% rename from Documentation/devicetree/bindings/gpu/img,powervr.yaml rename to Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml index a13298f1a1827..256e252f8087f 100644 --- a/Documentation/devicetree/bindings/gpu/img,powervr.yaml +++ b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml @@ -2,10 +2,10 @@ # Copyright (c) 2023 Imagination Technologies Ltd. %YAML 1.2 --- -$id: http://devicetree.org/schemas/gpu/img,powervr.yaml# +$id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: Imagination Technologies PowerVR and IMG GPU +title: Imagination Technologies PowerVR and IMG Rogue GPUs maintainers: - Frank Binns <frank.binns@imgtec.com> diff --git a/MAINTAINERS b/MAINTAINERS index bcacd665f2594..2a4e8d2c69c40 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10468,7 +10468,7 @@ M: Donald Robson <donald.robson@imgtec.com> M: Matt Coster <matt.coster@imgtec.com> S: Supported T: git git://anongit.freedesktop.org/drm/drm-misc -F: Documentation/devicetree/bindings/gpu/img,powervr.yaml +F: Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml F: Documentation/gpu/imagination/ F: drivers/gpu/drm/imagination/ F: include/uapi/drm/pvr_drm.h