[v2,1/2] dt-bindings: display: panel: panel-simple: Add compatible property for waveshare 7inch touchscreen panel
Message ID | 20240109070949.23957-2-shengyang.chen@starfivetech.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-20471-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:37c1:b0:101:2151:f287 with SMTP id y1csp1492282dyq; Mon, 8 Jan 2024 23:27:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IE6zOJx33eDadG55weG239XNkld35TPDNgE7Vf/8wAMQjlenGVY7dyCSLZClQFoe6KTyhXL X-Received: by 2002:a17:907:971a:b0:a23:49c4:3e89 with SMTP id jg26-20020a170907971a00b00a2349c43e89mr380856ejc.10.1704785258390; Mon, 08 Jan 2024 23:27:38 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1704785258; cv=pass; d=google.com; s=arc-20160816; b=p66hSEUm98wwKJpHHjbaXp7kPOmP/SC8OWbG4I5RXo89WvfSeEYVdaw27FfMesUA5e rE0k+hoxzzFA1zsTYYhYaXF5VlcADmMqSjqEfC0IVwfsxpi/JE39bgkNKzP6MPDDvCDQ pmLpaIy6KcetvacqCuEJXeCVK6ND9YN6S1wxo/hs6Afh7pYgTAvu+owwQmxz7vJYXv+s ngMJyEDtyvM/c+sD4jjoQuE7XmGSCRXtiOPQDhVEN18DmL/7Fx5fXc0ckHy4bT8t6cR+ APP16ZQ0eTlPza9arKLqgszWnajCF2dA/uHTNdj5vL2DU6bdNGiy1XkESNvAmCUguGVp 3N6Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:in-reply-to:message-id:date:subject:cc:to:from; bh=pHvQt90YSAOgZH+tF5NoT0NxAop9t+SbJupHJGljm8A=; fh=tiApDVwX1tV4UyMHBb6gVYzaS0NSWv3MtspnrfDqZ+I=; b=AiA9XtXbRKm7nd39SP4JhI0GTqmhtcp8K3G9j3BPv9k1XhM5W1XRwkoN7J1Jl0YCNv P5Jja0hMIfoiJqIxyUQScZvhldNF0xM5EVQ2qv0rMvFZgGt1i1QZ3aKJaiEGA/l51XCp c9AUVKghZM8+arjlHlGkbopFxoovltYKnNKJdZSPaMdGJfyoMT2BB6f4HX2LQSVsqPQL qBtUwXAddQ4qgGoCvwgZVoXHS7QHsQycxR1Jc90pOE0EcOKqHUzs6rzIp6t6jzjTY6/u hDcf5EpAaNsYSg6g3MRK9Y468YcNWgZ6ujglYbdUsRoaorir0cGkgjwHGj0SExxHa0Jk V5LA== ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=starfivetech.com dkim=pass dkdomain=starfivetech.com dmarc=pass fromdomain=starfivetech.com); spf=pass (google.com: domain of linux-kernel+bounces-20471-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-20471-ouuuleilei=gmail.com@vger.kernel.org" Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id v4-20020a1709062f0400b00a2b2ceba0cdsi529133eji.51.2024.01.08.23.27.38 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 23:27:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-20471-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=starfivetech.com dkim=pass dkdomain=starfivetech.com dmarc=pass fromdomain=starfivetech.com); spf=pass (google.com: domain of linux-kernel+bounces-20471-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-20471-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id D32211F26CFC for <ouuuleilei@gmail.com>; Tue, 9 Jan 2024 07:27:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D3B9E2420E; Tue, 9 Jan 2024 07:25:28 +0000 (UTC) Received: from CHN02-SH0-obe.outbound.protection.partner.outlook.cn (mail-sh0chn02on2089.outbound.protection.partner.outlook.cn [139.219.146.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8060125102; Tue, 9 Jan 2024 07:25:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=starfivetech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=starfivetech.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jcrh4rzlSrr3/TGLrqKwLQgo0a04FajpJs8Se6cfC4UK6TtilkVsKHaB5SeatCDVamLEflCxCjtTK73y39PGIgydJ1jEWtZQJuqM4so5o5P0GKFchKb+bDQsnsMZSao5FH4uMqIJrgi67DSUYED9pxv0B2jEdtfFfpptbXBOyoIFPUjR9dfvnOiHsANANkItZbRd9FFRhLqBstCrZoCoz0gLz9YG3CtyWYXhrOMlrfX3LvQx1k/zgc0eWM0bLONZnBmvwg8mexrKEyMkpHFqV/huXJewbGmNHwxC0uIwlm5NrjYGcCJ/Fmans6/Eb3QyI8lIPzwkcl8i1bKUEWshFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pHvQt90YSAOgZH+tF5NoT0NxAop9t+SbJupHJGljm8A=; b=kXqH1/KgaOd0r2l8QE66keOhoHd7MYXFWKv4zSP2KJPzaBeNe052+3F2Q40OX8y3UV1hnNRB72VAAfCYcKhIIamrp8oV7l5UOIPuNjGVKDnjq40eHiybuETFv2LBonEoFfZijLEXpCuK1CgU8oAg748x0fAk8XMDuiksL0dAvcjxkU6akhSkFdZuWjGExCr/vN3VjsoEQAA/7+3O6XMp6Ay04bDPSg5HIXH7Q+3ETh3BblzLNIYAg68JNS8CxxANkqvoW+9n/HbC2EeUHh9Lb3SthKGMrMyDPdDjD8d1f88u+Cu1PP/MiccA35cqKrpGkBFjFkl1H3hZh6OSkk5Nig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=starfivetech.com; dmarc=pass action=none header.from=starfivetech.com; dkim=pass header.d=starfivetech.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=starfivetech.com; Received: from NT0PR01MB1070.CHNPR01.prod.partner.outlook.cn (2406:e500:c510:3::6) by NT0PR01MB1133.CHNPR01.prod.partner.outlook.cn (2406:e500:c510:6::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7135.20; Tue, 9 Jan 2024 07:09:58 +0000 Received: from NT0PR01MB1070.CHNPR01.prod.partner.outlook.cn ([fe80::85fc:7fb9:8b00:dd88]) by NT0PR01MB1070.CHNPR01.prod.partner.outlook.cn ([fe80::85fc:7fb9:8b00:dd88%3]) with mapi id 15.20.7135.019; Tue, 9 Jan 2024 07:09:58 +0000 From: Shengyang Chen <shengyang.chen@starfivetech.com> To: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: neil.armstrong@linaro.org, quic_jesszhan@quicinc.com, sam@ravnborg.org, airlied@gmail.com, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, wahrenst@gmx.net, dave.stevenson@raspberrypi.com, thierry.reding@gmail.com, changhuang.liang@starfivetech.com, keith.zhao@starfivetech.com, shengyang.chen@starfivetech.com, jack.zhu@starfivetech.com, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add compatible property for waveshare 7inch touchscreen panel Date: Tue, 9 Jan 2024 15:09:48 +0800 Message-Id: <20240109070949.23957-2-shengyang.chen@starfivetech.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20240109070949.23957-1-shengyang.chen@starfivetech.com> References: <20240109070949.23957-1-shengyang.chen@starfivetech.com> Content-Type: text/plain X-ClientProxiedBy: NT0PR01CA0013.CHNPR01.prod.partner.outlook.cn (2406:e500:c510::17) To NT0PR01MB1070.CHNPR01.prod.partner.outlook.cn (2406:e500:c510:3::6) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: NT0PR01MB1070:EE_|NT0PR01MB1133:EE_ X-MS-Office365-Filtering-Correlation-Id: 819c26bb-e6a6-44d2-ebd2-08dc10e1fd0a X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9QZWV7dp5OUnmtsEBXSgTQ+JgQZhj0thIMwyYuTgnEv8BpFhNTpWi6E0iZxpPTmgbeZAntD8dW0p2QOHbwgy6+nJ5l39L/X5W6dbp6KG2yxC3v/bBOIBxOv4I1ctcqS18o5YQexJw8subW5eO6cd++VpOCtL2K1XgNeT6QEfUgL8BYYBhy9CrT02hQhRHBvRCaD111dIoVZAmvMSdyHGySsEaIG6ZALiCabA0BUtgxWjEHCYdDVeK2wD74+ZnKWQmnmrrRuD6lyAaYjGTVn0r+W9fJ5y3vNACiSx+cJspPmMbaNaaGg+uiIyehUWPDJhPRTgX8yT65CpAnm8hPyiJlqzKJQrZYmo4GE2zkX4nPca1vJZVoWJ+kZ0Dtlvu6VNy7oEU/MKPFOJtXSwh70PtMX46wTSdOMkFoTABNehVUKDpw3b+iLWMcW2XiG+/0yWxfINHd6s0ZU7U+IR+3VISXsgBsOtjSUZ4Q4Q2BrXX8gwg/K1B8d2tofx63TjVms1uTOo/uSgRBtv+Y0voO+b6eHeRsVMqEGNRQzyKddvaf6umaifFr7rO/4g33PvVcaj X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:NT0PR01MB1070.CHNPR01.prod.partner.outlook.cn;PTR:;CAT:NONE;SFS:(13230031)(396003)(39830400003)(366004)(346002)(136003)(230922051799003)(451199024)(186009)(1800799012)(64100799003)(66476007)(66946007)(4326008)(66556008)(8936002)(44832011)(36756003)(26005)(2616005)(6666004)(1076003)(508600001)(8676002)(41320700001)(41300700001)(5660300002)(2906002)(7416002)(52116002)(40180700001)(38350700005)(40160700002)(86362001)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Q615R01p6+AXljuF4rLvLVTl7SWcfJQr01N5EYLiVsM4LPjoylG5/TSzhRIcNmBQFBUPackEw/MHHywuyUM65D6nTrEcPdkteIEEQzbTjzxRWbcPY8VeA1dsw8CK69ODGWzwjh7a9tuniIkyFMW5YMuwf2yR8FYHYOTdX5Wg2O6jGY8M5OSkthguDXGKG0up8vszn8oFBzmkhZ3H9RskD6bPIUVlbXqrwUG3hxcXDfpXopy51zJTi/d7WkfEsQ/QBVSymY31vDOwtulYh9QariJ6PSMuJ3C8uoYDPEuD0uViyojWKXfJ15ZVLWVuI3t+rGZiIo4edQwlw8G+r8gvOBVxCry+2+brgUeGqUb7dTTzhhHKpc1S9F22W6QnAnEi3w7gKzkY7Dv8ITTuq/kDoEp3JZ/0H+wx8WfAqxwX34KhjIzxbAsD+mifq/l8XxyiKrBzIew3f9iYBiqk68X/HDXRKILgjzBqVv385xil60Qior70YWjjXOrxdxXSYOx1VN5IEH+0e/zcuXUtliYqiWkaVDxSMR5FQT5bEefSjYM9uueUxsp8NGVYQL3ErRENt0EK7aCyv4e+0q5XYweKeN3ggLgKixyyh96X7zGdIdXpYNTYg1aWQ3g8kkEi+gsl9vRUw8Ku0ue+CZrtoQLMrR6ujoDLSDMSsOM6tY37oYN/wyR1YN3n8frphFGD2YT5mNQ665e6k3WTQzqVidhlvFnvEmQiRpGIrztGr4lOi/JfpcxBBeSuiBHXadxCfIc32zm2+OfivnKhoPBtkhrKhW+cXiS5mp8kkypq7X9aABw/NmqpUBbVK2uu/CjxtJSrwMM0eL3O12Q2+3l9MHJD2mSlSCTTH9yzj/P1uVS6v7u8rqwMAQji8v7QZb9HOg5wukVcOHRcPE28MWJuB9zCi0OnhS/tJCaqVrnaxuXoMRAmA71kgv8eCceXkQ5WSM7Yv/ewdZUVuVjKqLpuge0uqZM2HRyjej9KmiV4unMQrGWJ4bmKQlOefpAOWChTJePSaeccOgsZ3KpZ9lsCi+PWckIXL9ov4WdOPtaDJkq4FByWz02Y4GsU8pnwirwo6MtL1NmwtHlRkO3zRpJ75HE4IQlX9MCZRfkTknJ/7Inh+MCvHc3WB7fs0eROCXyw4pOnrPKrDaU++YN59ArMGhJXv+lDn4B7t+3PzQg8EnG9GccYW+Re0PSR4+5KyLDXwb2DSq+LQmJK0VWpsOxg1ra8dJUiMQ7WFAB3wlaRiuKegHWUVD4P8WC9d/D7TW4lFActhp5F3/vLkD89dnAICNWjKQd7QYSE1U+R5rVqrqHaeSP5iOKwUJJWg+se3uEUQSuhthVYeQ4P0Ok3XA1q7ewtVzzsnbb71IzrR3EjL1COb6llLlur9hKIEt6Q4ZWhcVjkLwmVLVqY0Hac2NdU9TwR+AIVewOCiolbIoXBFQQsRdcRF4+nqqyNQFa+Jgqgnv4pWldn4nSdBIh0rd9T8Pz4Om+SFZmC6gTRoz9SUV4CWhl2hpb06yTkvX7Xpwr4OQDMyeYa/8rwT1q/u+d/XCrIZCYLtnSwhPM7I0ATFRjsmqZunzC3BnVowEOmTNY4XLU4gYSVBmqi6+gLCzjlQyynJFLhBdq91xp1Sa2FPC04kIQ= X-OriginatorOrg: starfivetech.com X-MS-Exchange-CrossTenant-Network-Message-Id: 819c26bb-e6a6-44d2-ebd2-08dc10e1fd0a X-MS-Exchange-CrossTenant-AuthSource: NT0PR01MB1070.CHNPR01.prod.partner.outlook.cn X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2024 07:09:57.9687 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 06fe3fa3-1221-43d3-861b-5a4ee687a85c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QbVemyxFMpwTsYSDYtmKpi+Q0kQfbawPfFGww3uQFBAMeiBw0FixbVnzBCQ1e+NcuSFZaUyzyVTCVbSiUSdhExvKKB27r6Agtfnd7LTTrVM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: NT0PR01MB1133 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787596906966063871 X-GMAIL-MSGID: 1787596906966063871 |
Series |
Add waveshare 7inch touchscreen panel support
|
|
Commit Message
Shengyang Chen
Jan. 9, 2024, 7:09 a.m. UTC
The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480 panel It can be drived by Raspberry Pi panel's process but it needs different timing from Raspberry Pi panel. Add compatible property for it. Signed-off-by: Keith Zhao <keith.zhao@starfivetech.com> Signed-off-by: Shengyang Chen <shengyang.chen@starfivetech.com> --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+)
Comments
On Tue, Jan 09, 2024 at 03:09:48PM +0800, Shengyang Chen wrote: > The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480 panel > It can be drived by Raspberry Pi panel's process but it needs different > timing from Raspberry Pi panel. Add compatible property for it. > > Signed-off-by: Keith Zhao <keith.zhao@starfivetech.com> > Signed-off-by: Shengyang Chen <shengyang.chen@starfivetech.com> > --- > .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > index 11422af3477e..02f6b1b2ddc9 100644 > --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > @@ -335,6 +335,8 @@ properties: > - vivax,tpc9150-panel > # VXT 800x480 color TFT LCD panel > - vxt,vl050-8048nt-c01 > + # Waveshare 7" (800x480) touchscreen LCD panel > + - waveshare,7inch-touchscreen Is "7inch-touchscreen" really a specific enough identifier for this device? > # Winstar Display Corporation 3.5" QVGA (320x240) TFT LCD panel > - winstar,wf35ltiacd > # Yes Optoelectronics YTC700TLAG-05-201C 7" TFT LCD panel > -- > 2.17.1 >
On 09/01/2024 17:32, Conor Dooley wrote: > On Tue, Jan 09, 2024 at 03:09:48PM +0800, Shengyang Chen wrote: >> The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480 panel >> It can be drived by Raspberry Pi panel's process but it needs different >> timing from Raspberry Pi panel. Add compatible property for it. >> >> Signed-off-by: Keith Zhao <keith.zhao@starfivetech.com> >> Signed-off-by: Shengyang Chen <shengyang.chen@starfivetech.com> >> --- >> .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml >> index 11422af3477e..02f6b1b2ddc9 100644 >> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml >> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml >> @@ -335,6 +335,8 @@ properties: >> - vivax,tpc9150-panel >> # VXT 800x480 color TFT LCD panel >> - vxt,vl050-8048nt-c01 >> + # Waveshare 7" (800x480) touchscreen LCD panel >> + - waveshare,7inch-touchscreen > > Is "7inch-touchscreen" really a specific enough identifier for this > device? Waveshare has very precise SKUs, this should be something like waveshare,7inch-dsi-sku19885 perhaps Neil > >> # Winstar Display Corporation 3.5" QVGA (320x240) TFT LCD panel >> - winstar,wf35ltiacd >> # Yes Optoelectronics YTC700TLAG-05-201C 7" TFT LCD panel >> -- >> 2.17.1 >>
Hi, Conor Thanks for comment. > -----Original Message----- > From: Conor Dooley <conor@kernel.org> > Sent: 2024年1月10日 0:32 > To: Shengyang Chen <shengyang.chen@starfivetech.com> > Cc: devicetree@vger.kernel.org; dri-devel@lists.freedesktop.org; > neil.armstrong@linaro.org; quic_jesszhan@quicinc.com; sam@ravnborg.org; > airlied@gmail.com; daniel@ffwll.ch; maarten.lankhorst@linux.intel.com; > mripard@kernel.org; tzimmermann@suse.de; robh+dt@kernel.org; > krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; wahrenst@gmx.net; > dave.stevenson@raspberrypi.com; thierry.reding@gmail.com; Changhuang > Liang <changhuang.liang@starfivetech.com>; Keith Zhao > <keith.zhao@starfivetech.com>; Jack Zhu <jack.zhu@starfivetech.com>; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add > compatible property for waveshare 7inch touchscreen panel > > On Tue, Jan 09, 2024 at 03:09:48PM +0800, Shengyang Chen wrote: > > The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480 > > panel It can be drived by Raspberry Pi panel's process but it needs > > different timing from Raspberry Pi panel. Add compatible property for it. > > > > Signed-off-by: Keith Zhao <keith.zhao@starfivetech.com> > > Signed-off-by: Shengyang Chen <shengyang.chen@starfivetech.com> > > --- > > .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > > b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > > index 11422af3477e..02f6b1b2ddc9 100644 > > --- > > a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yam > > +++ l > > @@ -335,6 +335,8 @@ properties: > > - vivax,tpc9150-panel > > # VXT 800x480 color TFT LCD panel > > - vxt,vl050-8048nt-c01 > > + # Waveshare 7" (800x480) touchscreen LCD panel > > + - waveshare,7inch-touchscreen > > Is "7inch-touchscreen" really a specific enough identifier for this device? > Referring to official website[1] and Neil's suggestion, maybe I should change to "7inch-touchscreen-dsi-lcd" or "waveshare,7inch-dsi-sku19885" if the next patch version is needed. [1]: https://www.waveshare.com/7inch-dsi-lcd.htm > > # Winstar Display Corporation 3.5" QVGA (320x240) TFT LCD panel > > - winstar,wf35ltiacd > > # Yes Optoelectronics YTC700TLAG-05-201C 7" TFT LCD panel > > -- > > 2.17.1 > > Best Regards, Shengyang
> -----Original Message----- > From: neil.armstrong@linaro.org <neil.armstrong@linaro.org> > Sent: 2024年1月10日 17:06 > To: Conor Dooley <conor@kernel.org>; Shengyang Chen > <shengyang.chen@starfivetech.com> > Cc: devicetree@vger.kernel.org; dri-devel@lists.freedesktop.org; > quic_jesszhan@quicinc.com; sam@ravnborg.org; airlied@gmail.com; > daniel@ffwll.ch; maarten.lankhorst@linux.intel.com; mripard@kernel.org; > tzimmermann@suse.de; robh+dt@kernel.org; > krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; wahrenst@gmx.net; > dave.stevenson@raspberrypi.com; thierry.reding@gmail.com; Changhuang > Liang <changhuang.liang@starfivetech.com>; Keith Zhao > <keith.zhao@starfivetech.com>; Jack Zhu <jack.zhu@starfivetech.com>; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add > compatible property for waveshare 7inch touchscreen panel > > On 09/01/2024 17:32, Conor Dooley wrote: > > On Tue, Jan 09, 2024 at 03:09:48PM +0800, Shengyang Chen wrote: > >> The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480 > >> panel It can be drived by Raspberry Pi panel's process but it needs > >> different timing from Raspberry Pi panel. Add compatible property for it. > >> > >> Signed-off-by: Keith Zhao <keith.zhao@starfivetech.com> > >> Signed-off-by: Shengyang Chen <shengyang.chen@starfivetech.com> > >> --- > >> .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git > >> a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > >> b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > >> index 11422af3477e..02f6b1b2ddc9 100644 > >> --- > >> a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > >> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.ya > >> +++ ml > >> @@ -335,6 +335,8 @@ properties: > >> - vivax,tpc9150-panel > >> # VXT 800x480 color TFT LCD panel > >> - vxt,vl050-8048nt-c01 > >> + # Waveshare 7" (800x480) touchscreen LCD panel > >> + - waveshare,7inch-touchscreen > > > > Is "7inch-touchscreen" really a specific enough identifier for this > > device? > > Waveshare has very precise SKUs, this should be something like > waveshare,7inch-dsi-sku19885 perhaps > > Neil thanks for mention, It will be checked if next version is needed. > > > > >> # Winstar Display Corporation 3.5" QVGA (320x240) TFT LCD > panel > >> - winstar,wf35ltiacd > >> # Yes Optoelectronics YTC700TLAG-05-201C 7" TFT LCD panel > >> -- > >> 2.17.1 > >>
On Tue, Jan 16, 2024 at 09:40:21AM +0000, Shengyang Chen wrote: > Hi, Conor > > Thanks for comment. > > > -----Original Message----- > > From: Conor Dooley <conor@kernel.org> > > Sent: 2024年1月10日 0:32 > > To: Shengyang Chen <shengyang.chen@starfivetech.com> > > Cc: devicetree@vger.kernel.org; dri-devel@lists.freedesktop.org; > > neil.armstrong@linaro.org; quic_jesszhan@quicinc.com; sam@ravnborg.org; > > airlied@gmail.com; daniel@ffwll.ch; maarten.lankhorst@linux.intel.com; > > mripard@kernel.org; tzimmermann@suse.de; robh+dt@kernel.org; > > krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; wahrenst@gmx.net; > > dave.stevenson@raspberrypi.com; thierry.reding@gmail.com; Changhuang > > Liang <changhuang.liang@starfivetech.com>; Keith Zhao > > <keith.zhao@starfivetech.com>; Jack Zhu <jack.zhu@starfivetech.com>; > > linux-kernel@vger.kernel.org > > Subject: Re: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add > > compatible property for waveshare 7inch touchscreen panel > > > > On Tue, Jan 09, 2024 at 03:09:48PM +0800, Shengyang Chen wrote: > > > The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480 > > > panel It can be drived by Raspberry Pi panel's process but it needs > > > different timing from Raspberry Pi panel. Add compatible property for it. > > > > > > Signed-off-by: Keith Zhao <keith.zhao@starfivetech.com> > > > Signed-off-by: Shengyang Chen <shengyang.chen@starfivetech.com> > > > --- > > > .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > > > b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > > > index 11422af3477e..02f6b1b2ddc9 100644 > > > --- > > > a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > > > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yam > > > +++ l > > > @@ -335,6 +335,8 @@ properties: > > > - vivax,tpc9150-panel > > > # VXT 800x480 color TFT LCD panel > > > - vxt,vl050-8048nt-c01 > > > + # Waveshare 7" (800x480) touchscreen LCD panel > > > + - waveshare,7inch-touchscreen > > > > Is "7inch-touchscreen" really a specific enough identifier for this device? > > > > Referring to official website[1] and Neil's suggestion, maybe I should change to > "7inch-touchscreen-dsi-lcd" or "waveshare,7inch-dsi-sku19885" if the next patch version is needed. The one with the sku certainly seems more specific, if a next version is needed I would use that. Thanks, Conor.
diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml index 11422af3477e..02f6b1b2ddc9 100644 --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml @@ -335,6 +335,8 @@ properties: - vivax,tpc9150-panel # VXT 800x480 color TFT LCD panel - vxt,vl050-8048nt-c01 + # Waveshare 7" (800x480) touchscreen LCD panel + - waveshare,7inch-touchscreen # Winstar Display Corporation 3.5" QVGA (320x240) TFT LCD panel - winstar,wf35ltiacd # Yes Optoelectronics YTC700TLAG-05-201C 7" TFT LCD panel