Message ID | 3852ff28ea7d5d8f2086d8dd78aeff8d1d984991.1704748435.git.soyer@irl.hu |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-20125-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:37c1:b0:101:2151:f287 with SMTP id y1csp1282781dyq; Mon, 8 Jan 2024 13:22:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IEt6HlHfJQAT5TVSZzrCuCMTQZuYoThs51b2rVim9VdjcAtxrGM8R5dWkQXFSxjUB3PK0sW X-Received: by 2002:a05:620a:4042:b0:781:d8e4:f132 with SMTP id i2-20020a05620a404200b00781d8e4f132mr6455319qko.108.1704748978011; Mon, 08 Jan 2024 13:22:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704748978; cv=none; d=google.com; s=arc-20160816; b=AxH5ijGuXeM3zBsPLNmpydzWc8tU30EKwikujOB2gkVMRybF5g0tfQuD1TMbWyWYWd qC1oLGFHg8eqhF/kH1BsCLYfznWgczzgJ4MgCxUhqHQXhsmfxpswglR+2JYQ6ZOc7pbI Dw59VKZExxyYR8bAIreUfQuDvSV7/v6sfn5N6AXwC0TLcqBYIdJZ1AyzY8FFD6juxgnR hHEWvQgoLYjdHEn5h3A6x+BGHhvZW299zlPATcvxw8uSDlMGTX2yslHWL0weyGAj9FJ3 0jYKTlTCVrX8OPisTPqYjoOlos33ATvTBTyUl/ZXR1sCDVfzrQH7PKy9UTpFF6Acdozc rN1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=VUNdXHOSE1otKVhqoQJ0vnl1Z/KCXX9dHaRXKroZRmA=; fh=QJVlMtpGOITfJkwhswfNhG25s4S9XnD6rakAEruRZMI=; b=PJutskJGDJYmpyv1hHXYTsgJVia/EnzHzJkFB7XKe4uIEYNz38pISzAPgoSyRAviL7 b5F0/T/EWb7yghNZ4NSZfjxqgoKV6gqjVxO4Ud1+TtmlE+O2m08qkscY+hcuNEfenQ2A DGIGIQ5L2dFBM8TxffdA6u+sRJrindSX6Nlu7kyuztWhSnFP5m9QvEaIxFngS0xu9lqp Px7Nhu2zZoxJUAXTGpkapPj3gSKgWKslVTF2V4BcvmaZWD1yjgVo1XTqlaefR7Wte1/U cQDzb3H8rPUGurBJW6aFzIxcCRaDL3PD3wtz0wY7kuoG5nQgzFic1SckJsq9Dro0oyZH 2I5Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-20125-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-20125-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=irl.hu Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id v7-20020a05620a0f0700b0078320a85898si630087qkl.295.2024.01.08.13.22.57 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 13:22:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-20125-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-20125-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-20125-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=irl.hu Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id CB7521C2268F for <ouuuleilei@gmail.com>; Mon, 8 Jan 2024 21:22:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 08B6E56461; Mon, 8 Jan 2024 21:22:44 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from irl.hu (irl.hu [95.85.9.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BFD455E77; Mon, 8 Jan 2024 21:22:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=irl.hu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=irl.hu Received: from fedori.lan (51b681dd.dsl.pool.telekom.hu [::ffff:81.182.129.221]) (AUTH: CRAM-MD5 soyer@irl.hu, ) by irl.hu with ESMTPSA id 0000000000072D22.00000000659C666B.00161D8E; Mon, 08 Jan 2024 22:17:30 +0100 From: Gergo Koteles <soyer@irl.hu> To: Shenghao Ding <shenghao-ding@ti.com>, Kevin Lu <kevin-lu@ti.com>, Baojun Xu <baojun.xu@ti.com>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com> Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, Gergo Koteles <soyer@irl.hu>, kernel test robot <lkp@intel.com> Subject: [PATCH] ALSA: hda/tas2781: annotate calibration data endianness Date: Mon, 8 Jan 2024 22:16:46 +0100 Message-ID: <3852ff28ea7d5d8f2086d8dd78aeff8d1d984991.1704748435.git.soyer@irl.hu> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Mime-Autoconverted: from 8bit to 7bit by courier 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787558864263762784 X-GMAIL-MSGID: 1787558864263762784 |
Series |
ALSA: hda/tas2781: annotate calibration data endianness
|
|
Commit Message
Gergo Koteles
Jan. 8, 2024, 9:16 p.m. UTC
Sparse reports an endian mismatch.
The amplifier expects the calibration data as big-endian.
Use the __be32 type to express endianness better.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202401072137.Oc7pQgRW-lkp@intel.com/
Signed-off-by: Gergo Koteles <soyer@irl.hu>
---
sound/pci/hda/tas2781_hda_i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
base-commit: 736c40609d31481b3b2fffe8c239f2c86fb2b54c
Comments
On Mon, 08 Jan 2024 22:16:46 +0100, Gergo Koteles wrote: > > Sparse reports an endian mismatch. > The amplifier expects the calibration data as big-endian. > Use the __be32 type to express endianness better. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202401072137.Oc7pQgRW-lkp@intel.com/ > > Signed-off-by: Gergo Koteles <soyer@irl.hu> Thanks, applied with the additional Fixes tag to the commit. Takashi
diff --git a/sound/pci/hda/tas2781_hda_i2c.c b/sound/pci/hda/tas2781_hda_i2c.c index 4805cf0b6480..2dd809de62e5 100644 --- a/sound/pci/hda/tas2781_hda_i2c.c +++ b/sound/pci/hda/tas2781_hda_i2c.c @@ -424,8 +424,8 @@ static const struct snd_kcontrol_new tas2781_dsp_conf_ctrl = { static void tas2563_apply_calib(struct tasdevice_priv *tas_priv) { - unsigned int data; int offset = 0; + __be32 data; int ret; for (int i = 0; i < tas_priv->ndev; i++) {