Message ID | 20240108095902.22725-2-quic_riteshk@quicinc.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-19311-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:37c1:b0:101:2151:f287 with SMTP id y1csp923468dyq; Mon, 8 Jan 2024 02:01:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IEeuu4fgIz4pCe/6e7WACMthmjnc3DSXJbzCML+3Wi8TLwe9Ks/C3+vRZTnuFNla2GQvBvq X-Received: by 2002:a17:906:66d0:b0:a28:f8d2:7897 with SMTP id k16-20020a17090666d000b00a28f8d27897mr1451591ejp.20.1704708092394; Mon, 08 Jan 2024 02:01:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704708092; cv=none; d=google.com; s=arc-20160816; b=mZFu3dgxLD1KB6Pf35PAVU64u18kciMtN+rI5TyKn+nXisvNNiLMRUNy3Xy7bgfy2u Fg/F8R4BvgN+6RwkQLS7XYNlOYp1lDPpNxO4P8D/KaGFFes/RLCoKtP7Koga2NyfAYrT sIx6G8sL4ZdpVT5z7yP7LOMM9AeBsTybxXzIrTtKtTiuWoev2LdzjAW7z+16Raj0OAod N7lJjyI/YEGepd0P8R6I7s+Hm/R7kSJvQgnXfQafrt14RjCsszinw5S2rCSSx6OsLiqN l6tVagShFi6xlcc75yZ9gy/QxbhLeWDrYqcBe1GFeqHMmPWnUN1WJBUrpeWQ4QtOCeMp uqMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-id:precedence:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=0A4dWjeTe964GhDfrDlin8+L7fz961yrQfFOr4Gh+o4=; fh=nrqIME74Uzfz2gHgNxf/SXFomsrZC2a0ACuSuobK8aQ=; b=VmzrBPw7L2PBVpxWEQYJcS3mCxXM3SQsB/piXnZ1zGqqMg6oGKXKno6smLphDC+N+M EHdxWwnHBCiHV31EJFbbr+qWCjm2UfiXKmXK62ACr/j2jdqI167S0mcEUKpIB1YN8p2N yVwAvxmNlZTD185fu8H/jZR3mCO/vYBEtzBPRSnoIMnp6oB31gn9DRhMUCzUIRj6evbi 7HGsY9ChDUvYOE1Z4s6gLoqa45s+ykXhFiMSZjdT4ZOEC8+zqvoIovzt2bkega9V1tvu EV+KbHROMiSOClD7ac8sVxY5JCNEh/LoRxOJXi+OQipEL1DCCT3yYeqGG6H4sqM5jJaj 2xRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=HX0Aw6iX; spf=pass (google.com: domain of linux-kernel+bounces-19311-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-19311-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id h21-20020a1709062dd500b00a233b305069si2991605eji.812.2024.01.08.02.01.32 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 02:01:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-19311-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=HX0Aw6iX; spf=pass (google.com: domain of linux-kernel+bounces-19311-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-19311-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 0573F1F22294 for <ouuuleilei@gmail.com>; Mon, 8 Jan 2024 10:01:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7D6061426D; Mon, 8 Jan 2024 09:59:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="HX0Aw6iX" X-Original-To: linux-kernel@vger.kernel.org Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B507134AC; Mon, 8 Jan 2024 09:59:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qualcomm.com Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 4086Tspa004308; Mon, 8 Jan 2024 09:59:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= from:to:cc:subject:date:message-id:in-reply-to:references; s= qcppdkim1; bh=0A4dWjeTe964GhDfrDlin8+L7fz961yrQfFOr4Gh+o4=; b=HX 0Aw6iXyUlGeyVisLFH46Aeynbzmf/AILyIPbIkU2pjEkUDXWXCLx5/vbwWQTghXf hVg/28Tuwg8ip2B2XW35R807klFB5jNocRifzvzT82ZYW5APXccIfzUqiXg3z+Ld 9PVSE+tXoRje2TS5Iz6e/bHPCXfHmxXxX8JFI/TF1OTEAUVbAFbsfeH1E56aeVYD LjoXkNj9+S687IT55fSN6SWYr3piQMOVPVwiUIhLt8rkX0/mXuBRP1X4gsWcYovq osdx6Zfwhhjyc5/NlnrruoB25X9Uq2GmGALjtmVPLhUEeEEkrKjfE0Qlz+ce1swV gciT/RX4pwCfxEVYrzbw== Received: from apblrppmta02.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.18.19]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3vgbu2gcad-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 08 Jan 2024 09:59:16 +0000 (GMT) Received: from pps.filterd (APBLRPPMTA02.qualcomm.com [127.0.0.1]) by APBLRPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 4089xDAm022554; Mon, 8 Jan 2024 09:59:13 GMT Received: from pps.reinject (localhost [127.0.0.1]) by APBLRPPMTA02.qualcomm.com (PPS) with ESMTPS id 3veyxkkdk5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 08 Jan 2024 09:59:13 +0000 Received: from APBLRPPMTA02.qualcomm.com (APBLRPPMTA02.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 4089xChB022539; Mon, 8 Jan 2024 09:59:12 GMT Received: from hu-maiyas-hyd.qualcomm.com (hu-riteshk-hyd.qualcomm.com [10.147.241.247]) by APBLRPPMTA02.qualcomm.com (PPS) with ESMTP id 4089xCjS022534; Mon, 08 Jan 2024 09:59:12 +0000 Received: by hu-maiyas-hyd.qualcomm.com (Postfix, from userid 2314801) id 398EA5013A8; Mon, 8 Jan 2024 15:29:11 +0530 (+0530) From: Ritesh Kumar <quic_riteshk@quicinc.com> To: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ritesh Kumar <quic_riteshk@quicinc.com>, neil.armstrong@linaro.org, quic_jesszhan@quicinc.com, sam@ravnborg.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, quic_abhinavk@quicinc.com, quic_rajeevny@quicinc.com, quic_vproddut@quicinc.com, sumit.semwal@linaro.org Subject: [v2 1/2] dt-bindings: display: panel: Add Novatek NT36672E LCD DSI Date: Mon, 8 Jan 2024 15:29:01 +0530 Message-Id: <20240108095902.22725-2-quic_riteshk@quicinc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20240108095902.22725-1-quic_riteshk@quicinc.com> References: <20240108095902.22725-1-quic_riteshk@quicinc.com> X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: p8_jVZJPHqjPRky-0SFjoWPFTJQavOrk X-Proofpoint-ORIG-GUID: p8_jVZJPHqjPRky-0SFjoWPFTJQavOrk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-09_01,2023-12-07_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 bulkscore=0 adultscore=0 phishscore=0 spamscore=0 clxscore=1015 mlxlogscore=999 impostorscore=0 priorityscore=1501 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2311290000 definitions=main-2401080084 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787515992301572280 X-GMAIL-MSGID: 1787515992301572280 |
Series |
Add support for Novatek NT36672E LCD DSI panel
|
|
Commit Message
Ritesh Kumar
Jan. 8, 2024, 9:59 a.m. UTC
Document Novatek NT36672E FHD+ LCD DSI panel.
Signed-off-by: Ritesh Kumar <quic_riteshk@quicinc.com>
---
v2: Fixed review comments from Krzysztof
- renamed to novatek,nt36672e, since the binding is for the IC and
not the panel.
- moved additionalProperties after required.
---
.../display/panel/novatek,nt36672e.yaml | 66 +++++++++++++++++++
1 file changed, 66 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml
Comments
On 08/01/2024 10:59, Ritesh Kumar wrote: > Document Novatek NT36672E FHD+ LCD DSI panel. > > Signed-off-by: Ritesh Kumar <quic_riteshk@quicinc.com> > > --- > v2: Fixed review comments from Krzysztof Please use standard email subjects, so with the PATCH keyword in the title. `git format-patch` helps here to create proper versioned patches. Another useful tool is b4. Skipping the PATCH keyword makes filtering of emails more difficult thus making the review process less convenient. > - renamed to novatek,nt36672e, since the binding is for the IC and > not the panel. > - moved additionalProperties after required. > --- > .../display/panel/novatek,nt36672e.yaml | 66 +++++++++++++++++++ > 1 file changed, 66 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml > new file mode 100644 > index 000000000000..dc4672f3d01d > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml > @@ -0,0 +1,66 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/novatek,nt36672e.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Novatek NT36672E LCD DSI Panel > + > +maintainers: > + - Ritesh Kumar <quic_riteshk@quicinc.com> > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: novatek,nt36672e > + > + reg: > + maxItems: 1 > + description: DSI virtual channel > + > + vddi-supply: true > + avdd-supply: true > + avee-supply: true Are these names of pins? Somehow I have troubles believing that NT36672A and NT36672E have entirely different names for these... Best regards, Krzysztof
>-----Original Message----- >From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >Sent: Monday, January 8, 2024 3:38 PM >To: Ritesh Kumar (QUIC) <quic_riteshk@quicinc.com>; dri- >devel@lists.freedesktop.org; devicetree@vger.kernel.org; linux- >kernel@vger.kernel.org >Cc: neil.armstrong@linaro.org; Jessica Zhang (QUIC) ><quic_jesszhan@quicinc.com>; sam@ravnborg.org; >maarten.lankhorst@linux.intel.com; mripard@kernel.org; >tzimmermann@suse.de; airlied@gmail.com; daniel@ffwll.ch; >robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; >Abhinav Kumar (QUIC) <quic_abhinavk@quicinc.com>; Rajeev Nandan (QUIC) ><quic_rajeevny@quicinc.com>; Vishnuvardhan Prodduturi (QUIC) ><quic_vproddut@quicinc.com>; sumit.semwal@linaro.org >Subject: Re: [v2 1/2] dt-bindings: display: panel: Add Novatek NT36672E LCD >DSI > >On 08/01/2024 10:59, Ritesh Kumar wrote: >> Document Novatek NT36672E FHD+ LCD DSI panel. >> >> Signed-off-by: Ritesh Kumar <quic_riteshk@quicinc.com> >> >> --- >> v2: Fixed review comments from Krzysztof > >Please use standard email subjects, so with the PATCH keyword in the title. `git >format-patch` helps here to create proper versioned patches. >Another useful tool is b4. Skipping the PATCH keyword makes filtering of emails >more difficult thus making the review process less convenient. I am using git format-patch only. I think the name of series is changed causing the trouble. > >> - renamed to novatek,nt36672e, since the binding is for the IC and >> not the panel. >> - moved additionalProperties after required. >> --- >> .../display/panel/novatek,nt36672e.yaml | 66 +++++++++++++++++++ >> 1 file changed, 66 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml >> >> diff --git >> >a/Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yam >> l >> >b/Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yam >> l >> new file mode 100644 >> index 000000000000..dc4672f3d01d >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36672e >> +++ .yaml >> @@ -0,0 +1,66 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2 >> +--- >> +$id: >> +http://devicetree.org/schemas/display/panel/novatek,nt36672e.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Novatek NT36672E LCD DSI Panel >> + >> +maintainers: >> + - Ritesh Kumar <quic_riteshk@quicinc.com> >> + >> +allOf: >> + - $ref: panel-common.yaml# >> + >> +properties: >> + compatible: >> + const: novatek,nt36672e >> + >> + reg: >> + maxItems: 1 >> + description: DSI virtual channel >> + >> + vddi-supply: true >> + avdd-supply: true >> + avee-supply: true > >Are these names of pins? Somehow I have troubles believing that NT36672A >and NT36672E have entirely different names for these... Yes, these are name of pins. Below is the Pin Description from NT36672E Datasheet: vddi - Power supply to the I/O. avdd - Positive input analog power for driver IC use. avee - Negative input analog power for driver IC use. I could not find datasheet of NT36672A online to compare the names. Thanks, Ritesh
On 08/01/2024 11:07, Krzysztof Kozlowski wrote: > On 08/01/2024 10:59, Ritesh Kumar wrote: >> Document Novatek NT36672E FHD+ LCD DSI panel. >> >> Signed-off-by: Ritesh Kumar <quic_riteshk@quicinc.com> >> >> --- >> v2: Fixed review comments from Krzysztof > > Please use standard email subjects, so with the PATCH keyword in the > title. `git format-patch` helps here to create proper versioned patches. > Another useful tool is b4. Skipping the PATCH keyword makes filtering of > emails more difficult thus making the review process less convenient. That was for the future (I understand making that mistake once with your v1, but that's v2), no need to resend only for this. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- This is an automated instruction, just in case, because many review tags are being ignored. If you know the process, you can skip it (please do not feel offended by me posting it here - no bad intentions intended). If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml new file mode 100644 index 000000000000..dc4672f3d01d --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml @@ -0,0 +1,66 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/novatek,nt36672e.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Novatek NT36672E LCD DSI Panel + +maintainers: + - Ritesh Kumar <quic_riteshk@quicinc.com> + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + const: novatek,nt36672e + + reg: + maxItems: 1 + description: DSI virtual channel + + vddi-supply: true + avdd-supply: true + avee-supply: true + port: true + reset-gpios: true + backlight: true + +required: + - compatible + - reg + - vddi-supply + - avdd-supply + - avee-supply + - reset-gpios + - port + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + dsi { + #address-cells = <1>; + #size-cells = <0>; + panel@0 { + compatible = "novatek,nt36672e"; + reg = <0>; + + reset-gpios = <&tlmm 44 GPIO_ACTIVE_HIGH>; + + vddi-supply = <&vreg_l8c_1p8>; + avdd-supply = <&disp_avdd>; + avee-supply = <&disp_avee>; + + backlight = <&pwm_backlight>; + + port { + panel0_in: endpoint { + remote-endpoint = <&dsi0_out>; + }; + }; + }; + }; +...