Message ID | 20240104130123.37115-7-brgl@bgdev.pl |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-16680-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp5597275dyb; Thu, 4 Jan 2024 05:06:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IHIe/yBQ3ZwrU+Hev1ei/65zlGFNtft5iqnVoHCnEX2qzFl+SPNv1f21q5/E+N6v8VwTKOq X-Received: by 2002:a05:6122:20a8:b0:4b7:18b3:b128 with SMTP id i40-20020a05612220a800b004b718b3b128mr441109vkd.19.1704373577556; Thu, 04 Jan 2024 05:06:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704373577; cv=none; d=google.com; s=arc-20160816; b=NOiWgQfVUHZ4GWtaCFM5+fJZmiMNotJWl7pi2dWxdSVNUxeYn2q+AzfqQ+GssgVLP9 khN0QzHHaGYqdDRQo1J/lkl4ALm5m1HFXlDf6uBfFMeVHjr4FZ/KPzC0pCnazWil5MjO 0PU+gmGaWcLLpRAQLBx/dJv8vqwqiuGOQ9zNQzUcGpaKypgPwzLdTU6/ILTaSiPL5K5b k7OvNExLtekPixGAp1cUapGn40U2Zq1BRCUaryBLbWdph74ddFEQ+0+huCOHQqbyDmM6 9kMOUTQwrcU5Dd6uRxbFZT4iMEUlcj77mHmg3x4WLNZqsDq9btTs9pqg9l2Otl+hp73U H2zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=DA5aHFJ46r457gaZ61RwpP8TkLsec2lgKs71JTHrGEQ=; fh=1uFngekeZT2FVGQaKpK4gjTIex4FU0hdfexTfOUKej8=; b=TRtaME8ChPr6WuY8sdjpJqYQDLcO3+WJQcWyLs1GpfvjLjAtOoI06iiKYKYmg1T1l4 b8OWEyoNgC7q0ZDThO0qxCW43PSoMjS+jX2/9iuFObg16unmKRtePjDQGriAb4iSPzyP xc4x43bntk6eC9FxZemH9VkLdsm0/m3zU57fn1IRc6xQGzw5kd3LCy+GydXL+bqlw2xk LYDyDokIEpl/uYIol6fBHf+xREk142bTigy205jLNlT4tafNhdF7h1tqO/NsqSm/6Yo8 Pa2V7XNnx3xKKLnCYbOULc7HJ+x32P1i4U81SWISeIRhpWDtNN/7S2DAmy/dGOpYDu+c DBVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=DJZleFYX; spf=pass (google.com: domain of linux-kernel+bounces-16680-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-16680-ouuuleilei=gmail.com@vger.kernel.org" Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id 187-20020a1f14c4000000b004b6e3fa75a0si3342402vku.7.2024.01.04.05.06.17 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jan 2024 05:06:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-16680-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=DJZleFYX; spf=pass (google.com: domain of linux-kernel+bounces-16680-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-16680-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 5366D1C20E42 for <ouuuleilei@gmail.com>; Thu, 4 Jan 2024 13:06:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 866D524B21; Thu, 4 Jan 2024 13:02:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="DJZleFYX" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2142C249FE for <linux-kernel@vger.kernel.org>; Thu, 4 Jan 2024 13:02:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2cd1aeb1b02so5584961fa.2 for <linux-kernel@vger.kernel.org>; Thu, 04 Jan 2024 05:02:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1704373332; x=1704978132; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DA5aHFJ46r457gaZ61RwpP8TkLsec2lgKs71JTHrGEQ=; b=DJZleFYXxWZY9pk+c/Ehi5OSl4NVSFuUu0j6/9cSWmaVsDXtL+d0AQVaTqQW/o4yPM WdIHaj4c4UsRzaN/lYeVhjzLv3/EOXF7yrgMQW42nEQJT6xgoO/ZhlR8tlJ3jvsK3rpu ph8iby0pvdvmWGu7eaqSJPd4trBW03ILPcVsOfSEA1ynVrf8IIbWTajurqnnVSp7AK4D pgikgrkCWXfgAqDkPT6Y+YwanUmfQ9cEVRbcSWY7DRowbuht9QlZ79B3u5N2DkCjaVsg UuDiLboYKrUsnxfLIp/YVPG0Xa798MDz3yABbVRGL9y/GccdLVm/F0NJ+h4OvGDp130p EwAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704373332; x=1704978132; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DA5aHFJ46r457gaZ61RwpP8TkLsec2lgKs71JTHrGEQ=; b=w6fHlg8hBDMi4Mv1LNgtkNUmtoiq47+mfyn9wo0cwCKBYY660ChVTZSdvHJHyTbCNC wgAszsHoaS4OEJepFMbPbAGX5ht9V1b0S3jJWpe6EOwtef5rix6DAp70L7xkdzLA/X44 lWTvuPgq0fPyPRV4x8vFQ1r6VedBMIno36oqGL+A7empYx7hgdmjC+LQus69uOpU2jwO zaKhYwAGk1EtNkrnSKiGQr3+lthfAXPw2jYd30EjdsB8TKTO2TQg1v6BNRs8DgrFqrN0 1M8rI8PbvJpSaRDuXw3jNQIjO7kZ8Z439b82rBxcisOMM/vkaOk+A49v4lMYAAw3UbGP 6JRw== X-Gm-Message-State: AOJu0YwVmkR/TI7ErVZvy5oBHpuXaLUxl2WEpUTc6mWkyiaqCRdJDZfu FB32bgiylqnrQczK2F4d/ud4P1Nkvy7YyQ== X-Received: by 2002:a2e:7d07:0:b0:2cc:d574:6057 with SMTP id y7-20020a2e7d07000000b002ccd5746057mr314367ljc.73.1704373331828; Thu, 04 Jan 2024 05:02:11 -0800 (PST) Received: from brgl-uxlite.home ([2a01:cb1d:334:ac00:5b69:3768:8459:8fee]) by smtp.gmail.com with ESMTPSA id w5-20020a5d5445000000b0033660f75d08sm32887387wrv.116.2024.01.04.05.02.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jan 2024 05:02:11 -0800 (PST) From: Bartosz Golaszewski <brgl@bgdev.pl> To: Kalle Valo <kvalo@kernel.org>, "David S . Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>, Heiko Stuebner <heiko@sntech.de>, Jernej Skrabec <jernej.skrabec@gmail.com>, Chris Morgan <macromorgan@hotmail.com>, Linus Walleij <linus.walleij@linaro.org>, Geert Uytterhoeven <geert+renesas@glider.be>, Arnd Bergmann <arnd@arndb.de>, Neil Armstrong <neil.armstrong@linaro.org>, =?utf-8?q?N=C3=ADcolas_F_=2E_R_?= =?utf-8?q?=2E_A_=2E_Prado?= <nfraprado@collabora.com>, Marek Szyprowski <m.szyprowski@samsung.com>, Peng Fan <peng.fan@nxp.com>, Robert Richter <rrichter@amd.com>, Dan Williams <dan.j.williams@intel.com>, Jonathan Cameron <Jonathan.Cameron@huawei.com>, Terry Bowman <terry.bowman@amd.com>, Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>, =?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>, Huacai Chen <chenhuacai@kernel.org>, Alex Elder <elder@linaro.org>, Srini Kandagatla <srinivas.kandagatla@linaro.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Subject: [RFC 6/9] dt-bindings: vendor-prefixes: add a PCI prefix for Qualcomm Atheros Date: Thu, 4 Jan 2024 14:01:20 +0100 Message-Id: <20240104130123.37115-7-brgl@bgdev.pl> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240104130123.37115-1-brgl@bgdev.pl> References: <20240104130123.37115-1-brgl@bgdev.pl> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787165228123538763 X-GMAIL-MSGID: 1787165228123538763 |
Series |
PCI: introduce the concept of power sequencing of PCIe devices
|
|
Commit Message
Bartosz Golaszewski
Jan. 4, 2024, 1:01 p.m. UTC
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Document the PCI vendor prefix for Qualcomm Atheros so that we can define the QCA PCI devices on device tree. Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 1 + 1 file changed, 1 insertion(+)
Comments
On Thu, 04 Jan 2024 14:01:20 +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Document the PCI vendor prefix for Qualcomm Atheros so that we can > define the QCA PCI devices on device tree. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > --- > Documentation/devicetree/bindings/vendor-prefixes.yaml | 1 + > 1 file changed, 1 insertion(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/vendor-prefixes.yaml:1116:13: [error] empty value in block mapping (empty-values) dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/vendor-prefixes.yaml: patternProperties:^qca,.*: None is not of type 'object', 'boolean' from schema $id: http://json-schema.org/draft-07/schema# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/vendor-prefixes.yaml: ignoring, error in schema: patternProperties: ^qca,.* doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240104130123.37115-7-brgl@bgdev.pl The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Hi, On Thu, Jan 04, 2024 at 02:01:20PM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Document the PCI vendor prefix for Qualcomm Atheros so that we can > define the QCA PCI devices on device tree. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > --- > Documentation/devicetree/bindings/vendor-prefixes.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml > index 2dc098b39234..297d6037cd12 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml > @@ -1128,6 +1128,7 @@ patternProperties: > "^purism,.*": > description: Purism, SPC > "^qca,.*": > + "^pci17cb,.*": I don't think it's a good idea to list all the PCI vendor IDs in vendor-prefixes.yaml. To please the tooling, I suggest to have a generic entry instead. Something like this (untested): "^pci[0-9a-f][0-9a-f][0-9a-f][0-9a-f],.*": description: PCI SIG Vendor ID Note, that we we already have a bunch of them: grep -ho 'pci[0-9a-f][0-9a-f][0-9a-f][0-9a-f],' **/*.dts* | sort | uniq -c 70 pci0014, 3 pci10b5, 1 pci10ee, 6 pci14e4, 1 pci16c3, 2 pci17a0, 1 pci17cb, 1 pci1b4b, 63 pci8086, Greetings, -- Sebastian > description: Qualcomm Atheros, Inc. > "^qcom,.*": > description: Qualcomm Technologies, Inc > -- > 2.40.1 > >
On Thu, Jan 04, 2024 at 02:01:20PM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Document the PCI vendor prefix for Qualcomm Atheros so that we can > define the QCA PCI devices on device tree. Why? vendor-prefixes.yaml is only applied to property names. 'qca' should be the prefix for those. Rob
On Mon, Jan 8, 2024 at 8:10 PM Rob Herring <robh@kernel.org> wrote: > > On Thu, Jan 04, 2024 at 02:01:20PM +0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > > > Document the PCI vendor prefix for Qualcomm Atheros so that we can > > define the QCA PCI devices on device tree. > > Why? vendor-prefixes.yaml is only applied to property names. 'qca' > should be the prefix for those. > > Rob I didn't have any better idea. PCI devices on DT are defined by their "pci<vendor ID>,<model ID>" compatible, not regular human-readable strings and this makes checkpatch.pl complain. I'm open to suggestions. Bartosz
On Mon, Jan 8, 2024 at 12:22 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > On Mon, Jan 8, 2024 at 8:10 PM Rob Herring <robh@kernel.org> wrote: > > > > On Thu, Jan 04, 2024 at 02:01:20PM +0100, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > > > > > Document the PCI vendor prefix for Qualcomm Atheros so that we can > > > define the QCA PCI devices on device tree. > > > > Why? vendor-prefixes.yaml is only applied to property names. 'qca' > > should be the prefix for those. > > > > Rob > > I didn't have any better idea. PCI devices on DT are defined by their > "pci<vendor ID>,<model ID>" compatible, not regular human-readable > strings and this makes checkpatch.pl complain. > > I'm open to suggestions. The checkpatch.pl check predates schemas and we could consider just dropping it. The only thing it provides is checking a patch rather than the tree (which the schema do). It's pretty hacky because it just greps the tree for a compatible string which is not entirely accurate. Also, we can extract an exact list of compatibles with "dt-extract-compatibles" which would make a better check, but I'm not sure making dtschema a dependency on checkpatch would be good. The other option is just ignore the warning. PCI compatibles are fairly rare. Rob
On 09/01/2024 03:56, Rob Herring wrote: > On Mon, Jan 8, 2024 at 12:22 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: >> >> On Mon, Jan 8, 2024 at 8:10 PM Rob Herring <robh@kernel.org> wrote: >>> >>> On Thu, Jan 04, 2024 at 02:01:20PM +0100, Bartosz Golaszewski wrote: >>>> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> >>>> >>>> Document the PCI vendor prefix for Qualcomm Atheros so that we can >>>> define the QCA PCI devices on device tree. >>> >>> Why? vendor-prefixes.yaml is only applied to property names. 'qca' >>> should be the prefix for those. >>> >>> Rob >> >> I didn't have any better idea. PCI devices on DT are defined by their >> "pci<vendor ID>,<model ID>" compatible, not regular human-readable >> strings and this makes checkpatch.pl complain. >> >> I'm open to suggestions. > > The checkpatch.pl check predates schemas and we could consider just > dropping it. The only thing it provides is checking a patch rather > than the tree (which the schema do). It's pretty hacky because it just > greps the tree for a compatible string which is not entirely accurate. > Also, we can extract an exact list of compatibles with > "dt-extract-compatibles" which would make a better check, but I'm not > sure making dtschema a dependency on checkpatch would be good. > > The other option is just ignore the warning. PCI compatibles are fairly rare. Yep, the same warnings are for EEPROM and USB VID/PID compatibles, and we live with these, so I don't think PCI should be treated differently. Best regards, Krzysztof
On Tue, Jan 9, 2024 at 10:17 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 09/01/2024 03:56, Rob Herring wrote: > > On Mon, Jan 8, 2024 at 12:22 PM Bartosz Golaszewski <brgl@bgdevpl> wrote: > >> > >> On Mon, Jan 8, 2024 at 8:10 PM Rob Herring <robh@kernel.org> wrote: > >>> > >>> On Thu, Jan 04, 2024 at 02:01:20PM +0100, Bartosz Golaszewski wrote: > >>>> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > >>>> > >>>> Document the PCI vendor prefix for Qualcomm Atheros so that we can > >>>> define the QCA PCI devices on device tree. > >>> > >>> Why? vendor-prefixes.yaml is only applied to property names. 'qca' > >>> should be the prefix for those. > >>> > >>> Rob > >> > >> I didn't have any better idea. PCI devices on DT are defined by their > >> "pci<vendor ID>,<model ID>" compatible, not regular human-readable > >> strings and this makes checkpatch.pl complain. > >> > >> I'm open to suggestions. > > > > The checkpatch.pl check predates schemas and we could consider just > > dropping it. The only thing it provides is checking a patch rather > > than the tree (which the schema do). It's pretty hacky because it just > > greps the tree for a compatible string which is not entirely accurate. > > Also, we can extract an exact list of compatibles with > > "dt-extract-compatibles" which would make a better check, but I'm not > > sure making dtschema a dependency on checkpatch would be good. > > > > The other option is just ignore the warning. PCI compatibles are fairly rare. > > Yep, the same warnings are for EEPROM and USB VID/PID compatibles, and > we live with these, so I don't think PCI should be treated differently. > Got it, I will drop this patch. Bart
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml index 2dc098b39234..297d6037cd12 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml @@ -1128,6 +1128,7 @@ patternProperties: "^purism,.*": description: Purism, SPC "^qca,.*": + "^pci17cb,.*": description: Qualcomm Atheros, Inc. "^qcom,.*": description: Qualcomm Technologies, Inc