Message ID | 20240107152557.3561341-1-enachman@marvell.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-18891-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:37c1:b0:101:2151:f287 with SMTP id y1csp585847dyq; Sun, 7 Jan 2024 07:26:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IGV/MrU8M6COSw3RONGyhtP5aU9r83LBep32U6VV2RqeHmcVNvCIQ/bauUL9yPJnYWYM7KN X-Received: by 2002:a05:620a:109b:b0:781:b6a7:2d6c with SMTP id g27-20020a05620a109b00b00781b6a72d6cmr7459465qkk.8.1704641192450; Sun, 07 Jan 2024 07:26:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704641192; cv=none; d=google.com; s=arc-20160816; b=IVUFjhG/MXX5RkRoej5KircC0YUyyv/haSMmTAOQMQx98rCe3AQNNsRZ8xqb8hBzVk sDPsOI/ENetrdng7LT8qp7e+bWfAcoSBwvqz6evtDkcuzKcf5PAC95gE5hrAM8VPSJ01 Cj106Zbm9Y1PzXrlLZTkpwPdd05EQ4GbdU+lU4ANvgo/F4f/xB3GeGrlKWmosJfbvF32 xwEnoq0q8ZPrQxfODb+IFc8ZhZvlsSeVWjH7oyY1qGMw1+6muqVBnTn9g1cOuKY9/vLz T4yQ8JxlX0K/xUIDCSUwzTf0r3Wnx9mFM9ViRH6FVij3FHZgpn1j3VhFdUUgYI8Yxm0F yHbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=E5WheNxtE7KIkYNksOdMvdibyOlZ+13KdYGfnetHwPQ=; fh=V091NHCVLgrdTZ3EuD9m/Xy9x2ck0giP23gKuTDthH8=; b=qGcpbEoc315x4ZuPGoAZ3QCIPiraH95aMgwSfsf9kQJmI3JjbPpLLO10vJDjgUWfTM +401498WiZgojQRSkYL3T3u4TcsRKErdB85GwTljgMhM0bsL91QphXsis9oMEGXNR93t EXar9zu73LRGYESpvgAuQ6k0ZQliw1siBZqyfMpbmXbbkqtPHy2ll/Z+0XOOGWZ3h7wS PNO+7q9B65KU/eTwZCyhTNX6IFfU/p9QCyGOiSv56DcmINDiUbSdXuN9LSk1x9zvL0YT dWxOf1asPEUnKguoWjuSSOmg2NIcH+HVVZUTUNuuVSVOM7dI9lqI8GzxxEPEumP4m75g lgjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@marvell.com header.s=pfpt0220 header.b=Ymf4zCPK; spf=pass (google.com: domain of linux-kernel+bounces-18891-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-18891-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=marvell.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id v7-20020a0c9c07000000b0067f70fc7fcdsi5850632qve.405.2024.01.07.07.26.32 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jan 2024 07:26:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-18891-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@marvell.com header.s=pfpt0220 header.b=Ymf4zCPK; spf=pass (google.com: domain of linux-kernel+bounces-18891-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-18891-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=marvell.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 3E8951C20CCF for <ouuuleilei@gmail.com>; Sun, 7 Jan 2024 15:26:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C5ED413AEA; Sun, 7 Jan 2024 15:26:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="Ymf4zCPK" X-Original-To: linux-kernel@vger.kernel.org Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AE91134BE; Sun, 7 Jan 2024 15:26:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=marvell.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.helo=mx0b-0016f401.pphosted.com Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 407EvqbT029122; Sun, 7 Jan 2024 07:26:04 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding:content-type; s=pfpt0220; bh=E5WheNxt E7KIkYNksOdMvdibyOlZ+13KdYGfnetHwPQ=; b=Ymf4zCPKtJp3L3WPIFv8GrQN lQ9H5VchrHDrG/uQFN4KKxM/Bs4prtajI398Xs4zVo3fL43nexFpRoDOWZIjg0js 1fSu+keVFf742Tou4MNUB2axDu7OUBXNw97vtX7J4mIx/EIo7sc3fu64ulTuuUII QGHflJrMgafwbM9DnWS6RN9XYVLz1yAO6Tw44e3xPjHeYAi9Smgr9lpGm4/sbG0N OXjUE5sRZ57f2D2I1F0kGwVpqT2Iv7mPRcfgf/vrB+7MYy4ovlkjyn29ZBc7Ic1Z sSLh5SvwEbuUAFYyoaSYUle5yPY1NSS6SbtI+IaGccpiYtp8fFkKsnB4lMZQBg== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3vf78n29jm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Sun, 07 Jan 2024 07:26:04 -0800 (PST) Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Sun, 7 Jan 2024 07:26:02 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Sun, 7 Jan 2024 07:26:02 -0800 Received: from dc3lp-swdev041.marvell.com (dc3lp-swdev041.marvell.com [10.6.60.191]) by maili.marvell.com (Postfix) with ESMTP id 6EC373F7093; Sun, 7 Jan 2024 07:26:00 -0800 (PST) From: Elad Nachman <enachman@marvell.com> To: <gregkh@linuxfoundation.org>, <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>, <devicetree@vger.kernel.org>, <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org> CC: <enachman@marvell.com> Subject: [PATCH] dt-bindings: usb: Add Marvell ac5 Date: Sun, 7 Jan 2024 17:25:57 +0200 Message-ID: <20240107152557.3561341-1-enachman@marvell.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-ORIG-GUID: Y5RTahJgokMjyWMMpqEtt-U1bWBPK9sI X-Proofpoint-GUID: Y5RTahJgokMjyWMMpqEtt-U1bWBPK9sI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-09_02,2023-12-07_01,2023-05-22_02 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787445842760745466 X-GMAIL-MSGID: 1787445842760745466 |
Series |
dt-bindings: usb: Add Marvell ac5
|
|
Commit Message
Elad Nachman
Jan. 7, 2024, 3:25 p.m. UTC
From: Elad Nachman <enachman@marvell.com> Add Marvell ac5 device tree bindings to generic EHCI. This compatible enables the Marvell Orion platform code to properly configure the DMA mask for the Marvell AC5 SOC. Signed-off-by: Elad Nachman <enachman@marvell.com> --- Documentation/devicetree/bindings/usb/generic-ehci.yaml | 1 + 1 file changed, 1 insertion(+)
Comments
On Sun, Jan 07, 2024 at 05:25:57PM +0200, Elad Nachman wrote: > From: Elad Nachman <enachman@marvell.com> > > Add Marvell ac5 device tree bindings to generic EHCI. > This compatible enables the Marvell Orion platform code > to properly configure the DMA mask for the Marvell AC5 SOC. > > Signed-off-by: Elad Nachman <enachman@marvell.com> Maybe I am dumb, but I don't understand how this does what the commit message says. There's no fallback to generic-ehci or any other compatible that is already understood by the driver. What am I missing? > --- > Documentation/devicetree/bindings/usb/generic-ehci.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > index 87986c45be88..2ed178f16a78 100644 > --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml > +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > @@ -77,6 +77,7 @@ properties: > - const: usb-ehci > - enum: > - generic-ehci > + - marvell,ac5-ehci > - marvell,armada-3700-ehci > - marvell,orion-ehci > - nuvoton,npcm750-ehci > -- > 2.25.1 >
> -----Original Message----- > From: Conor Dooley <conor@kernel.org> > Sent: Monday, January 8, 2024 7:15 PM > To: Elad Nachman <enachman@marvell.com> > Cc: gregkh@linuxfoundation.org; robh+dt@kernel.org; > krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; > devicetree@vger.kernel.org; linux-usb@vger.kernel.org; linux- > kernel@vger.kernel.org > Subject: [EXT] Re: [PATCH] dt-bindings: usb: Add Marvell ac5 > > External Email > > ---------------------------------------------------------------------- > On Sun, Jan 07, 2024 at 05:25:57PM +0200, Elad Nachman wrote: > > From: Elad Nachman <enachman@marvell.com> > > > > Add Marvell ac5 device tree bindings to generic EHCI. > > This compatible enables the Marvell Orion platform code to properly > > configure the DMA mask for the Marvell AC5 SOC. > > > > Signed-off-by: Elad Nachman <enachman@marvell.com> > > Maybe I am dumb, but I don't understand how this does what the commit > message says. There's no fallback to generic-ehci or any other compatible > that is already understood by the driver. > > What am I missing? Following guidance by Andrew Lunn on my mmc patchset, I have split the patchset Into a single patch for dt-bindings review and another for USB driver review. The USB driver patch utilizing this new dt bindings compatible string is here: https://patchwork.kernel.org/project/linux-usb/patch/20240107163307.3677347-1-enachman@marvell.com/ > > > --- > > Documentation/devicetree/bindings/usb/generic-ehci.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > index 87986c45be88..2ed178f16a78 100644 > > --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > @@ -77,6 +77,7 @@ properties: > > - const: usb-ehci > > - enum: > > - generic-ehci > > + - marvell,ac5-ehci > > - marvell,armada-3700-ehci > > - marvell,orion-ehci > > - nuvoton,npcm750-ehci > > -- > > 2.25.1 > > Elad.
On Mon, Jan 08, 2024 at 05:47:24PM +0000, Elad Nachman wrote: > > > > -----Original Message----- > > From: Conor Dooley <conor@kernel.org> > > Sent: Monday, January 8, 2024 7:15 PM > > To: Elad Nachman <enachman@marvell.com> > > Cc: gregkh@linuxfoundation.org; robh+dt@kernel.org; > > krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; > > devicetree@vger.kernel.org; linux-usb@vger.kernel.org; linux- > > kernel@vger.kernel.org > > Subject: [EXT] Re: [PATCH] dt-bindings: usb: Add Marvell ac5 > > > > External Email > > > > ---------------------------------------------------------------------- > > On Sun, Jan 07, 2024 at 05:25:57PM +0200, Elad Nachman wrote: > > > From: Elad Nachman <enachman@marvell.com> > > > > > > Add Marvell ac5 device tree bindings to generic EHCI. > > > This compatible enables the Marvell Orion platform code to properly > > > configure the DMA mask for the Marvell AC5 SOC. > > > > > > Signed-off-by: Elad Nachman <enachman@marvell.com> > > > > Maybe I am dumb, but I don't understand how this does what the commit > > message says. There's no fallback to generic-ehci or any other compatible > > that is already understood by the driver. > > > > What am I missing? > > Following guidance by Andrew Lunn on my mmc patchset, I have split the patchset > Into a single patch for dt-bindings review and another for USB driver review. I don't understand that advice. dt-bindings should (almost) always be with the driver. Otherwise you just confuse people like me. Perhaps Andrew meant sending dt*s* patches separately from the driver & bindings? Cheers, Conor. > > The USB driver patch utilizing this new dt bindings compatible string is here: > > https://patchwork.kernel.org/project/linux-usb/patch/20240107163307.3677347-1-enachman@marvell.com/ > > > > > > --- > > > Documentation/devicetree/bindings/usb/generic-ehci.yaml | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > > b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > > index 87986c45be88..2ed178f16a78 100644 > > > --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > > +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > > @@ -77,6 +77,7 @@ properties: > > > - const: usb-ehci > > > - enum: > > > - generic-ehci > > > + - marvell,ac5-ehci > > > - marvell,armada-3700-ehci > > > - marvell,orion-ehci > > > - nuvoton,npcm750-ehci > > > -- > > > 2.25.1 > > > > > Elad.
> -----Original Message----- > From: Conor Dooley <conor@kernel.org> > Sent: Monday, January 8, 2024 8:01 PM > To: Elad Nachman <enachman@marvell.com> > Cc: gregkh@linuxfoundation.org; robh+dt@kernel.org; > krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; > devicetree@vger.kernel.org; linux-usb@vger.kernel.org; linux- > kernel@vger.kernel.org > Subject: Re: [EXT] Re: [PATCH] dt-bindings: usb: Add Marvell ac5 > > On Mon, Jan 08, 2024 at 05:47:24PM +0000, Elad Nachman wrote: > > > > > > > -----Original Message----- > > > From: Conor Dooley <conor@kernel.org> > > > Sent: Monday, January 8, 2024 7:15 PM > > > To: Elad Nachman <enachman@marvell.com> > > > Cc: gregkh@linuxfoundation.org; robh+dt@kernel.org; > > > krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; > > > devicetree@vger.kernel.org; linux-usb@vger.kernel.org; linux- > > > kernel@vger.kernel.org > > > Subject: [EXT] Re: [PATCH] dt-bindings: usb: Add Marvell ac5 > > > > > > External Email > > > > > > -------------------------------------------------------------------- > > > -- On Sun, Jan 07, 2024 at 05:25:57PM +0200, Elad Nachman wrote: > > > > From: Elad Nachman <enachman@marvell.com> > > > > > > > > Add Marvell ac5 device tree bindings to generic EHCI. > > > > This compatible enables the Marvell Orion platform code to > > > > properly configure the DMA mask for the Marvell AC5 SOC. > > > > > > > > Signed-off-by: Elad Nachman <enachman@marvell.com> > > > > > > Maybe I am dumb, but I don't understand how this does what the > > > commit message says. There's no fallback to generic-ehci or any > > > other compatible that is already understood by the driver. > > > > > > What am I missing? > > > > Following guidance by Andrew Lunn on my mmc patchset, I have split the > > patchset Into a single patch for dt-bindings review and another for USB > driver review. > > I don't understand that advice. dt-bindings should (almost) always be with > the driver. Otherwise you just confuse people like me. > > Perhaps Andrew meant sending dt*s* patches separately from the driver & > bindings? The rational was different people making the actual merge, into different intermediate git REPOs, before mering into linux-next. > > Cheers, > Conor. > > > > > The USB driver patch utilizing this new dt bindings compatible string is here: > > > > https://patchwork.kernel.org/project/linux-usb/patch/20240107163307.36 > > 77347-1-enachman@marvell.com/ > > > > > > > > > --- > > > > Documentation/devicetree/bindings/usb/generic-ehci.yaml | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git > > > > a/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > > > b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > > > index 87986c45be88..2ed178f16a78 100644 > > > > --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > > > +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > > > @@ -77,6 +77,7 @@ properties: > > > > - const: usb-ehci > > > > - enum: > > > > - generic-ehci > > > > + - marvell,ac5-ehci > > > > - marvell,armada-3700-ehci > > > > - marvell,orion-ehci > > > > - nuvoton,npcm750-ehci > > > > -- > > > > 2.25.1 > > > > > > > > Elad. Elad.
On Mon, Jan 08, 2024 at 06:15:51PM +0000, Elad Nachman wrote: > > -----Original Message----- > > From: Conor Dooley <conor@kernel.org> > > On Mon, Jan 08, 2024 at 05:47:24PM +0000, Elad Nachman wrote: > > > > -----Original Message----- > > > > From: Conor Dooley <conor@kernel.org> > > > > -- On Sun, Jan 07, 2024 at 05:25:57PM +0200, Elad Nachman wrote: > > > > > From: Elad Nachman <enachman@marvell.com> > > > > > > > > > > Add Marvell ac5 device tree bindings to generic EHCI. > > > > > This compatible enables the Marvell Orion platform code to > > > > > properly configure the DMA mask for the Marvell AC5 SOC. > > > > > > > > > > Signed-off-by: Elad Nachman <enachman@marvell.com> > > > > > > > > Maybe I am dumb, but I don't understand how this does what the > > > > commit message says. There's no fallback to generic-ehci or any > > > > other compatible that is already understood by the driver. > > > > > > > > What am I missing? > > > > > > Following guidance by Andrew Lunn on my mmc patchset, I have split the > > > patchset Into a single patch for dt-bindings review and another for USB > > driver review. > > > > I don't understand that advice. dt-bindings should (almost) always be with > > the driver. Otherwise you just confuse people like me. > > > > Perhaps Andrew meant sending dt*s* patches separately from the driver & > > bindings? > > The rational was different people making the actual merge, into different > intermediate git REPOs, before mering into linux-next. Which almost certainly means he was talking about dts patches, not dt-bindings. bindings (almost) always go through the same tree as the driver that uses them. Cheers, Conor. > > > The USB driver patch utilizing this new dt bindings compatible string is here: > > > > > > https://patchwork.kernel.org/project/linux-usb/patch/20240107163307.36 > > > 77347-1-enachman@marvell.com/ > > > > > > > > > > > > --- > > > > > Documentation/devicetree/bindings/usb/generic-ehci.yaml | 1 + > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > diff --git > > > > > a/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > > > > b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > > > > index 87986c45be88..2ed178f16a78 100644 > > > > > --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > > > > +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > > > > @@ -77,6 +77,7 @@ properties: > > > > > - const: usb-ehci > > > > > - enum: > > > > > - generic-ehci > > > > > + - marvell,ac5-ehci > > > > > - marvell,armada-3700-ehci > > > > > - marvell,orion-ehci > > > > > - nuvoton,npcm750-ehci > > > > > -- > > > > > 2.25.1 > > > > > > > > > > > Elad. > > Elad.
On 08/01/2024 19:15, Elad Nachman wrote: > > >> -----Original Message----- >> From: Conor Dooley <conor@kernel.org> >> Sent: Monday, January 8, 2024 8:01 PM >> To: Elad Nachman <enachman@marvell.com> >> Cc: gregkh@linuxfoundation.org; robh+dt@kernel.org; >> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; >> devicetree@vger.kernel.org; linux-usb@vger.kernel.org; linux- >> kernel@vger.kernel.org >> Subject: Re: [EXT] Re: [PATCH] dt-bindings: usb: Add Marvell ac5 >> >> On Mon, Jan 08, 2024 at 05:47:24PM +0000, Elad Nachman wrote: >>> >>> >>>> -----Original Message----- >>>> From: Conor Dooley <conor@kernel.org> >>>> Sent: Monday, January 8, 2024 7:15 PM >>>> To: Elad Nachman <enachman@marvell.com> >>>> Cc: gregkh@linuxfoundation.org; robh+dt@kernel.org; >>>> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; >>>> devicetree@vger.kernel.org; linux-usb@vger.kernel.org; linux- >>>> kernel@vger.kernel.org >>>> Subject: [EXT] Re: [PATCH] dt-bindings: usb: Add Marvell ac5 >>>> >>>> External Email >>>> >>>> -------------------------------------------------------------------- >>>> -- On Sun, Jan 07, 2024 at 05:25:57PM +0200, Elad Nachman wrote: >>>>> From: Elad Nachman <enachman@marvell.com> >>>>> >>>>> Add Marvell ac5 device tree bindings to generic EHCI. >>>>> This compatible enables the Marvell Orion platform code to >>>>> properly configure the DMA mask for the Marvell AC5 SOC. >>>>> >>>>> Signed-off-by: Elad Nachman <enachman@marvell.com> >>>> >>>> Maybe I am dumb, but I don't understand how this does what the >>>> commit message says. There's no fallback to generic-ehci or any >>>> other compatible that is already understood by the driver. >>>> >>>> What am I missing? >>> >>> Following guidance by Andrew Lunn on my mmc patchset, I have split the >>> patchset Into a single patch for dt-bindings review and another for USB >> driver review. >> >> I don't understand that advice. dt-bindings should (almost) always be with >> the driver. Otherwise you just confuse people like me. >> >> Perhaps Andrew meant sending dt*s* patches separately from the driver & >> bindings? > > The rational was different people making the actual merge, into different intermediate git REPOs, before mering into linux-next. Sorry, but NAK. The submitting-patches for bindings expresses this as well: bindings go with the driver. There was never an advice from Andrew about splitting binding. He clearly said that FIRST PATCH, so the DTS, goes via separate tree. Absolutely nothing about splitting the binding. https://lore.kernel.org/all/cfbbe706-5953-488c-9bff-f72f6d00b44f@lunn.ch/ Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Documentation/devicetree/bindings/usb/generic-ehci.yaml index 87986c45be88..2ed178f16a78 100644 --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml @@ -77,6 +77,7 @@ properties: - const: usb-ehci - enum: - generic-ehci + - marvell,ac5-ehci - marvell,armada-3700-ehci - marvell,orion-ehci - nuvoton,npcm750-ehci