diff mbox series

MIPS/GAS: mips.exp, mark all mipsisa32*-linux as addr32

Message ID 20231124085512.1812516-1-yunqiang.su@cipunited.com
State Accepted
Headers
Series MIPS/GAS: mips.exp, mark all mipsisa32*-linux as addr32 |

Checks

Context Check Description
snail/binutils-gdb-check success Github commit url

Commit Message

YunQiang Su Nov. 24, 2023, 8:55 a.m. UTC 
  Currently, only mipsisa32-linux and mipsisa32el-linux is marked
as addr32, which make mipsisa32rN(el) not marked.

This change can fix 2 test failures on mipsisa32rN(el)-linux:
	FAIL: MIPS MIPS64 MIPS-3D ASE instructions (-mips3d flag)
	FAIL: MIPS MIPS64 MDMX ASE instructions (-mdmx flag)

These failures don't happen for mipsisa32rN-mti-elf etc,
due to that, the output is set as NO_ABI instead of O32, then
gas won't warn:
	`fp=64' used with a 32-bit ABI
Maybe, we should change this behaivour in future.
---
 gas/testsuite/gas/mips/mips.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Nick Clifton Jan. 8, 2024, 2:45 p.m. UTC | #1 
Hi YunQiang,

> Currently, only mipsisa32-linux and mipsisa32el-linux is marked
> as addr32, which make mipsisa32rN(el) not marked.
> 
> This change can fix 2 test failures on mipsisa32rN(el)-linux:
> 	FAIL: MIPS MIPS64 MIPS-3D ASE instructions (-mips3d flag)
> 	FAIL: MIPS MIPS64 MDMX ASE instructions (-mdmx flag)

Patch approved and applied.

Cheers
   Nick
diff mbox series

Patch

diff --git a/gas/testsuite/gas/mips/mips.exp b/gas/testsuite/gas/mips/mips.exp
index bfcb3cbfaf3..d85db116967 100644
--- a/gas/testsuite/gas/mips/mips.exp
+++ b/gas/testsuite/gas/mips/mips.exp
@@ -564,7 +564,7 @@  if { [istarget mips*-*-vxworks*] } {
 	"MIPS invalid switch to SVR4 PIC from VxWorks PIC"
 } elseif { [istarget mips*-*-*] } {
     set addr32 [expr [istarget mipstx39*-*-*] || [istarget mips-*-linux*] || [istarget mipsel-*-linux*] \
-		     || [istarget mipsisa32-*-linux*] || [istarget mipsisa32el-*-linux*]]
+		     || [istarget mipsisa32*-*-linux*]]
     set has_newabi [expr [istarget *-*-irix6*] || [istarget mips*-*-linux*] \
                          || [istarget mips*-sde-elf*] || [istarget mips*-mti-elf*] \
                          || [istarget mips*-img-elf*]]