Message ID | 20240108072253.30183-2-qiujingbao.dlmu@gmail.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-19135-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:37c1:b0:101:2151:f287 with SMTP id y1csp872832dyq; Sun, 7 Jan 2024 23:23:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IEDCuJNVWOVldwnDKC3l326wUccPsNSDPBJO3kDbtl3IX5WkdFyNzei1lcYyS+52ifyWfFF X-Received: by 2002:a17:907:7e8a:b0:a2a:d108:7883 with SMTP id qb10-20020a1709077e8a00b00a2ad1087883mr270658ejc.135.1704698608677; Sun, 07 Jan 2024 23:23:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704698608; cv=none; d=google.com; s=arc-20160816; b=0a/chNvcQmOqL06Jbj8lm7RnOGxlNOOgNpFITGtVtieUsn3rkcR9LDGeEF48pPrv3F Y9+AC3zZ+LwKUA0YH6kzxMlZvFY2gzQGEt/JLNfOsLn4hQI3lzomrXsbX7ZqLQ5I6v/k VXBMsAyE2Ph8q/QdLAD637uqR528cbyI7aafc5hiF4Np/vg5Y7QnxCr8vuANw0GHA0t8 BZFcHSJDMm2w0QqK1YSSvbWW9G75Um1W7XQ2glcrZoseNR5TyiF4+3ymVp2M2Nnlxkgf XGVJEOdrio+jyRxzqzroMVl5rGZRk9bQfpiIp77TdfYMeqJplFZoogRfP7Wn6rXXIrAL lE5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=oU/7KnaY3R8It+5bk/kDDayYUebGyI/ajRMVKGdFzEk=; fh=duIfd7nXQo5012tZMrW0USTpl6mu8lithfpxKgenZvM=; b=ZV/VulqL5sV8BhoEwj8fBKButfepo9/MB2+kBMw3gsqyc2zZ58+UgmZ1dOOvHrjd3g X2bxUKZVpYDmXC3CrRAeHwnBOn9PIPuN7acT6idlcTBTRi7uG3bz/trGTMe6wApncvmM T0l1gVz7hHjtFI89Pd9dbgGYf/n2JeSme4ITha0Q7Bghjv9hTM9fT2soC6x1taZNNRQw 7jJBz6D1nmair42KY9Cx+JjKhQQWZ3HXuYTqPml5LyEdEdIpdJ6YpJGpMnEdfVwfHHR8 65VHIGESZsC9uVGEDx23ySnGvzLIzZYawZEGrYtK/n/AVqOjahBrE7r5FK535NMOC0oA QBAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=OHoA19XS; spf=pass (google.com: domain of linux-kernel+bounces-19135-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-19135-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id kj23-20020a170907765700b00a28f1eaeaedsi3037176ejc.698.2024.01.07.23.23.28 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jan 2024 23:23:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-19135-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=OHoA19XS; spf=pass (google.com: domain of linux-kernel+bounces-19135-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-19135-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 4A05B1F21CE7 for <ouuuleilei@gmail.com>; Mon, 8 Jan 2024 07:23:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 492348BE3; Mon, 8 Jan 2024 07:23:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OHoA19XS" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E7249467; Mon, 8 Jan 2024 07:23:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1d3e84fded7so3184985ad.1; Sun, 07 Jan 2024 23:23:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704698583; x=1705303383; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oU/7KnaY3R8It+5bk/kDDayYUebGyI/ajRMVKGdFzEk=; b=OHoA19XSQ/PYue/gsqkSftz1+lf2i86fGNAWvV8EcH08k2hb8inHEin9pF7IplMDX0 mIMmCI11uCIJYJl9cZGCp451FtEve/Z8ewJPzPG/ovuI0DmKl4bIzSTyo2thn0X/E2zt aM+I60XvcBgOVxGbMHzlohnBFWvjBSg1oS67cxdtmTQQR3OFTL1Ys1vQ+CBjgi5BPXry 6U+UxdB3jzWMiCUt3OoWsr4dNihzsFM0MZ4TXFdba9w33xVMjrZG4lhq1+JdN1ZRAqKd DLDF0poXUwcE8/V1PCr2ivdXgO1iI5U+Ugl0DPM+Qly9kXPvzutdI0kUgy5l0dGJxLgE 9DOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704698583; x=1705303383; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oU/7KnaY3R8It+5bk/kDDayYUebGyI/ajRMVKGdFzEk=; b=aInOGEGpNC4zZQx/ow803CCC0XP3ame5DbyXJxegl6u69Vcrof6dJpYb6ywSSqHwtO MUcponQbr15PLyEnxF9TXntG/u0HyAxM88z4TvkfyeloU3Hk9N0o4eppaE8SpYLclTaB v3L2p3m8Dne1WARHnfZvB4Zlgt31w0Gk4WrC6LbPWzVJPWsRNQZppNMmjoUYucsUeATs G3KJ+BLN3bBkWAn9t2mtEqKPo65LBoN/476P/gLkt8vnCichlWfjfvWeimEye5x5LA3y e0xlwFD/HwMS+fjWY+v2jo789L0BSx/MGL22DPza5ffK6YfeuNpR7pKPttdsY5yeEDdS 3JNg== X-Gm-Message-State: AOJu0Yy9N2A50Z3Flj6cHwJoHReQ8CGUjuEbRWnP6nAyXL9+gEyfiqaA rkYhKUIUbpgFB7s/v6MOkfU= X-Received: by 2002:a17:902:ecc4:b0:1d4:f319:85ea with SMTP id a4-20020a170902ecc400b001d4f31985eamr1043649plh.117.1704698583380; Sun, 07 Jan 2024 23:23:03 -0800 (PST) Received: from localhost ([39.70.12.102]) by smtp.gmail.com with ESMTPSA id c5-20020a170902d90500b001d33e6521b9sm5545937plz.14.2024.01.07.23.23.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jan 2024 23:23:03 -0800 (PST) From: Jingbao Qiu <qiujingbao.dlmu@gmail.com> To: a.zummo@towertech.it, alexandre.belloni@bootlin.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 1/1] dt-bindings: rtc: sophgo: add RTC support for Sophgo CV1800 series SoC Date: Mon, 8 Jan 2024 15:22:53 +0800 Message-ID: <20240108072253.30183-2-qiujingbao.dlmu@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240108072253.30183-1-qiujingbao.dlmu@gmail.com> References: <20240108072253.30183-1-qiujingbao.dlmu@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787506048643081569 X-GMAIL-MSGID: 1787506048643081569 |
Series |
[v5,1/1] dt-bindings: rtc: sophgo: add RTC support for Sophgo CV1800 series SoC
|
|
Commit Message
Jingbao Qiu
Jan. 8, 2024, 7:22 a.m. UTC
Add RTC devicetree binding for Sophgo CV1800 SoC. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@gmail.com> --- .../bindings/rtc/sophgo,cv1800-rtc.yaml | 56 +++++++++++++++++++ 1 file changed, 56 insertions(+) create mode 100644 Documentation/devicetree/bindings/rtc/sophgo,cv1800-rtc.yaml
Comments
On 08/01/2024 08:22, Jingbao Qiu wrote: > Add RTC devicetree binding for Sophgo CV1800 SoC. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@gmail.com> > --- > .../bindings/rtc/sophgo,cv1800-rtc.yaml | 56 +++++++++++++++++++ > 1 file changed, 56 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/sophgo,cv1800-rtc.yaml > > diff --git a/Documentation/devicetree/bindings/rtc/sophgo,cv1800-rtc.yaml b/Documentation/devicetree/bindings/rtc/sophgo,cv1800-rtc.yaml > new file mode 100644 > index 000000000000..01a926cb5c81 > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/sophgo,cv1800-rtc.yaml > @@ -0,0 +1,56 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/sophgo,cv1800-rtc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Real Time Clock of the Sophgo CV1800 SoC > + > +allOf: > + - $ref: rtc.yaml# Why the allOf has moved? > + > +maintainers: > + - Jingbao Qiu <qiujingbao.dlmu@gmail.com> > + > +description: > + Real Time Clock (RTC) is an independently powered module > + within the chip, which includes a 32KHz oscillator and a > + Power On Reset/POR submodule. It can be used for time display > + and timed alarm generation. In addition, the hardware state > + machine provides triggering and timing control for chip > + power on, off, and reset. > + > +properties: > + compatible: > + items: > + - const: sophgo,cv1800-rtc > + - const: syscon Why is this syscon? Description does not explain this. > + > + reg: > + maxItems: 1 Best regards, Krzysztof
On Mon, Jan 8, 2024 at 4:04 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 08/01/2024 08:22, Jingbao Qiu wrote: > > Add RTC devicetree binding for Sophgo CV1800 SoC. > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@gmail.com> > > --- > > .../bindings/rtc/sophgo,cv1800-rtc.yaml | 56 +++++++++++++++++++ > > 1 file changed, 56 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/rtc/sophgo,cv1800-rtc.yaml > > > > diff --git a/Documentation/devicetree/bindings/rtc/sophgo,cv1800-rtc.yaml b/Documentation/devicetree/bindings/rtc/sophgo,cv1800-rtc.yaml > > new file mode 100644 > > index 000000000000..01a926cb5c81 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/rtc/sophgo,cv1800-rtc.yaml > > @@ -0,0 +1,56 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/rtc/sophgo,cv1800-rtc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Real Time Clock of the Sophgo CV1800 SoC > > + > > +allOf: > > + - $ref: rtc.yaml# > > Why the allOf has moved? Hi, Do you mean allof should be under maintainers? Or other meanings. > > > + > > +maintainers: > > + - Jingbao Qiu <qiujingbao.dlmu@gmail.com> > > + > > +description: > > + Real Time Clock (RTC) is an independently powered module > > + within the chip, which includes a 32KHz oscillator and a > > + Power On Reset/POR submodule. It can be used for time display > > + and timed alarm generation. In addition, the hardware state > > + machine provides triggering and timing control for chip > > + power on, off, and reset. > > + > > +properties: > > + compatible: > > + items: > > + - const: sophgo,cv1800-rtc > > + - const: syscon > > Why is this syscon? Description does not explain this. Because the driver of the submodule POR in RTC only requires register address and range to work, according to what you said, it is only a compatible attribute and does not need to be a child node. So I wrote the following in the changelog. - add syscon attribute to share registers with POR Best regards, Jingbao Qiu
On 08/01/2024 10:10, Jingbao Qiu wrote: > On Mon, Jan 8, 2024 at 4:04 PM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On 08/01/2024 08:22, Jingbao Qiu wrote: >>> Add RTC devicetree binding for Sophgo CV1800 SoC. >>> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@gmail.com> >>> --- >>> .../bindings/rtc/sophgo,cv1800-rtc.yaml | 56 +++++++++++++++++++ >>> 1 file changed, 56 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/rtc/sophgo,cv1800-rtc.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/rtc/sophgo,cv1800-rtc.yaml b/Documentation/devicetree/bindings/rtc/sophgo,cv1800-rtc.yaml >>> new file mode 100644 >>> index 000000000000..01a926cb5c81 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/rtc/sophgo,cv1800-rtc.yaml >>> @@ -0,0 +1,56 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/rtc/sophgo,cv1800-rtc.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Real Time Clock of the Sophgo CV1800 SoC >>> + >>> +allOf: >>> + - $ref: rtc.yaml# >> >> Why the allOf has moved? > > Hi, > Do you mean allof should be under maintainers? Or other meanings. Yes and the patch which got my review had it correctly placed. > >> >>> + >>> +maintainers: >>> + - Jingbao Qiu <qiujingbao.dlmu@gmail.com> >>> + >>> +description: >>> + Real Time Clock (RTC) is an independently powered module >>> + within the chip, which includes a 32KHz oscillator and a >>> + Power On Reset/POR submodule. It can be used for time display >>> + and timed alarm generation. In addition, the hardware state >>> + machine provides triggering and timing control for chip >>> + power on, off, and reset. >>> + >>> +properties: >>> + compatible: >>> + items: >>> + - const: sophgo,cv1800-rtc >>> + - const: syscon >> >> Why is this syscon? Description does not explain this. > > Because the driver of the submodule POR in RTC only requires register > address and range to work, according to what you said, it is only a compatible > attribute and does not need to be a child node. What child node has anything to do with syscon? Anyway I don't understand that. > > So I wrote the following in the changelog. > > - add syscon attribute to share registers > with POR Where is this syscon attribute? Please point me to specific line in DTS and in the driver. Best regards, Krzysztof
On Mon, Jan 8, 2024 at 5:28 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 08/01/2024 10:10, Jingbao Qiu wrote: > > On Mon, Jan 8, 2024 at 4:04 PM Krzysztof Kozlowski > > <krzysztof.kozlowski@linaro.org> wrote: > >> > >> On 08/01/2024 08:22, Jingbao Qiu wrote: > >>> Add RTC devicetree binding for Sophgo CV1800 SoC. > >>> > >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >>> Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@gmail.com> > >>> --- > >>> .../bindings/rtc/sophgo,cv1800-rtc.yaml | 56 +++++++++++++++++++ > >>> 1 file changed, 56 insertions(+) > >>> create mode 100644 Documentation/devicetree/bindings/rtc/sophgo,cv1800-rtc.yaml > >>> > >>> diff --git a/Documentation/devicetree/bindings/rtc/sophgo,cv1800-rtc.yaml b/Documentation/devicetree/bindings/rtc/sophgo,cv1800-rtc.yaml > >>> new file mode 100644 > >>> index 000000000000..01a926cb5c81 > >>> --- /dev/null > >>> +++ b/Documentation/devicetree/bindings/rtc/sophgo,cv1800-rtc.yaml > >>> @@ -0,0 +1,56 @@ > >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >>> +%YAML 1.2 > >>> +--- > >>> +$id: http://devicetree.org/schemas/rtc/sophgo,cv1800-rtc.yaml# > >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >>> + > >>> +title: Real Time Clock of the Sophgo CV1800 SoC > >>> + > >>> +allOf: > >>> + - $ref: rtc.yaml# > >> > >> Why the allOf has moved? > > > > Hi, > > Do you mean allof should be under maintainers? Or other meanings. > > Yes and the patch which got my review had it correctly placed. > Thank you for your reply. I will adjust their order. > > > >> > >>> + > >>> +maintainers: > >>> + - Jingbao Qiu <qiujingbao.dlmu@gmail.com> > >>> + > >>> +description: > >>> + Real Time Clock (RTC) is an independently powered module > >>> + within the chip, which includes a 32KHz oscillator and a > >>> + Power On Reset/POR submodule. It can be used for time display > >>> + and timed alarm generation. In addition, the hardware state > >>> + machine provides triggering and timing control for chip > >>> + power on, off, and reset. > >>> + > >>> +properties: > >>> + compatible: > >>> + items: > >>> + - const: sophgo,cv1800-rtc > >>> + - const: syscon > >> > >> Why is this syscon? Description does not explain this. > > > > Because the driver of the submodule POR in RTC only requires register > > address and range to work, according to what you said, it is only a compatible > > attribute and does not need to be a child node. > > What child node has anything to do with syscon? Anyway I don't > understand that. > > > > > So I wrote the following in the changelog. > > > > - add syscon attribute to share registers > > with POR > > Where is this syscon attribute? Please point me to specific line in DTS > and in the driver. I will explain in the next version of DTS. Thank you again for your patient reply. Best regards, Jingbao Qiu
On 08/01/2024 14:47, Jingbao Qiu wrote: >>> So I wrote the following in the changelog. >>> >>> - add syscon attribute to share registers >>> with POR >> >> Where is this syscon attribute? Please point me to specific line in DTS >> and in the driver. > > I will explain in the next version of DTS. > Thank you again for your patient reply. You added some syscon attribute. What is this? Best regards, Krzysztof
On Mon, Jan 8, 2024 at 11:24 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 08/01/2024 14:47, Jingbao Qiu wrote: > >>> So I wrote the following in the changelog. > >>> > >>> - add syscon attribute to share registers > >>> with POR > >> > >> Where is this syscon attribute? Please point me to specific line in DTS > >> and in the driver. > > > > I will explain in the next version of DTS. > > Thank you again for your patient reply. > > You added some syscon attribute. What is this? > This RTC device has a POR submodule, which is explained in the description. The corresponding driver of the POR submodule provides power off restart function. The driver of the POR submodule just uses reg to work.As you mentioned in your last comment.POR is empty, so there is little point in having it as subnode. we need share the reg to POR. RTC driver and POR driver will access this address simultaneously. so,I added this syscon attribute. Best regards, Jingbao Qiu
On 09/01/2024 03:26, Jingbao Qiu wrote: > On Mon, Jan 8, 2024 at 11:24 PM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On 08/01/2024 14:47, Jingbao Qiu wrote: >>>>> So I wrote the following in the changelog. >>>>> >>>>> - add syscon attribute to share registers >>>>> with POR >>>> >>>> Where is this syscon attribute? Please point me to specific line in DTS >>>> and in the driver. >>> >>> I will explain in the next version of DTS. >>> Thank you again for your patient reply. >> >> You added some syscon attribute. What is this? >> > > This RTC device has a POR submodule, which is explained in the description. > The corresponding driver of the POR submodule provides power off > restart function. > The driver of the POR submodule just uses reg to work.As you mentioned in your > last comment.POR is empty, so there is little point in having it as > subnode. we need > share the reg to POR. RTC driver and POR driver will access this > address simultaneously. > so,I added this syscon attribute. Nothing from above explains what is "syscon attribute", but if you cannot explain it, at least point me to where did you add this syscon attribute? Changelog said you added it. Where? Best regards, Krzysztof
On Tue, Jan 9, 2024 at 4:02 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 09/01/2024 03:26, Jingbao Qiu wrote: > > On Mon, Jan 8, 2024 at 11:24 PM Krzysztof Kozlowski > > <krzysztof.kozlowski@linaro.org> wrote: > >> > >> On 08/01/2024 14:47, Jingbao Qiu wrote: > >>>>> So I wrote the following in the changelog. > >>>>> > >>>>> - add syscon attribute to share registers > >>>>> with POR > >>>> > >>>> Where is this syscon attribute? Please point me to specific line in DTS > >>>> and in the driver. > >>> > >>> I will explain in the next version of DTS. > >>> Thank you again for your patient reply. > >> > >> You added some syscon attribute. What is this? > >> > > > > This RTC device has a POR submodule, which is explained in the description. > > The corresponding driver of the POR submodule provides power off > > restart function. > > The driver of the POR submodule just uses reg to work.As you mentioned in your > > last comment.POR is empty, so there is little point in having it as > > subnode. we need > > share the reg to POR. RTC driver and POR driver will access this > > address simultaneously. > > so,I added this syscon attribute. > > Nothing from above explains what is "syscon attribute", but if you > cannot explain it, at least point me to where did you add this syscon > attribute? Changelog said you added it. Where? > Thank you for your comment. I will add it in the next version. Best regards, Jingbao Qiu
diff --git a/Documentation/devicetree/bindings/rtc/sophgo,cv1800-rtc.yaml b/Documentation/devicetree/bindings/rtc/sophgo,cv1800-rtc.yaml new file mode 100644 index 000000000000..01a926cb5c81 --- /dev/null +++ b/Documentation/devicetree/bindings/rtc/sophgo,cv1800-rtc.yaml @@ -0,0 +1,56 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/rtc/sophgo,cv1800-rtc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Real Time Clock of the Sophgo CV1800 SoC + +allOf: + - $ref: rtc.yaml# + +maintainers: + - Jingbao Qiu <qiujingbao.dlmu@gmail.com> + +description: + Real Time Clock (RTC) is an independently powered module + within the chip, which includes a 32KHz oscillator and a + Power On Reset/POR submodule. It can be used for time display + and timed alarm generation. In addition, the hardware state + machine provides triggering and timing control for chip + power on, off, and reset. + +properties: + compatible: + items: + - const: sophgo,cv1800-rtc + - const: syscon + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + maxItems: 1 + +required: + - compatible + - reg + - interrupts + - clocks + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + + rtc@5025000 { + compatible = "sophgo,cv1800-rtc", "syscon"; + reg = <0x5025000 0x2000>; + interrupts = <17 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clk 15>; + }; +...