diff mbox series

[v1,1/1] selftests: net: increase timeout value for tests

Message ID 20240107003929.891669-1-mirsad.todorovac@alu.unizg.hr
State New
Headers
Series [v1,1/1] selftests: net: increase timeout value for tests |

Commit Message

Mirsad Todorovac Jan. 7, 2024, 12:39 a.m. UTC 
  In particular, fcnal-test.sh timed out on slower hardware after
some new permutations of tests were added.

This single test ran for almost an hour instead of the expected
25 min (1500s). 75 minutes should suffice for most systems.

Cc: David Ahern <dsahern@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: netdev@vger.kernel.org
Cc: linux-kselftest@vger.kernel.org
Signed-off-by: Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>
---
 tools/testing/selftests/net/settings | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Hangbin Liu Jan. 7, 2024, 12:49 p.m. UTC | #1 
On Sun, Jan 07, 2024 at 01:39:29AM +0100, Mirsad Todorovac wrote:
> In particular, fcnal-test.sh timed out on slower hardware after
> some new permutations of tests were added.
> 
> This single test ran for almost an hour instead of the expected
> 25 min (1500s). 75 minutes should suffice for most systems.
> 
> Cc: David Ahern <dsahern@kernel.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: Shuah Khan <shuah@kernel.org>
> Cc: netdev@vger.kernel.org
> Cc: linux-kselftest@vger.kernel.org
> Signed-off-by: Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>
> ---
>  tools/testing/selftests/net/settings | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/net/settings b/tools/testing/selftests/net/settings
> index dfc27cdc6c05..ed8418e8217a 100644
> --- a/tools/testing/selftests/net/settings
> +++ b/tools/testing/selftests/net/settings
> @@ -1 +1 @@
> -timeout=1500
> +timeout=4500
> -- 
> 2.40.1
> 

FYI, the net-next patch 779283b7770f ("selftests/net: convert fcnal-test.sh
to run it in unique namespace") has extended the timeout to 3600s.

Thanks
Hangbin
Mirsad Todorovac Jan. 7, 2024, 3:22 p.m. UTC | #2 
On 07. 01. 2024. 13:49, Hangbin Liu wrote:
> On Sun, Jan 07, 2024 at 01:39:29AM +0100, Mirsad Todorovac wrote:
>> In particular, fcnal-test.sh timed out on slower hardware after
>> some new permutations of tests were added.
>>
>> This single test ran for almost an hour instead of the expected
>> 25 min (1500s). 75 minutes should suffice for most systems.
>>
>> Cc: David Ahern <dsahern@kernel.org>
>> Cc: "David S. Miller" <davem@davemloft.net>
>> Cc: Eric Dumazet <edumazet@google.com>
>> Cc: Jakub Kicinski <kuba@kernel.org>
>> Cc: Paolo Abeni <pabeni@redhat.com>
>> Cc: Shuah Khan <shuah@kernel.org>
>> Cc: netdev@vger.kernel.org
>> Cc: linux-kselftest@vger.kernel.org
>> Signed-off-by: Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>
>> ---
>>  tools/testing/selftests/net/settings | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/net/settings b/tools/testing/selftests/net/settings
>> index dfc27cdc6c05..ed8418e8217a 100644
>> --- a/tools/testing/selftests/net/settings
>> +++ b/tools/testing/selftests/net/settings
>> @@ -1 +1 @@
>> -timeout=1500
>> +timeout=4500
>> -- 
>> 2.40.1
>>
> 
> FYI, the net-next patch 779283b7770f ("selftests/net: convert fcnal-test.sh
> to run it in unique namespace") has extended the timeout to 3600s.
> 
> Thanks
> Hangbin

Copy that.

Haven't checked the net-next tree, sorry.

As your patch is prior art, then this commit is duplicate work.

Haven't yet found howto follow all the next-trees required to fix selftests,
though :-/ 

Best regards,
Mirsad
diff mbox series

Patch

diff --git a/tools/testing/selftests/net/settings b/tools/testing/selftests/net/settings
index dfc27cdc6c05..ed8418e8217a 100644
--- a/tools/testing/selftests/net/settings
+++ b/tools/testing/selftests/net/settings
@@ -1 +1 @@ 
-timeout=1500
+timeout=4500