[v2,1/2] dt-bindings: reset: mediatek: add MT7988 LVTS reset ID

Message ID 20240105162056.43266-2-linux@fw-web.de
State New
Headers
Series Add reset controller to mt7988 infracfg |

Commit Message

Frank Wunderlich Jan. 5, 2024, 4:20 p.m. UTC
  From: Frank Wunderlich <frank-w@public-files.de>

Add reset constant for using as index in driver and dts.

Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
v2:
 - add missing commit message and SoB
 - change value of infrareset to 0
---
 include/dt-bindings/reset/mediatek,mt7988-resets.h | 4 ++++
 1 file changed, 4 insertions(+)
  

Comments

Krzysztof Kozlowski Jan. 7, 2024, 11:23 a.m. UTC | #1
On 05/01/2024 17:20, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
> 
> Add reset constant for using as index in driver and dts.
> 
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> v2:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
  
Matthias Brugger Jan. 22, 2024, 8:57 a.m. UTC | #2
On 05/01/2024 17:20, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
> 
> Add reset constant for using as index in driver and dts.
> 
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

> ---
> v2:
>   - add missing commit message and SoB
>   - change value of infrareset to 0
> ---
>   include/dt-bindings/reset/mediatek,mt7988-resets.h | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/include/dt-bindings/reset/mediatek,mt7988-resets.h b/include/dt-bindings/reset/mediatek,mt7988-resets.h
> index 493301971367..0216eeb249c7 100644
> --- a/include/dt-bindings/reset/mediatek,mt7988-resets.h
> +++ b/include/dt-bindings/reset/mediatek,mt7988-resets.h
> @@ -10,4 +10,8 @@
>   /* ETHWARP resets */
>   #define MT7988_ETHWARP_RST_SWITCH		0
>   
> +/* INFRA resets */
> +#define MT7988_INFRA_RST0_THERM_CTRL_SWRST	0
> +
>   #endif  /* _DT_BINDINGS_RESET_CONTROLLER_MT7988 */
> +
  
Frank Wunderlich Jan. 24, 2024, 5:01 p.m. UTC | #3
> Gesendet: Montag, 22. Januar 2024 um 09:57 Uhr
> Von: "Matthias Brugger" <matthias.bgg@gmail.com>
> On 05/01/2024 17:20, Frank Wunderlich wrote:
> > From: Frank Wunderlich <frank-w@public-files.de>
> >
> > Add reset constant for using as index in driver and dts.
> >
> > Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

Hi

good to hear again from you Matthias. unfortunately there is already a v3 out,
where i added multiple reset offsets/ids. Can you please review this one?

https://patchwork.kernel.org/project/linux-mediatek/list/?series=817619

and i also wait for 2 other patches to be reviewed before bpi-r4 dts patches can go in:

https://patchwork.kernel.org/project/linux-mediatek/patch/20231025170832.78727-5-linux@fw-web.de/

regards Frank
  

Patch

diff --git a/include/dt-bindings/reset/mediatek,mt7988-resets.h b/include/dt-bindings/reset/mediatek,mt7988-resets.h
index 493301971367..0216eeb249c7 100644
--- a/include/dt-bindings/reset/mediatek,mt7988-resets.h
+++ b/include/dt-bindings/reset/mediatek,mt7988-resets.h
@@ -10,4 +10,8 @@ 
 /* ETHWARP resets */
 #define MT7988_ETHWARP_RST_SWITCH		0
 
+/* INFRA resets */
+#define MT7988_INFRA_RST0_THERM_CTRL_SWRST	0
+
 #endif  /* _DT_BINDINGS_RESET_CONTROLLER_MT7988 */
+