Message ID | 20240105110007.3f932561@canb.auug.org.au |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-17344-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp5935841dyb; Thu, 4 Jan 2024 16:00:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IHjan0OkPXeq4fgeAa6HgZ40e1WOMrImiAQGnEXZ89+4xj/bP3n4Dn3oHJKS3xhnpMF0V0x X-Received: by 2002:a05:622a:203:b0:428:301e:3e3c with SMTP id b3-20020a05622a020300b00428301e3e3cmr1428819qtx.12.1704412837156; Thu, 04 Jan 2024 16:00:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704412837; cv=none; d=google.com; s=arc-20160816; b=CSlTzer6Z+hlDJFQlSbpdEZtM1E05x+PW8neK0k1v/yXPREAxZulzPkPSx3p5NzSA3 y7Uy61ynJwmpWewymXzKRflDikO2hnfpZny+v1rZWqbjGL6+0mR6VNfZ7qyoV3BwZ2/U XteT5GMd0tiQbaL1K1wlgQ87GJbRpdsxLFyBFy99BHtBMN+czgX58Nt71jsEgadM4Lb3 aMoEJfBj4wx3ryEGqXvo52i2ENBhc1XAW65zE+8cwQMXafeYsmiVkhFc06U+V60K8SVH s4mk88ViiQjsLTXHz9p5D/2m8tXS7nhLAEOSg/C//boi9lgMYOcpCej7rx5GzPhvCTV8 WkLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:subject:cc:to:from:date:dkim-signature; bh=fKTT20mUaFZY3aDpSIBX+2Ae7sQrUaC79fPao4Mb0Fw=; fh=sIvEq0NsstD4EEueBiHK/4EQehJ/Gc/Ni5QHgTe5ZfE=; b=DzSvKAfkEfJdspMetQIHj/+pFSZ99kcyvii4aRz75u85FhH/H1Ga2o3NMRKeUEEwG1 OalWAkODegWd830+zWdietTyjtLdajUTl2ERNH0Ae/jpBmUOZbJj/2GKR3elCJXj9uU+ OssbMPoHHcNmJ4U4v1QVVgnb05OUw8ZCOcGxA6VmPYmMqWmzDqrVD3W72uoUwAqfP0Rp uVoAYGGcpAS+tPDVNNIFFRwzh6o248eopyeOe9dVJ2Q7zNHew2hGVjW4Ng1Wy3S/sKAc oX5JAovNgngnlStRmLxxwPyTB77t3lStNQCUaJm3dz4PpR0wpB+NjUgzxBJx1QmJ3iMI Ll1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canb.auug.org.au header.s=201702 header.b=TCmSXmbQ; spf=pass (google.com: domain of linux-kernel+bounces-17344-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-17344-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canb.auug.org.au Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id v13-20020a05622a188d00b00428ad750e3dsi659616qtc.3.2024.01.04.16.00.37 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jan 2024 16:00:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-17344-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@canb.auug.org.au header.s=201702 header.b=TCmSXmbQ; spf=pass (google.com: domain of linux-kernel+bounces-17344-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-17344-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canb.auug.org.au Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id EE3761C22121 for <ouuuleilei@gmail.com>; Fri, 5 Jan 2024 00:00:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 654582D62E; Fri, 5 Jan 2024 00:00:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=canb.auug.org.au header.i=@canb.auug.org.au header.b="TCmSXmbQ" X-Original-To: linux-kernel@vger.kernel.org Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB4F92D601; Fri, 5 Jan 2024 00:00:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=canb.auug.org.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=canb.auug.org.au DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canb.auug.org.au; s=201702; t=1704412810; bh=fKTT20mUaFZY3aDpSIBX+2Ae7sQrUaC79fPao4Mb0Fw=; h=Date:From:To:Cc:Subject:From; b=TCmSXmbQ7Y3+a9JsKY0i5cANtaJ7cT67pUSaPAWxiKxXX2AXU8Q/Jtb0ArC9l7r8q 6fuUbPawVMeksZb6SX/cdSMM0LV9DRMVwI2K22ErZPs1RnoC9mfVTi2XNYN7TgjJZM r45lOjl18xgtyTKEi8vzf2c2lxDOE27HmGBYtz+qAlpy9U2yW+ZiMsoHQ57+EgnKYj q7nCjBjxoMvM4AZLTMIJCKVo3/oqXY4crGyn79KhJPJabao7RT7ZApgQBWtOiv9uCL nFEUlE38VJyosmKK25Iw4kU769waCsFqCYfpjkCnt/3vkY10k3Kxn4XoTKHBN84TmH QVOT4PYmSXIkw== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4T5k9P1dNMz4x1p; Fri, 5 Jan 2024 11:00:09 +1100 (AEDT) Date: Fri, 5 Jan 2024 11:00:07 +1100 From: Stephen Rothwell <sfr@canb.auug.org.au> To: Chuck Lever <chuck.lever@oracle.com> Cc: Jeff Layton <jlayton@kernel.org>, Jeffrey Layton <jlayton@redhat.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Linux Next Mailing List <linux-next@vger.kernel.org>, NeilBrown <neilb@suse.de> Subject: linux-next: manual merge of the nfsd tree with the nfsd-fixes tree Message-ID: <20240105110007.3f932561@canb.auug.org.au> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/4J7C/_dIb=E8/SkMhbC3zsY"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787206394997231682 X-GMAIL-MSGID: 1787206394997231682 |
Series |
linux-next: manual merge of the nfsd tree with the nfsd-fixes tree
|
|
Commit Message
Stephen Rothwell
Jan. 5, 2024, midnight UTC
Hi all, Today's linux-next merge of the nfsd tree got a conflict in: fs/nfsd/nfsctl.c between commit: 76d296a82657 ("nfsd: drop the nfsd_put helper") from the nfsd-fixes tree and commits: 3a0b966ab40f ("SUNRPC: discard sv_refcnt, and svc_get/svc_put") 9bf4b41b79a3 ("nfsd: rename nfsd_last_thread() to nfsd_destroy_serv()") from the nfsd tree. I fixed it up (see below) and can carry the fix as necessary. This is now fixed as far as linux-next is concerned, but any non trivial conflicts should be mentioned to your upstream maintainer when your tree is submitted for merging. You may also want to consider cooperating with the maintainer of the conflicting tree to minimise any particularly complex conflicts.
Comments
On Fri, Jan 05, 2024 at 11:00:07AM +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the nfsd tree got a conflict in: > > fs/nfsd/nfsctl.c > > between commit: > > 76d296a82657 ("nfsd: drop the nfsd_put helper") > > from the nfsd-fixes tree and commits: > > 3a0b966ab40f ("SUNRPC: discard sv_refcnt, and svc_get/svc_put") > 9bf4b41b79a3 ("nfsd: rename nfsd_last_thread() to nfsd_destroy_serv()") > > from the nfsd tree. Ugh. I plan to rebase nfsd-next as soon as 76d296a82657 ("nfsd: drop the nfsd_put helper") is merged. I'll have a closer look at this conflict tomorrow (my time). > I fixed it up (see below) and can carry the fix as necessary. This > is now fixed as far as linux-next is concerned, but any non trivial > conflicts should be mentioned to your upstream maintainer when your tree > is submitted for merging. You may also want to consider cooperating > with the maintainer of the conflicting tree to minimise any particularly > complex conflicts. > > -- > Cheers, > Stephen Rothwell > > diff --cc fs/nfsd/nfsctl.c > index 87fed75808ff,cca1dd7b8c55..000000000000 > --- a/fs/nfsd/nfsctl.c > +++ b/fs/nfsd/nfsctl.c > @@@ -704,15 -707,12 +708,12 @@@ static ssize_t __write_ports_addfd(cha > if (err != 0) > return err; > > - err = svc_addsock(nn->nfsd_serv, net, fd, buf, SIMPLE_TRANSACTION_LIMIT, cred); > + serv = nn->nfsd_serv; > + err = svc_addsock(serv, net, fd, buf, SIMPLE_TRANSACTION_LIMIT, cred); > > - if (err < 0 && !serv->sv_nrthreads && !nn->keep_active) > - nfsd_last_thread(net); > - else if (err >= 0 && !serv->sv_nrthreads && !xchg(&nn->keep_active, 1)) > - svc_get(serv); > - if (!nn->nfsd_serv->sv_nrthreads && > - list_empty(&nn->nfsd_serv->sv_permsocks)) > ++ if (!serv->sv_nrthreads && list_empty(&serv->sv_permsocks)) > + nfsd_destroy_serv(net); > > - svc_put(serv); > return err; > } > > @@@ -750,22 -748,18 +751,17 @@@ static ssize_t __write_ports_addxprt(ch > if (err < 0 && err != -EAFNOSUPPORT) > goto out_close; > > - if (!serv->sv_nrthreads && !xchg(&nn->keep_active, 1)) > - svc_get(serv); > - > - svc_put(serv); > return 0; > out_close: > - xprt = svc_find_xprt(nn->nfsd_serv, transport, net, PF_INET, port); > + xprt = svc_find_xprt(serv, transport, net, PF_INET, port); > if (xprt != NULL) { > svc_xprt_close(xprt); > svc_xprt_put(xprt); > } > out_err: > - if (!serv->sv_nrthreads && !nn->keep_active) > - nfsd_last_thread(net); > - if (!nn->nfsd_serv->sv_nrthreads && > - list_empty(&nn->nfsd_serv->sv_permsocks)) > ++ if (!serv->sv_nrthreads && list_empty(&serv->sv_permsocks)) > + nfsd_destroy_serv(net); > > - svc_put(serv); > return err; > } >
Hi Chuck, On Thu, 4 Jan 2024 22:51:07 -0500 Chuck Lever <chuck.lever@oracle.com> wrote: > > I plan to rebase nfsd-next as soon as 76d296a82657 ("nfsd: drop the > nfsd_put helper") is merged. I'll have a closer look at this > conflict tomorrow (my time). Instead of rebasing your tree just before the merge window, why not just merge nfsd-fixes into the nfsd tree?
> On Jan 5, 2024, at 5:33 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > Hi Chuck, > > On Thu, 4 Jan 2024 22:51:07 -0500 Chuck Lever <chuck.lever@oracle.com> wrote: >> >> I plan to rebase nfsd-next as soon as 76d296a82657 ("nfsd: drop the >> nfsd_put helper") is merged. I'll have a closer look at this >> conflict tomorrow (my time). > > Instead of rebasing your tree just before the merge window, why not > just merge nfsd-fixes into the nfsd tree? My development toolchain is stgit, where rebasing is butt- simple. I'm not smart enough to make all that work out, and merges make my head hurt. That's why I let you and Linus handle it, and then never rebase once my PRs are merged into torvalds/linux.git. I'm open to learning more, but I might resist making my dev workflow more complicated. -- Chuck Lever
Hi Chuck, On Sat, 6 Jan 2024 00:26:53 +0000 Chuck Lever III <chuck.lever@oracle.com> wrote: > > My development toolchain is stgit, where rebasing is butt- > simple. > > I'm not smart enough to make all that work out, and merges > make my head hurt. That's why I let you and Linus handle it, > and then never rebase once my PRs are merged into > torvalds/linux.git. > > I'm open to learning more, but I might resist making my dev > workflow more complicated. Understood, but if you are interested, see Documentation/maintainer/rebasing-and-merging.rst
diff --cc fs/nfsd/nfsctl.c index 87fed75808ff,cca1dd7b8c55..000000000000 --- a/fs/nfsd/nfsctl.c