Message ID | 20231221165805.0c4771c1@canb.auug.org.au |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-7875-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2483:b0:fb:cd0c:d3e with SMTP id q3csp208119dyi; Wed, 20 Dec 2023 21:58:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IHBV6gR0yIPz/4K0+cHockUS4NY5GsKXlILczfqakR0GKLQx89cf1xBUHqBY/C1+whVcsyZ X-Received: by 2002:a25:ad21:0:b0:dbd:3ff8:eba8 with SMTP id y33-20020a25ad21000000b00dbd3ff8eba8mr660814ybi.18.1703138324204; Wed, 20 Dec 2023 21:58:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703138324; cv=none; d=google.com; s=arc-20160816; b=if/voghD6cCekSyDdZJXw+bDHIdxAVArlsSFvkzPQ4uYdGI32DZm1Til5sJINZIqNO zV0z9MHXVWz4ylIi7tVsdpUwmmg4/JGu4iiHTpWRRaGM2+6YV8KRD0nN9nlD6NEC4OiR /amxjYb+jl1OVAiX+aNYQ0rHumFri6cBFPFyorKETw8hAowK8eNfUOrN6IQ5OAY6J9ij vQLB9X0xafxwMJ8/dQh0D4jV0yz/q9sHDLHXyvWEgknK+Ro4E5RkFUyAkzj6RURwSUMy Xg3I0t8KxQqKsuvHM9ZmJAFST4YLIHjilvtdD3420y/MQDx78Z9SY3oaclO8pBNlcZ6D 2+IQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:subject:cc:to:from:date:dkim-signature; bh=W9WVhROU+IkzZLwkcXujAUaruo43ab/6jRxwxCmucCQ=; fh=IIpBq85ljUotdvBcw9mdyL8GadkmAcb79uo/zKqb/mQ=; b=QBdFLh+WqrMf/whSzaxzNgmerSF9PuMxZqGXFJPGEA/rto3w7d2VeoZgg1TzDQn9d5 GPdWipTBbfp+KCBJzY7g5tG7jH0ZzOSn5W7rcBBqguOMsDFCSKaJWW1qH9U1ZATH+Gi6 JeGMPsoPyXCPbCu983p+ychvTKiDVXRSQ7kk2yjmKwyPEBQ5bXLzaB8fJpx0KQ8tl/Dv HsvJPtodIKdDgQdYPhufHAVPiohvOsLtrH+dutaav45qqn4FxgaAXLDPnft5t5izkEH0 MRw48I6T0qa5l4rsg/eu3/+q7xs2K6RQQJlyouqNhg2zaFRROWJG5ufrcSwkwJuCAO1P s4fA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canb.auug.org.au header.s=201702 header.b=Vs3XnrV2; spf=pass (google.com: domain of linux-kernel+bounces-7875-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7875-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canb.auug.org.au Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id l190-20020a6388c7000000b005cd88fb7735si979081pgd.551.2023.12.20.21.58.44 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 21:58:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-7875-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@canb.auug.org.au header.s=201702 header.b=Vs3XnrV2; spf=pass (google.com: domain of linux-kernel+bounces-7875-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7875-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canb.auug.org.au Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id EFC9C28557F for <ouuuleilei@gmail.com>; Thu, 21 Dec 2023 05:58:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 362DE11735; Thu, 21 Dec 2023 05:58:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=canb.auug.org.au header.i=@canb.auug.org.au header.b="Vs3XnrV2" X-Original-To: linux-kernel@vger.kernel.org Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8B19C2E6; Thu, 21 Dec 2023 05:58:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=canb.auug.org.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=canb.auug.org.au DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canb.auug.org.au; s=201702; t=1703138287; bh=W9WVhROU+IkzZLwkcXujAUaruo43ab/6jRxwxCmucCQ=; h=Date:From:To:Cc:Subject:From; b=Vs3XnrV2DBaQye1qqFRU4nZywhbLwz/LF0l9b3l4mN+9cwK5d8CqBypB26Ab0T3xy 6cTaRexp+nnVR/VUQw93kuDu0VrVy1RGqAwwy9Ee58MWHhqMZ1s6rRzrTN5bQgzA+Q S1WsHC7SK6Gjz7oibeZpp3CiIq7cs1R7Gys5TJnNHwoCpw/echOXiZ9sBflu8fRr/f QhZdjZPoKz3Duntd1azZtX8+1Qdwr4dRLfCw71vrPOXy9PMBcJF8sddOXcZSQ+Actf QHA/TrNyNlW1P4SChFzu0oH+M5Zvy03CuAeaQc+nC1OU/Xh1MSN7cOQAcDL+zbqiBQ J5/qJm+f32IAQ== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4SwfqL44kgz4wbr; Thu, 21 Dec 2023 16:58:06 +1100 (AEDT) Date: Thu, 21 Dec 2023 16:58:05 +1100 From: Stephen Rothwell <sfr@canb.auug.org.au> To: Lee Jones <lee@kernel.org>, Thierry Reding <thierry.reding@gmail.com> Cc: Sean Young <sean@mess.org>, Flavio Suligoi <f.suligoi@asem.it>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Linux Next Mailing List <linux-next@vger.kernel.org> Subject: linux-next: build failure after merge of the pwm tree Message-ID: <20231221165805.0c4771c1@canb.auug.org.au> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/V1ol2N+FvGoGBHhVCu54mCy"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785869971204821265 X-GMAIL-MSGID: 1785869971204821265 |
Series |
linux-next: build failure after merge of the pwm tree
|
|
Commit Message
Stephen Rothwell
Dec. 21, 2023, 5:58 a.m. UTC
Hi all, After merging the backlight tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/video/backlight/mp3309c.c: In function 'mp3309c_bl_update_status': drivers/video/backlight/mp3309c.c:134:23: error: implicit declaration of function 'pwm_apply_state'; did you mean 'pwm_apply_args'? [-Werror=implicit-function-declaration] 134 | ret = pwm_apply_state(chip->pwmd, &pwmstate); | ^~~~~~~~~~~~~~~ | pwm_apply_args Caused by commit c748a6d77c06 ("pwm: Rename pwm_apply_state() to pwm_apply_might_sleep()") interacting with commit 2e914516a58c ("backlight: mp3309c: Add support for MPS MP3309C") from the backlight tree. I have appplied the following merge fix patch. From: Stephen Rothwell <sfr@canb.auug.org.au> Date: Thu, 21 Dec 2023 16:13:37 +1100 Subject: [PATCH] fix up for "backlight: mp3309c: Add support for MPS MP3309C" from the backlight tree interacting with commit c748a6d77c06 ("pwm: Rename pwm_apply_state() to pwm_apply_might_sleep()") from the pwm tree. Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> --- drivers/video/backlight/mp3309c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On Thu, Dec 21, 2023 at 04:58:05PM +1100, Stephen Rothwell wrote: > Hi all, > > After merging the backlight tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/video/backlight/mp3309c.c: In function 'mp3309c_bl_update_status': > drivers/video/backlight/mp3309c.c:134:23: error: implicit declaration of function 'pwm_apply_state'; did you mean 'pwm_apply_args'? [-Werror=implicit-function-declaration] > 134 | ret = pwm_apply_state(chip->pwmd, &pwmstate); > | ^~~~~~~~~~~~~~~ > | pwm_apply_args > > Caused by commit > > c748a6d77c06 ("pwm: Rename pwm_apply_state() to pwm_apply_might_sleep()") > > interacting with commit > > 2e914516a58c ("backlight: mp3309c: Add support for MPS MP3309C") > > from the backlight tree. > > I have appplied the following merge fix patch. > > From: Stephen Rothwell <sfr@canb.auug.org.au> > Date: Thu, 21 Dec 2023 16:13:37 +1100 > Subject: [PATCH] fix up for "backlight: mp3309c: Add support for MPS MP3309C" > > from the backlight tree interacting with commit > > c748a6d77c06 ("pwm: Rename pwm_apply_state() to pwm_apply_might_sleep()") > > from the pwm tree. > > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> > --- > drivers/video/backlight/mp3309c.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/backlight/mp3309c.c b/drivers/video/backlight/mp3309c.c > index 34d71259fac1..b0d9aef6942b 100644 > --- a/drivers/video/backlight/mp3309c.c > +++ b/drivers/video/backlight/mp3309c.c > @@ -131,7 +131,7 @@ static int mp3309c_bl_update_status(struct backlight_device *bl) > chip->pdata->levels[brightness], > chip->pdata->levels[chip->pdata->max_brightness]); > pwmstate.enabled = true; > - ret = pwm_apply_state(chip->pwmd, &pwmstate); > + ret = pwm_apply_might_sleep(chip->pwmd, &pwmstate); > if (ret) > return ret; > > @@ -393,7 +393,7 @@ static int mp3309c_probe(struct i2c_client *client) > chip->pdata->default_brightness, > chip->pdata->max_brightness); > pwmstate.enabled = true; > - ret = pwm_apply_state(chip->pwmd, &pwmstate); > + ret = pwm_apply_might_sleep(chip->pwmd, &pwmstate); > if (ret) > return dev_err_probe(chip->dev, ret, > "error setting pwm device\n"); Hi Lee, We could exchange stable tags to make this work, but given that people (myself included) are getting into holiday mode I'm inclined to just add a pwm_apply_state() compatibility inline for now and then we can address this in the new year or for the next cycle. What do you think? Thierry
On Thu, 21 Dec 2023, Thierry Reding wrote: > On Thu, Dec 21, 2023 at 04:58:05PM +1100, Stephen Rothwell wrote: > > Hi all, > > > > After merging the backlight tree, today's linux-next build (x86_64 > > allmodconfig) failed like this: > > > > drivers/video/backlight/mp3309c.c: In function 'mp3309c_bl_update_status': > > drivers/video/backlight/mp3309c.c:134:23: error: implicit declaration of function 'pwm_apply_state'; did you mean 'pwm_apply_args'? [-Werror=implicit-function-declaration] > > 134 | ret = pwm_apply_state(chip->pwmd, &pwmstate); > > | ^~~~~~~~~~~~~~~ > > | pwm_apply_args > > > > Caused by commit > > > > c748a6d77c06 ("pwm: Rename pwm_apply_state() to pwm_apply_might_sleep()") > > > > interacting with commit > > > > 2e914516a58c ("backlight: mp3309c: Add support for MPS MP3309C") > > > > from the backlight tree. > > > > I have appplied the following merge fix patch. > > > > From: Stephen Rothwell <sfr@canb.auug.org.au> > > Date: Thu, 21 Dec 2023 16:13:37 +1100 > > Subject: [PATCH] fix up for "backlight: mp3309c: Add support for MPS MP3309C" > > > > from the backlight tree interacting with commit > > > > c748a6d77c06 ("pwm: Rename pwm_apply_state() to pwm_apply_might_sleep()") > > > > from the pwm tree. > > > > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> > > --- > > drivers/video/backlight/mp3309c.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/video/backlight/mp3309c.c b/drivers/video/backlight/mp3309c.c > > index 34d71259fac1..b0d9aef6942b 100644 > > --- a/drivers/video/backlight/mp3309c.c > > +++ b/drivers/video/backlight/mp3309c.c > > @@ -131,7 +131,7 @@ static int mp3309c_bl_update_status(struct backlight_device *bl) > > chip->pdata->levels[brightness], > > chip->pdata->levels[chip->pdata->max_brightness]); > > pwmstate.enabled = true; > > - ret = pwm_apply_state(chip->pwmd, &pwmstate); > > + ret = pwm_apply_might_sleep(chip->pwmd, &pwmstate); > > if (ret) > > return ret; > > > > @@ -393,7 +393,7 @@ static int mp3309c_probe(struct i2c_client *client) > > chip->pdata->default_brightness, > > chip->pdata->max_brightness); > > pwmstate.enabled = true; > > - ret = pwm_apply_state(chip->pwmd, &pwmstate); > > + ret = pwm_apply_might_sleep(chip->pwmd, &pwmstate); > > if (ret) > > return dev_err_probe(chip->dev, ret, > > "error setting pwm device\n"); > > Hi Lee, > > We could exchange stable tags to make this work, but given that people > (myself included) are getting into holiday mode I'm inclined to just add > a pwm_apply_state() compatibility inline for now and then we can address > this in the new year or for the next cycle. What do you think? Sorry, why is this happening? I still see support for pwm_apply_state() in -next.
On Thu, Dec 21, 2023 at 10:09:50AM +0000, Lee Jones wrote: > On Thu, 21 Dec 2023, Thierry Reding wrote: > > > On Thu, Dec 21, 2023 at 04:58:05PM +1100, Stephen Rothwell wrote: > > > Hi all, > > > > > > After merging the backlight tree, today's linux-next build (x86_64 > > > allmodconfig) failed like this: > > > > > > drivers/video/backlight/mp3309c.c: In function 'mp3309c_bl_update_status': > > > drivers/video/backlight/mp3309c.c:134:23: error: implicit declaration of function 'pwm_apply_state'; did you mean 'pwm_apply_args'? [-Werror=implicit-function-declaration] > > > 134 | ret = pwm_apply_state(chip->pwmd, &pwmstate); > > > | ^~~~~~~~~~~~~~~ > > > | pwm_apply_args > > > > > > Caused by commit > > > > > > c748a6d77c06 ("pwm: Rename pwm_apply_state() to pwm_apply_might_sleep()") > > > > > > interacting with commit > > > > > > 2e914516a58c ("backlight: mp3309c: Add support for MPS MP3309C") > > > > > > from the backlight tree. > > > > > > I have appplied the following merge fix patch. > > > > > > From: Stephen Rothwell <sfr@canb.auug.org.au> > > > Date: Thu, 21 Dec 2023 16:13:37 +1100 > > > Subject: [PATCH] fix up for "backlight: mp3309c: Add support for MPS MP3309C" > > > > > > from the backlight tree interacting with commit > > > > > > c748a6d77c06 ("pwm: Rename pwm_apply_state() to pwm_apply_might_sleep()") > > > > > > from the pwm tree. > > > > > > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> > > > --- > > > drivers/video/backlight/mp3309c.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/video/backlight/mp3309c.c b/drivers/video/backlight/mp3309c.c > > > index 34d71259fac1..b0d9aef6942b 100644 > > > --- a/drivers/video/backlight/mp3309c.c > > > +++ b/drivers/video/backlight/mp3309c.c > > > @@ -131,7 +131,7 @@ static int mp3309c_bl_update_status(struct backlight_device *bl) > > > chip->pdata->levels[brightness], > > > chip->pdata->levels[chip->pdata->max_brightness]); > > > pwmstate.enabled = true; > > > - ret = pwm_apply_state(chip->pwmd, &pwmstate); > > > + ret = pwm_apply_might_sleep(chip->pwmd, &pwmstate); > > > if (ret) > > > return ret; > > > > > > @@ -393,7 +393,7 @@ static int mp3309c_probe(struct i2c_client *client) > > > chip->pdata->default_brightness, > > > chip->pdata->max_brightness); > > > pwmstate.enabled = true; > > > - ret = pwm_apply_state(chip->pwmd, &pwmstate); > > > + ret = pwm_apply_might_sleep(chip->pwmd, &pwmstate); > > > if (ret) > > > return dev_err_probe(chip->dev, ret, > > > "error setting pwm device\n"); > > > > Hi Lee, > > > > We could exchange stable tags to make this work, but given that people > > (myself included) are getting into holiday mode I'm inclined to just add > > a pwm_apply_state() compatibility inline for now and then we can address > > this in the new year or for the next cycle. What do you think? > > Sorry, why is this happening? > > I still see support for pwm_apply_state() in -next. Not any more: $ git grep pwm_apply_state linux-next/master $ Sean
On Thu, 21 Dec 2023, Sean Young wrote: > On Thu, Dec 21, 2023 at 10:09:50AM +0000, Lee Jones wrote: > > On Thu, 21 Dec 2023, Thierry Reding wrote: > > > > > On Thu, Dec 21, 2023 at 04:58:05PM +1100, Stephen Rothwell wrote: > > > > Hi all, > > > > > > > > After merging the backlight tree, today's linux-next build (x86_64 > > > > allmodconfig) failed like this: > > > > > > > > drivers/video/backlight/mp3309c.c: In function 'mp3309c_bl_update_status': > > > > drivers/video/backlight/mp3309c.c:134:23: error: implicit declaration of function 'pwm_apply_state'; did you mean 'pwm_apply_args'? [-Werror=implicit-function-declaration] > > > > 134 | ret = pwm_apply_state(chip->pwmd, &pwmstate); > > > > | ^~~~~~~~~~~~~~~ > > > > | pwm_apply_args > > > > > > > > Caused by commit > > > > > > > > c748a6d77c06 ("pwm: Rename pwm_apply_state() to pwm_apply_might_sleep()") > > > > > > > > interacting with commit > > > > > > > > 2e914516a58c ("backlight: mp3309c: Add support for MPS MP3309C") > > > > > > > > from the backlight tree. > > > > > > > > I have appplied the following merge fix patch. > > > > > > > > From: Stephen Rothwell <sfr@canb.auug.org.au> > > > > Date: Thu, 21 Dec 2023 16:13:37 +1100 > > > > Subject: [PATCH] fix up for "backlight: mp3309c: Add support for MPS MP3309C" > > > > > > > > from the backlight tree interacting with commit > > > > > > > > c748a6d77c06 ("pwm: Rename pwm_apply_state() to pwm_apply_might_sleep()") > > > > > > > > from the pwm tree. > > > > > > > > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> > > > > --- > > > > drivers/video/backlight/mp3309c.c | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/drivers/video/backlight/mp3309c.c b/drivers/video/backlight/mp3309c.c > > > > index 34d71259fac1..b0d9aef6942b 100644 > > > > --- a/drivers/video/backlight/mp3309c.c > > > > +++ b/drivers/video/backlight/mp3309c.c > > > > @@ -131,7 +131,7 @@ static int mp3309c_bl_update_status(struct backlight_device *bl) > > > > chip->pdata->levels[brightness], > > > > chip->pdata->levels[chip->pdata->max_brightness]); > > > > pwmstate.enabled = true; > > > > - ret = pwm_apply_state(chip->pwmd, &pwmstate); > > > > + ret = pwm_apply_might_sleep(chip->pwmd, &pwmstate); > > > > if (ret) > > > > return ret; > > > > > > > > @@ -393,7 +393,7 @@ static int mp3309c_probe(struct i2c_client *client) > > > > chip->pdata->default_brightness, > > > > chip->pdata->max_brightness); > > > > pwmstate.enabled = true; > > > > - ret = pwm_apply_state(chip->pwmd, &pwmstate); > > > > + ret = pwm_apply_might_sleep(chip->pwmd, &pwmstate); > > > > if (ret) > > > > return dev_err_probe(chip->dev, ret, > > > > "error setting pwm device\n"); > > > > > > Hi Lee, > > > > > > We could exchange stable tags to make this work, but given that people > > > (myself included) are getting into holiday mode I'm inclined to just add > > > a pwm_apply_state() compatibility inline for now and then we can address > > > this in the new year or for the next cycle. What do you think? > > > > Sorry, why is this happening? > > > > I still see support for pwm_apply_state() in -next. > > Not any more: > > $ git grep pwm_apply_state linux-next/master > $ Okay, that's changed since this morning. I think the easiest solution would be to take Stephen's patch.
On Thu, 21 Dec 2023 16:58:05 +1100, Stephen Rothwell wrote: > After merging the backlight tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/video/backlight/mp3309c.c: In function 'mp3309c_bl_update_status': > drivers/video/backlight/mp3309c.c:134:23: error: implicit declaration of function 'pwm_apply_state'; did you mean 'pwm_apply_args'? [-Werror=implicit-function-declaration] > 134 | ret = pwm_apply_state(chip->pwmd, &pwmstate); > | ^~~~~~~~~~~~~~~ > | pwm_apply_args > > [...] Applied, thanks! [1/1] linux-next: build failure after merge of the pwm tree commit: f7baa9ccef93ba1c36a8ecf58c2f4e86fb3181b9 -- Lee Jones [李琼斯]
On Thu, 21 Dec 2023, Lee Jones wrote: > On Thu, 21 Dec 2023 16:58:05 +1100, Stephen Rothwell wrote: > > After merging the backlight tree, today's linux-next build (x86_64 > > allmodconfig) failed like this: > > > > drivers/video/backlight/mp3309c.c: In function 'mp3309c_bl_update_status': > > drivers/video/backlight/mp3309c.c:134:23: error: implicit declaration of function 'pwm_apply_state'; did you mean 'pwm_apply_args'? [-Werror=implicit-function-declaration] > > 134 | ret = pwm_apply_state(chip->pwmd, &pwmstate); > > | ^~~~~~~~~~~~~~~ > > | pwm_apply_args > > > > [...] > > Applied, thanks! > > [1/1] linux-next: build failure after merge of the pwm tree > commit: f7baa9ccef93ba1c36a8ecf58c2f4e86fb3181b9 Actually it's: f7baa9ccef93b ("backlight: mp3309c: Rename pwm_apply_state() to pwm_apply_might_sleep()") But don't bank on the commit ID staying the same.
On Thu, Dec 21, 2023 at 12:58:01PM +0000, Lee Jones wrote: > On Thu, 21 Dec 2023, Lee Jones wrote: > > > On Thu, 21 Dec 2023 16:58:05 +1100, Stephen Rothwell wrote: > > > After merging the backlight tree, today's linux-next build (x86_64 > > > allmodconfig) failed like this: > > > > > > drivers/video/backlight/mp3309c.c: In function 'mp3309c_bl_update_status': > > > drivers/video/backlight/mp3309c.c:134:23: error: implicit declaration of function 'pwm_apply_state'; did you mean 'pwm_apply_args'? [-Werror=implicit-function-declaration] > > > 134 | ret = pwm_apply_state(chip->pwmd, &pwmstate); > > > | ^~~~~~~~~~~~~~~ > > > | pwm_apply_args > > > > > > [...] > > > > Applied, thanks! > > > > [1/1] linux-next: build failure after merge of the pwm tree > > commit: f7baa9ccef93ba1c36a8ecf58c2f4e86fb3181b9 > > Actually it's: > > f7baa9ccef93b ("backlight: mp3309c: Rename pwm_apply_state() to pwm_apply_might_sleep()") > > But don't bank on the commit ID staying the same. This is likely going to break the build on your branch because pwm_apply_might_sleep() is only available in the PWM tree right now. In any case, I've now pushed a commit that adds pwm_apply_state() back as a compatibility stub, so it should be okay for you to drop this if you run into problems. It's always possible that somebody else wants to add a new caller of pwm_apply_state() and in retrospect we should've probably done this from the start, at least as a transitional measure for one or two cycles. Thierry
Hi all, On Thu, 21 Dec 2023 19:34:57 +0100 Thierry Reding <thierry.reding@gmail.com> wrote: > > On Thu, Dec 21, 2023 at 12:58:01PM +0000, Lee Jones wrote: > > On Thu, 21 Dec 2023, Lee Jones wrote: > > > > > On Thu, 21 Dec 2023 16:58:05 +1100, Stephen Rothwell wrote: > > > > After merging the backlight tree, today's linux-next build (x86_64 > > > > allmodconfig) failed like this: > > > > > > > > drivers/video/backlight/mp3309c.c: In function 'mp3309c_bl_update_status': > > > > drivers/video/backlight/mp3309c.c:134:23: error: implicit declaration of function 'pwm_apply_state'; did you mean 'pwm_apply_args'? [-Werror=implicit-function-declaration] > > > > 134 | ret = pwm_apply_state(chip->pwmd, &pwmstate); > > > > | ^~~~~~~~~~~~~~~ > > > > | pwm_apply_args > > > > > > > > [...] > > > > > > Applied, thanks! > > > > > > [1/1] linux-next: build failure after merge of the pwm tree > > > commit: f7baa9ccef93ba1c36a8ecf58c2f4e86fb3181b9 > > > > Actually it's: > > > > f7baa9ccef93b ("backlight: mp3309c: Rename pwm_apply_state() to pwm_apply_might_sleep()") > > > > But don't bank on the commit ID staying the same. > > This is likely going to break the build on your branch because > pwm_apply_might_sleep() is only available in the PWM tree right now. In And break it did (since I merge the backlight tree before the pwm tree), so I used the backlight tree from 20231221.
Hi Lee, On Fri, 22 Dec 2023 12:27:58 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > On Thu, 21 Dec 2023 19:34:57 +0100 Thierry Reding <thierry.reding@gmail.com> wrote: > > > > On Thu, Dec 21, 2023 at 12:58:01PM +0000, Lee Jones wrote: > > > On Thu, 21 Dec 2023, Lee Jones wrote: > > > > > > > On Thu, 21 Dec 2023 16:58:05 +1100, Stephen Rothwell wrote: > > > > > After merging the backlight tree, today's linux-next build (x86_64 > > > > > allmodconfig) failed like this: > > > > > > > > > > drivers/video/backlight/mp3309c.c: In function 'mp3309c_bl_update_status': > > > > > drivers/video/backlight/mp3309c.c:134:23: error: implicit declaration of function 'pwm_apply_state'; did you mean 'pwm_apply_args'? [-Werror=implicit-function-declaration] > > > > > 134 | ret = pwm_apply_state(chip->pwmd, &pwmstate); > > > > > | ^~~~~~~~~~~~~~~ > > > > > | pwm_apply_args > > > > > > > > > > [...] > > > > > > > > Applied, thanks! > > > > > > > > [1/1] linux-next: build failure after merge of the pwm tree > > > > commit: f7baa9ccef93ba1c36a8ecf58c2f4e86fb3181b9 > > > > > > Actually it's: > > > > > > f7baa9ccef93b ("backlight: mp3309c: Rename pwm_apply_state() to pwm_apply_might_sleep()") > > > > > > But don't bank on the commit ID staying the same. > > > > This is likely going to break the build on your branch because > > pwm_apply_might_sleep() is only available in the PWM tree right now. In > > And break it did (since I merge the backlight tree before the pwm > tree), so I used the backlight tree from 20231221. Please remove that merge fix patch from your tree.
Hi all, On Tue, 2 Jan 2024 11:47:58 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > On Fri, 22 Dec 2023 12:27:58 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > > > On Thu, 21 Dec 2023 19:34:57 +0100 Thierry Reding <thierry.reding@gmail.com> wrote: > > > > > > On Thu, Dec 21, 2023 at 12:58:01PM +0000, Lee Jones wrote: > > > > On Thu, 21 Dec 2023, Lee Jones wrote: > > > > > > > > > On Thu, 21 Dec 2023 16:58:05 +1100, Stephen Rothwell wrote: > > > > > > After merging the backlight tree, today's linux-next build (x86_64 > > > > > > allmodconfig) failed like this: > > > > > > > > > > > > drivers/video/backlight/mp3309c.c: In function 'mp3309c_bl_update_status': > > > > > > drivers/video/backlight/mp3309c.c:134:23: error: implicit declaration of function 'pwm_apply_state'; did you mean 'pwm_apply_args'? [-Werror=implicit-function-declaration] > > > > > > 134 | ret = pwm_apply_state(chip->pwmd, &pwmstate); > > > > > > | ^~~~~~~~~~~~~~~ > > > > > > | pwm_apply_args > > > > > > > > > > > > [...] > > > > > > > > > > Applied, thanks! > > > > > > > > > > [1/1] linux-next: build failure after merge of the pwm tree > > > > > commit: f7baa9ccef93ba1c36a8ecf58c2f4e86fb3181b9 > > > > > > > > Actually it's: > > > > > > > > f7baa9ccef93b ("backlight: mp3309c: Rename pwm_apply_state() to pwm_apply_might_sleep()") > > > > > > > > But don't bank on the commit ID staying the same. > > > > > > This is likely going to break the build on your branch because > > > pwm_apply_might_sleep() is only available in the PWM tree right now. In > > > > And break it did (since I merge the backlight tree before the pwm > > tree), so I used the backlight tree from 20231221. > > Please remove that merge fix patch from your tree. The build of the backlight tree is still failing.
[also add Jingoo (additional backlight maintainer) and Linus] On Thu, Dec 21, 2023 at 07:34:57PM +0100, Thierry Reding wrote: > On Thu, Dec 21, 2023 at 12:58:01PM +0000, Lee Jones wrote: > > On Thu, 21 Dec 2023, Lee Jones wrote: > > > > > On Thu, 21 Dec 2023 16:58:05 +1100, Stephen Rothwell wrote: > > > > After merging the backlight tree, today's linux-next build (x86_64 > > > > allmodconfig) failed like this: > > > > > > > > drivers/video/backlight/mp3309c.c: In function 'mp3309c_bl_update_status': > > > > drivers/video/backlight/mp3309c.c:134:23: error: implicit declaration of function 'pwm_apply_state'; did you mean 'pwm_apply_args'? [-Werror=implicit-function-declaration] > > > > 134 | ret = pwm_apply_state(chip->pwmd, &pwmstate); > > > > | ^~~~~~~~~~~~~~~ > > > > | pwm_apply_args > > > > > > > > [...] > > > > > > Applied, thanks! > > > > > > [1/1] linux-next: build failure after merge of the pwm tree > > > commit: f7baa9ccef93ba1c36a8ecf58c2f4e86fb3181b9 > > > > Actually it's: > > > > f7baa9ccef93b ("backlight: mp3309c: Rename pwm_apply_state() to pwm_apply_might_sleep()") > > > > But don't bank on the commit ID staying the same. > > This is likely going to break the build on your branch because > pwm_apply_might_sleep() is only available in the PWM tree right now. In > any case, I've now pushed a commit that adds pwm_apply_state() back as a > compatibility stub, so it should be okay for you to drop this if you > run into problems. It's always possible that somebody else wants to add > a new caller of pwm_apply_state() and in retrospect we should've > probably done this from the start, at least as a transitional measure > for one or two cycles. > Hi Lee and Thierry, I know that we're still on New Year vibes, so some things are not up to full steam for now; but since we're close to v6.7 release and v6.8 merge window, hence allow me to ask: Stephen Rothwell is still complaining about backlight tree build failure due to f7baa9ccef93b, yet it has not been fixed so far. Has the culprit been dropped/reverted as he requested? The worst case is the culprit slips through and become part of backlight PR and Linus will likely not happy with the build regression (maybe he had to fix by himself). Thanks.
On Thu, Jan 04, 2024 at 05:02:41PM +0700, Bagas Sanjaya wrote: > [also add Jingoo (additional backlight maintainer) and Linus] > > On Thu, Dec 21, 2023 at 07:34:57PM +0100, Thierry Reding wrote: > > On Thu, Dec 21, 2023 at 12:58:01PM +0000, Lee Jones wrote: > > > On Thu, 21 Dec 2023, Lee Jones wrote: > > > > > > > On Thu, 21 Dec 2023 16:58:05 +1100, Stephen Rothwell wrote: > > > > > After merging the backlight tree, today's linux-next build (x86_64 > > > > > allmodconfig) failed like this: > > > > > > > > > > drivers/video/backlight/mp3309c.c: In function 'mp3309c_bl_update_status': > > > > > drivers/video/backlight/mp3309c.c:134:23: error: implicit declaration of function 'pwm_apply_state'; did you mean 'pwm_apply_args'? [-Werror=implicit-function-declaration] > > > > > 134 | ret = pwm_apply_state(chip->pwmd, &pwmstate); > > > > > | ^~~~~~~~~~~~~~~ > > > > > | pwm_apply_args > > > > > > > > > > [...] > > > > > > > > Applied, thanks! > > > > > > > > [1/1] linux-next: build failure after merge of the pwm tree > > > > commit: f7baa9ccef93ba1c36a8ecf58c2f4e86fb3181b9 > > > > > > Actually it's: > > > > > > f7baa9ccef93b ("backlight: mp3309c: Rename pwm_apply_state() to pwm_apply_might_sleep()") > > > > > > But don't bank on the commit ID staying the same. > > > > This is likely going to break the build on your branch because > > pwm_apply_might_sleep() is only available in the PWM tree right now. In > > any case, I've now pushed a commit that adds pwm_apply_state() back as a > > compatibility stub, so it should be okay for you to drop this if you > > run into problems. It's always possible that somebody else wants to add > > a new caller of pwm_apply_state() and in retrospect we should've > > probably done this from the start, at least as a transitional measure > > for one or two cycles. > > > > Hi Lee and Thierry, > > I know that we're still on New Year vibes, so some things are not up to full > steam for now; but since we're close to v6.7 release and v6.8 merge window, > hence allow me to ask: > > Stephen Rothwell is still complaining about backlight tree build failure > due to f7baa9ccef93b, yet it has not been fixed so far. Has the culprit > been dropped/reverted as he requested? The worst case is the culprit slips > through and become part of backlight PR and Linus will likely not happy > with the build regression (maybe he had to fix by himself). This should be fixed by 9a216587a03df, and on current linux-next I can't reproduce the problem any more (x86_64 allmodconfig). Thanks, Sean
Hi all, On Thu, 4 Jan 2024 12:50:28 +0000 Sean Young <sean@mess.org> wrote: > > On Thu, Jan 04, 2024 at 05:02:41PM +0700, Bagas Sanjaya wrote: > > [also add Jingoo (additional backlight maintainer) and Linus] > > > > On Thu, Dec 21, 2023 at 07:34:57PM +0100, Thierry Reding wrote: > > > On Thu, Dec 21, 2023 at 12:58:01PM +0000, Lee Jones wrote: > > > > On Thu, 21 Dec 2023, Lee Jones wrote: > > > > > > > > > On Thu, 21 Dec 2023 16:58:05 +1100, Stephen Rothwell wrote: > > > > > > After merging the backlight tree, today's linux-next build (x86_64 > > > > > > allmodconfig) failed like this: > > > > > > > > > > > > drivers/video/backlight/mp3309c.c: In function 'mp3309c_bl_update_status': > > > > > > drivers/video/backlight/mp3309c.c:134:23: error: implicit declaration of function 'pwm_apply_state'; did you mean 'pwm_apply_args'? [-Werror=implicit-function-declaration] > > > > > > 134 | ret = pwm_apply_state(chip->pwmd, &pwmstate); > > > > > > | ^~~~~~~~~~~~~~~ > > > > > > | pwm_apply_args > > > > > > > > > > > > [...] > > > > > > > > > > Applied, thanks! > > > > > > > > > > [1/1] linux-next: build failure after merge of the pwm tree > > > > > commit: f7baa9ccef93ba1c36a8ecf58c2f4e86fb3181b9 > > > > > > > > Actually it's: > > > > > > > > f7baa9ccef93b ("backlight: mp3309c: Rename pwm_apply_state() to pwm_apply_might_sleep()") > > > > > > > > But don't bank on the commit ID staying the same. > > > > > > This is likely going to break the build on your branch because > > > pwm_apply_might_sleep() is only available in the PWM tree right now. In > > > any case, I've now pushed a commit that adds pwm_apply_state() back as a > > > compatibility stub, so it should be okay for you to drop this if you > > > run into problems. It's always possible that somebody else wants to add > > > a new caller of pwm_apply_state() and in retrospect we should've > > > probably done this from the start, at least as a transitional measure > > > for one or two cycles. > > > > > > > Hi Lee and Thierry, > > > > I know that we're still on New Year vibes, so some things are not up to full > > steam for now; but since we're close to v6.7 release and v6.8 merge window, > > hence allow me to ask: > > > > Stephen Rothwell is still complaining about backlight tree build failure > > due to f7baa9ccef93b, yet it has not been fixed so far. Has the culprit > > been dropped/reverted as he requested? The worst case is the culprit slips > > through and become part of backlight PR and Linus will likely not happy > > with the build regression (maybe he had to fix by himself). > > This should be fixed by 9a216587a03df, and on current linux-next I can't > reproduce the problem any more (x86_64 allmodconfig). Of course linux-next is fine, because I have fixed it up in there. Here is the problem: the backlight tree (git://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git#for-backlight-next) is broken when built in its own because of the above patch (which is commit f7baa9ccef93). In linux-next, I have been merging the previous working version of the backlight tree (with head commit 7d84a63a39b7). The patch (commit f7baa9ccef93) can only be applied to the merge of the backlight tree and the pwm tree (git://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/linux-pwm.git#for-next) which is merged much later in the linux-next process. If the backlight tree was merged by Linus before the pwm tree, it would break his build (and he would not be happy). But the patch on the head of the backlight tree was made unnecessary by commit 9a216587a03d in the pwm tree. So, please either revert commit f7baa9ccef93 in the backlight tree (or simply to a "git reset --hard HEAD^" there). The patch of commit f7baa9ccef93 can be applied some time later (after Linus has merged both trees.
On Thu, Jan 04, 2024 at 12:50:28PM +0000, Sean Young wrote: > On Thu, Jan 04, 2024 at 05:02:41PM +0700, Bagas Sanjaya wrote: > > [also add Jingoo (additional backlight maintainer) and Linus] > > > > On Thu, Dec 21, 2023 at 07:34:57PM +0100, Thierry Reding wrote: > > > On Thu, Dec 21, 2023 at 12:58:01PM +0000, Lee Jones wrote: > > > > On Thu, 21 Dec 2023, Lee Jones wrote: > > > > > > > > > On Thu, 21 Dec 2023 16:58:05 +1100, Stephen Rothwell wrote: > > > > > > After merging the backlight tree, today's linux-next build (x86_64 > > > > > > allmodconfig) failed like this: > > > > > > > > > > > > drivers/video/backlight/mp3309c.c: In function 'mp3309c_bl_update_status': > > > > > > drivers/video/backlight/mp3309c.c:134:23: error: implicit declaration of function 'pwm_apply_state'; did you mean 'pwm_apply_args'? [-Werror=implicit-function-declaration] > > > > > > 134 | ret = pwm_apply_state(chip->pwmd, &pwmstate); > > > > > > | ^~~~~~~~~~~~~~~ > > > > > > | pwm_apply_args > > > > > > > > > > > > [...] > > > > > > > > > > Applied, thanks! > > > > > > > > > > [1/1] linux-next: build failure after merge of the pwm tree > > > > > commit: f7baa9ccef93ba1c36a8ecf58c2f4e86fb3181b9 > > > > > > > > Actually it's: > > > > > > > > f7baa9ccef93b ("backlight: mp3309c: Rename pwm_apply_state() to pwm_apply_might_sleep()") > > > > > > > > But don't bank on the commit ID staying the same. > > > > > > This is likely going to break the build on your branch because > > > pwm_apply_might_sleep() is only available in the PWM tree right now. In > > > any case, I've now pushed a commit that adds pwm_apply_state() back as a > > > compatibility stub, so it should be okay for you to drop this if you > > > run into problems. It's always possible that somebody else wants to add > > > a new caller of pwm_apply_state() and in retrospect we should've > > > probably done this from the start, at least as a transitional measure > > > for one or two cycles. > > > > > > > Hi Lee and Thierry, > > > > I know that we're still on New Year vibes, so some things are not up to full > > steam for now; but since we're close to v6.7 release and v6.8 merge window, > > hence allow me to ask: > > > > Stephen Rothwell is still complaining about backlight tree build failure > > due to f7baa9ccef93b, yet it has not been fixed so far. Has the culprit > > been dropped/reverted as he requested? The worst case is the culprit slips > > through and become part of backlight PR and Linus will likely not happy > > with the build regression (maybe he had to fix by himself). > > This should be fixed by 9a216587a03df, and on current linux-next I can't > reproduce the problem any more (x86_64 allmodconfig). OK, thanks!
On Fri, 05 Jan 2024, Stephen Rothwell wrote: > Hi all, > > On Thu, 4 Jan 2024 12:50:28 +0000 Sean Young <sean@mess.org> wrote: > > > > On Thu, Jan 04, 2024 at 05:02:41PM +0700, Bagas Sanjaya wrote: > > > [also add Jingoo (additional backlight maintainer) and Linus] > > > > > > On Thu, Dec 21, 2023 at 07:34:57PM +0100, Thierry Reding wrote: > > > > On Thu, Dec 21, 2023 at 12:58:01PM +0000, Lee Jones wrote: > > > > > On Thu, 21 Dec 2023, Lee Jones wrote: > > > > > > > > > > > On Thu, 21 Dec 2023 16:58:05 +1100, Stephen Rothwell wrote: > > > > > > > After merging the backlight tree, today's linux-next build (x86_64 > > > > > > > allmodconfig) failed like this: > > > > > > > > > > > > > > drivers/video/backlight/mp3309c.c: In function 'mp3309c_bl_update_status': > > > > > > > drivers/video/backlight/mp3309c.c:134:23: error: implicit declaration of function 'pwm_apply_state'; did you mean 'pwm_apply_args'? [-Werror=implicit-function-declaration] > > > > > > > 134 | ret = pwm_apply_state(chip->pwmd, &pwmstate); > > > > > > > | ^~~~~~~~~~~~~~~ > > > > > > > | pwm_apply_args > > > > > > > > > > > > > > [...] > > > > > > > > > > > > Applied, thanks! > > > > > > > > > > > > [1/1] linux-next: build failure after merge of the pwm tree > > > > > > commit: f7baa9ccef93ba1c36a8ecf58c2f4e86fb3181b9 > > > > > > > > > > Actually it's: > > > > > > > > > > f7baa9ccef93b ("backlight: mp3309c: Rename pwm_apply_state() to pwm_apply_might_sleep()") > > > > > > > > > > But don't bank on the commit ID staying the same. > > > > > > > > This is likely going to break the build on your branch because > > > > pwm_apply_might_sleep() is only available in the PWM tree right now. In > > > > any case, I've now pushed a commit that adds pwm_apply_state() back as a > > > > compatibility stub, so it should be okay for you to drop this if you > > > > run into problems. It's always possible that somebody else wants to add > > > > a new caller of pwm_apply_state() and in retrospect we should've > > > > probably done this from the start, at least as a transitional measure > > > > for one or two cycles. > > > > > > > > > > Hi Lee and Thierry, > > > > > > I know that we're still on New Year vibes, so some things are not up to full > > > steam for now; but since we're close to v6.7 release and v6.8 merge window, > > > hence allow me to ask: > > > > > > Stephen Rothwell is still complaining about backlight tree build failure > > > due to f7baa9ccef93b, yet it has not been fixed so far. Has the culprit > > > been dropped/reverted as he requested? The worst case is the culprit slips > > > through and become part of backlight PR and Linus will likely not happy > > > with the build regression (maybe he had to fix by himself). > > > > This should be fixed by 9a216587a03df, and on current linux-next I can't > > reproduce the problem any more (x86_64 allmodconfig). > > Of course linux-next is fine, because I have fixed it up in there. > > Here is the problem: the backlight tree > (git://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git#for-backlight-next) > is broken when built in its own because of the above patch (which is > commit f7baa9ccef93). In linux-next, I have been merging the previous > working version of the backlight tree (with head commit 7d84a63a39b7). > The patch (commit f7baa9ccef93) can only be applied to the merge of the > backlight tree and the pwm tree > (git://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/linux-pwm.git#for-next) > which is merged much later in the linux-next process. If the backlight > tree was merged by Linus before the pwm tree, it would break his build > (and he would not be happy). But the patch on the head of the > backlight tree was made unnecessary by commit 9a216587a03d in the pwm > tree. So, please either revert commit f7baa9ccef93 in the backlight > tree (or simply to a "git reset --hard HEAD^" there). The patch of > commit f7baa9ccef93 can be applied some time later (after Linus has > merged both trees. Works for me. It is done!
diff --git a/drivers/video/backlight/mp3309c.c b/drivers/video/backlight/mp3309c.c index 34d71259fac1..b0d9aef6942b 100644 --- a/drivers/video/backlight/mp3309c.c +++ b/drivers/video/backlight/mp3309c.c @@ -131,7 +131,7 @@ static int mp3309c_bl_update_status(struct backlight_device *bl) chip->pdata->levels[brightness], chip->pdata->levels[chip->pdata->max_brightness]); pwmstate.enabled = true; - ret = pwm_apply_state(chip->pwmd, &pwmstate); + ret = pwm_apply_might_sleep(chip->pwmd, &pwmstate); if (ret) return ret; @@ -393,7 +393,7 @@ static int mp3309c_probe(struct i2c_client *client) chip->pdata->default_brightness, chip->pdata->max_brightness); pwmstate.enabled = true; - ret = pwm_apply_state(chip->pwmd, &pwmstate); + ret = pwm_apply_might_sleep(chip->pwmd, &pwmstate); if (ret) return dev_err_probe(chip->dev, ret, "error setting pwm device\n");