diff mbox series

blk-cgroup: clean up after commit f1c006f1c685

Message ID 20240104180031.148148-1-neelx@redhat.com
State New
Headers
Series blk-cgroup: clean up after commit f1c006f1c685 |

Commit Message

Daniel Vacek Jan. 4, 2024, 6 p.m. UTC 
  Commit f1c006f1c685 moved deletion of the list blkg->q_node
from blkg_destroy() to blkg_free_workfn(). Clean up the now
useless variable.

Signed-off-by: Daniel Vacek <neelx@redhat.com>
---
 block/blk-cgroup.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Tejun Heo Jan. 4, 2024, 9:57 p.m. UTC | #1 
On Thu, Jan 04, 2024 at 07:00:30PM +0100, Daniel Vacek wrote:
> Commit f1c006f1c685 moved deletion of the list blkg->q_node
> from blkg_destroy() to blkg_free_workfn(). Clean up the now
> useless variable.
> 
> Signed-off-by: Daniel Vacek <neelx@redhat.com>

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.
Jens Axboe Jan. 4, 2024, 11:06 p.m. UTC | #2 
On 1/4/24 11:00 AM, Daniel Vacek wrote:
> Commit f1c006f1c685 moved deletion of the list blkg->q_node
> from blkg_destroy() to blkg_free_workfn(). Clean up the now
> useless variable.

I'll fix up your commit this time, but please take a look at
your title and tell me if you think it's a good one? Not
very descriptive, is it.
Jens Axboe Jan. 4, 2024, 11:10 p.m. UTC | #3 
On Thu, 04 Jan 2024 19:00:30 +0100, Daniel Vacek wrote:
> Commit f1c006f1c685 moved deletion of the list blkg->q_node
> from blkg_destroy() to blkg_free_workfn(). Clean up the now
> useless variable.
> 
> 

Applied, thanks!

[1/1] blk-cgroup: clean up after commit f1c006f1c685
      commit: fab4c16c527e24c804efa4992b3cf40438c9b227

Best regards,
diff mbox series

Patch

diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
index 4b48c2c440981..2f39bd7cb6db5 100644
--- a/block/blk-cgroup.c
+++ b/block/blk-cgroup.c
@@ -575,13 +575,13 @@  static void blkg_destroy(struct blkcg_gq *blkg)
 static void blkg_destroy_all(struct gendisk *disk)
 {
 	struct request_queue *q = disk->queue;
-	struct blkcg_gq *blkg, *n;
+	struct blkcg_gq *blkg;
 	int count = BLKG_DESTROY_BATCH_SIZE;
 	int i;
 
 restart:
 	spin_lock_irq(&q->queue_lock);
-	list_for_each_entry_safe(blkg, n, &q->blkg_list, q_node) {
+	list_for_each_entry(blkg, &q->blkg_list, q_node) {
 		struct blkcg *blkcg = blkg->blkcg;
 
 		if (hlist_unhashed(&blkg->blkcg_node))