[RESEND] HID: hid-elan: use default remove for hid device

Message ID 20221117121314.5577-1-marcus.folkesson@gmail.com
State New
Headers
Series [RESEND] HID: hid-elan: use default remove for hid device |

Commit Message

Marcus Folkesson Nov. 17, 2022, 12:13 p.m. UTC
  hid_device_remove() will call hid_hw_stop() as default .remove function
if no function is specified.

Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
---
 drivers/hid/hid-elan.c | 6 ------
 1 file changed, 6 deletions(-)
  

Comments

Jiri Kosina Nov. 21, 2022, 9:17 p.m. UTC | #1
On Thu, 17 Nov 2022, Marcus Folkesson wrote:

> hid_device_remove() will call hid_hw_stop() as default .remove function
> if no function is specified.
> 
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>

Applied.
  

Patch

diff --git a/drivers/hid/hid-elan.c b/drivers/hid/hid-elan.c
index 8e4a5528e25d..76d93fc48f6a 100644
--- a/drivers/hid/hid-elan.c
+++ b/drivers/hid/hid-elan.c
@@ -507,11 +507,6 @@  static int elan_probe(struct hid_device *hdev, const struct hid_device_id *id)
 	return ret;
 }
 
-static void elan_remove(struct hid_device *hdev)
-{
-	hid_hw_stop(hdev);
-}
-
 static const struct hid_device_id elan_devices[] = {
 	{ HID_USB_DEVICE(USB_VENDOR_ID_ELAN, USB_DEVICE_ID_HP_X2),
 	  .driver_data = ELAN_HAS_LED },
@@ -529,7 +524,6 @@  static struct hid_driver elan_driver = {
 	.input_configured = elan_input_configured,
 	.raw_event = elan_raw_event,
 	.probe = elan_probe,
-	.remove = elan_remove,
 };
 
 module_hid_driver(elan_driver);