diff mbox series

[v1] perf stat: Fix hard coded ll miss units

Message ID 20231211181242.1721059-1-irogers@google.com
State New
Headers
Series [v1] perf stat: Fix hard coded ll miss units |

Commit Message

Ian Rogers Dec. 11, 2023, 6:12 p.m. UTC 
  Copy-paste error where LL cache misses are reported as l1i.

Suggested-by: Guillaume Endignoux <guillaumee@google.com>
Fixes: 0a57b910807a ("perf stat: Use counts rather than saved_value")
Signed-off-by: Ian Rogers <irogers@google.com>
---
 tools/perf/util/stat-shadow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ian Rogers Jan. 2, 2024, 7:34 p.m. UTC | #1 
On Mon, Dec 11, 2023 at 10:13 AM Ian Rogers <irogers@google.com> wrote:
>
> Copy-paste error where LL cache misses are reported as l1i.
>
> Suggested-by: Guillaume Endignoux <guillaumee@google.com>
> Fixes: 0a57b910807a ("perf stat: Use counts rather than saved_value")
> Signed-off-by: Ian Rogers <irogers@google.com>

Ping. Trivial 1 character fix but no reviews :-(

Thanks,
Ian

> ---
>  tools/perf/util/stat-shadow.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c
> index 1c5c3eeba4cf..e31426167852 100644
> --- a/tools/perf/util/stat-shadow.c
> +++ b/tools/perf/util/stat-shadow.c
> @@ -264,7 +264,7 @@ static void print_ll_miss(struct perf_stat_config *config,
>         static const double color_ratios[3] = {20.0, 10.0, 5.0};
>
>         print_ratio(config, evsel, aggr_idx, misses, out, STAT_LL_CACHE, color_ratios,
> -                   "of all L1-icache accesses");
> +                   "of all LL-cache accesses");
>  }
>
>  static void print_dtlb_miss(struct perf_stat_config *config,
> --
> 2.43.0.472.g3155946c3a-goog
>
Liang, Kan Jan. 2, 2024, 8:01 p.m. UTC | #2 
On 2024-01-02 2:34 p.m., Ian Rogers wrote:
> On Mon, Dec 11, 2023 at 10:13 AM Ian Rogers <irogers@google.com> wrote:
>>
>> Copy-paste error where LL cache misses are reported as l1i.
>>
>> Suggested-by: Guillaume Endignoux <guillaumee@google.com>
>> Fixes: 0a57b910807a ("perf stat: Use counts rather than saved_value")
>> Signed-off-by: Ian Rogers <irogers@google.com>
>

Reviewed-by: Kan Liang <kan.liang@linux.intel.com>

Thanks,
Kan

> Ping. Trivial 1 character fix but no reviews :-(
> 
> Thanks,
> Ian
> 
>> ---
>>  tools/perf/util/stat-shadow.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c
>> index 1c5c3eeba4cf..e31426167852 100644
>> --- a/tools/perf/util/stat-shadow.c
>> +++ b/tools/perf/util/stat-shadow.c
>> @@ -264,7 +264,7 @@ static void print_ll_miss(struct perf_stat_config *config,
>>         static const double color_ratios[3] = {20.0, 10.0, 5.0};
>>
>>         print_ratio(config, evsel, aggr_idx, misses, out, STAT_LL_CACHE, color_ratios,
>> -                   "of all L1-icache accesses");
>> +                   "of all LL-cache accesses");
>>  }
>>
>>  static void print_dtlb_miss(struct perf_stat_config *config,
>> --
>> 2.43.0.472.g3155946c3a-goog
>>
>
Arnaldo Carvalho de Melo Jan. 3, 2024, 4:47 p.m. UTC | #3 
Em Tue, Jan 02, 2024 at 03:01:55PM -0500, Liang, Kan escreveu:
> 
> 
> On 2024-01-02 2:34 p.m., Ian Rogers wrote:
> > On Mon, Dec 11, 2023 at 10:13 AM Ian Rogers <irogers@google.com> wrote:
> >>
> >> Copy-paste error where LL cache misses are reported as l1i.
> >>
> >> Suggested-by: Guillaume Endignoux <guillaumee@google.com>
> >> Fixes: 0a57b910807a ("perf stat: Use counts rather than saved_value")
> >> Signed-off-by: Ian Rogers <irogers@google.com>
> >
> 
> Reviewed-by: Kan Liang <kan.liang@linux.intel.com>

Thanks, applied to perf-tools-next.

- Arnaldo

 
> Thanks,
> Kan
> 
> > Ping. Trivial 1 character fix but no reviews :-(
> > 
> > Thanks,
> > Ian
> > 
> >> ---
> >>  tools/perf/util/stat-shadow.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c
> >> index 1c5c3eeba4cf..e31426167852 100644
> >> --- a/tools/perf/util/stat-shadow.c
> >> +++ b/tools/perf/util/stat-shadow.c
> >> @@ -264,7 +264,7 @@ static void print_ll_miss(struct perf_stat_config *config,
> >>         static const double color_ratios[3] = {20.0, 10.0, 5.0};
> >>
> >>         print_ratio(config, evsel, aggr_idx, misses, out, STAT_LL_CACHE, color_ratios,
> >> -                   "of all L1-icache accesses");
> >> +                   "of all LL-cache accesses");
> >>  }
> >>
> >>  static void print_dtlb_miss(struct perf_stat_config *config,
> >> --
> >> 2.43.0.472.g3155946c3a-goog
> >>
> >
diff mbox series

Patch

diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c
index 1c5c3eeba4cf..e31426167852 100644
--- a/tools/perf/util/stat-shadow.c
+++ b/tools/perf/util/stat-shadow.c
@@ -264,7 +264,7 @@  static void print_ll_miss(struct perf_stat_config *config,
 	static const double color_ratios[3] = {20.0, 10.0, 5.0};
 
 	print_ratio(config, evsel, aggr_idx, misses, out, STAT_LL_CACHE, color_ratios,
-		    "of all L1-icache accesses");
+		    "of all LL-cache accesses");
 }
 
 static void print_dtlb_miss(struct perf_stat_config *config,