Message ID | 20231224143500.10940-2-petre.rodan@subdimension.ro |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-10721-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2483:b0:fb:cd0c:d3e with SMTP id q3csp2160900dyi; Sun, 24 Dec 2023 06:36:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IGmmCDovxtKV/hr1+an3r1iSwpijEdn0+2AjX7+eu+7S/6WQy9d88GZ3sexiA/waDUAQ1nI X-Received: by 2002:a50:935c:0:b0:553:aa33:7876 with SMTP id n28-20020a50935c000000b00553aa337876mr1920820eda.31.1703428565107; Sun, 24 Dec 2023 06:36:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703428565; cv=none; d=google.com; s=arc-20160816; b=CpCCKgOZAykOZWaQ69KZZXy3byeME6EdV3fdvgFLJdDExghZ73erNk822yg9YbM8m7 0UHQswhlGpZRgBITTWyOeQJrbEYIw7mBnDyzeRRkaXFUTedSxs3cFm3jPi+GyoWSC8tC XkWfGexBpCecrSRcoaACRNMs/9W9YyUzuBiFo+BvU84yky/N48lgI26G2XDgyrrCitFE grw0swDQxbA+4EtLK90/nj7UiOVsJlcbMcM5ehqzrj/bJf5PcpwErQ+jNY3dNOQumvDN NMVliu3/y83qgMzVXSUlLl3m9MletVAwoT78DSz9a495ezhM8LcuG5Ef557rnzysEuDS QR4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=oRMlm6Cc/X8+3TT6FqWc16ulv+fw9P/DKSN7M0Wvchc=; fh=A3NghPjUcaYWJrBEcBDmjinT5n8U7kPeBkd9SVrhfnk=; b=UqC6YG1CXrm9EqB6F2sZZc7IvUWNMEYQybOhZ1WGp8Jvv6y6TS+i9cdAYJNjeEUAxi xWLgJga+a/ScH9qpqCAuNcyHGzDxE2TQL6RrdVG3BJiOyPNCbv14X3mGxM6LIpsY6/EN cusveOjdMOifaaB+VyOj+MTpckPnMQA0HUO0ASPlzXhyn+EPj8wknCKlq109yVObO53n qiyWesiUCyf0qGVRNRVLWmejNj0RGR9Y3TBWZLmJDlnrf8KKwajbV+DXcJxPdkFBWGHP BTTzttKq8LpsCDUIJWOGFhDi4tLKTShC4ldVuB13DanAENDbaR7sH5xN9pAc/JTYgM2d IdFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@subdimension.ro header.s=skycaves header.b=kSM00V4u; spf=pass (google.com: domain of linux-kernel+bounces-10721-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-10721-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=subdimension.ro Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id g4-20020a1709064e4400b00a1dcf3d7806si3645245ejw.287.2023.12.24.06.36.04 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Dec 2023 06:36:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-10721-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@subdimension.ro header.s=skycaves header.b=kSM00V4u; spf=pass (google.com: domain of linux-kernel+bounces-10721-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-10721-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=subdimension.ro Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id B89931F20C28 for <ouuuleilei@gmail.com>; Sun, 24 Dec 2023 14:36:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F317FD30F; Sun, 24 Dec 2023 14:35:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=subdimension.ro header.i=@subdimension.ro header.b="kSM00V4u" X-Original-To: linux-kernel@vger.kernel.org Received: from mail.subdimension.ro (skycaves.subdimension.ro [172.104.132.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EADB715D0; Sun, 24 Dec 2023 14:35:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=subdimension.ro Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=subdimension.ro Received: from localhost.localdomain (unknown [188.24.94.216]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mail.subdimension.ro (Postfix) with ESMTPSA id E016228B538; Sun, 24 Dec 2023 14:35:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=subdimension.ro; s=skycaves; t=1703428510; bh=gnzCEEr9FE5S/35WvgRN9WGB3sJnxOb4JQsoYP6j3nM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=kSM00V4uakA2eSqATirN/KIGEm+h4F2zSk1Vf30fp+yZBeggqZ9oSy+VveDKh6LH5 PCrfCB5sGH9P/38gel27e6nbBolpDqbLiEZ62H9X0OKrY3mJng17GJvObeYIGHPHyp veEb+EltaNU4Tm9UqbbxUq6eI7Vwav1Cj6eu553Q= From: Petre Rodan <petre.rodan@subdimension.ro> To: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Petre Rodan <petre.rodan@subdimension.ro>, Andreas Klinger <ak@it-klinger.de>, Jonathan Cameron <jic23@kernel.org>, Lars-Peter Clausen <lars@metafoo.de>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org> Subject: [PATCH v2 01/10] dt-bindings: iio: pressure: honeywell,mprls0025pa.yaml fix Date: Sun, 24 Dec 2023 16:34:46 +0200 Message-ID: <20231224143500.10940-2-petre.rodan@subdimension.ro> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231224143500.10940-1-petre.rodan@subdimension.ro> References: <20231224143500.10940-1-petre.rodan@subdimension.ro> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786174311048256007 X-GMAIL-MSGID: 1786174311048256007 |
Series |
changes to mprls0025pa
|
|
Commit Message
Petre Rodan
Dec. 24, 2023, 2:34 p.m. UTC
Define enum inside the honeywell,transfer-function property block. Set the correct irq edge in the example block. Based on the datasheet, in table 13 on page 11: "End-of-conversion indicator: This pin is set high when a measurement and calculation have been completed and the data is ready to be clocked out" Add description on End-of-conversion interrupt. Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro> Signed-off-by: Andreas Klinger <ak@it-klinger.de> --- .../bindings/iio/pressure/honeywell,mprls0025pa.yaml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) -- 2.41.0
Comments
On 24/12/2023 15:34, Petre Rodan wrote: > Define enum inside the honeywell,transfer-function property block. > > Set the correct irq edge in the example block. > Based on the datasheet, in table 13 on page 11: > "End-of-conversion indicator: This pin is set high when a measurement > and calculation have been completed and the data is ready to be > clocked out" > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Sun, 24 Dec 2023 16:34:46 +0200 Petre Rodan <petre.rodan@subdimension.ro> wrote: > Define enum inside the honeywell,transfer-function property block. > > Set the correct irq edge in the example block. > Based on the datasheet, in table 13 on page 11: > "End-of-conversion indicator: This pin is set high when a measurement > and calculation have been completed and the data is ready to be > clocked out" > > Add description on End-of-conversion interrupt. > > Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro> > Signed-off-by: Andreas Klinger <ak@it-klinger.de> What's the relationship between Andreas and this patch? Petre seems to have sent it so either Andreas should have a Co-authored-by or should be the author... Or not there at all Thanks, Jonathan > --- > .../bindings/iio/pressure/honeywell,mprls0025pa.yaml | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml b/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml > index d9e903fbfd99..84ced4e5a7da 100644 > --- a/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml > +++ b/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml > @@ -42,6 +42,10 @@ properties: > maxItems: 1 > > interrupts: > + description: > + Optional interrupt for indicating End-of-conversion. > + If not present, the driver loops for a while until the received status > + byte indicates correct measurement. > maxItems: 1 > > reset-gpios: > @@ -65,6 +69,7 @@ properties: > 1 - A, 10% to 90% of 2^24 (1677722 .. 15099494) > 2 - B, 2.5% to 22.5% of 2^24 (419430 .. 3774874) > 3 - C, 20% to 80% of 2^24 (3355443 .. 13421773) > + enum: [1, 2, 3] > $ref: /schemas/types.yaml#/definitions/uint32 > > vdd-supply: > @@ -93,7 +98,7 @@ examples: > reg = <0x18>; > reset-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>; > interrupt-parent = <&gpio3>; > - interrupts = <21 IRQ_TYPE_EDGE_FALLING>; > + interrupts = <21 IRQ_TYPE_EDGE_RISING>; > honeywell,pmin-pascal = <0>; > honeywell,pmax-pascal = <172369>; > honeywell,transfer-function = <1>; > -- > 2.41.0 >
On Tue, 26 Dec 2023 16:28:39 +0000 Jonathan Cameron <jic23@kernel.org> wrote: > On Sun, 24 Dec 2023 16:34:46 +0200 > Petre Rodan <petre.rodan@subdimension.ro> wrote: > > > Define enum inside the honeywell,transfer-function property block. > > > > Set the correct irq edge in the example block. > > Based on the datasheet, in table 13 on page 11: > > "End-of-conversion indicator: This pin is set high when a measurement > > and calculation have been completed and the data is ready to be > > clocked out" > > > > Add description on End-of-conversion interrupt. > > > > Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro> > > Signed-off-by: Andreas Klinger <ak@it-klinger.de> > What's the relationship between Andreas and this patch? > > Petre seems to have sent it so either Andreas should have a Co-authored-by or Co-developed-by: that is. > should be the author... Or not there at all > > Thanks, > > Jonathan > > > --- > > .../bindings/iio/pressure/honeywell,mprls0025pa.yaml | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml b/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml > > index d9e903fbfd99..84ced4e5a7da 100644 > > --- a/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml > > +++ b/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml > > @@ -42,6 +42,10 @@ properties: > > maxItems: 1 > > > > interrupts: > > + description: > > + Optional interrupt for indicating End-of-conversion. > > + If not present, the driver loops for a while until the received status > > + byte indicates correct measurement. > > maxItems: 1 > > > > reset-gpios: > > @@ -65,6 +69,7 @@ properties: > > 1 - A, 10% to 90% of 2^24 (1677722 .. 15099494) > > 2 - B, 2.5% to 22.5% of 2^24 (419430 .. 3774874) > > 3 - C, 20% to 80% of 2^24 (3355443 .. 13421773) > > + enum: [1, 2, 3] > > $ref: /schemas/types.yaml#/definitions/uint32 > > > > vdd-supply: > > @@ -93,7 +98,7 @@ examples: > > reg = <0x18>; > > reset-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>; > > interrupt-parent = <&gpio3>; > > - interrupts = <21 IRQ_TYPE_EDGE_FALLING>; > > + interrupts = <21 IRQ_TYPE_EDGE_RISING>; > > honeywell,pmin-pascal = <0>; > > honeywell,pmax-pascal = <172369>; > > honeywell,transfer-function = <1>; > > -- > > 2.41.0 > > > >
Hello Cameron, On Tue, Dec 26, 2023 at 04:28:39PM +0000, Jonathan Cameron wrote: > On Sun, 24 Dec 2023 16:34:46 +0200 > Petre Rodan <petre.rodan@subdimension.ro> wrote: > > > Define enum inside the honeywell,transfer-function property block. > > > > Set the correct irq edge in the example block. > > Based on the datasheet, in table 13 on page 11: > > "End-of-conversion indicator: This pin is set high when a measurement > > and calculation have been completed and the data is ready to be > > clocked out" > > > > Add description on End-of-conversion interrupt. > > > > Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro> > > Signed-off-by: Andreas Klinger <ak@it-klinger.de> > What's the relationship between Andreas and this patch? > > Petre seems to have sent it so either Andreas should have a Co-authored-by or > should be the author... Or not there at all Andreas has written this driver as it is in the mainline tree right now and he is marked as a maintainer for it. A month back I told him about the enum off-by-one problem and also about my plan of adding more features to the driver. He was happy to accept my code and once I sent v1 of this patch to the list has asked to work together for the v2 you see here. This has helped with cleaning up the code. He requested the additional 'Signed-off-by' tag, but if you have a more explicit one I will happily use it. 'Co-developed-by' it is. He also owns an i2c version of the sensor so he was able to make sure that the original half of the driver still works after my refactor, hence the 'Tested-by' tag in the last patch. please tell me how do the 'fixes'/feature/improvement tags/keywords look like? are these to be added on the subject line, or should they reside near my 'Signed-off-by' inside the email body? I probably missed the documentation where these are covered :) also, should I add a 'Reviewed-by:' you for 09/10 and 10/10 (the last two patches)? best regards, peter
On Wed, 27 Dec 2023 09:11:35 +0200 Petre Rodan <petre.rodan@subdimension.ro> wrote: > Hello Cameron, > > On Tue, Dec 26, 2023 at 04:28:39PM +0000, Jonathan Cameron wrote: > > On Sun, 24 Dec 2023 16:34:46 +0200 > > Petre Rodan <petre.rodan@subdimension.ro> wrote: > > > > > Define enum inside the honeywell,transfer-function property block. > > > > > > Set the correct irq edge in the example block. > > > Based on the datasheet, in table 13 on page 11: > > > "End-of-conversion indicator: This pin is set high when a measurement > > > and calculation have been completed and the data is ready to be > > > clocked out" > > > > > > Add description on End-of-conversion interrupt. > > > > > > Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro> > > > Signed-off-by: Andreas Klinger <ak@it-klinger.de> > > What's the relationship between Andreas and this patch? > > > > Petre seems to have sent it so either Andreas should have a Co-authored-by or > > should be the author... Or not there at all > > Andreas has written this driver as it is in the mainline tree right now and he > is marked as a maintainer for it. > A month back I told him about the enum off-by-one problem and also about my plan > of adding more features to the driver. > He was happy to accept my code and once I sent v1 of this patch to the list has > asked to work together for the v2 you see here. This has helped with cleaning up > the code. He requested the additional 'Signed-off-by' tag, but if you have a more > explicit one I will happily use it. 'Co-developed-by' it is. Yup, needs combination of Co-developed-by and a Sign off for this case as in effect both of you wrote the code. > > He also owns an i2c version of the sensor so he was able to make sure that the > original half of the driver still works after my refactor, hence the 'Tested-by' > tag in the last patch. That's fine. > > please tell me how do the 'fixes'/feature/improvement tags/keywords look like? > are these to be added on the subject line, or should they reside near my > 'Signed-off-by' inside the email body? I probably missed the documentation where > these are covered :) See https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst for lots of detail. The fixes tag has a particular format and goes in the main tag block. Lots of examples in tree so can just take a look at the git history for how to apply these rules in practice. > > also, should I add a 'Reviewed-by:' you for 09/10 and 10/10 (the last two patches)? No. Tags should be explicitly given. I tend not to give RB for stuff I'll pick up because they will have my SoB anyway as the person who applies the patches and that includes reviewing. In this case, Andreas asked for a tag to be included whereas I have not. Jonathan > > best regards, > peter
diff --git a/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml b/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml index d9e903fbfd99..84ced4e5a7da 100644 --- a/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml +++ b/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml @@ -42,6 +42,10 @@ properties: maxItems: 1 interrupts: + description: + Optional interrupt for indicating End-of-conversion. + If not present, the driver loops for a while until the received status + byte indicates correct measurement. maxItems: 1 reset-gpios: @@ -65,6 +69,7 @@ properties: 1 - A, 10% to 90% of 2^24 (1677722 .. 15099494) 2 - B, 2.5% to 22.5% of 2^24 (419430 .. 3774874) 3 - C, 20% to 80% of 2^24 (3355443 .. 13421773) + enum: [1, 2, 3] $ref: /schemas/types.yaml#/definitions/uint32 vdd-supply: @@ -93,7 +98,7 @@ examples: reg = <0x18>; reset-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>; interrupt-parent = <&gpio3>; - interrupts = <21 IRQ_TYPE_EDGE_FALLING>; + interrupts = <21 IRQ_TYPE_EDGE_RISING>; honeywell,pmin-pascal = <0>; honeywell,pmax-pascal = <172369>; honeywell,transfer-function = <1>;