Message ID | 20231227-mbly-clk-v2-3-a05db63c380f@bootlin.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-12119-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp1531549dyb; Wed, 27 Dec 2023 08:26:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IGLOJMHr5hBSu2Yedv96PbFAxhJ0hPudrTeBYdw4jWnOLUeHAnpZDUUXnm2Wkv7qazmTkr9 X-Received: by 2002:a17:902:d355:b0:1d4:786a:20d2 with SMTP id l21-20020a170902d35500b001d4786a20d2mr1196400plk.92.1703694371847; Wed, 27 Dec 2023 08:26:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703694371; cv=none; d=google.com; s=arc-20160816; b=jnLTGaaWns51E0aM9a3wVplK/jaaEel5N4mRIH4R2EkhdDI/RbaatttvQ7eSdoRybI VEaUqy/p07xIeJpCr/JWVILROMegmmFlCd8cufX9DMkjlhSBlPlcp4FYxi+3y4jayuh5 VW/2Tan0bz53aKUv08PEtF2kIQbGywvKUfK6IpYGhPmwR22aac9luWoJV7FUzzWZa8aF Apn2g7c5qFEh3/qOc7fayc4Di8CU6FgfHv/r5F3AcD5osD3N/a3W2kJXItCxezd9dd2r kv4L2mBivPl1yc/qVQjcKnbV6QsyP+BPMBuSwHsFCLnkNZHud5WQLCA8n3Xcs6ZIYU5T ei2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=LZfTV5tQJozPVh1HdxHi4GAo8AbjnMqrW5AJiiS9+Pg=; fh=LfLGsUUJa4TlTn3K59Ppdl4ZPEps7A8D2ImHmD7mMyU=; b=0REhMP4DA6/U920St7DxVls5kDzSFykjA6HLGpLpJU/xpe/S51ute7TjBd4S6MJ5Y3 P2KCNkF3cqiIP4vRhcpYZLIDl+7rrziTg4pC9P/yyYO6ol0HvhdNpew0IJNH1ALJ5SeR ZNoEnWKVxu6UxhxxVifOEZWD9MC6r5acqPU+G3JdGEHiskKco+njjYaO12FdJyqD7AXh Tcm82OW/zkv8SxSS18NYE6Y+nkqm6RSq1LMDGfrfWHCu9aqbVmgAtI6SwhkDMqMW01Z0 NKGTi1zWyF9medwc3X6m5ird9pAba7krTjAPDFrMM/Mxh8oD4QNo6XjUfb4qJMPd6msW ymyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=dYUPE12x; spf=pass (google.com: domain of linux-kernel+bounces-12119-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12119-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id ju24-20020a170903429800b001d3eb45963bsi11091350plb.103.2023.12.27.08.26.11 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 08:26:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12119-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=dYUPE12x; spf=pass (google.com: domain of linux-kernel+bounces-12119-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12119-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id DA97AB2276B for <ouuuleilei@gmail.com>; Wed, 27 Dec 2023 16:25:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6DC5D47F4F; Wed, 27 Dec 2023 16:24:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="dYUPE12x" X-Original-To: linux-kernel@vger.kernel.org Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 725BC46424; Wed, 27 Dec 2023 16:24:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 18B1BFF80F; Wed, 27 Dec 2023 16:24:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1703694246; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LZfTV5tQJozPVh1HdxHi4GAo8AbjnMqrW5AJiiS9+Pg=; b=dYUPE12xoMMXQKoRAVw9nBpyWekw/6+dkNyL/3K+Vf/40Z2EmPC2mtZTATZc5FE0VURmxq baP872LslrVG14iJXvYtZpJ0djaaJOU/Zo5cFaoYvYOwMFbn1L+NVnHS2sUIFhBnCJqnMV ZD6bkgkaJVEWDi59Pe3uPQ3l5ft+6rkGX36PDHGQv2O5Gcza+iL5ytFUTWZe/8cogdnbhw oYHIXnDXmVCqQORdd81atXTNexQKoUgrWi17whtpmFo6Z5StEzBKfddnxLOKu4jjUESee7 W1MPSuFKvc3G7heufgdE/yW7I4SJ2Nw/0bQ5ROzwwM5+Ea66SOB7kNrH68aqLw== From: =?utf-8?q?Th=C3=A9o_Lebrun?= <theo.lebrun@bootlin.com> Date: Wed, 27 Dec 2023 17:23:53 +0100 Subject: [PATCH v2 3/6] dt-bindings: soc: mobileye: add EyeQ5 OLB system controller Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20231227-mbly-clk-v2-3-a05db63c380f@bootlin.com> References: <20231227-mbly-clk-v2-0-a05db63c380f@bootlin.com> In-Reply-To: <20231227-mbly-clk-v2-0-a05db63c380f@bootlin.com> To: Gregory CLEMENT <gregory.clement@bootlin.com>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Thomas Bogendoerfer <tsbogend@alpha.franken.de> Cc: Vladimir Kondratiev <vladimir.kondratiev@mobileye.com>, linux-mips@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Tawfik Bayouk <tawfik.bayouk@mobileye.com>, =?utf-8?q?Th=C3=A9o_Lebrun?= <theo.lebrun@bootlin.com> X-Mailer: b4 0.12.4 X-GND-Sasl: theo.lebrun@bootlin.com X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786453029253880944 X-GMAIL-MSGID: 1786453029253880944 |
Series |
Add support for Mobileye EyeQ5 clock controller
|
|
Commit Message
Théo Lebrun
Dec. 27, 2023, 4:23 p.m. UTC
Add documentation to describe the "Other Logic Block" syscon.
Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
---
.../bindings/soc/mobileye/mobileye,eyeq5-olb.yaml | 44 ++++++++++++++++++++++
MAINTAINERS | 1 +
2 files changed, 45 insertions(+)
Comments
On Wed, Dec 27, 2023 at 10:24 AM Théo Lebrun <theo.lebrun@bootlin.com> wrote: > > Add documentation to describe the "Other Logic Block" syscon. > > Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> > --- > .../bindings/soc/mobileye/mobileye,eyeq5-olb.yaml | 44 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 45 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml b/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml > new file mode 100644 > index 000000000000..b148a49b08f1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/mobileye/mobileye,eyeq5-olb.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mobileye EyeQ5 SoC system controller > + > +maintainers: > + - Grégory Clement <gregory.clement@bootlin.com> > + - Théo Lebrun <theo.lebrun@bootlin.com> > + - Vladimir Kondratiev <vladimir.kondratiev@mobileye.com> > + > +description: > + OLB ("Other Logic Block") is a hardware block grouping smaller blocks. Clocks, > + resets, pinctrl are being handled from here. I don't see resets or pinctrl in the binding. Please make it complete whether you have the driver or not. As-is, you don't need clocks to be a child node. > + > +properties: > + compatible: > + items: > + - const: mobileye,eyeq5-olb > + - const: syscon > + - const: simple-mfd > + > + reg: > + maxItems: 1 > + > + reg-io-width: > + const: 4 Why do you need this? It is not a generic block and can only ever be 1 value. > + > +required: > + - compatible > + - reg > + - reg-io-width > + > +additionalProperties: false > + > +examples: > + - | > + olb@e00000 { > + compatible = "mobileye,eyeq5-olb", "syscon", "simple-mfd"; > + reg = <0xe00000 0x400>; > + reg-io-width = <4>; Make this example complete and drop the child node example. Rob
On 27/12/2023 17:23, Théo Lebrun wrote: > Add documentation to describe the "Other Logic Block" syscon. > > Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> > --- > .../bindings/soc/mobileye/mobileye,eyeq5-olb.yaml | 44 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 45 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml b/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml > new file mode 100644 > index 000000000000..b148a49b08f1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/mobileye/mobileye,eyeq5-olb.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mobileye EyeQ5 SoC system controller > + > +maintainers: > + - Grégory Clement <gregory.clement@bootlin.com> > + - Théo Lebrun <theo.lebrun@bootlin.com> > + - Vladimir Kondratiev <vladimir.kondratiev@mobileye.com> > + > +description: > + OLB ("Other Logic Block") is a hardware block grouping smaller blocks. Clocks, > + resets, pinctrl are being handled from here. > + > +properties: > + compatible: > + items: > + - const: mobileye,eyeq5-olb > + - const: syscon > + - const: simple-mfd > + > + reg: > + maxItems: 1 > + > + reg-io-width: > + const: 4 > + > +required: > + - compatible > + - reg > + - reg-io-width It's still wrong order of the patches. Binding should be complete, so you miss clock-controller in this patch. If you ordered them hoping there is no dependency between patches, it will not work. You still have dependency! Your next patch still depends on this, which should be clearly expressed either in cover letter or next patch. Best regards, Krzysztof
Hello, On Wed Dec 27, 2023 at 7:27 PM CET, Rob Herring wrote: > On Wed, Dec 27, 2023 at 10:24 AM Théo Lebrun <theo.lebrun@bootlin.com> wrote: > > > > Add documentation to describe the "Other Logic Block" syscon. > > > > Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> > > --- > > .../bindings/soc/mobileye/mobileye,eyeq5-olb.yaml | 44 ++++++++++++++++++++++ > > MAINTAINERS | 1 + > > 2 files changed, 45 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml b/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml > > new file mode 100644 > > index 000000000000..b148a49b08f1 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml > > @@ -0,0 +1,44 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/soc/mobileye/mobileye,eyeq5-olb.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Mobileye EyeQ5 SoC system controller > > + > > +maintainers: > > + - Grégory Clement <gregory.clement@bootlin.com> > > + - Théo Lebrun <theo.lebrun@bootlin.com> > > + - Vladimir Kondratiev <vladimir.kondratiev@mobileye.com> > > + > > +description: > > + OLB ("Other Logic Block") is a hardware block grouping smaller blocks. Clocks, > > + resets, pinctrl are being handled from here. > > I don't see resets or pinctrl in the binding. Please make it complete > whether you have the driver or not. > > As-is, you don't need clocks to be a child node. Will do. Would it make sense to have the three drivers be a single series? Else we could have the dt-bindings be part of the base platform support series[1]. [1]: https://lore.kernel.org/lkml/20231212163459.1923041-1-gregory.clement@bootlin.com/ > > +properties: > > + compatible: > > + items: > > + - const: mobileye,eyeq5-olb > > + - const: syscon > > + - const: simple-mfd > > + > > + reg: > > + maxItems: 1 > > + > > + reg-io-width: > > + const: 4 > > Why do you need this? It is not a generic block and can only ever be 1 > value. This block is still a syscon in the end. I wanted to explicit that access width must be 4 bytes and nothing else. Does you question mean you think I should be removing it? > > +required: > > + - compatible > > + - reg > > + - reg-io-width > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + olb@e00000 { > > + compatible = "mobileye,eyeq5-olb", "syscon", "simple-mfd"; > > + reg = <0xe00000 0x400>; > > + reg-io-width = <4>; > > Make this example complete and drop the child node example. I hesitated inbetween the two options, I'll fix that on the next revision. Thanks! -- Théo Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Hello, On Thu Dec 28, 2023 at 8:21 AM CET, Krzysztof Kozlowski wrote: > On 27/12/2023 17:23, Théo Lebrun wrote: > > Add documentation to describe the "Other Logic Block" syscon. > > > > Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> > > --- > > .../bindings/soc/mobileye/mobileye,eyeq5-olb.yaml | 44 ++++++++++++++++++++++ > > MAINTAINERS | 1 + > > 2 files changed, 45 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml b/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml > > new file mode 100644 > > index 000000000000..b148a49b08f1 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml > > @@ -0,0 +1,44 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/soc/mobileye/mobileye,eyeq5-olb.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Mobileye EyeQ5 SoC system controller > > + > > +maintainers: > > + - Grégory Clement <gregory.clement@bootlin.com> > > + - Théo Lebrun <theo.lebrun@bootlin.com> > > + - Vladimir Kondratiev <vladimir.kondratiev@mobileye.com> > > + > > +description: > > + OLB ("Other Logic Block") is a hardware block grouping smaller blocks. Clocks, > > + resets, pinctrl are being handled from here. > > + > > +properties: > > + compatible: > > + items: > > + - const: mobileye,eyeq5-olb > > + - const: syscon > > + - const: simple-mfd > > + > > + reg: > > + maxItems: 1 > > + > > + reg-io-width: > > + const: 4 > > + > > +required: > > + - compatible > > + - reg > > + - reg-io-width > > It's still wrong order of the patches. Binding should be complete, so > you miss clock-controller in this patch. If you ordered them hoping > there is no dependency between patches, it will not work. You still have > dependency! Your next patch still depends on this, which should be > clearly expressed either in cover letter or next patch. Ah you read me right, I did indeed expect ordering to be enough. I'll squash all changes to mobileye,eyeq5-olb.yaml into a single commit to avoid any dependency. Thanks, -- Théo Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
On Thu, Dec 28, 2023 at 03:57:55PM +0100, Théo Lebrun wrote: > Hello, > > On Wed Dec 27, 2023 at 7:27 PM CET, Rob Herring wrote: > > On Wed, Dec 27, 2023 at 10:24 AM Théo Lebrun <theo.lebrun@bootlin.com> wrote: > > > > > > Add documentation to describe the "Other Logic Block" syscon. > > > > > > Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> > > > --- > > > .../bindings/soc/mobileye/mobileye,eyeq5-olb.yaml | 44 ++++++++++++++++++++++ > > > MAINTAINERS | 1 + > > > 2 files changed, 45 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml b/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml > > > new file mode 100644 > > > index 000000000000..b148a49b08f1 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml > > > @@ -0,0 +1,44 @@ > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/soc/mobileye/mobileye,eyeq5-olb.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Mobileye EyeQ5 SoC system controller > > > + > > > +maintainers: > > > + - Grégory Clement <gregory.clement@bootlin.com> > > > + - Théo Lebrun <theo.lebrun@bootlin.com> > > > + - Vladimir Kondratiev <vladimir.kondratiev@mobileye.com> > > > + > > > +description: > > > + OLB ("Other Logic Block") is a hardware block grouping smaller blocks. Clocks, > > > + resets, pinctrl are being handled from here. > > > > I don't see resets or pinctrl in the binding. Please make it complete > > whether you have the driver or not. > > > > As-is, you don't need clocks to be a child node. > > Will do. Would it make sense to have the three drivers be a single > series? You could, but doesn't have to be. Just make the binding complete. Whether you have the drivers done is up to you. > Else we could have the dt-bindings be part of the base platform > support series[1]. > > [1]: https://lore.kernel.org/lkml/20231212163459.1923041-1-gregory.clement@bootlin.com/ > > > > +properties: > > > + compatible: > > > + items: > > > + - const: mobileye,eyeq5-olb > > > + - const: syscon > > > + - const: simple-mfd > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + reg-io-width: > > > + const: 4 > > > > Why do you need this? It is not a generic block and can only ever be 1 > > value. > > This block is still a syscon in the end. I wanted to explicit that > access width must be 4 bytes and nothing else. > > Does you question mean you think I should be removing it? Yes. It can be implied by compatible. Rob
diff --git a/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml b/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml new file mode 100644 index 000000000000..b148a49b08f1 --- /dev/null +++ b/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml @@ -0,0 +1,44 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/soc/mobileye/mobileye,eyeq5-olb.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Mobileye EyeQ5 SoC system controller + +maintainers: + - Grégory Clement <gregory.clement@bootlin.com> + - Théo Lebrun <theo.lebrun@bootlin.com> + - Vladimir Kondratiev <vladimir.kondratiev@mobileye.com> + +description: + OLB ("Other Logic Block") is a hardware block grouping smaller blocks. Clocks, + resets, pinctrl are being handled from here. + +properties: + compatible: + items: + - const: mobileye,eyeq5-olb + - const: syscon + - const: simple-mfd + + reg: + maxItems: 1 + + reg-io-width: + const: 4 + +required: + - compatible + - reg + - reg-io-width + +additionalProperties: false + +examples: + - | + olb@e00000 { + compatible = "mobileye,eyeq5-olb", "syscon", "simple-mfd"; + reg = <0xe00000 0x400>; + reg-io-width = <4>; + }; diff --git a/MAINTAINERS b/MAINTAINERS index 4a7bd6b40d74..d955b1e80e53 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14553,6 +14553,7 @@ M: Théo Lebrun <theo.lebrun@bootlin.com> L: linux-mips@vger.kernel.org S: Maintained F: Documentation/devicetree/bindings/mips/mobileye.yaml +F: Documentation/devicetree/bindings/soc/mobileye/ F: arch/mips/boot/dts/mobileye/ F: arch/mips/configs/generic/board-eyeq5.config F: arch/mips/generic/board-epm5.its.S