Message ID | 20231220082803.345153-1-naresh.solanki@9elements.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-6570-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp2494860dyi; Wed, 20 Dec 2023 00:30:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IE+tQ+99i+7WObn19BjZabZyRjylFGYOYvxyxlVMMUSy/XigD3zgHdRMr2pHm2sdPtWWnO/ X-Received: by 2002:a05:6a00:9389:b0:6d5:d6c1:6379 with SMTP id ka9-20020a056a00938900b006d5d6c16379mr3287814pfb.47.1703061010355; Wed, 20 Dec 2023 00:30:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703061010; cv=none; d=google.com; s=arc-20160816; b=M81CmMslJiGN84Ojys5ub7Dald0kntQmbtiUbuzvNEhxSc48jLD1xXEnGdI4xcNZr3 B6f6Id+OFJIoZ3qX9b9Zyhr0bhFfMVFf2Pc19akZhOlNNGw+nyhKWzM7dXuS1ubEaOk/ W4oCPxSnkAzeEnPC+bOQseI8Qw+HAdap7z9qORIf519UQ9lfPoG1pV3Voq/veGhfhQSc 7l35zKBlQ1Nrq37sduKh411n4FGdZuiiPoJHFndM2/34fw1vzW+WJM94JLYeqoDE+DI9 RqWBl55ajmcfrwspR+E47PFH39Nq4vVJk1Nm6/RZOLhuko4f4b5KiKqmdR48UQh7aqAA yOwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=Pnge+1KVjVw+sI86vmpy7qUzgDU254VIm7qUPhyPlKQ=; fh=CuA3e7TIJAx20sUC+9/civ42qQ0M4HxBJLaicSklPa8=; b=NkrqHkux/89gTycb+X8Qy1xRdGHW1uWjDqT6NQkzRalQmd/EDbIuWVKW9QNkXE9gxo rIfSv8fPDG+2FWAsYzJXW1Iss4Q46m6/pb6QrxZ8JHYAbK8Bj92rsYrMnzA+JjKDK8nn mceDqMAHra4f2t1jJE+sHtZ25mKp+Wql8pJZhzfs1cenKbqEOLSUMTfl/4d8DWvVLjrl z9lEo0EJbdpdnp139uMPyJ7KpKIKSFFPzyPuKlyOtDONST2bxX0O0BI6oWmasGx/02ZO 3UR4ZYxAxjkKYl0iLScFeZysD5uk54Ri9BJr3HPyTHkI15nGXdBHZzXypyAsgVh4pfCk 3ZSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=MZrQwlO3; spf=pass (google.com: domain of linux-kernel+bounces-6570-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-6570-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id fm22-20020a056a002f9600b006d38c94f324si907753pfb.362.2023.12.20.00.30.09 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 00:30:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-6570-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=MZrQwlO3; spf=pass (google.com: domain of linux-kernel+bounces-6570-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-6570-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 6AF7EB25C02 for <ouuuleilei@gmail.com>; Wed, 20 Dec 2023 08:29:01 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 08DA51DA56; Wed, 20 Dec 2023 08:28:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=9elements.com header.i=@9elements.com header.b="MZrQwlO3" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A74741CF8F for <linux-kernel@vger.kernel.org>; Wed, 20 Dec 2023 08:28:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=9elements.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=9elements.com Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-552fba34d69so5190331a12.3 for <linux-kernel@vger.kernel.org>; Wed, 20 Dec 2023 00:28:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; t=1703060888; x=1703665688; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Pnge+1KVjVw+sI86vmpy7qUzgDU254VIm7qUPhyPlKQ=; b=MZrQwlO3xukNXXNfYYdSjx8yDcUF3KcGglmtgTF3x+FXcAsgBVFQ0Xd5mDVD8PPcNr ZvDdjY+JgdhUZXxo20rXlqi8MWUK1fCDGjEoLw9yoZ90bqFwHBP6bBiekqvmNGCT17KS umQtaN+tT+uZY9sR4XGVETWOf0xiuccHI+niiwQVnsmVxwD9hIUOtGaqGQxeMQ7RlArS xZD7iIwBaDZoaZRJ/QbwdjkGd1ESJgaJ1LxtO3trdkYm5Bva3hjk1HeDXjUyxofyIOai 0kVhWk23qT5VHrDfBCU27+9RZcBJtWmZQ7qeAiysyuXY0ifB5knb7uCIuJS5EuJr54nd 4H6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703060888; x=1703665688; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Pnge+1KVjVw+sI86vmpy7qUzgDU254VIm7qUPhyPlKQ=; b=xDeMVEGX9CifvZ/9C7BQJzGmFKTQa4T4DQwUg3nD/CfcJWLXUvHydX5tI+R9S16vHD IHJVOG4wrQiqy02GcmQ1SOTaE0X6Cffrjpl4wa+EX9pGJ2myxYyrF2Ne2Bbu1yVS8l5k /xmCOdGQh1o695CXiyEpkAGvbJp2y5pIHJH/DWfTki9z437thm5Gbhwyl0nQckunSVH4 y/2QO15P3fBnDHwaEsZyETYPbiMdVoEzKPRUlAIqLu8ck8YHWrrQEilrji/14pH8T0RV pCELMhjP9BGWQz/hHLv6auOB+9fFjNErMOAmlGOhn0BXgPN+wh9ExQ9jMerj8ZR3Uzot a3fQ== X-Gm-Message-State: AOJu0YxU0vKfZ7mSh3d5gmbViwB7p2VObuJYz0jBYFn5BMjMZCVifQfg 8YG78jcS2PNMAjCY24//5+PoccnKLF7Tt9pejdB5eQ== X-Received: by 2002:a17:906:c784:b0:a23:3621:a542 with SMTP id cw4-20020a170906c78400b00a233621a542mr3111987ejb.108.1703060887793; Wed, 20 Dec 2023 00:28:07 -0800 (PST) Received: from stroh80.sec.9e.network (ip-078-094-000-051.um19.pools.vodafone-ip.de. [78.94.0.51]) by smtp.gmail.com with ESMTPSA id s20-20020a170906bc5400b00a26965e4caesm334778ejv.43.2023.12.20.00.28.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 00:28:07 -0800 (PST) From: Naresh Solanki <naresh.solanki@9elements.com> To: Peter Rosin <peda@axentia.se>, Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Patrick Rudolph <patrick.rudolph@9elements.com>, Naresh Solanki <naresh.solanki@9elements.com>, Rob Herring <robh@kernel.org>, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RESEND PATCH v5 1/2] dt-bindings: i2c: pca954x: Add custom properties for MAX7357 Date: Wed, 20 Dec 2023 13:58:01 +0530 Message-ID: <20231220082803.345153-1-naresh.solanki@9elements.com> X-Mailer: git-send-email 2.41.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785788901713528497 X-GMAIL-MSGID: 1785788901713528497 |
Series |
[RESEND,v5,1/2] dt-bindings: i2c: pca954x: Add custom properties for MAX7357
|
|
Commit Message
Naresh Solanki
Dec. 20, 2023, 8:28 a.m. UTC
From: Patrick Rudolph <patrick.rudolph@9elements.com> Maxim Max7357 has a configuration register to enable additional features. These features aren't enabled by default & its up to board designer to enable the same as it may have unexpected side effects. These should be validated for proper functioning & detection of devices in secondary bus as sometimes it can cause secondary bus being disabled. Add booleans for: - maxim,isolate-stuck-channel - maxim,send-flush-out-sequence - maxim,preconnection-wiggle-test-enable Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com> Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com> Reviewed-by: Rob Herring <robh@kernel.org> --- Changes in V4: - Drop max7358. Changes in V3: - Update commit message Changes in V2: - Update properties. --- .../bindings/i2c/i2c-mux-pca954x.yaml | 30 +++++++++++++++++++ 1 file changed, 30 insertions(+) base-commit: 76998e5bcdf155b36c7066808a0a65b2ee13cb2a
Comments
On Wed, Dec 20, 2023 at 01:58:01PM +0530, Naresh Solanki wrote: > From: Patrick Rudolph <patrick.rudolph@9elements.com> > > Maxim Max7357 has a configuration register to enable additional > features. These features aren't enabled by default & its up to > board designer to enable the same as it may have unexpected side effects. > > These should be validated for proper functioning & detection of devices > in secondary bus as sometimes it can cause secondary bus being disabled. > > Add booleans for: > - maxim,isolate-stuck-channel > - maxim,send-flush-out-sequence > - maxim,preconnection-wiggle-test-enable > > Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com> > Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com> > Reviewed-by: Rob Herring <robh@kernel.org> Rob, are you really OK with these bindings? They look more like configuration instead of HW description to me. > --- > Changes in V4: > - Drop max7358. > Changes in V3: > - Update commit message > Changes in V2: > - Update properties. > --- > .../bindings/i2c/i2c-mux-pca954x.yaml | 30 +++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml > index 2d7bb998b0e9..9aa0585200c9 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml > +++ b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml > @@ -71,6 +71,23 @@ properties: > description: A voltage regulator supplying power to the chip. On PCA9846 > the regulator supplies power to VDD2 (core logic) and optionally to VDD1. > > + maxim,isolate-stuck-channel: > + type: boolean > + description: Allows to use non faulty channels while a stuck channel is > + isolated from the upstream bus. If not set all channels are isolated from > + the upstream bus until the fault is cleared. > + > + maxim,send-flush-out-sequence: > + type: boolean > + description: Send a flush-out sequence to stuck auxiliary buses > + automatically after a stuck channel is being detected. > + > + maxim,preconnection-wiggle-test-enable: > + type: boolean > + description: Send a STOP condition to the auxiliary buses when the switch > + register activates a channel to detect a stuck high fault. On fault the > + channel is isolated from the upstream bus. > + > required: > - compatible > - reg > @@ -95,6 +112,19 @@ allOf: > "#interrupt-cells": false > interrupt-controller: false > > + - if: > + not: > + properties: > + compatible: > + contains: > + enum: > + - maxim,max7357 > + then: > + properties: > + maxim,isolate-stuck-channel: false > + maxim,send-flush-out-sequence: false > + maxim,preconnection-wiggle-test-enable: false > + > unevaluatedProperties: false > > examples: > > base-commit: 76998e5bcdf155b36c7066808a0a65b2ee13cb2a > -- > 2.41.0 > >
On 20/12/2023 21:50, Wolfram Sang wrote: > On Wed, Dec 20, 2023 at 01:58:01PM +0530, Naresh Solanki wrote: >> From: Patrick Rudolph <patrick.rudolph@9elements.com> >> >> Maxim Max7357 has a configuration register to enable additional >> features. These features aren't enabled by default & its up to >> board designer to enable the same as it may have unexpected side effects. >> >> These should be validated for proper functioning & detection of devices >> in secondary bus as sometimes it can cause secondary bus being disabled. >> >> Add booleans for: >> - maxim,isolate-stuck-channel >> - maxim,send-flush-out-sequence >> - maxim,preconnection-wiggle-test-enable >> >> Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com> >> Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com> >> Reviewed-by: Rob Herring <robh@kernel.org> > > Rob, are you really OK with these bindings? They look more like > configuration instead of HW description to me. Some explanation was provided here: https://lore.kernel.org/all/CABqG17g8QOgU7cObe=4EMLbEC1PeZWxdPXt7zzFs35JGqpRbfg@mail.gmail.com/ AFAIU, these properties are board-design choice. Best regards, Krzysztof
> Some explanation was provided here: > https://lore.kernel.org/all/CABqG17g8QOgU7cObe=4EMLbEC1PeZWxdPXt7zzFs35JGqpRbfg@mail.gmail.com/ > > AFAIU, these properties are board-design choice. Hey, thanks for the heads up. I agree that these options should not be "on" by default. I am still not fully convinced they serve as hardware description, though. Need to think about it some more...
Hi Wolfram, On Fri, 22 Dec 2023 at 16:05, Wolfram Sang <wsa@kernel.org> wrote: > > > > Some explanation was provided here: > > https://lore.kernel.org/all/CABqG17g8QOgU7cObe=4EMLbEC1PeZWxdPXt7zzFs35JGqpRbfg@mail.gmail.com/ > > > > AFAIU, these properties are board-design choice. > > Hey, thanks for the heads up. I agree that these options should not be > "on" by default. I am still not fully convinced they serve as hardware > description, though. Need to think about it some more... Any update on this ? Let me know if I can help with additional information. Regards, Naresh >
diff --git a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml index 2d7bb998b0e9..9aa0585200c9 100644 --- a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml +++ b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml @@ -71,6 +71,23 @@ properties: description: A voltage regulator supplying power to the chip. On PCA9846 the regulator supplies power to VDD2 (core logic) and optionally to VDD1. + maxim,isolate-stuck-channel: + type: boolean + description: Allows to use non faulty channels while a stuck channel is + isolated from the upstream bus. If not set all channels are isolated from + the upstream bus until the fault is cleared. + + maxim,send-flush-out-sequence: + type: boolean + description: Send a flush-out sequence to stuck auxiliary buses + automatically after a stuck channel is being detected. + + maxim,preconnection-wiggle-test-enable: + type: boolean + description: Send a STOP condition to the auxiliary buses when the switch + register activates a channel to detect a stuck high fault. On fault the + channel is isolated from the upstream bus. + required: - compatible - reg @@ -95,6 +112,19 @@ allOf: "#interrupt-cells": false interrupt-controller: false + - if: + not: + properties: + compatible: + contains: + enum: + - maxim,max7357 + then: + properties: + maxim,isolate-stuck-channel: false + maxim,send-flush-out-sequence: false + maxim,preconnection-wiggle-test-enable: false + unevaluatedProperties: false examples: