Message ID | 20231220141831.10063-1-colin.i.king@gmail.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-7047-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp2668874dyi; Wed, 20 Dec 2023 06:18:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IH0rvrWETtx0XjkdvXh+0wycc+ZeOgCaPzHSYLehCsplOKPpxbIEGejFJko4rJuBjuzJRzB X-Received: by 2002:a05:6358:787:b0:170:b81b:4a20 with SMTP id n7-20020a056358078700b00170b81b4a20mr20880824rwj.51.1703081938312; Wed, 20 Dec 2023 06:18:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703081938; cv=none; d=google.com; s=arc-20160816; b=LfJrZMi+cV4GMfC6IVuQLtvm7B1v7Y/bFL5Lb6aSutCb34dAgDgo1kA2ZrvYNVf1YY 0KQMV8xdZ11JZ+ah/j6o8M3VOkdfvyEXUUKHPPz+hgR+soO2W5wJCuMjbV5l8JdbqqZk mx19agZ1frfsiT9k8KAsabBz6gHSwiL7RxhsMRvnCfRJ4msSJ2MT3jMUq9b5c2KRcYEr Fdi4v6MJc6n9AV/XYHHGibucNuMvwPQniRxTnCExFFfHAYrpgj3sOEmsZOBcYrq/mwW+ dMzro2WQaO435P+086lvOYE2lwv1F1HHSGGd0O7ZQCBRTV8J/bzqDpdj0IeKDKzll6B2 k85A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=wtboqIOajZ+9kRzpEuYvtN45b5wd0evNFunITw7khVI=; fh=9KnBa8jw3HAgnuQlorTmOllDzUlPjil/gbJLLDMjPAk=; b=fSCaXqoTkc2gBy8DI8yT5DAhaijXn2K3eydFXDMpWnayLIL6x8p6jtem/115UbKjMT B51Pr8UvwB+bR9SoyOnyPzdFnzSTgsOuCP4SaTsoBO2uO1258S1SVQfTPxeK05aq2VSA 4z2uSLXLcizGhHQFaHikHMjbrEXR79qxjPvsOZPzyZcV9tkgpGKs3iNAMLn1RxvlqsXg zIeUHH12Z8GI4empxd3Dj0G88aKCn6+kgk7y1n6sCvukA45l6FiWLSre9DZM3tYe9SGy rlwt28ZBrlggMWoxB34b9R0B04WLbA67igZlcpVMqYjsNFs1Tm5cfkpTq2t6u+NVmP5n frKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=kvPST8UF; spf=pass (google.com: domain of linux-kernel+bounces-7047-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7047-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id x8-20020a654548000000b005c5e24d4364si21081660pgr.428.2023.12.20.06.18.58 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 06:18:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-7047-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=kvPST8UF; spf=pass (google.com: domain of linux-kernel+bounces-7047-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7047-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 103132831FE for <ouuuleilei@gmail.com>; Wed, 20 Dec 2023 14:18:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 340193984E; Wed, 20 Dec 2023 14:18:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kvPST8UF" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33D4B38DDD; Wed, 20 Dec 2023 14:18:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3367a304091so739074f8f.3; Wed, 20 Dec 2023 06:18:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703081913; x=1703686713; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wtboqIOajZ+9kRzpEuYvtN45b5wd0evNFunITw7khVI=; b=kvPST8UFr0/7w/lyjF61+teanbCnJhBRWVCdAwxh3v/Sm0eHr0f8b5uO+bUrqpTT8z zmGMWV5xOo+dZ1CrJ8y1s72tFSAJGaryEW3Gy7jPdgESiX9eeaVdXnAJmlVdpYv4W/fa ket62nCJ3wr1fpRUsctfkiAfmMQOUojvsvyZ/nT4YUB3wWa63VbrYuV/fFSIfG/xY6hf xPRWDarR/HZzNHubv8SbFkLei5PODmGR56ib128zb8WCbM9Papi+6lu2mRjaSv3/yQZt b0fswzmYIVN90ILKBIHAqJEzircBVrFvsL49LgjyLj2NGTJIyOwgsPEF7YtN9HENa4tO W0DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703081913; x=1703686713; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wtboqIOajZ+9kRzpEuYvtN45b5wd0evNFunITw7khVI=; b=GuPVqLe8M4u3pKbyM4BwLZvZ05p8HVejppUTnhT2Zvu+nAtpZgBaR3Epw7FxZElzdj hIcOcOtDVw+YVJjpBDye3p5bXxFDRBNvnNA9UmTK8UDYt2ZGcxab+yxa+Oq/dMp41r4g gYusePCI/L1ua+bDC37cz8DYK95YcH3R9adu/839d4UogYaMCycp3c3/Utls0Q6PxEGj opbt6WDcBcyMt4lrAB27otNpeDZt6w8oLxAgQM8tusYfkwbPDCGYHazobTDczJA0cMxI csqzUHyGI1iWMMYttjqafRzCQzDekSsmHoKhrKoElbTmd2o0PsPsEiFeCOIAhsSXSTjV v8fg== X-Gm-Message-State: AOJu0YyKadpb9bcnOxWorIY2WYpBB4gRAAgFNwbwod+5esuwHnP4Ucqh x+voGo/zL+DibCamxDaiGRM= X-Received: by 2002:a05:600c:4e4b:b0:40d:35a6:af23 with SMTP id e11-20020a05600c4e4b00b0040d35a6af23mr358445wmq.26.1703081913140; Wed, 20 Dec 2023 06:18:33 -0800 (PST) Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net. [80.193.200.194]) by smtp.gmail.com with ESMTPSA id j7-20020a05600c190700b0040c31bb66dcsm7466687wmq.20.2023.12.20.06.18.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 06:18:32 -0800 (PST) From: Colin Ian King <colin.i.king@gmail.com> To: Ping-Ke Shih <pkshih@realtek.com>, Kalle Valo <kvalo@kernel.org>, linux-wireless@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] wifi: rtw89: mac: Fix spelling mistakes "notfify" -> "notify" Date: Wed, 20 Dec 2023 14:18:31 +0000 Message-Id: <20231220141831.10063-1-colin.i.king@gmail.com> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785810846142200787 X-GMAIL-MSGID: 1785810846142200787 |
Series |
[next] wifi: rtw89: mac: Fix spelling mistakes "notfify" -> "notify"
|
|
Commit Message
Colin Ian King
Dec. 20, 2023, 2:18 p.m. UTC
There are two spelling mistakes in rtw89_err error messages. Fix these
and also add space between [ERR] and message text.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/net/wireless/realtek/rtw89/mac_be.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
> -----Original Message----- > From: Colin Ian King <colin.i.king@gmail.com> > Sent: Wednesday, December 20, 2023 10:19 PM > To: Ping-Ke Shih <pkshih@realtek.com>; Kalle Valo <kvalo@kernel.org>; linux-wireless@vger.kernel.org > Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [PATCH][next] wifi: rtw89: mac: Fix spelling mistakes "notfify" -> "notify" > > There are two spelling mistakes in rtw89_err error messages. Fix these > and also add space between [ERR] and message text. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Acked-by: Ping-Ke Shih <pkshih@realtek.com> Thanks for the correctness. Could I know the tool you used to find out these typo? Ping-Ke
On 22/12/2023 00:19, Ping-Ke Shih wrote: > > >> -----Original Message----- >> From: Colin Ian King <colin.i.king@gmail.com> >> Sent: Wednesday, December 20, 2023 10:19 PM >> To: Ping-Ke Shih <pkshih@realtek.com>; Kalle Valo <kvalo@kernel.org>; linux-wireless@vger.kernel.org >> Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org >> Subject: [PATCH][next] wifi: rtw89: mac: Fix spelling mistakes "notfify" -> "notify" >> >> There are two spelling mistakes in rtw89_err error messages. Fix these >> and also add space between [ERR] and message text. >> >> Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > > Acked-by: Ping-Ke Shih <pkshih@realtek.com> > > Thanks for the correctness. Could I know the tool you used to find out these > typo? Sure, https://github.com/ColinIanKing/kernelscan It needs the american dictionary, installed in /usr/share/dict e.g. apt-get install wamerican and then spellcheck with: ./kernelscan -k path-to-code-you-want-to-scan I run kernelscan on the entire linux-next source daily and diff the days's results with the previous day using the meld diff tool. Colin > > Ping-Ke > >
> -----Original Message----- > From: Colin King (gmail) <colin.i.king@gmail.com> > Sent: Friday, December 22, 2023 8:09 PM > To: Ping-Ke Shih <pkshih@realtek.com>; Kalle Valo <kvalo@kernel.org>; linux-wireless@vger.kernel.org > Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH][next] wifi: rtw89: mac: Fix spelling mistakes "notfify" -> "notify" > > On 22/12/2023 00:19, Ping-Ke Shih wrote: > > > > > >> -----Original Message----- > >> From: Colin Ian King <colin.i.king@gmail.com> > >> Sent: Wednesday, December 20, 2023 10:19 PM > >> To: Ping-Ke Shih <pkshih@realtek.com>; Kalle Valo <kvalo@kernel.org>; linux-wireless@vger.kernel.org > >> Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org > >> Subject: [PATCH][next] wifi: rtw89: mac: Fix spelling mistakes "notfify" -> "notify" > >> > >> There are two spelling mistakes in rtw89_err error messages. Fix these > >> and also add space between [ERR] and message text. > >> > >> Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > > > > Acked-by: Ping-Ke Shih <pkshih@realtek.com> > > > > Thanks for the correctness. Could I know the tool you used to find out these > > typo? > > Sure, > > https://github.com/ColinIanKing/kernelscan > > It needs the american dictionary, installed in /usr/share/dict e.g. > apt-get install wamerican > > and then spellcheck with: > > ./kernelscan -k path-to-code-you-want-to-scan Thanks for the tool. :-) I will try to scan my driver before sending out patches. Ping-Ke
Colin Ian King <colin.i.king@gmail.com> wrote: > There are two spelling mistakes in rtw89_err error messages. Fix these > and also add space between [ERR] and message text. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > Acked-by: Ping-Ke Shih <pkshih@realtek.com> Patch applied to wireless-next.git, thanks. 6aeaa379291b wifi: rtw89: mac: Fix spelling mistakes "notfify" -> "notify"
diff --git a/drivers/net/wireless/realtek/rtw89/mac_be.c b/drivers/net/wireless/realtek/rtw89/mac_be.c index be30c9346293..4befbe06cd15 100644 --- a/drivers/net/wireless/realtek/rtw89/mac_be.c +++ b/drivers/net/wireless/realtek/rtw89/mac_be.c @@ -1616,7 +1616,7 @@ static int dbcc_enable_be(struct rtw89_dev *rtwdev, bool enable) if (test_bit(RTW89_FLAG_FW_RDY, rtwdev->flags)) { ret = rtw89_fw_h2c_notify_dbcc(rtwdev, true); if (ret) { - rtw89_err(rtwdev, "%s:[ERR]notfify dbcc1 fail %d\n", + rtw89_err(rtwdev, "%s:[ERR] notify dbcc1 fail %d\n", __func__, ret); return ret; } @@ -1625,7 +1625,7 @@ static int dbcc_enable_be(struct rtw89_dev *rtwdev, bool enable) if (test_bit(RTW89_FLAG_FW_RDY, rtwdev->flags)) { ret = rtw89_fw_h2c_notify_dbcc(rtwdev, false); if (ret) { - rtw89_err(rtwdev, "%s:[ERR]notfify dbcc1 fail %d\n", + rtw89_err(rtwdev, "%s:[ERR] notify dbcc1 fail %d\n", __func__, ret); return ret; }