Message ID | 202312201059100522230@zte.com.cn |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-6308-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp2383582dyi; Tue, 19 Dec 2023 19:00:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IEhfmtdXYWIFgsDnjWPiFKQX4Bo2R9nXxwhZS1oyivfbYYDp0rBK0G0jIvrhlvOAsCTF28B X-Received: by 2002:a17:906:e089:b0:a23:53f6:d66f with SMTP id gh9-20020a170906e08900b00a2353f6d66fmr2255287ejb.138.1703041239635; Tue, 19 Dec 2023 19:00:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703041239; cv=none; d=google.com; s=arc-20160816; b=yZUEft54FbBVjnr5tEQWLUjMiflpesjwRlh/IGw3I6zSfGrp4baRmMvzubcwpHkO3m Q4inXRZivb5P6ggPSCAWRNyvu2+kieIC60cc5p0YcGT7oB0ehj7XEI77/EUXLwQnhtLX DyzqYaiT7siiv3Ndulob90vGIglWvrexO/ErDqwcOgLk5OvT0ZrR7mLeLQECgC6FqTqW /3tkUTN3lPoxrVuLZW+7eaRbceeI62c8nazNRKV8txc2vbD/ZH6b/VY2OVyIESDKy/Dx a2ct2nYFPPnvfLwDGcMFLwXhXl6aSQijiKemlP2JYHlyzwdH6mD6AyHr2SfIWGHBeoQ3 c/EA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=subject:cc:to:from:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:message-id:date; bh=Q7qd9rAYbyE78EI7G0jqVeD6w7iai5vItPPEl4188QU=; fh=dP7dsXdsr14PAp8cLVnA1AvjUXbvIFoIcNNW8BRuuw0=; b=U5VS4VrGn2hgKRyYWlIAsJ6h2mnC4SaE0SdrNo7P34+FpWPlt3eoHJzD3S0EHXKy8O ylECtMMLIC8mYTotBryUdrJfs/ovWXs/Wq3W93p2bad5utjEcWyDoPl7uTlnmT7H19If 8cPCnUjXLWXuvKV21jLBgtt8Enu2dWzOlYpZQIew/VDd3wkIlKNIC6qze7o+HsjQx281 Q21yAHVjU2DTLmYVkU/58gX5134Z5OJ7o9682Wmcz/BbOkZLf8YYL59PvF6/M4qKmUwT T4YVsNyHVjjRY99eSjAzN1lST4mllavc4syqG/fw/318KLfGhTY2rLjBNe6VbxaZPS9J pLOw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-6308-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-6308-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id l12-20020a170906078c00b00a23338363bfsi3199724ejc.479.2023.12.19.19.00.39 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 19:00:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-6308-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-6308-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-6308-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 40A181F264BD for <ouuuleilei@gmail.com>; Wed, 20 Dec 2023 03:00:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BC32115491; Wed, 20 Dec 2023 02:59:45 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from mxde.zte.com.cn (mxde.zte.com.cn [209.9.37.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E5E1CA41 for <linux-kernel@vger.kernel.org>; Wed, 20 Dec 2023 02:59:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zte.com.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=zte.com.cn Received: from mxhk.zte.com.cn (unknown [192.168.250.138]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mxde.zte.com.cn (FangMail) with ESMTPS id 4Svyvq0fhlz68Jxc for <linux-kernel@vger.kernel.org>; Wed, 20 Dec 2023 10:59:35 +0800 (CST) Received: from mse-fl2.zte.com.cn (unknown [10.5.228.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4Svyvf0vg8z4xPYr; Wed, 20 Dec 2023 10:59:26 +0800 (CST) Received: from xaxapp02.zte.com.cn ([10.88.97.241]) by mse-fl2.zte.com.cn with SMTP id 3BK2x8Rl080444; Wed, 20 Dec 2023 10:59:08 +0800 (+08) (envelope-from yang.guang5@zte.com.cn) Received: from mapi (xaxapp03[null]) by mapi (Zmail) with MAPI id mid31; Wed, 20 Dec 2023 10:59:10 +0800 (CST) Date: Wed, 20 Dec 2023 10:59:10 +0800 (CST) X-Zmail-TransId: 2afb6582587effffffffa43-f1f6a X-Mailer: Zmail v1.0 Message-ID: <202312201059100522230@zte.com.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> Mime-Version: 1.0 From: <yang.guang5@zte.com.cn> To: <lee@kernel.org> Cc: <jiang.xuexin@zte.com.cn>, <chen.haonan2@zte.com.cn>, <cgel.zte@gmail.com>, <patches@opensource.cirrus.com>, <linux-kernel@vger.kernel.org> Subject: =?utf-8?q?=5BPATCH_v2=5D_mfd=3A_wm8994=3A_Switch_to_use_dev=5Ferr?= =?utf-8?q?=5Fprobe=28=29_helper?= Content-Type: text/plain; charset="UTF-8" X-MAIL: mse-fl2.zte.com.cn 3BK2x8Rl080444 X-Fangmail-Gw-Spam-Type: 0 X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 65825895.000/4Svyvq0fhlz68Jxc X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785768171095529337 X-GMAIL-MSGID: 1785768171095529337 |
Series |
[v2] mfd: wm8994: Switch to use dev_err_probe() helper
|
|
Commit Message
yang.guang5@zte.com.cn
Dec. 20, 2023, 2:59 a.m. UTC
From: Yang Guang <yang.guang5@zte.com.cn> dev_err() can be replace with dev_err_probe() which will check if error code is -EPROBE_DEFER. Signed-off-by: Chen Haonan <chen.haonan2@zte.com.cn> --- drivers/mfd/wm8994-core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
Comments
On Wed, 20 Dec 2023, yang.guang5@zte.com.cn wrote: > From: Yang Guang <yang.guang5@zte.com.cn> > > dev_err() can be replace with dev_err_probe() which will > check if error code is -EPROBE_DEFER. > > Signed-off-by: Chen Haonan <chen.haonan2@zte.com.cn> > --- > drivers/mfd/wm8994-core.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) How did you create and send this patch? When I try to apply this, I get: ERROR: patch seems to be corrupt (line wrapped?) #37: FILE: drivers/mfd/wm8994-core.c:384: 2.25.1 ERROR: Missing Signed-off-by: line by nominal patch author 'Yang Guang <yang.guang5@zte.com.cn>' total: 2 errors, 0 warnings, 14 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. "[PATCH v2] mfd: wm8994: Switch to use dev_err_probe() helper" has style problems, please review. AND: Applying: mfd: wm8994: Switch to use dev_err_probe() helper error: corrupt patch at line 22 error: could not build fake ancestor Patch failed at 0001 mfd: wm8994: Switch to use dev_err_probe() helper Please fix and resubmit. > diff --git a/drivers/mfd/wm8994-core.c b/drivers/mfd/wm8994-core.c > index d5ac066f9db4..c43273527425 100644 > --- a/drivers/mfd/wm8994-core.c > +++ b/drivers/mfd/wm8994-core.c > @@ -378,10 +378,8 @@ static int wm8994_device_init(struct wm8994 *wm8994, int irq) > */ > ret = regulator_bulk_get(wm8994->dev, wm8994->num_supplies, > wm8994->supplies); > - if (ret != 0) { > - if (ret != -EPROBE_DEFER) > - dev_err(wm8994->dev, "Failed to get supplies: %d\n", > - ret); > + if (ret != 0) { > + dev_err_probe(wm8994->dev, ret, "Failed to get supplies\n"); > goto err; > } > > -- > 2.25.1
diff --git a/drivers/mfd/wm8994-core.c b/drivers/mfd/wm8994-core.c index d5ac066f9db4..c43273527425 100644 --- a/drivers/mfd/wm8994-core.c +++ b/drivers/mfd/wm8994-core.c @@ -378,10 +378,8 @@ static int wm8994_device_init(struct wm8994 *wm8994, int irq) */ ret = regulator_bulk_get(wm8994->dev, wm8994->num_supplies, wm8994->supplies); - if (ret != 0) { - if (ret != -EPROBE_DEFER) - dev_err(wm8994->dev, "Failed to get supplies: %d\n", - ret); + if (ret != 0) { + dev_err_probe(wm8994->dev, ret, "Failed to get supplies\n"); goto err; }