Message ID | aada12dc-7679-4dd3-97be-a8f429020c90@suse.com |
---|---|
State | Accepted |
Headers |
Return-Path: <binutils-bounces+ouuuleilei=gmail.com@sourceware.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp9220896dys; Fri, 15 Dec 2023 04:07:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IGRWE9FICRHKXJiPSo0kQ9FAz9+y6Ptf3SZztcH0F9/koIuXfmGi6m6NgCpd4P9stcg2bNV X-Received: by 2002:a05:6102:d88:b0:465:f863:e12e with SMTP id d8-20020a0561020d8800b00465f863e12emr8948543vst.20.1702642060287; Fri, 15 Dec 2023 04:07:40 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1702642060; cv=pass; d=google.com; s=arc-20160816; b=bNJ1pcULXf4xAk6Wm2bFEtXbZ3FsPsf37zK5HK99ww8DvApcFYe9NJovGebacEq0bG 4UCxvVBfTA24XRkIL7+AeMqhYYaB87s2ROKMDYC4qSbFZ88icMlVRyv5FmAthTYF7IUn SohL91nqagU8sFrbokPp0cE27G8h5MGAByzJXu+1MjNteOl0to/NRCAD29vtpngjjBFS qn2DJyx38TNygZx/7rMIkm65rGNsm+YfFtkD+GfWvnS25lfStXhp1blPt0oZY35zSDBI tVqxWQ2E2OEGLHXpNKDiL7sABoNg6pi9ZQSCaLwKEBQHNtrW3p3GnHrlF7CIy3/gBZSH BC6A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :in-reply-to:autocrypt:references:cc:to:from:content-language :subject:user-agent:mime-version:date:message-id:dkim-signature :arc-filter:dmarc-filter:delivered-to; bh=GXbShzpVI7qr0XYCBcgl8juLD0puQsIbTppcJfY1eeY=; fh=/y5qbuWjah3AfyCXUlqYRK1h3tjfRZVNgV5YkOv6kX4=; b=QvXzRPAq/8xSa3BSJQl3vEqTlSw/0M9+C8tCC12cRQB5Gb//j5n46VwuXdUJ9rTUTO N7xi72lWtwHE/d5FIIhCwWvwvPVxn0GDV+/L+1AHFfha7wtdeYVHwcgEYnZl1eS2W7Mx 7u3Q2KnBD0tc6pMWREWu3FHSHHFdI9ujh1/enAt6LIwE9arwjga5WNcBST7hDTgwTEUZ j5YUWpDdXpwRrGDN/CSMBtQe2ThIxCnwiStBwLuLmYIs6d0ahUJqgmhVmxG9gja/c+LN aCO1Gm94c4TOL3TawguJPrOub3t1RLWAoybMJn4XlHEUNLtANUi4oE2hEn025una/bFG /TXw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.com header.s=google header.b=Dvmg0b5T; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id e11-20020a67fb4b000000b004649037848bsi3229187vsr.84.2023.12.15.04.07.40 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 04:07:40 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=google header.b=Dvmg0b5T; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EC661386D604 for <ouuuleilei@gmail.com>; Fri, 15 Dec 2023 12:07:39 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by sourceware.org (Postfix) with ESMTPS id 3D62E3865C2A for <binutils@sourceware.org>; Fri, 15 Dec 2023 12:07:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3D62E3865C2A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3D62E3865C2A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::229 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702642053; cv=none; b=eK+vDMxh1ANgFrpfG2JgIYOajTlbuzptcmMhH7fcFF4gQ5xpi9+YMsRT/NZKfwiaBYwTSipGnvRi0bHVCJ0542BksnDKbluu7FDAgjTAfoDkpIw66oxPe6HjF4P7ZvBSSbmvldrbJ/3T2+uQYZWUfVb+AONvvOlMkh+aguCsWeU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702642053; c=relaxed/simple; bh=YNMkD3yMmz/LvegMciSNGVMTPXYtH7bGYO2DsIXNOXU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=NN7zRpaeljr5GC05gBtuy9ApIICqoaKbzTNsplBxknCjA0UsH5HO5rT3QAfSL452LysDmtREa3KjwbYLxrxNzgGt/j3VnqjHrW17CSzZgnGovbvw836MNAf7GMdPb7XyjFNpiPgwY27/jMHJh7LUMyBV3CfaW6+0FumAwxGYX1c= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2c9fbb846b7so5367771fa.2 for <binutils@sourceware.org>; Fri, 15 Dec 2023 04:07:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1702642051; x=1703246851; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=GXbShzpVI7qr0XYCBcgl8juLD0puQsIbTppcJfY1eeY=; b=Dvmg0b5Tth44jKcN7m5cum0IVXRSvr//jwbbxh1zHSrA68doNH/UFxUJQZ1+LQMIJp RkqSNrvd5tY4d7Oa24bSF2Clo14Fe5F0jybKyKhODqgz+4bSStDYzggXmguUvaKrLSVa nXSw1vrP1NsIwf9lU6p20agNk/da+IhX5aZscb/HNk2f+/YBoAfJMB+d//oTtRIFlFh0 VfuExwOn/pGL/BqHRgy8NcmzURaccuKjxh8jr5TGqSJQLUePv7yXdL9oUXAevdjc19Wz 4TzkzGYl+himlBnyxMZJhs8mzV0BhXUK84EIRydDrXb2N5vsM9jpcPkLjy4xSegGbD4T lxQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702642051; x=1703246851; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GXbShzpVI7qr0XYCBcgl8juLD0puQsIbTppcJfY1eeY=; b=O1Yh2pEvp1sggkNkastBayOwamj/7AZHGwGdsRACOO94wGk+GmyZsAsFN3K8A7wm5+ vNNG4rD24eTIqHYqtMzM10VhoJ/5rddCxelpVD9Nfl/OUAcSsV902W7RBNLgfVsjErhR pz9Vm41VE4r0vBh7pX2mkXBuoporPkEEMkIGDnnDr2VVkaKKKCyrlS63dv+qNsulL5TF KCDdCsRSGmz29kNU8CnqG4kRBVS0kKWKvindMBHnHofxx3E5L8zlGOSsAm9Wx6wjRN/n bxE8FiHlmh98I03INQs48KzgIZIUQ952XZ0GbBz9c4i8bnqwuPeIg2vZQBflewG4hfaa Rsvg== X-Gm-Message-State: AOJu0YymGn9xR7WR7drVX+OkWbQL7Nq1DvQ0STys7AVLtHhrA8MTUC54 MQ2RGrcnrdellFpZDxLxa0p51NdUQp0dwBpWk9zX X-Received: by 2002:a2e:b892:0:b0:2cb:5b8a:7013 with SMTP id r18-20020a2eb892000000b002cb5b8a7013mr4735065ljp.75.1702642050839; Fri, 15 Dec 2023 04:07:30 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id k9-20020a056e02156900b0035da74cd896sm4764564ilu.77.2023.12.15.04.07.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Dec 2023 04:07:30 -0800 (PST) Message-ID: <aada12dc-7679-4dd3-97be-a8f429020c90@suse.com> Date: Fri, 15 Dec 2023 13:07:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 03/22] RISC-V: drop .bss override Content-Language: en-US From: Jan Beulich <jbeulich@suse.com> To: Binutils <binutils@sourceware.org> Cc: Nick Clifton <nickc@redhat.com>, Alan Modra <amodra@gmail.com>, Palmer Dabbelt <palmer@dabbelt.com>, Andrew Waterman <andrew@sifive.com>, Jim Wilson <jim.wilson.gcc@gmail.com>, Nelson Chu <nelson@rivosinc.com> References: <5e1fe3bc-78ca-4c54-a19c-f8efa015f839@suse.com> Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <5e1fe3bc-78ca-4c54-a19c-f8efa015f839@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3026.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list <binutils.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/binutils>, <mailto:binutils-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/binutils/> List-Post: <mailto:binutils@sourceware.org> List-Help: <mailto:binutils-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/binutils>, <mailto:binutils-request@sourceware.org?subject=subscribe> Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785349600669763734 X-GMAIL-MSGID: 1785349600669763734 |
Series |
ELF: correct handling of simplified section directives
|
|
Checks
Context | Check | Description |
---|---|---|
snail/binutils-gdb-check | success | Github commit url |
Commit Message
Jan Beulich
Dec. 15, 2023, 12:07 p.m. UTC
It doesn't look to be a good idea to override the custom handler that ELF has; afaict doing so broke .previous, and a sub-section specifier wasn't accepted either.
Comments
I passed the regressions of riscv-gnu-toolchain, so if no one objects, then it seems safe to commit. Thanks Nelson On Fri, Dec 15, 2023 at 8:07 PM Jan Beulich <jbeulich@suse.com> wrote: > It doesn't look to be a good idea to override the custom handler that > ELF has; afaict doing so broke .previous, and a sub-section specifier > wasn't accepted either. > > --- a/gas/config/tc-riscv.c > +++ b/gas/config/tc-riscv.c > @@ -4471,15 +4471,6 @@ s_dtprel (int bytes) > demand_empty_rest_of_line (); > } > > -/* Handle the .bss pseudo-op. */ > - > -static void > -s_bss (int ignore ATTRIBUTE_UNUSED) > -{ > - subseg_set (bss_section, 0); > - demand_empty_rest_of_line (); > -} > - > static void > riscv_make_nops (char *buf, bfd_vma bytes) > { > @@ -5202,7 +5193,6 @@ static const pseudo_typeS riscv_pseudo_t > {"dword", cons, 8}, > {"dtprelword", s_dtprel, 4}, > {"dtpreldword", s_dtprel, 8}, > - {"bss", s_bss, 0}, > {"uleb128", s_riscv_leb128, 0}, > {"sleb128", s_riscv_leb128, 1}, > {"insn", s_riscv_insn, 0}, > --- a/gas/doc/c-riscv.texi > +++ b/gas/doc/c-riscv.texi > @@ -138,10 +138,6 @@ Emits a DTP-relative word (or double-wor > meant to be used by the compiler in shared libraries for DWARF debug info > for > thread local variables. > > -@cindex BSS directive > -@item .bss > -Sets the current section to the BSS section. > - > @cindex LEB128 directives > @item .uleb128 @var{value} > @itemx .sleb128 @var{value} > >
--- a/gas/config/tc-riscv.c +++ b/gas/config/tc-riscv.c @@ -4471,15 +4471,6 @@ s_dtprel (int bytes) demand_empty_rest_of_line (); } -/* Handle the .bss pseudo-op. */ - -static void -s_bss (int ignore ATTRIBUTE_UNUSED) -{ - subseg_set (bss_section, 0); - demand_empty_rest_of_line (); -} - static void riscv_make_nops (char *buf, bfd_vma bytes) { @@ -5202,7 +5193,6 @@ static const pseudo_typeS riscv_pseudo_t {"dword", cons, 8}, {"dtprelword", s_dtprel, 4}, {"dtpreldword", s_dtprel, 8}, - {"bss", s_bss, 0}, {"uleb128", s_riscv_leb128, 0}, {"sleb128", s_riscv_leb128, 1}, {"insn", s_riscv_insn, 0}, --- a/gas/doc/c-riscv.texi +++ b/gas/doc/c-riscv.texi @@ -138,10 +138,6 @@ Emits a DTP-relative word (or double-wor meant to be used by the compiler in shared libraries for DWARF debug info for thread local variables. -@cindex BSS directive -@item .bss -Sets the current section to the BSS section. - @cindex LEB128 directives @item .uleb128 @var{value} @itemx .sleb128 @var{value}