Message ID | 202312201048538333616@zte.com.cn |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-6301-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp2380019dyi; Tue, 19 Dec 2023 18:49:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IHbqmSeSJj5OMzVY45BjuyqFN3dwNoptD1b2zIi49oLakcuZlS0U8MHgLnziDxD7VqJoFAr X-Received: by 2002:a05:6602:449:b0:7b6:f32f:9a72 with SMTP id e9-20020a056602044900b007b6f32f9a72mr23162507iov.22.1703040581174; Tue, 19 Dec 2023 18:49:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703040581; cv=none; d=google.com; s=arc-20160816; b=0XrCsUMc8C/skFMV/yaeh1iol6VlsuFXA1V6YY6e6pisE/KyAH/qHjkESpTtcye/MK xb7QvhjaPigOL/ExZkeBbCqcr4I6AhzeYx1h5PU2r7O4XEmsCXdM1TicFyc16pYwDDLg 44TewUVCcsBLgHs+MXQX32g/0QobidZVpNAlDFbwDt/UHQVrTswwxJ9lkCPAHX1Nh/9/ ex52mQ4je//M1QRVYdRiFULn3hcEqeiaGkkyC9NGAaFQgz3y0B1yExXJF49bS4hao0wR DL78cwkPWXAirxx5iLT62pf0t8a74eZSc1Oxd420DcLgX1fu5F1R/1AnZD6NUngh9Ott 8SWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=subject:cc:to:from:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:message-id:date; bh=vNW9/reUdJuXpleOaHFZyixRfgg5e60V812od5GEj0w=; fh=80BMigBfxR3AzK79daUrWPwyRKLabYslJjfmM2FHAT0=; b=mN+6gqEY379WNzT+rQ7m+hdy8hgLuq/HHf+j5I+ztjq2kH6p+KO6HbHsz4U7kAI7J8 kHKNX058gjbq2ImuMjBwtB+h3pZqbJ1SqdN2IjBLgDe4QqgAPj7SxNMXWJKlTaXMaZwW qBq4hdVa2wmP0L7zYRSUzA2rZu1jm7jiTJQX02AA8exGaoVhcDSp6tjhGJrmn6zqg7U8 FscQWvZVGSi5insFfH4adOVlHfvV0qQJnUVvCnOGbq1crVggtEFABN4zpSYNAF8Dq9jM TaqJQqgJHnvVqg53KBSCx6dQnBmr96OUumQTrjH0g5uuUDtHqpm2DpKeHETwGH7jFEA9 X5bA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-6301-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-6301-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id y31-20020a634b1f000000b005c635a9d1f2si20188983pga.156.2023.12.19.18.49.41 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 18:49:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-6301-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-6301-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-6301-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id BDD17287FDA for <ouuuleilei@gmail.com>; Wed, 20 Dec 2023 02:49:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4703C8F71; Wed, 20 Dec 2023 02:49:08 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.216.63.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF3E98827 for <linux-kernel@vger.kernel.org>; Wed, 20 Dec 2023 02:49:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zte.com.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=zte.com.cn Received: from mse-fl2.zte.com.cn (unknown [10.5.228.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4Svygc57qqz8XrRF; Wed, 20 Dec 2023 10:49:00 +0800 (CST) Received: from xaxapp01.zte.com.cn ([10.88.99.176]) by mse-fl2.zte.com.cn with SMTP id 3BK2mqt7068198; Wed, 20 Dec 2023 10:48:52 +0800 (+08) (envelope-from yang.guang5@zte.com.cn) Received: from mapi (xaxapp02[null]) by mapi (Zmail) with MAPI id mid31; Wed, 20 Dec 2023 10:48:53 +0800 (CST) Date: Wed, 20 Dec 2023 10:48:53 +0800 (CST) X-Zmail-TransId: 2afa65825615ffffffffd39-0a04b X-Mailer: Zmail v1.0 Message-ID: <202312201048538333616@zte.com.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> Mime-Version: 1.0 From: <yang.guang5@zte.com.cn> To: <hanxu5@huaqin.corp-partner.google.com> Cc: <jiang.xuexin@zte.com.cn>, <chen.haonan2@zte.com.cn>, <cgel.zte@gmail.com>, <neil.armstrong@linaro.org>, <quic_jesszhan@quicinc.com>, <sam@ravnborg.org>, <maarten.lankhorst@linux.intel.com>, <mripard@kernel.org>, <tzimmermann@suse.de>, <airlied@gmail.com>, <daniel@ffwll.ch>, <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org> Subject: =?utf-8?q?=5BPATCH_linux-next=5D_drm/panel=3A_Simplify_with_dev=5Fe?= =?utf-8?q?rr=5Fprobe=28=29?= Content-Type: text/plain; charset="UTF-8" X-MAIL: mse-fl2.zte.com.cn 3BK2mqt7068198 X-Fangmail-Gw-Spam-Type: 0 X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 6582561C.001/4Svygc57qqz8XrRF X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785767480825136165 X-GMAIL-MSGID: 1785767480825136165 |
Series |
[linux-next] drm/panel: Simplify with dev_err_probe()
|
|
Commit Message
yang.guang5@zte.com.cn
Dec. 20, 2023, 2:48 a.m. UTC
From: Yang Guang <yang.guang5@zte.com.cn> dev_err_probe() can check if the error code is -EPROBE_DEFER and can return the error code, replacing dev_err() with it simplifies the code. Signed-off-by: Chen Haonan <chen.haonan2@zte.com.cn> --- drivers/gpu/drm/panel/panel-boe-himax8279d.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-)
Comments
On 12/19/2023 6:48 PM, yang.guang5@zte.com.cn wrote: > From: Yang Guang <yang.guang5@zte.com.cn> > > dev_err_probe() can check if the error code is -EPROBE_DEFER > and can return the error code, replacing dev_err() with it > simplifies the code. > > Signed-off-by: Chen Haonan <chen.haonan2@zte.com.cn> Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com> Thanks, Jessica Zhang > --- > drivers/gpu/drm/panel/panel-boe-himax8279d.c | 18 ++++++------------ > 1 file changed, 6 insertions(+), 12 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-boe-himax8279d.c b/drivers/gpu/drm/panel/panel-boe-himax8279d.c > index 11b64acbe8a9..e225840b0d67 100644 > --- a/drivers/gpu/drm/panel/panel-boe-himax8279d.c > +++ b/drivers/gpu/drm/panel/panel-boe-himax8279d.c > @@ -854,26 +854,20 @@ static int panel_add(struct panel_info *pinfo) > > pinfo->pp18_gpio = devm_gpiod_get(dev, "pp18", GPIOD_OUT_HIGH); > if (IS_ERR(pinfo->pp18_gpio)) { > - ret = PTR_ERR(pinfo->pp18_gpio); > - if (ret != -EPROBE_DEFER) > - dev_err(dev, "failed to get pp18 gpio: %d\n", ret); > - return ret; > + return dev_err_probe(dev, PTR_ERR(pinfo->pp18_gpio), > + "failed to get pp18 gpio\n"); > } > > pinfo->pp33_gpio = devm_gpiod_get(dev, "pp33", GPIOD_OUT_HIGH); > if (IS_ERR(pinfo->pp33_gpio)) { > - ret = PTR_ERR(pinfo->pp33_gpio); > - if (ret != -EPROBE_DEFER) > - dev_err(dev, "failed to get pp33 gpio: %d\n", ret); > - return ret; > + return dev_err_probe(dev, PTR_ERR(pinfo->pp33_gpio), > + "failed to get pp33 gpio\n"); > } > > pinfo->enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_HIGH); > if (IS_ERR(pinfo->enable_gpio)) { > - ret = PTR_ERR(pinfo->enable_gpio); > - if (ret != -EPROBE_DEFER) > - dev_err(dev, "failed to get enable gpio: %d\n", ret); > - return ret; > + return dev_err_probe(dev, PTR_ERR(pinfo->enable_gpio), > + "failed to get enable gpio\n"); > } > > drm_panel_init(&pinfo->base, dev, &panel_funcs, > -- > 2.25.1
On 20/12/2023 03:48, yang.guang5@zte.com.cn wrote: > From: Yang Guang <yang.guang5@zte.com.cn> > > dev_err_probe() can check if the error code is -EPROBE_DEFER > and can return the error code, replacing dev_err() with it > simplifies the code. > > Signed-off-by: Chen Haonan <chen.haonan2@zte.com.cn> Got the following checkpatch error: ERROR:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Yang Guang <yang.guang5@zte.com.cn>' Thanks, Neil > --- > drivers/gpu/drm/panel/panel-boe-himax8279d.c | 18 ++++++------------ > 1 file changed, 6 insertions(+), 12 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-boe-himax8279d.c b/drivers/gpu/drm/panel/panel-boe-himax8279d.c > index 11b64acbe8a9..e225840b0d67 100644 > --- a/drivers/gpu/drm/panel/panel-boe-himax8279d.c > +++ b/drivers/gpu/drm/panel/panel-boe-himax8279d.c > @@ -854,26 +854,20 @@ static int panel_add(struct panel_info *pinfo) > > pinfo->pp18_gpio = devm_gpiod_get(dev, "pp18", GPIOD_OUT_HIGH); > if (IS_ERR(pinfo->pp18_gpio)) { > - ret = PTR_ERR(pinfo->pp18_gpio); > - if (ret != -EPROBE_DEFER) > - dev_err(dev, "failed to get pp18 gpio: %d\n", ret); > - return ret; > + return dev_err_probe(dev, PTR_ERR(pinfo->pp18_gpio), > + "failed to get pp18 gpio\n"); > } > > pinfo->pp33_gpio = devm_gpiod_get(dev, "pp33", GPIOD_OUT_HIGH); > if (IS_ERR(pinfo->pp33_gpio)) { > - ret = PTR_ERR(pinfo->pp33_gpio); > - if (ret != -EPROBE_DEFER) > - dev_err(dev, "failed to get pp33 gpio: %d\n", ret); > - return ret; > + return dev_err_probe(dev, PTR_ERR(pinfo->pp33_gpio), > + "failed to get pp33 gpio\n"); > } > > pinfo->enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_HIGH); > if (IS_ERR(pinfo->enable_gpio)) { > - ret = PTR_ERR(pinfo->enable_gpio); > - if (ret != -EPROBE_DEFER) > - dev_err(dev, "failed to get enable gpio: %d\n", ret); > - return ret; > + return dev_err_probe(dev, PTR_ERR(pinfo->enable_gpio), > + "failed to get enable gpio\n"); > } > > drm_panel_init(&pinfo->base, dev, &panel_funcs,
Hi, On Wed, 20 Dec 2023 10:48:53 +0800, yang.guang5@zte.com.cn wrote: > dev_err_probe() can check if the error code is -EPROBE_DEFER > and can return the error code, replacing dev_err() with it > simplifies the code. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/1] drm/panel: Simplify with dev_err_probe() https://cgit.freedesktop.org/drm/drm-misc/commit/?id=9f78b3ae051d9eeeed9658cf54b3f0ea6920097b
diff --git a/drivers/gpu/drm/panel/panel-boe-himax8279d.c b/drivers/gpu/drm/panel/panel-boe-himax8279d.c index 11b64acbe8a9..e225840b0d67 100644 --- a/drivers/gpu/drm/panel/panel-boe-himax8279d.c +++ b/drivers/gpu/drm/panel/panel-boe-himax8279d.c @@ -854,26 +854,20 @@ static int panel_add(struct panel_info *pinfo) pinfo->pp18_gpio = devm_gpiod_get(dev, "pp18", GPIOD_OUT_HIGH); if (IS_ERR(pinfo->pp18_gpio)) { - ret = PTR_ERR(pinfo->pp18_gpio); - if (ret != -EPROBE_DEFER) - dev_err(dev, "failed to get pp18 gpio: %d\n", ret); - return ret; + return dev_err_probe(dev, PTR_ERR(pinfo->pp18_gpio), + "failed to get pp18 gpio\n"); } pinfo->pp33_gpio = devm_gpiod_get(dev, "pp33", GPIOD_OUT_HIGH); if (IS_ERR(pinfo->pp33_gpio)) { - ret = PTR_ERR(pinfo->pp33_gpio); - if (ret != -EPROBE_DEFER) - dev_err(dev, "failed to get pp33 gpio: %d\n", ret); - return ret; + return dev_err_probe(dev, PTR_ERR(pinfo->pp33_gpio), + "failed to get pp33 gpio\n"); } pinfo->enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_HIGH); if (IS_ERR(pinfo->enable_gpio)) { - ret = PTR_ERR(pinfo->enable_gpio); - if (ret != -EPROBE_DEFER) - dev_err(dev, "failed to get enable gpio: %d\n", ret); - return ret; + return dev_err_probe(dev, PTR_ERR(pinfo->enable_gpio), + "failed to get enable gpio\n"); } drm_panel_init(&pinfo->base, dev, &panel_funcs,