Message ID | 20221121104742.1007486-1-lili.li@intel.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp1508255wrr; Mon, 21 Nov 2022 02:53:00 -0800 (PST) X-Google-Smtp-Source: AA0mqf4rDrqNlo0u+I04Mg0p3ncjnEYm8xxPXor/6Hh5D+BAw4SvIk7qD5QR4sVpKCHqs5f4oQSV X-Received: by 2002:a05:6402:3ce:b0:469:40c:ecfb with SMTP id t14-20020a05640203ce00b00469040cecfbmr12857943edw.164.1669027979821; Mon, 21 Nov 2022 02:52:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669027979; cv=none; d=google.com; s=arc-20160816; b=YQKLG7DuiBwhjIkdI5CE0HG3f8GfeI/1pu0cPrAcon+Af4qOX51IMo6pC69T7aXkTr g0Sv280s0jz31ylFlikqJEFv8DfuYbSMISDurf0OdMFHBMiHJhnDOyrhXHgyqHgC+6W+ byZVlfiL4mUNPyIulWD3e/qhLg5IKDE3jLynh1yqE9kgcqnN/oozjjxr5dfVsk7KSVzP 0X9bB5xIOWmUwMx+ej78zskFn8P0ugNXJrqGcLra8ORtB8LGQP2+0I63FM9XDKXVPf3E SpikEwCjnH0PGguOxkBcQ4gfHvjRAEGjtXu/TFtYjADIu/uHlHnOplnhpjH4dtGFNyNU wK4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from:dkim-signature; bh=Vg3RjgE5v1hdUcLI+5IyxQFF1dEVicuIFWb1ArZHHzI=; b=x3N7+r9hMWhd/hnbpcGty3icFA87zB+b1GivsPbuAf8wBXNuXrJPkx2YWFsZLdqD86 DG0okM8SI9MeC4TsIVXw6JAH+MZ6SC5r5bHLXinEDr+gm4pQS++99FRFNGJln68jTxa1 xkS0obsUjDS0Euh3gfnvaDSBZmdPgbH7rUwwfwgKFjUeoAPipURuez52hSu9SVOfun0F eXJaD8o26vN/IgU4nxJqNrdQd8r2FeSNUKeR/z9dJ5h+uOimYoxrRDuxa/14kGgO7eh9 vCmfRmQ33zyqEFRXwekLr6PEI8L+fuY/10RNSZOsEAnGAoTJreDqaDTQUTHQPKiAQ6lp f0dg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Imha5nvN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u5-20020a17090657c500b00782161b3422si7691675ejr.914.2022.11.21.02.52.31; Mon, 21 Nov 2022 02:52:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Imha5nvN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229515AbiKUKrA (ORCPT <rfc822;peter110.wang@gmail.com> + 99 others); Mon, 21 Nov 2022 05:47:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229699AbiKUKqt (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 21 Nov 2022 05:46:49 -0500 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B10C97991F for <linux-kernel@vger.kernel.org>; Mon, 21 Nov 2022 02:46:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669027608; x=1700563608; h=from:to:subject:date:message-id:mime-version: content-transfer-encoding; bh=CYBGgKZa3V7R4jeaL1Zz2bLgJGSPjHevyvScslfBpTs=; b=Imha5nvNdPhP5tKQKxeKkRl+oRiBhWr+afH7Y3E2HsFZfD0y7cfh/QRR JpB4F5dmOPl2djo+pmXX6atnkRB5Q3HMeGboUHsOeZDIyfaQLReirQxpB kHjVsaTsqAEE7ibhNSwbdtaDlUuOB8EZLmHquI0RLNFqITkbfs2cwZ6T1 pBrIHDgJwmS0rLRyMMUqUE1lknzu5hIkMQ3S6XL7glJX4+b9xfYZQ+QGJ gAeiulbzW0WXLomIK/YL/K7OpxadLchtZQzGvJCLkO2p/OTf4xDptB5TF 4/ErnQjVZrso1AYVbvUOiMW785xnlV3RQd7FUZIfkcDNKsfqdfmiqttIt Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10537"; a="340387150" X-IronPort-AV: E=Sophos;i="5.96,181,1665471600"; d="scan'208";a="340387150" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2022 02:46:42 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10537"; a="729964350" X-IronPort-AV: E=Sophos;i="5.96,181,1665471600"; d="scan'208";a="729964350" Received: from lili-desktop.bj.intel.com ([10.238.144.122]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2022 02:46:40 -0800 From: lili.li@intel.com To: tiwai@suse.com, perex@perex.cz, broonie@kernel.org, cezary.rojewski@intel.com, kai.vehmanen@linux.intel.com, pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH] ASoC: Intel: Skylake: Fix Kconfig dependency Date: Mon, 21 Nov 2022 18:47:42 +0800 Message-Id: <20221121104742.1007486-1-lili.li@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750102683413366127?= X-GMAIL-MSGID: =?utf-8?q?1750102683413366127?= |
Series |
ASoC: Intel: Skylake: Fix Kconfig dependency
|
|
Commit Message
lili.li@intel.com
Nov. 21, 2022, 10:47 a.m. UTC
From: Lili Li <lili.li@intel.com> Commit e4746d94d00c ("ASoC: Intel: Skylake: Introduce HDA codec init and exit routines") introduced HDA codec init routine which depends on SND_HDA. Select SND_SOC_HDAC_HDA unconditionally to fix following compile error: ERROR: modpost: "snd_hda_codec_device_init" [sound/soc/intel/skylake/snd-soc-skl.ko] undefined! Fixes: e4746d94d00c ("ASoC: Intel: Skylake: Introduce HDA codec init and exit routines") Reviewed-by: Junxiao Chang <junxiao.chang@intel.com> Suggested-by: Cezary Rojewski <cezary.rojewski@intel.com> Signed-off-by: Lili Li <lili.li@intel.com> --- sound/soc/intel/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 2022-11-21 11:47 AM, lili.li@intel.com wrote: > From: Lili Li <lili.li@intel.com> > > Commit e4746d94d00c ("ASoC: Intel: Skylake: Introduce HDA codec init and > exit routines") introduced HDA codec init routine which depends on SND_HDA. > Select SND_SOC_HDAC_HDA unconditionally to fix following compile error: > ERROR: modpost: "snd_hda_codec_device_init" [sound/soc/intel/skylake/snd-soc-skl.ko] undefined! > > Fixes: e4746d94d00c ("ASoC: Intel: Skylake: Introduce HDA codec init and exit routines") > Reviewed-by: Junxiao Chang <junxiao.chang@intel.com> > Suggested-by: Cezary Rojewski <cezary.rojewski@intel.com> > Signed-off-by: Lili Li <lili.li@intel.com> > --- > sound/soc/intel/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig > index d2ca710ac3fa..ac799de4f7fd 100644 > --- a/sound/soc/intel/Kconfig > +++ b/sound/soc/intel/Kconfig > @@ -177,7 +177,7 @@ config SND_SOC_INTEL_SKYLAKE_COMMON > select SND_HDA_DSP_LOADER > select SND_SOC_TOPOLOGY > select SND_SOC_INTEL_SST > - select SND_SOC_HDAC_HDA if SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC > + select SND_SOC_HDAC_HDA > select SND_SOC_ACPI_INTEL_MATCH > select SND_INTEL_DSP_CONFIG > help Thanks once again your for report and input. Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
On Mon, 21 Nov 2022 18:47:42 +0800, lili.li@intel.com wrote: > From: Lili Li <lili.li@intel.com> > > Commit e4746d94d00c ("ASoC: Intel: Skylake: Introduce HDA codec init and > exit routines") introduced HDA codec init routine which depends on SND_HDA. > Select SND_SOC_HDAC_HDA unconditionally to fix following compile error: > ERROR: modpost: "snd_hda_codec_device_init" [sound/soc/intel/skylake/snd-soc-skl.ko] undefined! > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: Intel: Skylake: Fix Kconfig dependency commit: e5d4d2b23aed20a7815d1b500dbcd50af1da0023 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig index d2ca710ac3fa..ac799de4f7fd 100644 --- a/sound/soc/intel/Kconfig +++ b/sound/soc/intel/Kconfig @@ -177,7 +177,7 @@ config SND_SOC_INTEL_SKYLAKE_COMMON select SND_HDA_DSP_LOADER select SND_SOC_TOPOLOGY select SND_SOC_INTEL_SST - select SND_SOC_HDAC_HDA if SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC + select SND_SOC_HDAC_HDA select SND_SOC_ACPI_INTEL_MATCH select SND_INTEL_DSP_CONFIG help