Message ID | 20231201092654.34614-2-anna-maria@linutronix.de |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp991424vqy; Fri, 1 Dec 2023 01:27:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IElGRuwq7Ga3L0flINzmiDUun9RqLI2Oey9jQ+yjyJxu8g6tQrYtWl9RiOuspYBFFSCCNm2 X-Received: by 2002:a05:6830:344a:b0:6d8:16e3:c50b with SMTP id b10-20020a056830344a00b006d816e3c50bmr2651667otu.33.1701422834824; Fri, 01 Dec 2023 01:27:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701422834; cv=none; d=google.com; s=arc-20160816; b=yLSz2sNVnI+1uWrkMLQPtHTzGDkvBQZzCbDCWcTKYEjWOjf4B162RJivSF6pG2nF7+ iabEFPxOkmUE4JikJep/0J/Ecfkx3ADFLr1I42ocDqGI7yTwq7SYy3rAlaaMLH9mbNHT iZN0eiqLCaT2mgVCXjfhVXBS2K4+MqAMX98xg4vDRHjyv0cu8vUfpklmKkJAWtd58YCG e3SwrIRWWOw7hn0iNILnOZ4nhRy7+HqWZ4Xu36ntmTGcFl2/Jz43QL/Mw44rUeUF3MCu K7Js9iCudi2XfeQQGPXwuvOksI6+uq/vKq8I7hSE49B71FTtDcGpz7ZEJIfHWAAcBNl3 T9Mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:dkim-signature :dkim-signature:from; bh=Q6FUfFnmqt4IfzZcGlQkVi9fkygYWanokVt8epCh18g=; fh=PG6uS4TiiUSDyl8D/joYkWbwCgDm4ug0ir2h7tHBJXQ=; b=P4v8h8LYJA/GQeJNeewoqa3fZQQ+yT64QARaxlZYAEffTz3eT+gJ37lt7CNLbV7tOB 4LvhUJHq1GkklZScre38Vubu1KjdwFbAeCRa3vmM/a7KdFSpO2MI/FLIQUBO0b1vmH9C 73mt4IhRguoJAdYa9J08gwFsPwUGbi5ePcn9m4r2GzmCvMVp+Bn+MF/0Ix1dISBu4ai5 v5Mgaux6fT6IIeXoEXlGArLRtMH7I9E+VY8sbQZ8oHwd7ZJLohLYAc0SiWzdvlnadtTN CJiX2erV7uMcWlRIeQYWQHJ48xypKce9cBEf1imB4BNlQSvUbea8lHPL7qDbK3yvPi0Q +CCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=lgvXqUjF; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=swIBVCbe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id ca6-20020a056a02068600b005c63a36938fsi1932194pgb.809.2023.12.01.01.27.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 01:27:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=lgvXqUjF; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=swIBVCbe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 0712D81552C5; Fri, 1 Dec 2023 01:27:12 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378013AbjLAJ1D (ORCPT <rfc822;ruipengqi7@gmail.com> + 99 others); Fri, 1 Dec 2023 04:27:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229455AbjLAJ1B (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 1 Dec 2023 04:27:01 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75009194 for <linux-kernel@vger.kernel.org>; Fri, 1 Dec 2023 01:27:08 -0800 (PST) From: Anna-Maria Behnsen <anna-maria@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1701422826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q6FUfFnmqt4IfzZcGlQkVi9fkygYWanokVt8epCh18g=; b=lgvXqUjFJoLwU9+ZZLvtquxTwT6ofi+2y79zdhzkCm+arupJRiVKmMIVcB3lduxwWCFofb MFOL7JDx6+6MFnMmEPZRzTDdRIidDu055pueLPcpiGoOrPv1g40SAikE1AQ96Zg1aCUWsu /RfyywAtAOETUaaOeWDUdTjDg1K5i8v5TCoy1b8UAilHhdNHc0/3AnPNkftGpd67MIalU9 PXMyPG5DMKfCOgRGIYO2Vtiq31A/P7fOfozAca61lrAgMbutkFYtbzGQ38QYnXCUZcDprj jhoN1vY2o7ZgxvN6IUOgYw/d4bOtBFlACxjARMnb88bChF6B1h2PGlbSvNVcnQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1701422826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q6FUfFnmqt4IfzZcGlQkVi9fkygYWanokVt8epCh18g=; b=swIBVCbe9PNsC1cAlRdY84Lq5DKzwDPoPs3oPMIaRGhQn1B3L/aGAyxpp9foQnhZvbP1Cq ixM6qqPcxQvkLZBg== To: linux-kernel@vger.kernel.org Cc: Peter Zijlstra <peterz@infradead.org>, John Stultz <jstultz@google.com>, Thomas Gleixner <tglx@linutronix.de>, Eric Dumazet <edumazet@google.com>, "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>, Arjan van de Ven <arjan@infradead.org>, "Paul E . McKenney" <paulmck@kernel.org>, Frederic Weisbecker <frederic@kernel.org>, Rik van Riel <riel@surriel.com>, Steven Rostedt <rostedt@goodmis.org>, Sebastian Siewior <bigeasy@linutronix.de>, Giovanni Gherdovich <ggherdovich@suse.cz>, Lukasz Luba <lukasz.luba@arm.com>, "Gautham R . Shenoy" <gautham.shenoy@amd.com>, Srinivas Pandruvada <srinivas.pandruvada@intel.com>, K Prateek Nayak <kprateek.nayak@amd.com>, Anna-Maria Behnsen <anna-maria@linutronix.de> Subject: [PATCH v9 01/32] tick-sched: Fix function names in comments Date: Fri, 1 Dec 2023 10:26:23 +0100 Message-Id: <20231201092654.34614-2-anna-maria@linutronix.de> In-Reply-To: <20231201092654.34614-1-anna-maria@linutronix.de> References: <20231201092654.34614-1-anna-maria@linutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 01 Dec 2023 01:27:12 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784071150561242093 X-GMAIL-MSGID: 1784071150561242093 |
Series |
timers: Move from a push remote at enqueue to a pull at expiry model
|
|
Commit Message
Anna-Maria Behnsen
Dec. 1, 2023, 9:26 a.m. UTC
When referencing functions in comments, it might be helpful to use full
function names (including the prefix) to be able to find it when grepping.
Signed-off-by: Anna-Maria Behnsen <anna-maria@linutronix.de>
---
v9: New cleanup patch
---
kernel/time/tick-sched.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
Comments
Le Fri, Dec 01, 2023 at 10:26:23AM +0100, Anna-Maria Behnsen a écrit : > When referencing functions in comments, it might be helpful to use full > function names (including the prefix) to be able to find it when grepping. > > Signed-off-by: Anna-Maria Behnsen <anna-maria@linutronix.de> Reviewed-by: Frederic Weisbecker <frederic@kernel.org> Just a small detail that be addressed as a further patch (or edited while applying). > --- > v9: New cleanup patch > --- > kernel/time/tick-sched.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c > index be77b021e5d6..5c28cc80fd25 100644 > --- a/kernel/time/tick-sched.c > +++ b/kernel/time/tick-sched.c > @@ -920,11 +920,11 @@ static void tick_nohz_stop_tick(struct tick_sched *ts, int cpu) > } > > /* > - * nohz_stop_sched_tick() can be called several times before > - * nohz_restart_sched_tick() is called. This happens when > - * interrupts arrive which do not cause a reschedule. In the > - * first call we save the current tick time, so we can restart > - * the scheduler tick in nohz_restart_sched_tick(). > + * tick_nohz_stop_sched_tick() can be called several times before s/tick_nohz_stop_sched_tick/tick_nohz_stop_tick Because in the case of nohz_full it's indeed true. But idle behaves the same even though it uses another function (tick_nohz_idle_stop_tick()). More generally tick_nohz_stop_tick() covers both idle and nohz_full case and behaves as described. I guess at some point we should rename tick_nohz_stop_sched_tick() to tick_nohz_full_stop_tick() to avoid such confusion. Thanks. > + * tick_nohz_restart_sched_tick() is called. This happens when > + * interrupts arrive which do not cause a reschedule. In the first call > + * we save the current tick time, so we can restart the scheduler tick > + * in tick_nohz_restart_sched_tick(). > */ > if (!ts->tick_stopped) { > calc_load_nohz_start(); > -- > 2.39.2 >
diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c index be77b021e5d6..5c28cc80fd25 100644 --- a/kernel/time/tick-sched.c +++ b/kernel/time/tick-sched.c @@ -920,11 +920,11 @@ static void tick_nohz_stop_tick(struct tick_sched *ts, int cpu) } /* - * nohz_stop_sched_tick() can be called several times before - * nohz_restart_sched_tick() is called. This happens when - * interrupts arrive which do not cause a reschedule. In the - * first call we save the current tick time, so we can restart - * the scheduler tick in nohz_restart_sched_tick(). + * tick_nohz_stop_sched_tick() can be called several times before + * tick_nohz_restart_sched_tick() is called. This happens when + * interrupts arrive which do not cause a reschedule. In the first call + * we save the current tick time, so we can restart the scheduler tick + * in tick_nohz_restart_sched_tick(). */ if (!ts->tick_stopped) { calc_load_nohz_start();